On 19/02/10 15:13, Vincent Massol wrote:

On Feb 19, 2010, at 2:58 PM, Jerome Velociter wrote:

...

Hi all,

I propose to add a column in the document index table to display the document titles. Right now we only display document name and space ; and users do relate to the title they enter in the edit Form, not to the technical name of the page.

Only issue is that currently we can't have this column sortable nor filterable since standard XE documents use the localization tool for their title, so searching and ordering would not provide with expected results.

I propose we add the column just after the page name one, non filterable/sortable (for the moment and until we find a way to make internationalized titles searchable) and non clickable. You can check the result on the incubator wiki (just the i18n key for the table header is missing)

http://incubator.myxwiki.org/xwiki/bin/view/Main/AllDocs

Note that this will force us to add a nice title to all documents in XE (this is not the case right now, some technical documents in "blacklisted" spaces still have no title)

JIRA issue : http://jira.xwiki.org/jira/browse/XE-603

I've commented on the issue.

You are too fast :) I've replied. Thanks, Jerome.

Thanks -Vincent _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs

On 19/02/10 15:23, Thomas Mortagne wrote:

On Fri, Feb 19, 2010 at 14:58, Jerome Velociter<[email protected]> wrote:

...

Hi all,

I propose to add a column in the document index table to display the document titles. Right now we only display document name and space ; and users do relate to the title they enter in the edit Form, not to the technical name of the page.

Only issue is that currently we can't have this column sortable nor filterable since standard XE documents use the localization tool for their title, so searching and ordering would not provide with expected results.

I propose we add the column just after the page name one, non filterable/sortable (for the moment and until we find a way to make internationalized titles searchable) and non clickable. You can check the result on the incubator wiki (just the i18n key for the table header is missing)

http://incubator.myxwiki.org/xwiki/bin/view/Main/AllDocs

* Since page title could be very big if someone did a mistake like an {{include}} in the first header without anything in the title field for example, we should probably protect the table by limiting the number of chars printer with some ... when it's too long.

* I did not tested on a 1280 screen, it could make the table not very nice maybe.

I'm on a 1280 right now and it's OK. We should test on a 1024 too.

...

Note that this will force us to add a nice title to all documents in XE (this is not the case right now, some technical documents in "blacklisted" spaces still have no title)

JIRA issue : http://jira.xwiki.org/jira/browse/XE-603

Opinions ?

Thanks, Jerome. _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs

On 02/19/2010 03:23 PM, Thomas Mortagne wrote:

On Fri, Feb 19, 2010 at 14:58, Jerome Velociter<[email protected]> wrote:

...

Hi all,

I propose to add a column in the document index table to display the document titles. Right now we only display document name and space ; and users do relate to the title they enter in the edit Form, not to the technical name of the page.

Only issue is that currently we can't have this column sortable nor filterable since standard XE documents use the localization tool for their title, so searching and ordering would not provide with expected results.

+1. The same is already done for the deleted documents/attachments.

...

I propose we add the column just after the page name one, non filterable/sortable (for the moment and until we find a way to make internationalized titles searchable) and non clickable. You can check the result on the incubator wiki (just the i18n key for the table header is missing)

IMO, it doesn't look good between the name and the space.

...

http://incubator.myxwiki.org/xwiki/bin/view/Main/AllDocs

* Since page title could be very big if someone did a mistake like an {{include}} in the first header without anything in the title field for example, we should probably protect the table by limiting the number of chars printer with some ... when it's too long.

Not so sure about this. If it's long but with spaces, that's OK, it will just create a fat row. If it's long without spaces (which shouldn't happen, since it's a title; this should happen more often for the document name, but there's a 250 chars limit on the name), then it might overflow on small screens. If it's long because of a user error, then it's good, at least it will be spotted, reported and fixed.

* I did not tested on a 1280 screen, it could make the table not very nice maybe.

Looks good so far. The actions look worse than the title, we should remove the text labels from there.

...

Note that this will force us to add a nice title to all documents in XE (this is not the case right now, some technical documents in "blacklisted" spaces still have no title)

We could make this an integration test, similar to the orphaned pages.

...

JIRA issue : http://jira.xwiki.org/jira/browse/XE-603

Opinions ?

Thanks, Jerome.

-- Sergiu Dumitriu http://purl.org/net/sergiu/

On 19/02/10 17:57, Thomas Mortagne wrote:

On Fri, Feb 19, 2010 at 17:26, Sergiu Dumitriu<[email protected]> wrote:

...

On 02/19/2010 03:23 PM, Thomas Mortagne wrote:

...

On Fri, Feb 19, 2010 at 14:58, Jerome Velociter<[email protected]> wrote:

...

Hi all,

I propose to add a column in the document index table to display the document titles. Right now we only display document name and space ; and users do relate to the title they enter in the edit Form, not to the technical name of the page.

Only issue is that currently we can't have this column sortable nor filterable since standard XE documents use the localization tool for their title, so searching and ordering would not provide with expected results.

+1. The same is already done for the deleted documents/attachments.

...

...

I propose we add the column just after the page name one, non filterable/sortable (for the moment and until we find a way to make internationalized titles searchable) and non clickable. You can check the result on the incubator wiki (just the i18n key for the table header is missing)

IMO, it doesn't look good between the name and the space.

...

...

http://incubator.myxwiki.org/xwiki/bin/view/Main/AllDocs

* Since page title could be very big if someone did a mistake like an {{include}} in the first header without anything in the title field for example, we should probably protect the table by limiting the number of chars printer with some ... when it's too long.

Not so sure about this. If it's long but with spaces, that's OK, it will just create a fat row. If it's long without spaces (which shouldn't happen, since it's a title; this should happen more often for the document name, but there's a 250 chars limit on the name), then it might overflow on small screens. If it's long because of a user error, then it's good, at least it will be spotted, reported and fixed.

Not sure it's good to break the UI whatever the reason...

I agree with Sergiu : if it is very long and has space it's OK and should be displayed, if it is very long without spaces, the problem is somewhere else. Sure we can decide to trim to be on the safe side, but the limit is hard to place (for example a title that spans over 5 lines would be OK to me, but maybe not for someone else). Jerome.

...

...

* I did not tested on a 1280 screen, it could make the table not very nice maybe.

Looks good so far. The actions look worse than the title, we should remove the text labels from there.

...

...

Note that this will force us to add a nice title to all documents in XE (this is not the case right now, some technical documents in "blacklisted" spaces still have no title)

We could make this an integration test, similar to the orphaned pages.

...

...

JIRA issue : http://jira.xwiki.org/jira/browse/XE-603

Opinions ?

Thanks, Jerome.

-- Sergiu Dumitriu http://purl.org/net/sergiu/ _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs

On 02/19/2010 06:33 PM, Jerome Velociter wrote:

On 19/02/10 17:26, Sergiu Dumitriu wrote:

...

On 02/19/2010 03:23 PM, Thomas Mortagne wrote:

...

On Fri, Feb 19, 2010 at 14:58, Jerome Velociter<[email protected]> wrote:

...

Hi all,

I propose to add a column in the document index table to display the document titles. Right now we only display document name and space ; and users do relate to the title they enter in the edit Form, not to the technical name of the page.

Only issue is that currently we can't have this column sortable nor filterable since standard XE documents use the localization tool for their title, so searching and ordering would not provide with expected results.

+1. The same is already done for the deleted documents/attachments.

...

...

I propose we add the column just after the page name one, non filterable/sortable (for the moment and until we find a way to make internationalized titles searchable) and non clickable. You can check the result on the incubator wiki (just the i18n key for the table header is missing)

IMO, it doesn't look good between the name and the space.

Where would you see it ? First column ?

It would be better from the user's point of view, since the title is what the users know and see. The name is technical. But there might be a problem. Normally the first column is the one that's sorted after, and the one that has the main link. And it can't be sorted or filtered anymore. Another option would be to put the name and title together, like it's done for the Deleted Attachments. The problem is that it's not intuitive that the filter works on the name, and not on the title, and users won't understand why "filtering doesn't work".

...

...

...

http://incubator.myxwiki.org/xwiki/bin/view/Main/AllDocs

* Since page title could be very big if someone did a mistake like an {{include}} in the first header without anything in the title field for example, we should probably protect the table by limiting the number of chars printer with some ... when it's too long.

Not so sure about this. If it's long but with spaces, that's OK, it will just create a fat row. If it's long without spaces (which shouldn't happen, since it's a title; this should happen more often for the document name, but there's a 250 chars limit on the name), then it might overflow on small screens. If it's long because of a user error, then it's good, at least it will be spotted, reported and fixed.

...

* I did not tested on a 1280 screen, it could make the table not very nice maybe.

Looks good so far. The actions look worse than the title, we should remove the text labels from there.

...

...

Note that this will force us to add a nice title to all documents in XE (this is not the case right now, some technical documents in "blacklisted" spaces still have no title)

We could make this an integration test, similar to the orphaned pages.

...

...

JIRA issue : http://jira.xwiki.org/jira/browse/XE-603

Opinions ?

Thanks, Jerome.

-- Sergiu Dumitriu http://purl.org/net/sergiu/

That was my idea initially but since we cannot have filters and sort on titles, we cannot get rid of the "name" column. (+ the name column is handy for advanced users that resonate by doc name not title). And in the end, I think it's good to have both both name and title next one to another. It helps users getting to understand that they are two different things. Jerome. On 19/02/10 17:59, Flavius Olaru wrote:

What if we have doc.title instead of doc.name? and doc.title as a link to the document. I would like it more and would fit in 1024 resolutions better. And for long doc title we could do a trim to 50 characters for example.

<a href="doc.getURL('view')" title="$doc.title">#trimmed($doc.title, 50)</a>

#macro(trimmed $str $numchars) $doc.title.substring(0, 50) #end

WDYT?

On Fri, Feb 19, 2010 at 3:58 PM, Jerome Velociter<[email protected]> wrote:

...

Hi all,

I propose to add a column in the document index table to display the document titles. Right now we only display document name and space ; and users do relate to the title they enter in the edit Form, not to the technical name of the page.

Only issue is that currently we can't have this column sortable nor filterable since standard XE documents use the localization tool for their title, so searching and ordering would not provide with expected results.

I propose we add the column just after the page name one, non filterable/sortable (for the moment and until we find a way to make internationalized titles searchable) and non clickable. You can check the result on the incubator wiki (just the i18n key for the table header is missing)

http://incubator.myxwiki.org/xwiki/bin/view/Main/AllDocs

Note that this will force us to add a nice title to all documents in XE (this is not the case right now, some technical documents in "blacklisted" spaces still have no title)

JIRA issue : http://jira.xwiki.org/jira/browse/XE-603

Opinions ?

Thanks, Jerome. _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs

On 02/19/2010 06:30 PM, Jerome Velociter wrote:

...

That was my idea initially but since we cannot have filters and sort on titles, we cannot get rid of the "name" column. (+ the name column is handy for advanced users that resonate by doc name not title).

The title field is sortable/filterable (this is static doc.title, not doc.getDisplayTitle). But it won't work anyway, since lots of documents use an inline title instead of the doc.title field. Thus, it would be strange to have empty cells.

What I meant is that most title fields in the default XE use the localization tool. The livetable display them evaluated, si in the end sorting and filtering does not provide the expected results

...

And in the end, I think it's good to have both both name and title next one to another. It helps users getting to understand that they are two different things.

Jerome.

On 19/02/10 17:59, Flavius Olaru wrote:

...

What if we have doc.title instead of doc.name? and doc.title as a link to the document. I would like it more and would fit in 1024 resolutions better. And for long doc title we could do a trim to 50 characters for example.

<a href="doc.getURL('view')" title="$doc.title">#trimmed($doc.title, 50)</a>

#macro(trimmed $str $numchars) $doc.title.substring(0, 50) #end

WDYT?

On Fri, Feb 19, 2010 at 3:58 PM, Jerome Velociter<[email protected]> wrote:

...

Hi all,

I propose to add a column in the document index table to display the document titles. Right now we only display document name and space ; and users do relate to the title they enter in the edit Form, not to the technical name of the page.

Only issue is that currently we can't have this column sortable nor filterable since standard XE documents use the localization tool for their title, so searching and ordering would not provide with expected results.

I propose we add the column just after the page name one, non filterable/sortable (for the moment and until we find a way to make internationalized titles searchable) and non clickable. You can check the result on the incubator wiki (just the i18n key for the table header is missing)

http://incubator.myxwiki.org/xwiki/bin/view/Main/AllDocs

Note that this will force us to add a nice title to all documents in XE (this is not the case right now, some technical documents in "blacklisted" spaces still have no title)

JIRA issue : http://jira.xwiki.org/jira/browse/XE-603

Opinions ?

-- Sergiu Dumitriu http://purl.org/net/sergiu/ _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs