Re: [xwiki-devs] [xwiki-notifications] r13338 - in sandbox/xwiki-webdav: references src/main/java/com/xpn/xwiki/plugin/webdav src/main/java/com/xpn/xwiki/plugin/webdav/mock src/main/java/com/xpn/xwiki/plugin/webdav/resources src/main/java/com/xpn/xwi
On Mon, Oct 6, 2008 at 1:25 PM, Vincent Massol <[email protected]> wrote:
Hi Asiri,
There was no comment in the commit. We always need a comment to know why you did this commit.
Sorry, this was a mistake. My first commit failed (out of date source) and then i forgot to include the comment on the second try.
Re XWikiDavITest could you follow our naming conventions: * set up method is protected and called setUp()
* test methods start with "test" and not 'try"
Ok, but since junit 4.0 has no restrictions on these names i was using what made the most sense. Anyway, i'll change them :) Thanks. - Asiri
Note: Haven't checked the rest.
Thanks -Vincent
On Oct 6, 2008, at 9:08 AM, asiri (SVN) wrote:
Author: asiri Date: 2008-10-06 09:08:11 +0200 (Mon, 06 Oct 2008) New Revision: 13338
Added: sandbox/xwiki-webdav/references/OldXWikiDavResource.java.Reference sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ resources/AbstractXWikiDavResource.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ resources/domain/AbstractXWikiDavFile.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ resources/views/AbstractXWikiDavView.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ utils/XWikiDavUtils.java Removed: sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ mock/MockXWikiServletContext.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ resources/XWikiDavResource.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ resources/domain/XWikiDavFile.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ resources/old/ sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ resources/views/XWikiDavView.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ utils/XWikiDavUtils.java Modified: sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ XWikiDavFilter.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ XWikiDavServlet.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ XWikiWebdavResponseImpl.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ mock/XWikiXMLRPCResponse.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ resources/domain/XWikiDavAttachment.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ resources/domain/XWikiDavPage.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ resources/domain/XWikiDavTempFile.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ resources/domain/XWikiDavWikiFile.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ resources/views/XWikiHomeDavView.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ resources/views/XWikiOrphansDavView.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ resources/views/XWikiRootDavView.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ resources/views/XWikiWhatsnewDavView.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ resources/views/attachments/XWikiAttachmentsByFirstLettersDavView.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ resources/views/attachments/XWikiAttachmentsBySpaceNameDavView.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ resources/views/attachments/XWikiAttachmentsDavView.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ resources/views/spaces/XWikiPagesByFirstLettersDavView.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ resources/views/spaces/XWikiPagesBySpaceNameDavView.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ resources/views/spaces/XWikiPagesDavView.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ utils/XWikiDavParams.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ utils/XWikiDavSession.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ utils/XWikiDavSessionProvider.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ utils/XWikiExportContext.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ utils/XWikiPropertyHandler.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ utils/XWikiResourceConfig.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ utils/XWikiResourceFactory.java sandbox/xwiki-webdav/src/test/java/com/xpn/xwiki/plugin/webdav/ tests/XWikiDavITest.java Log:
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
On Oct 6, 2008, at 10:13 AM, Asiri Rathnayake wrote:
On Mon, Oct 6, 2008 at 1:25 PM, Vincent Massol <[email protected]> wrote:
Hi Asiri,
There was no comment in the commit. We always need a comment to know why you did this commit.
Sorry, this was a mistake. My first commit failed (out of date source) and then i forgot to include the comment on the second try.
Re XWikiDavITest could you follow our naming conventions: * set up method is protected and called setUp()
* test methods start with "test" and not 'try"
Ok, but since junit 4.0 has no restrictions on these names i was using what made the most sense. Anyway, i'll change them :)
I know but using testXXX makes more sense than tryXXX and setUp/ tearDown are already used. BTW we don't use JUnit 4 in XWiki. We use only JUnit 3.8. If you want to change that you need to propose it as a new rule for the whole codebase not just for webdav, and propose best practices around it. Thanks -Vincent
Note: Haven't checked the rest.
Thanks -Vincent
On Oct 6, 2008, at 9:08 AM, asiri (SVN) wrote:
Author: asiri Date: 2008-10-06 09:08:11 +0200 (Mon, 06 Oct 2008) New Revision: 13338
Added: sandbox/xwiki-webdav/references/OldXWikiDavResource.java.Reference sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ resources/AbstractXWikiDavResource.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ resources/domain/AbstractXWikiDavFile.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ resources/views/AbstractXWikiDavView.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ utils/XWikiDavUtils.java Removed: sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ mock/MockXWikiServletContext.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ resources/XWikiDavResource.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ resources/domain/XWikiDavFile.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ resources/old/ sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ resources/views/XWikiDavView.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ utils/XWikiDavUtils.java Modified: sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ XWikiDavFilter.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ XWikiDavServlet.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ XWikiWebdavResponseImpl.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ mock/XWikiXMLRPCResponse.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ resources/domain/XWikiDavAttachment.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ resources/domain/XWikiDavPage.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ resources/domain/XWikiDavTempFile.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ resources/domain/XWikiDavWikiFile.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ resources/views/XWikiHomeDavView.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ resources/views/XWikiOrphansDavView.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ resources/views/XWikiRootDavView.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ resources/views/XWikiWhatsnewDavView.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ resources/views/attachments/ XWikiAttachmentsByFirstLettersDavView.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ resources/views/attachments/XWikiAttachmentsBySpaceNameDavView.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ resources/views/attachments/XWikiAttachmentsDavView.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ resources/views/spaces/XWikiPagesByFirstLettersDavView.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ resources/views/spaces/XWikiPagesBySpaceNameDavView.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ resources/views/spaces/XWikiPagesDavView.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ utils/XWikiDavParams.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ utils/XWikiDavSession.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ utils/XWikiDavSessionProvider.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ utils/XWikiExportContext.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ utils/XWikiPropertyHandler.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ utils/XWikiResourceConfig.java sandbox/xwiki-webdav/src/main/java/com/xpn/xwiki/plugin/webdav/ utils/XWikiResourceFactory.java sandbox/xwiki-webdav/src/test/java/com/xpn/xwiki/plugin/webdav/ tests/XWikiDavITest.java Log:
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
participants (2)
-
Asiri Rathnayake -
Vincent Massol