[xwiki-devs] [VOTE] New tool, xwiki-tool-standards-validator
Hi, I'd like to commit a new standalone tool, xwiki-tool-standards-validator, it allows to run XHTML and Dutch Web Guidelines validation tests (only a few rules for the moment) on an InputStream. This tool will be used by a new enterprise module that I'll commit right after, xwiki-enterprise-test-webstandards which runs the validators on every pages present in the XE distrib. Here's my +1, JV.
+1 On Fri, Nov 27, 2009 at 16:56, Jean-Vincent Drean <[email protected]> wrote:
Hi,
I'd like to commit a new standalone tool, xwiki-tool-standards-validator, it allows to run XHTML and Dutch Web Guidelines validation tests (only a few rules for the moment) on an InputStream. This tool will be used by a new enterprise module that I'll commit right after, xwiki-enterprise-test-webstandards which runs the validators on every pages present in the XE distrib.
Here's my +1, JV. _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
On Nov 27, 2009, at 4:56 PM, Jean-Vincent Drean wrote:
Hi,
I'd like to commit a new standalone tool, xwiki-tool-standards-validator, it allows to run XHTML and Dutch Web Guidelines validation tests (only a few rules for the moment) on an InputStream. This tool will be used by a new enterprise module that I'll commit right after, xwiki-enterprise-test-webstandards which runs the validators on every pages present in the XE distrib.
Here's my +1,
Cool I'm +1 even though I'm not sure why we need a tool module for this since it's used in a single place. Note: We need to add CSS validation too to this module. Thanks -Vincent
On Fri, Nov 27, 2009 at 5:07 PM, Vincent Massol <[email protected]> wrote:
Cool
I'm +1 even though I'm not sure why we need a tool module for this since it's used in a single place.
Note: We need to add CSS validation too to this module.
I made a tool for 2 reasons: - I wanted to have unit tests to validate Dutch Web Guidelines (DWG) rules - I think it can be useful outside of xwiki, there's no java tool for DWG validation and XHTML validation in a single call is quite handy. JV.
On Nov 27, 2009, at 5:19 PM, Jean-Vincent Drean wrote:
On Fri, Nov 27, 2009 at 5:07 PM, Vincent Massol <[email protected]> wrote:
Cool
I'm +1 even though I'm not sure why we need a tool module for this since it's used in a single place.
Note: We need to add CSS validation too to this module.
I made a tool for 2 reasons: - I wanted to have unit tests to validate Dutch Web Guidelines (DWG) rules
Good point
- I think it can be useful outside of xwiki, there's no java tool for DWG validation and XHTML validation in a single call is quite handy.
Yes I thought about this too, not sure XWiki would be the best place for such a generic tool though but I agree it's better to have it separate, we can point people to it. Thanks for the explanations -Vincent
On Nov 27, 2009, at 4:56 PM, Jean-Vincent Drean wrote:
Hi,
I'd like to commit a new standalone tool, xwiki-tool-standards-validator, it allows to run XHTML and Dutch Web Guidelines validation tests (only a few rules for the moment) on an InputStream. This tool will be used by a new enterprise module that I'll commit right after, xwiki-enterprise-test-webstandards which runs the validators on every pages present in the XE distrib.
Here's my +1, JV.
+1 -Fabio
Four +1, I'll commit it in a few minutes. I've created the XTVALIDATOR project in jira, I've notived the tools project category is named "XWiki Build Tools", WDYT about renaming it "XWiki Tools" since it doesn't contain build tools only (foxwiki, root webapp, etc) ? Thanks, JV. On Fri, Nov 27, 2009 at 4:56 PM, Jean-Vincent Drean <[email protected]> wrote:
Hi,
I'd like to commit a new standalone tool, xwiki-tool-standards-validator, it allows to run XHTML and Dutch Web Guidelines validation tests (only a few rules for the moment) on an InputStream. This tool will be used by a new enterprise module that I'll commit right after, xwiki-enterprise-test-webstandards which runs the validators on every pages present in the XE distrib.
Here's my +1, JV.
On Nov 27, 2009, at 6:02 PM, Jean-Vincent Drean wrote:
Four +1, I'll commit it in a few minutes. I've created the XTVALIDATOR project in jira, I've notived the tools project category is named "XWiki Build Tools", WDYT about renaming it "XWiki Tools" since it doesn't contain build tools only (foxwiki, root webapp, etc) ?
- Foxwiki must not be located here. It's supposed to be a top level project. It needs to be fixed and moved to the contrib project right now IMO since it's not maintained - Root Webapp shouldn't be there. It should be in web/ IMO or in platform/core/ somewhere or as a submodule of webdav since it's for webdav I'm not sure we should have non build tools in tools. Thanks -Vincent
Thanks, JV.
On Fri, Nov 27, 2009 at 4:56 PM, Jean-Vincent Drean <[email protected]> wrote:
Hi,
I'd like to commit a new standalone tool, xwiki-tool-standards-validator, it allows to run XHTML and Dutch Web Guidelines validation tests (only a few rules for the moment) on an InputStream. This tool will be used by a new enterprise module that I'll commit right after, xwiki-enterprise-test-webstandards which runs the validators on every pages present in the XE distrib.
Here's my +1, JV.
On 11/27/2009 06:23 PM, Vincent Massol wrote:
On Nov 27, 2009, at 6:02 PM, Jean-Vincent Drean wrote:
Four +1, I'll commit it in a few minutes. I've created the XTVALIDATOR project in jira, I've notived the tools project category is named "XWiki Build Tools", WDYT about renaming it "XWiki Tools" since it doesn't contain build tools only (foxwiki, root webapp, etc) ?
- Foxwiki must not be located here. It's supposed to be a top level project. It needs to be fixed and moved to the contrib project right now IMO since it's not maintained - Root Webapp shouldn't be there. It should be in web/ IMO or in platform/core/ somewhere or as a submodule of webdav since it's for webdav
No, it's not a submodule of webdav, it's related to jetty-resources, since it is supposed to be bundled with our standalone distribution as the root webapp for Jetty. It doesn't just fix WebDAV for some clients, it also redirects to /xwiki/ in the standalone package. By the way, should our installation instructions mention this tool needed to make WebDAV work properly? Which client breaks without it?
I'm not sure we should have non build tools in tools.
Thanks -Vincent
-- Sergiu Dumitriu http://purl.org/net/sergiu/
+1 for the vote. On Sun, Nov 29, 2009 at 9:10 AM, Sergiu Dumitriu <[email protected]> wrote:
On 11/27/2009 06:23 PM, Vincent Massol wrote:
On Nov 27, 2009, at 6:02 PM, Jean-Vincent Drean wrote:
Four +1, I'll commit it in a few minutes. I've created the XTVALIDATOR project in jira, I've notived the tools project category is named "XWiki Build Tools", WDYT about renaming it "XWiki Tools" since it doesn't contain build tools only (foxwiki, root webapp, etc) ?
- Foxwiki must not be located here. It's supposed to be a top level project. It needs to be fixed and moved to the contrib project right now IMO since it's not maintained - Root Webapp shouldn't be there. It should be in web/ IMO or in platform/core/ somewhere or as a submodule of webdav since it's for webdav
No, it's not a submodule of webdav, it's related to jetty-resources, since it is supposed to be bundled with our standalone distribution as the root webapp for Jetty. It doesn't just fix WebDAV for some clients, it also redirects to /xwiki/ in the standalone package.
By the way, should our installation instructions mention this tool needed to make WebDAV work properly? Which client breaks without it?
Yup, I'm noting it down. It's windows webdav redirector that breaks when top-level URL (/xwiki/) does not respond correctly to OPTIONS webdav request (i.e webdav redirector recursively checks whether WEBDAV operations are supported by the given URL, if /xwiki/ says it does not support webdav functions, webdav redirector fails even though /xwiki/webdav/ is a webdav enabled URL). Thanks for pointing, it didn't come to my mind because the normal jetty distribution bundles the root webapp by default. - Asiri
I'm not sure we should have non build tools in tools.
Thanks -Vincent
-- Sergiu Dumitriu http://purl.org/net/sergiu/ _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
By the way, should our installation instructions mention this tool
needed to make WebDAV work properly? Which client breaks without it?
Yup, I'm noting it down. It's windows webdav redirector that breaks when top-level URL (/xwiki/) does not respond correctly to OPTIONS webdav request (i.e webdav redirector recursively checks whether WEBDAV operations are supported by the given URL, if /xwiki/ says it does not support webdav functions, webdav redirector fails even though /xwiki/webdav/ is a webdav enabled URL).
Correction: both / & /xwiki/ need to respond correctly to webdav OPTIONS request. That's why root weapp is important. - Asiri
Thanks for pointing, it didn't come to my mind because the normal jetty distribution bundles the root webapp by default.
- Asiri
I'm not sure we should have non build tools in tools.
Thanks -Vincent
-- Sergiu Dumitriu http://purl.org/net/sergiu/ _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
On Nov 29, 2009, at 4:40 AM, Sergiu Dumitriu wrote:
On 11/27/2009 06:23 PM, Vincent Massol wrote:
On Nov 27, 2009, at 6:02 PM, Jean-Vincent Drean wrote:
Four +1, I'll commit it in a few minutes. I've created the XTVALIDATOR project in jira, I've notived the tools project category is named "XWiki Build Tools", WDYT about renaming it "XWiki Tools" since it doesn't contain build tools only (foxwiki, root webapp, etc) ?
- Foxwiki must not be located here. It's supposed to be a top level project. It needs to be fixed and moved to the contrib project right now IMO since it's not maintained - Root Webapp shouldn't be there. It should be in web/ IMO or in platform/core/ somewhere or as a submodule of webdav since it's for webdav
No, it's not a submodule of webdav, it's related to jetty-resources, since it is supposed to be bundled with our standalone distribution as the root webapp for Jetty. It doesn't just fix WebDAV for some clients, it also redirects to /xwiki/ in the standalone package.
Then it should probably be separated in 2 modules since when I looked at it I saw that most of code was related to WebDAV only. -Vincent
By the way, should our installation instructions mention this tool needed to make WebDAV work properly? Which client breaks without it?
I'm not sure we should have non build tools in tools.
Thanks -Vincent
+1 Thanks, Marius Jean-Vincent Drean wrote:
Hi,
I'd like to commit a new standalone tool, xwiki-tool-standards-validator, it allows to run XHTML and Dutch Web Guidelines validation tests (only a few rules for the moment) on an InputStream. This tool will be used by a new enterprise module that I'll commit right after, xwiki-enterprise-test-webstandards which runs the validators on every pages present in the XE distrib.
Here's my +1, JV. _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
participants (7)
-
Asiri Rathnayake -
Fabio Mancinelli -
Jean-Vincent Drean -
Marius Dumitru Florea -
Sergiu Dumitriu -
Thomas Mortagne -
Vincent Massol