[xwiki-devs] [Discussion] extract out an xwiki-openoffice module from xwiki-officeimporter module ?
Hello Devs, Currently xwiki-officeimporter contains logic for mainly two different tasks: 1. Manage the back-end openoffice process (and provide document conversion facilities). 2. Perform the actual transformation from office documents to wiki pages. (depends on point 1) xwiki-officeimporter module's code might appear a bit complex because of this mix up. Also I believe openoffice related code might have to be reused once we introduce an office-exporter module. I was wondering if it would be beneficial (in the long run) to extract out openoffice related code into a separate module (xwiki-openoffice). The main concern I have is that currently openoffice related code is inside org.xwiki.officeimporter.openoffice package which have to be changed to org.xwiki.openoffice if we are to extract out a xwiki-openoffice module, this could break a few things in public API. Even if we decide to do so, I don't think any of us (devs) would be able to do this within 2.2M1 time period. But I thought it's better to discuss about it a little now. Let me know what you think. Thanks. - Asiri
Hi Asiri, Right now I don't see any use case for reusing an openoffice module outside of the office importer/exporter. My current view: - we could extract this module but as a nested submodule of xwiki- officeimporter (could be renamed xwiki-office and have 3 submodules: xwiki-office-importer, xwiki-office-exporter and xwiki-office- openoffice) - however I think it's a bit overkill to do so since I don't see reusing the officeimporter without the openoffice module, etc. Thus my current thinking is that I don't see the interest of doing so and it's probably enough to make whatever separation is required through package names (you already have the openoffice package which sounds fine enough to me). Thanks -Vincent On Dec 19, 2009, at 10:52 AM, Asiri Rathnayake wrote:
Hello Devs,
Currently xwiki-officeimporter contains logic for mainly two different tasks:
1. Manage the back-end openoffice process (and provide document conversion facilities).
2. Perform the actual transformation from office documents to wiki pages. (depends on point 1)
xwiki-officeimporter module's code might appear a bit complex because of this mix up. Also I believe openoffice related code might have to be reused once we introduce an office-exporter module.
I was wondering if it would be beneficial (in the long run) to extract out openoffice related code into a separate module (xwiki-openoffice). The main concern I have is that currently openoffice related code is inside org.xwiki.officeimporter.openoffice package which have to be changed to org.xwiki.openoffice if we are to extract out a xwiki-openoffice module, this could break a few things in public API.
Even if we decide to do so, I don't think any of us (devs) would be able to do this within 2.2M1 time period. But I thought it's better to discuss about it a little now.
Let me know what you think.
Thanks.
- Asiri
On 12/19/2009 10:52 AM, Asiri Rathnayake wrote:
Hello Devs,
Currently xwiki-officeimporter contains logic for mainly two different tasks:
1. Manage the back-end openoffice process (and provide document conversion facilities).
2. Perform the actual transformation from office documents to wiki pages. (depends on point 1)
xwiki-officeimporter module's code might appear a bit complex because of this mix up. Also I believe openoffice related code might have to be reused once we introduce an office-exporter module.
I was wondering if it would be beneficial (in the long run) to extract out openoffice related code into a separate module (xwiki-openoffice). The main concern I have is that currently openoffice related code is inside org.xwiki.officeimporter.openoffice package which have to be changed to org.xwiki.openoffice if we are to extract out a xwiki-openoffice module, this could break a few things in public API.
Even if we decide to do so, I don't think any of us (devs) would be able to do this within 2.2M1 time period. But I thought it's better to discuss about it a little now.
Let me know what you think.
Will this module be useful outside the import/export feature? Can you think of any standalone usage? -- Sergiu Dumitriu http://purl.org/net/sergiu/
Hi, Will this module be useful outside the import/export feature? Can you
think of any standalone usage?
Other than import / export features, No. What I had in mind is something like what vincent suggested. I also have to agree that doing this kind of a separation just for the sake of modularizing might be an overkill at this point. However, if we introduce an xwiki-office-exporter module, we definitely do not want that module to depend on xwiki-office-importer module so that it can consume openoffice services (that doesn't sound right). So it seemed logical that we extract out an xwiki-office-openoffice (like vincent has suggested) module which will be consumed by both xwiki-office-importer and xwiki-office-exporter modules. Thanks. - Asiri
-- Sergiu Dumitriu http://purl.org/net/sergiu/ _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
Hi, On 12/19/2009 7:12 PM, Asiri Rathnayake wrote:
Hi,
Will this module be useful outside the import/export feature? Can you
think of any standalone usage?
Other than import / export features, No. What I had in mind is something like what vincent suggested. I also have to agree that doing this kind of a separation just for the sake of modularizing might be an overkill at this point.
However, if we introduce an xwiki-office-exporter module, we definitely do not want that module to depend on xwiki-office-importer module so that it can consume openoffice services (that doesn't sound right).
So it seemed logical that we extract out an xwiki-office-openoffice (like vincent has suggested) module which will be consumed by both xwiki-office-importer and xwiki-office-exporter modules.
Same issue here, why would you need the exporter as a separate platform module? IMO, you should have a single platform module for the office import/export functionality, and have the server management, importer and exporter as nested modules. Even if this proves to be insufficient in the future, you should not hurry the transition today since there's no actual roadmap for the exporter or other possible features. Thanks, Florin Ciubotaru
Thanks.
- Asiri
-- Sergiu Dumitriu http://purl.org/net/sergiu/ _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
Hi, Same issue here, why would you need the exporter as a separate platform
module? IMO, you should have a single platform module for the office import/export functionality, and have the server management, importer and exporter as nested modules.
This is what vincent has suggested (is it not?) and I also agree.
Even if this proves to be insufficient in the future, you should not hurry the transition today since there's no actual roadmap for the exporter or other possible features.
Yes, this is not something urgent and for a fact I won't have time to make this transition at this point. This is why I started a discussion rather than a vote or proposal. Thanks. - Asiri
Thanks, Florin Ciubotaru
Thanks.
- Asiri
-- Sergiu Dumitriu http://purl.org/net/sergiu/ _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
participants (4)
-
Asiri Rathnayake -
Florin Ciubotaru -
Sergiu Dumitriu -
Vincent Massol