[xwiki-devs] [GSOC][WEBDAV] Need a complete refactoring of code.
Hi Ludovic, I have added PUT / MKCOL support for xwiki-webdav but MKCOL support is limited at this point. Users can add spaces, pages (into spaces), edit / write changes into pages. But i've hit a wall trying to implement prent-child relationships (adding child pages). At this point i have to emphasize that we need to refactor our code base before moving any further, because XWikiDavResourceImpl is really huge and it's complexity drives me nuts at some points (sooo many if-else switches). At a first glance i see following class structure, DavResource | + - XWikiDavResource (abstract) | + - XWikiRootDavResource (for views) | + - XWikiSpaceDavResource | + - XWikiPageDavResource | + - XWikiAttachmentDavResource I've almost hit a dead-end with the current code base (because i was trying to stick with it) and i seriously believe we have to refactor. I can complete this refactoring within a week's time so that it won't affect my time line. Ludovic, what so you think ? If any of you have comments about the design i propose, please let me know. Thanks. - Asiri
Hi Asiri, I agree.. modularization is important.. I think you should also have different classes for each view.. It would be great to be able to extend the application with views (written in groovy for example). You could for example make a view of documents of a certain class.. I'm sending another email because I cannot run the prototype. Ludovic Asiri Rathnayake wrote:
Hi Ludovic,
I have added PUT / MKCOL support for xwiki-webdav but MKCOL support is limited at this point. Users can add spaces, pages (into spaces), edit / write changes into pages. But i've hit a wall trying to implement prent-child relationships (adding child pages).
At this point i have to emphasize that we need to refactor our code base before moving any further, because XWikiDavResourceImpl is really huge and it's complexity drives me nuts at some points (sooo many if-else switches).
At a first glance i see following class structure,
DavResource | + - XWikiDavResource (abstract) | + - XWikiRootDavResource (for views) | + - XWikiSpaceDavResource | + - XWikiPageDavResource | + - XWikiAttachmentDavResource
I've almost hit a dead-end with the current code base (because i was trying to stick with it) and i seriously believe we have to refactor.
I can complete this refactoring within a week's time so that it won't affect my time line.
Ludovic, what so you think ?
If any of you have comments about the design i propose, please let me know.
Thanks.
- Asiri
-- Ludovic Dubost Blog: http://blog.ludovic.org/ XWiki: http://www.xwiki.com Skype: ldubost GTalk: ldubost
On Sun, Jul 13, 2008 at 12:36 PM, Ludovic Dubost <[email protected]> wrote:
Hi Asiri,
I agree.. modularization is important.. I think you should also have different classes for each view..
Good Point. :) Thanks. - Asiri
It would be great to be able to extend the application with views (written in groovy for example).
You could for example make a view of documents of a certain class..
I'm sending another email because I cannot run the prototype.
Ludovic
Asiri Rathnayake wrote:
Hi Ludovic,
I have added PUT / MKCOL support for xwiki-webdav but MKCOL support is limited at this point. Users can add spaces, pages (into spaces), edit / write changes into pages. But i've hit a wall trying to implement prent-child relationships (adding child pages).
At this point i have to emphasize that we need to refactor our code base before moving any further, because XWikiDavResourceImpl is really huge and it's complexity drives me nuts at some points (sooo many if-else switches).
At a first glance i see following class structure,
DavResource | + - XWikiDavResource (abstract) | + - XWikiRootDavResource (for views) | + - XWikiSpaceDavResource | + - XWikiPageDavResource | + - XWikiAttachmentDavResource
I've almost hit a dead-end with the current code base (because i was trying to stick with it) and i seriously believe we have to refactor.
I can complete this refactoring within a week's time so that it won't affect my time line.
Ludovic, what so you think ?
If any of you have comments about the design i propose, please let me know.
Thanks.
- Asiri
-- Ludovic Dubost Blog: http://blog.ludovic.org/ XWiki: http://www.xwiki.com Skype: ldubost GTalk: ldubost
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
participants (2)
-
Asiri Rathnayake -
Ludovic Dubost