Re: [xwiki-devs] [xwiki-notifications] r21720 - platform/core/trunk/xwiki-shared-tests
On Jun 30, 2009, at 12:11 PM, tmortagne (SVN) wrote:
Author: tmortagne Date: 2009-06-30 12:11:59 +0200 (Tue, 30 Jun 2009) New Revision: 21720
Modified: platform/core/trunk/xwiki-shared-tests/pom.xml Log: XWIKI-4047: Shared test project should provide an implementation of slf4j for every unit test with dependencies needing it
Modified: platform/core/trunk/xwiki-shared-tests/pom.xml =================================================================== --- platform/core/trunk/xwiki-shared-tests/pom.xml 2009-06-30 09:05:32 UTC (rev 21719) +++ platform/core/trunk/xwiki-shared-tests/pom.xml 2009-06-30 10:11:59 UTC (rev 21720) @@ -65,5 +65,12 @@ <artifactId>ant</artifactId> <version>1.7.0</version> </dependency> + <!-- Make sure we provide a default implementation of slf4j for any test indirectly use it --> + <dependency> + <groupId>org.slf4j</groupId> + <artifactId>slf4j-log4j12</artifactId> + <version>1.5.8</version> + <scope>runtime</scope> + </dependency>
I don't understand why the tests who need slf4j don't add it in their poms? Is it required in all tests? BTW we should probably use a mock logger for the tests instead. Thanks -Vincent
On Tue, Jun 30, 2009 at 12:42, Vincent Massol<[email protected]> wrote:
On Jun 30, 2009, at 12:11 PM, tmortagne (SVN) wrote:
Author: tmortagne Date: 2009-06-30 12:11:59 +0200 (Tue, 30 Jun 2009) New Revision: 21720
Modified: platform/core/trunk/xwiki-shared-tests/pom.xml Log: XWIKI-4047: Shared test project should provide an implementation of slf4j for every unit test with dependencies needing it
Modified: platform/core/trunk/xwiki-shared-tests/pom.xml =================================================================== --- platform/core/trunk/xwiki-shared-tests/pom.xml 2009-06-30 09:05:32 UTC (rev 21719) +++ platform/core/trunk/xwiki-shared-tests/pom.xml 2009-06-30 10:11:59 UTC (rev 21720) @@ -65,5 +65,12 @@ <artifactId>ant</artifactId> <version>1.7.0</version> </dependency> + <!-- Make sure we provide a default implementation of slf4j for any test indirectly use it --> + <dependency> + <groupId>org.slf4j</groupId> + <artifactId>slf4j-log4j12</artifactId> + <version>1.5.8</version> + <scope>runtime</scope> + </dependency>
I don't understand why the tests who need slf4j don't add it in their poms? Is it required in all tests?
A lot of them will need it when asiri will add xwiki-properties (every test executing macros since it hibernate-validator uses slf4j) and all of them if we make embedded component manager use slf4j.
BTW we should probably use a mock logger for the tests instead.
Probably but since we have lot of code using log4j it's better for now to make slf4j code use the same canal.
Thanks -Vincent _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
participants (2)
-
Thomas Mortagne -
Vincent Massol