Hi, On Wed, Aug 26, 2009 at 9:34 AM, Vincent Massol <[email protected]> wrote:

On Aug 26, 2009, at 9:31 AM, Sergiu Dumitriu wrote:

...

Vincent Massol wrote:

...

Hi everyone,

hmm we need to decide where to put this. I think it's the first time we have pages for a skin.

Is that something we want? Till now we've used vms instead of pages for skins.

In the case of ColorThemes it's easy for users to create new ones so it makes sense to have all of them available as examples inside the wiki.

...

...

Or do you consider color themes independent of a given skin? In which case, we could decide to create an application for it in applications/

In the future this will be moved to a skin application, once we refactor the way skins work (new Skins.SkinClass and the logic behind it).

Right now, it's not hard-tied to the skin, so it makes sense as documents inside XE.

Another pb is that ColorThemes isn't put in the blacklisted spaces I think so this space will appear by default everywhere we list spaces (dashboard, etc) I don't think this is something simple users should see, right?

Agreed. Can we add the ColorThemes space to the list of blacklsted spaces easily? Guillaume

Thanks -Vincent

...

...

WDYT?

Thanks -Vincent

On Aug 26, 2009, at 9:21 AM, sdumitriu (SVN) wrote:

...

Author: sdumitriu Date: 2009-08-26 09:21:10 +0200 (Wed, 26 Aug 2009) New Revision: 22926

Added: enterprise/trunk/wiki/src/main/resources/ColorThemes/ enterprise/trunk/wiki/src/main/resources/ColorThemes/BlueSky.xml enterprise/trunk/wiki/src/main/resources/ColorThemes/Bordo.xml enterprise/trunk/wiki/src/main/resources/ColorThemes/ ColorThemeClass.xml enterprise/trunk/wiki/src/main/resources/ColorThemes/ ColorThemeSheet.xml enterprise/trunk/wiki/src/main/resources/ColorThemes/ ColorThemeTemplate.xml enterprise/trunk/wiki/src/main/resources/ColorThemes/ DefaultColorTheme.xml enterprise/trunk/wiki/src/main/resources/ColorThemes/InnerDark.xml enterprise/trunk/wiki/src/main/resources/ColorThemes/Nature.xml enterprise/trunk/wiki/src/main/resources/ColorThemes/Nightfall.xml enterprise/trunk/wiki/src/main/resources/ColorThemes/Peach.xml enterprise/trunk/wiki/src/main/resources/ColorThemes/WebHome.xml Log: XE-?: New ColorTheme application Done

_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs

-- Guillaume Lerouge Product Manager - XWiki Skype: wikibc Twitter: glerouge http://guillaumelerouge.com/

Just re-read my message and I realized I didn't express myself correctly so apologies for this. I definitely didn't mean that the color theme app was crap. I love it actually. I was talking generally speaking and answering Guillaume about not doing things that are technically not correct just because it would benefit some (0.1%) of users. Sorry for the tone and confusion, especially since I'm thrilled by the new skin and the color themes :) Thanks -Vincent On Wed, Aug 26, 2009 at 10:17 AM, Vincent Massol<[email protected]> wrote:

On Aug 26, 2009, at 9:50 AM, Guillaume Lerouge wrote:

...

Hi,

On Wed, Aug 26, 2009 at 9:34 AM, Vincent Massol <[email protected]> wrote:

...

On Aug 26, 2009, at 9:31 AM, Sergiu Dumitriu wrote:

...

Vincent Massol wrote:

...

Hi everyone,

hmm we need to decide where to put this. I think it's the first time we have pages for a skin.

Is that something we want? Till now we've used vms instead of pages for skins.

In the case of ColorThemes it's easy for users to create new ones so it makes sense to have all of them available as examples inside the wiki.

This isn't a good reason Guillaume. We cannot do technical crap just to satisfy the user's curiosity. For example are you suggesting we put all the java code we have as groovy code inside wiki pages so that people who want to see the code can do so easily?

The same applies for vms which could all be put as skins in wiki pages.

Letting users creating new color themes as wiki pages is one thing. Deciding that our skins are now packaged as both a zip and a XAR is another.

Thanks -Vincent

...

...

...

...

Or do you consider color themes independent of a given skin? In which case, we could decide to create an application for it in applications/

In the future this will be moved to a skin application, once we refactor the way skins work (new Skins.SkinClass and the logic behind it).

Right now, it's not hard-tied to the skin, so it makes sense as documents inside XE.

Another pb is that ColorThemes isn't put in the blacklisted spaces I think so this space will appear by default everywhere we list spaces (dashboard, etc) I don't think this is something simple users should see, right?

Agreed. Can we add the ColorThemes space to the list of blacklsted spaces easily?

Guillaume

...

Thanks -Vincent

...

...

WDYT?

Thanks -Vincent

On Aug 26, 2009, at 9:21 AM, sdumitriu (SVN) wrote:

...

Author: sdumitriu Date: 2009-08-26 09:21:10 +0200 (Wed, 26 Aug 2009) New Revision: 22926

Added: enterprise/trunk/wiki/src/main/resources/ColorThemes/ enterprise/trunk/wiki/src/main/resources/ColorThemes/BlueSky.xml enterprise/trunk/wiki/src/main/resources/ColorThemes/Bordo.xml enterprise/trunk/wiki/src/main/resources/ColorThemes/ ColorThemeClass.xml enterprise/trunk/wiki/src/main/resources/ColorThemes/ ColorThemeSheet.xml enterprise/trunk/wiki/src/main/resources/ColorThemes/ ColorThemeTemplate.xml enterprise/trunk/wiki/src/main/resources/ColorThemes/ DefaultColorTheme.xml enterprise/trunk/wiki/src/main/resources/ColorThemes/InnerDark.xml enterprise/trunk/wiki/src/main/resources/ColorThemes/Nature.xml enterprise/trunk/wiki/src/main/resources/ColorThemes/Nightfall.xml enterprise/trunk/wiki/src/main/resources/ColorThemes/Peach.xml enterprise/trunk/wiki/src/main/resources/ColorThemes/WebHome.xml Log: XE-?: New ColorTheme application Done