[xwiki-devs] [VOTE] Rendering API change: move Syntax classes to syntax package
Hi, I'd like to move syntax-related classes to org.rendering.syntax package. These are: - Syntax - SyntaxFactory - SyntaxType Right now they are in the org.rendering.parser package but that's not right since Syntax classes are used in Listeners, Parsers, Transformations, etc which are all top level rendering packages. This will break the API and is not backward compatible (for those using the rendering api directly) which is why I'd like to do this ASAP so that it's in XE 2.0 (which doesn't have to be backward compatible). Note that we already have lots of api breakage for the rendering module: <exclude>org/xwiki/rendering/listener/chaining/ AbstractChainingListener</exclude> <exclude>org/xwiki/rendering/renderer/EventsRenderer</ exclude> <exclude>org/xwiki/rendering/renderer/ PlainTextRenderer</exclude> <exclude>org/xwiki/rendering/renderer/TexRenderer</ exclude> <exclude>org/xwiki/rendering/renderer/XHTMLRenderer</ exclude> <exclude>org/xwiki/rendering/renderer/ XWikiSyntaxRenderer</exclude> <exclude>org/xwiki/rendering/renderer/ PrintRendererFactory</exclude> <exclude>org/xwiki/rendering/renderer/PrintRenderer</ exclude> <exclude>org/xwiki/rendering/renderer/chaining/ AbstractChainingPrintRenderer</exclude> <exclude>org/xwiki/rendering/renderer/xhtml/ DefaultXHTMLImageRenderer</exclude> <exclude>org/xwiki/rendering/renderer/xhtml/ DefaultXHTMLLinkRenderer</exclude> <exclude>org/xwiki/rendering/renderer/xhtml/ XHTMLRendererFactory</exclude> <exclude>org/xwiki/rendering/util/RenderersUtils</ exclude> <exclude>org/xwiki/rendering/parser/SyntaxFactory</ exclude> <exclude>org/xwiki/rendering/renderer/xhtml/ XHTMLImageRenderer</exclude> <exclude>org/xwiki/rendering/renderer/xhtml/ XHTMLLinkRenderer</exclude> <exclude>org/xwiki/rendering/parser/SyntaxType</ exclude> <exclude>org/xwiki/rendering/macro/descriptor/ MacroDescriptor</exclude> <exclude>org/xwiki/rendering/renderer/printer/ MonitoringWikiPrinter</exclude> <exclude>org/xwiki/rendering/configuration/ RenderingConfiguration</exclude> <exclude>org/xwiki/rendering/macro/MacroManager</ exclude> <exclude>org/xwiki/rendering/block/MacroBlock</exclude> <exclude>org/xwiki/rendering/macro/AbstractMacro</ exclude> <exclude>org/xwiki/rendering/macro/descriptor/ AbstractMacroDescriptor</exclude> <exclude>org/xwiki/rendering/macro/descriptor/ DefaultMacroDescriptor</exclude> <exclude>org/xwiki/rendering/block/ PlainTextBlockFilter</exclude> <exclude>org/xwiki/rendering/util/ParserUtils</exclude> This will add some more. Here's my +1 Thanks -Vincent
+1 Thanks, Marius Vincent Massol wrote:
Hi,
I'd like to move syntax-related classes to org.rendering.syntax package. These are: - Syntax - SyntaxFactory - SyntaxType
Right now they are in the org.rendering.parser package but that's not right since Syntax classes are used in Listeners, Parsers, Transformations, etc which are all top level rendering packages.
This will break the API and is not backward compatible (for those using the rendering api directly) which is why I'd like to do this ASAP so that it's in XE 2.0 (which doesn't have to be backward compatible).
Note that we already have lots of api breakage for the rendering module:
<exclude>org/xwiki/rendering/listener/chaining/ AbstractChainingListener</exclude> <exclude>org/xwiki/rendering/renderer/EventsRenderer</ exclude> <exclude>org/xwiki/rendering/renderer/ PlainTextRenderer</exclude> <exclude>org/xwiki/rendering/renderer/TexRenderer</ exclude> <exclude>org/xwiki/rendering/renderer/XHTMLRenderer</ exclude> <exclude>org/xwiki/rendering/renderer/ XWikiSyntaxRenderer</exclude> <exclude>org/xwiki/rendering/renderer/ PrintRendererFactory</exclude> <exclude>org/xwiki/rendering/renderer/PrintRenderer</ exclude> <exclude>org/xwiki/rendering/renderer/chaining/ AbstractChainingPrintRenderer</exclude> <exclude>org/xwiki/rendering/renderer/xhtml/ DefaultXHTMLImageRenderer</exclude> <exclude>org/xwiki/rendering/renderer/xhtml/ DefaultXHTMLLinkRenderer</exclude> <exclude>org/xwiki/rendering/renderer/xhtml/ XHTMLRendererFactory</exclude> <exclude>org/xwiki/rendering/util/RenderersUtils</ exclude> <exclude>org/xwiki/rendering/parser/SyntaxFactory</ exclude> <exclude>org/xwiki/rendering/renderer/xhtml/ XHTMLImageRenderer</exclude> <exclude>org/xwiki/rendering/renderer/xhtml/ XHTMLLinkRenderer</exclude> <exclude>org/xwiki/rendering/parser/SyntaxType</ exclude> <exclude>org/xwiki/rendering/macro/descriptor/ MacroDescriptor</exclude> <exclude>org/xwiki/rendering/renderer/printer/ MonitoringWikiPrinter</exclude> <exclude>org/xwiki/rendering/configuration/ RenderingConfiguration</exclude> <exclude>org/xwiki/rendering/macro/MacroManager</ exclude> <exclude>org/xwiki/rendering/block/MacroBlock</exclude> <exclude>org/xwiki/rendering/macro/AbstractMacro</ exclude> <exclude>org/xwiki/rendering/macro/descriptor/ AbstractMacroDescriptor</exclude> <exclude>org/xwiki/rendering/macro/descriptor/ DefaultMacroDescriptor</exclude> <exclude>org/xwiki/rendering/block/ PlainTextBlockFilter</exclude> <exclude>org/xwiki/rendering/util/ParserUtils</exclude>
This will add some more.
Here's my +1
Thanks -Vincent _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
+1 On Fri, Aug 14, 2009 at 08:51, Vincent Massol<[email protected]> wrote:
Hi,
I'd like to move syntax-related classes to org.rendering.syntax package. These are: - Syntax - SyntaxFactory - SyntaxType
Right now they are in the org.rendering.parser package but that's not right since Syntax classes are used in Listeners, Parsers, Transformations, etc which are all top level rendering packages.
This will break the API and is not backward compatible (for those using the rendering api directly) which is why I'd like to do this ASAP so that it's in XE 2.0 (which doesn't have to be backward compatible).
Note that we already have lots of api breakage for the rendering module:
<exclude>org/xwiki/rendering/listener/chaining/ AbstractChainingListener</exclude> <exclude>org/xwiki/rendering/renderer/EventsRenderer</ exclude> <exclude>org/xwiki/rendering/renderer/ PlainTextRenderer</exclude> <exclude>org/xwiki/rendering/renderer/TexRenderer</ exclude> <exclude>org/xwiki/rendering/renderer/XHTMLRenderer</ exclude> <exclude>org/xwiki/rendering/renderer/ XWikiSyntaxRenderer</exclude> <exclude>org/xwiki/rendering/renderer/ PrintRendererFactory</exclude> <exclude>org/xwiki/rendering/renderer/PrintRenderer</ exclude> <exclude>org/xwiki/rendering/renderer/chaining/ AbstractChainingPrintRenderer</exclude> <exclude>org/xwiki/rendering/renderer/xhtml/ DefaultXHTMLImageRenderer</exclude> <exclude>org/xwiki/rendering/renderer/xhtml/ DefaultXHTMLLinkRenderer</exclude> <exclude>org/xwiki/rendering/renderer/xhtml/ XHTMLRendererFactory</exclude> <exclude>org/xwiki/rendering/util/RenderersUtils</ exclude> <exclude>org/xwiki/rendering/parser/SyntaxFactory</ exclude> <exclude>org/xwiki/rendering/renderer/xhtml/ XHTMLImageRenderer</exclude> <exclude>org/xwiki/rendering/renderer/xhtml/ XHTMLLinkRenderer</exclude> <exclude>org/xwiki/rendering/parser/SyntaxType</ exclude> <exclude>org/xwiki/rendering/macro/descriptor/ MacroDescriptor</exclude> <exclude>org/xwiki/rendering/renderer/printer/ MonitoringWikiPrinter</exclude> <exclude>org/xwiki/rendering/configuration/ RenderingConfiguration</exclude> <exclude>org/xwiki/rendering/macro/MacroManager</ exclude> <exclude>org/xwiki/rendering/block/MacroBlock</exclude> <exclude>org/xwiki/rendering/macro/AbstractMacro</ exclude> <exclude>org/xwiki/rendering/macro/descriptor/ AbstractMacroDescriptor</exclude> <exclude>org/xwiki/rendering/macro/descriptor/ DefaultMacroDescriptor</exclude> <exclude>org/xwiki/rendering/block/ PlainTextBlockFilter</exclude> <exclude>org/xwiki/rendering/util/ParserUtils</exclude>
This will add some more.
Here's my +1
Thanks -Vincent _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
+1 Vincent Massol wrote:
Hi,
I'd like to move syntax-related classes to org.rendering.syntax package. These are: - Syntax - SyntaxFactory - SyntaxType
Right now they are in the org.rendering.parser package but that's not right since Syntax classes are used in Listeners, Parsers, Transformations, etc which are all top level rendering packages.
This will break the API and is not backward compatible (for those using the rendering api directly) which is why I'd like to do this ASAP so that it's in XE 2.0 (which doesn't have to be backward compatible).
Note that we already have lots of api breakage for the rendering module:
<exclude>org/xwiki/rendering/listener/chaining/ AbstractChainingListener</exclude> <exclude>org/xwiki/rendering/renderer/EventsRenderer</ exclude> <exclude>org/xwiki/rendering/renderer/ PlainTextRenderer</exclude> <exclude>org/xwiki/rendering/renderer/TexRenderer</ exclude> <exclude>org/xwiki/rendering/renderer/XHTMLRenderer</ exclude> <exclude>org/xwiki/rendering/renderer/ XWikiSyntaxRenderer</exclude> <exclude>org/xwiki/rendering/renderer/ PrintRendererFactory</exclude> <exclude>org/xwiki/rendering/renderer/PrintRenderer</ exclude> <exclude>org/xwiki/rendering/renderer/chaining/ AbstractChainingPrintRenderer</exclude> <exclude>org/xwiki/rendering/renderer/xhtml/ DefaultXHTMLImageRenderer</exclude> <exclude>org/xwiki/rendering/renderer/xhtml/ DefaultXHTMLLinkRenderer</exclude> <exclude>org/xwiki/rendering/renderer/xhtml/ XHTMLRendererFactory</exclude> <exclude>org/xwiki/rendering/util/RenderersUtils</ exclude> <exclude>org/xwiki/rendering/parser/SyntaxFactory</ exclude> <exclude>org/xwiki/rendering/renderer/xhtml/ XHTMLImageRenderer</exclude> <exclude>org/xwiki/rendering/renderer/xhtml/ XHTMLLinkRenderer</exclude> <exclude>org/xwiki/rendering/parser/SyntaxType</ exclude> <exclude>org/xwiki/rendering/macro/descriptor/ MacroDescriptor</exclude> <exclude>org/xwiki/rendering/renderer/printer/ MonitoringWikiPrinter</exclude> <exclude>org/xwiki/rendering/configuration/ RenderingConfiguration</exclude> <exclude>org/xwiki/rendering/macro/MacroManager</ exclude> <exclude>org/xwiki/rendering/block/MacroBlock</exclude> <exclude>org/xwiki/rendering/macro/AbstractMacro</ exclude> <exclude>org/xwiki/rendering/macro/descriptor/ AbstractMacroDescriptor</exclude> <exclude>org/xwiki/rendering/macro/descriptor/ DefaultMacroDescriptor</exclude> <exclude>org/xwiki/rendering/block/ PlainTextBlockFilter</exclude> <exclude>org/xwiki/rendering/util/ParserUtils</exclude>
This will add some more.
Here's my +1
-- Sergiu Dumitriu http://purl.org/net/sergiu/
+1 On Fri, Aug 14, 2009 at 12:21 PM, Vincent Massol <[email protected]> wrote:
Hi,
I'd like to move syntax-related classes to org.rendering.syntax package. These are: - Syntax - SyntaxFactory - SyntaxType
Right now they are in the org.rendering.parser package but that's not right since Syntax classes are used in Listeners, Parsers, Transformations, etc which are all top level rendering packages.
This will break the API and is not backward compatible (for those using the rendering api directly) which is why I'd like to do this ASAP so that it's in XE 2.0 (which doesn't have to be backward compatible).
Note that we already have lots of api breakage for the rendering module:
<exclude>org/xwiki/rendering/listener/chaining/ AbstractChainingListener</exclude> <exclude>org/xwiki/rendering/renderer/EventsRenderer</ exclude> <exclude>org/xwiki/rendering/renderer/ PlainTextRenderer</exclude> <exclude>org/xwiki/rendering/renderer/TexRenderer</ exclude> <exclude>org/xwiki/rendering/renderer/XHTMLRenderer</ exclude> <exclude>org/xwiki/rendering/renderer/ XWikiSyntaxRenderer</exclude> <exclude>org/xwiki/rendering/renderer/ PrintRendererFactory</exclude> <exclude>org/xwiki/rendering/renderer/PrintRenderer</ exclude> <exclude>org/xwiki/rendering/renderer/chaining/ AbstractChainingPrintRenderer</exclude> <exclude>org/xwiki/rendering/renderer/xhtml/ DefaultXHTMLImageRenderer</exclude> <exclude>org/xwiki/rendering/renderer/xhtml/ DefaultXHTMLLinkRenderer</exclude> <exclude>org/xwiki/rendering/renderer/xhtml/ XHTMLRendererFactory</exclude> <exclude>org/xwiki/rendering/util/RenderersUtils</ exclude> <exclude>org/xwiki/rendering/parser/SyntaxFactory</ exclude> <exclude>org/xwiki/rendering/renderer/xhtml/ XHTMLImageRenderer</exclude> <exclude>org/xwiki/rendering/renderer/xhtml/ XHTMLLinkRenderer</exclude> <exclude>org/xwiki/rendering/parser/SyntaxType</ exclude> <exclude>org/xwiki/rendering/macro/descriptor/ MacroDescriptor</exclude> <exclude>org/xwiki/rendering/renderer/printer/ MonitoringWikiPrinter</exclude> <exclude>org/xwiki/rendering/configuration/ RenderingConfiguration</exclude> <exclude>org/xwiki/rendering/macro/MacroManager</ exclude> <exclude>org/xwiki/rendering/block/MacroBlock</exclude> <exclude>org/xwiki/rendering/macro/AbstractMacro</ exclude> <exclude>org/xwiki/rendering/macro/descriptor/ AbstractMacroDescriptor</exclude> <exclude>org/xwiki/rendering/macro/descriptor/ DefaultMacroDescriptor</exclude> <exclude>org/xwiki/rendering/block/ PlainTextBlockFilter</exclude> <exclude>org/xwiki/rendering/util/ParserUtils</exclude>
This will add some more.
Here's my +1
Thanks -Vincent _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
participants (5)
-
Asiri Rathnayake -
Marius Dumitru Florea -
Sergiu Dumitriu -
Thomas Mortagne -
Vincent Massol