Hi, On Thu, Apr 10, 2014 at 1:18 PM, [email protected] <[email protected]>wrote:

Hi Caty,

On 10 Apr 2014 at 11:46:52, Ecaterina Moraru (Valica) ([email protected] (mailto:[email protected])) wrote:

...

Hi,

One of the objectives of 6.0 is to review the existing applications on extensions.xwiki.org, improve them and see how they would integrate in the new Flamingo skin (while also making improvements suggestions).

This mail covers the Flamingo integration for the Forum Application.

You can see the proposal at: http://design.xwiki.org/xwiki/bin/view/Proposal/ForumApplicationDesign

Any feedback is welcomed.

Very nice, I like it! Thanks for this proposal :)

Some comments/questions:

* On the home page ( http://design.xwiki.org/xwiki/bin/download/Proposal/ForumApplicationDesign/f...), the title is "Forum" and then there's a subtitle "All Forums" with a "Add forum" button. I was wondering if it wouldn't be nicer to have "All Forums" as the title and instead of the "Add forum" button, use the "+Add" button just above to let the user add a new forum (thus using the template provider feature)? That would make the UI even more pure.

Not sure what this 'template provider feature' is but ideally the buttons should all be grouped together. The problem is that right now the code for the buttons is found in menuview.vm so this layout with customized buttons after the #document-title/#document-info is more of a limitation we currently have with our extensibility. IMO the solution to this problem would be to have an extension point for the menus that allows applications to insert their functionality inside the menus, but maybe you can explain a bit more about 'template provider'.

* I find a forum's description a bit small and not visible enough compared to the list of topics: http://design.xwiki.org/xwiki/bin/download/Proposal/ForumApplicationDesign/d... we could do something to make it stand out more?

So I gave an example with: * a small description http://design.xwiki.org/xwiki/bin/download/Proposal/ForumApplicationDesign/d... * big description http://design.xwiki.org/xwiki/bin/download/Proposal/ForumApplicationDesign/f... The current layout accomodate ok if there is no text/small/big text. The hierarchy is done through space indentation. I've discussed with Max about making it more prominent by using background-color, but in the end this looked ok.

* When viewing all answers (for example http://design.xwiki.org/xwiki/bin/download/Proposal/ForumApplicationDesign/h...), each answer has a textarea visible to reply to a given answer. Mabye these textarea should not be shown by default and they should appear only when you click a "Reply" button?

This proposal focused very much on what is already implemented (with very small modifications/improvements) so the visible textarea is currently how it is now implemented. Your remark is good and is consistent with the way we add Topics or Answer: the textarea appears only when you press the 'Add' button.

* I think we're missing a compact view of all posts in a topic/forum, using a livetable for example. For example: http://www.jeuxvideo.com/forums/0-25271-0-1-0-1-0-dota-2.htm or http://forums.euw.leagueoflegends.com/board/forumdisplay.php?f=3

As I said before this proposals covers the current implementation. The problem with the Forum Application is that it is called Forum, but the functionality is not the classical one. Another application we have, called Bulletin Board, is more close to the standard implementation of how forums work. A new feature for this Forum App would be to provide a new view on the Forum's homepage where topics can be listed also as livetable, not just this current 'list view'. Currently this application only has 'List view' and a 'Sort' functionality in order to narrow down the entries, see http://design.xwiki.org/xwiki/bin/download/Proposal/ForumApplicationDesign/t... Another improvement for the 'List view' would be pagination.

* When listing all topics you seem to be cropping the topic description. We've noticed in the blog app that automatic cropping doesn't work so if we want that we'll need to ask the user to provide a short version and a long version description for a topic IMO.

The current implementation doesn't list any description, just the name. IMO is better to have this summary like mechanism. * In our Blog application we have a different field where the user can customize it; * we could try to automatic crop it - problems with the html macro used in WYSIWYG since it could break the display; * in my prototype I put the actual description and cropped with CSS - not so good from maybe a performance point of view. We can see what is the best solution for this, but IMO is better to provide some 'context' and not just the title.

* Should answers be implemented as page comments but styled differently than traditional comments? That would make sense to me. I noticed on your screenshots that the extradoc tabs at the bottom is not displayed.

So as I said this is already implemented. There is an automatically page naming mechanism that creates pages and objects for topic's answers. It is very hard to attach an attachment to a particular answer since they are generated, example: http://localhost:8080/xwiki/bin/view/Forums/Topic_4#.U0ZJ7q2SyLP http://localhost:8080/xwiki/bin/view/Forums/Topic_4#Topic4Answer_0 Since this is how it's done it's useless to try to put attachments to them since they will not correspond to this 'internal mapping' (I haven't studied the code in depth to know how this is really implemented). So the answer is that this is already implemented and I've removed confusing / not-working functionality. Is a 'feature'/'limitation' of the current implementation. Attachments can be added to an answer/comment by using the WYSIWYG Image functionality. Thank you for all your comments, Caty

Thanks! -Vincent

...

Thanks, Caty

_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs