Re: [xwiki-devs] [xwiki-notifications] r7713 - xwiki-platform/xwiki-applications/trunk/panels/src/main/resources/Panels
I don't like that. It means Panels can break the Panel Wizard... Also it means we'll get lots of user problems when people upgrade to 1.3M2 since they won't import the new panels... IMO this needs to be fixed in the Panel Wizard and the Panels should not be changed. -Vincent On Feb 13, 2008, at 11:25 PM, sdumitriu (SVN) wrote:
Author: sdumitriu Date: 2008-02-13 23:25:58 +0100 (Wed, 13 Feb 2008) New Revision: 7713
Modified: xwiki-platform/xwiki-applications/trunk/panels/src/main/resources/ Panels/Backlinks xwiki-platform/xwiki-applications/trunk/panels/src/main/resources/ Panels/EditTranslations Log: XAPANELS-42: Some panels break the panel wizard Fixed.
Modified: xwiki-platform/xwiki-applications/trunk/panels/src/main/ resources/Panels/Backlinks =================================================================== --- xwiki-platform/xwiki-applications/trunk/panels/src/main/ resources/Panels/Backlinks 2008-02-13 22:18:02 UTC (rev 7712) +++ xwiki-platform/xwiki-applications/trunk/panels/src/main/ resources/Panels/Backlinks 2008-02-13 22:25:58 UTC (rev 7713) @@ -136,7 +136,7 @@ </property> <property> <content>#set($blinks = $doc.getBacklinks()) -#if($blinks.size()>0) +#if($blinks.size()>0 || $showEmptyPanels) #panelheader('Backlinks') #set($first = true) #foreach($docname in $blinks)
Modified: xwiki-platform/xwiki-applications/trunk/panels/src/main/ resources/Panels/EditTranslations =================================================================== --- xwiki-platform/xwiki-applications/trunk/panels/src/main/ resources/Panels/EditTranslations 2008-02-13 22:18:02 UTC (rev 7712) +++ xwiki-platform/xwiki-applications/trunk/panels/src/main/ resources/Panels/EditTranslations 2008-02-13 22:25:58 UTC (rev 7713) @@ -99,7 +99,7 @@ <category>Information</category> </property> <property> -<content>#if($xwiki.isMultiLingual()==true) +<content>#if($xwiki.isMultiLingual()==true || $showEmptyPanels) #largepanelheader($msg.get("panels.translation.title")) #if(($request.language)&&($request.language! ="default")&&($doc.defaultLanguage!=$request.language)) #set($forcetrans = $request.language)
_______________________________________________ notifications mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/notifications
Me neither, but until XWIKI-584 gets fixed, that's the least I can do. This is just a quick workaround for fixing the panel wizard. Vincent Massol wrote:
I don't like that. It means Panels can break the Panel Wizard...
Also it means we'll get lots of user problems when people upgrade to 1.3M2 since they won't import the new panels...
IMO this needs to be fixed in the Panel Wizard and the Panels should not be changed.
-Vincent
On Feb 13, 2008, at 11:25 PM, sdumitriu (SVN) wrote:
Author: sdumitriu Date: 2008-02-13 23:25:58 +0100 (Wed, 13 Feb 2008) New Revision: 7713
Modified: xwiki-platform/xwiki-applications/trunk/panels/src/main/resources/ Panels/Backlinks xwiki-platform/xwiki-applications/trunk/panels/src/main/resources/ Panels/EditTranslations Log: XAPANELS-42: Some panels break the panel wizard Fixed.
Modified: xwiki-platform/xwiki-applications/trunk/panels/src/main/ resources/Panels/Backlinks =================================================================== --- xwiki-platform/xwiki-applications/trunk/panels/src/main/ resources/Panels/Backlinks 2008-02-13 22:18:02 UTC (rev 7712) +++ xwiki-platform/xwiki-applications/trunk/panels/src/main/ resources/Panels/Backlinks 2008-02-13 22:25:58 UTC (rev 7713) @@ -136,7 +136,7 @@ </property> <property> <content>#set($blinks = $doc.getBacklinks()) -#if($blinks.size()>0) +#if($blinks.size()>0 || $showEmptyPanels) #panelheader('Backlinks') #set($first = true) #foreach($docname in $blinks)
Modified: xwiki-platform/xwiki-applications/trunk/panels/src/main/ resources/Panels/EditTranslations =================================================================== --- xwiki-platform/xwiki-applications/trunk/panels/src/main/ resources/Panels/EditTranslations 2008-02-13 22:18:02 UTC (rev 7712) +++ xwiki-platform/xwiki-applications/trunk/panels/src/main/ resources/Panels/EditTranslations 2008-02-13 22:25:58 UTC (rev 7713) @@ -99,7 +99,7 @@ <category>Information</category> </property> <property> -<content>#if($xwiki.isMultiLingual()==true) +<content>#if($xwiki.isMultiLingual()==true || $showEmptyPanels) #largepanelheader($msg.get("panels.translation.title")) #if(($request.language)&&($request.language! ="default")&&($doc.defaultLanguage!=$request.language)) #set($forcetrans = $request.language)
-- Sergiu Dumitriu http://purl.org/net/sergiu/
participants (2)
-
Sergiu Dumitriu -
Vincent Massol