Re: [xwiki-devs] [xwiki-notifications] r23516 - platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/plugin/feed
Hi, On Sep 14, 2009, at 6:13 PM, jvdrean (SVN) wrote:
Author: jvdrean Date: 2009-09-14 18:13:16 +0200 (Mon, 14 Sep 2009) New Revision: 23516
Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/plugin/ feed/FeedPlugin.java platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/plugin/ feed/FeedPluginApi.java platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/plugin/ feed/SyndEntryDocumentSource.java platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/plugin/ feed/SyndEntrySource.java platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/plugin/ feed/SyndEntrySourceApi.java Log: [misc] Introduce generics
[snip]
/** @@ -470,7 +481,8 @@ */ public SyndFeed getWebFeed(String query, int count, int start) { - return getWebFeed(query, count, start, Collections.EMPTY_MAP); + Map<String, Object> metadata = new HashMap<String, Object>(); + return getWebFeed(query, count, start, metadata); }
Shouldn't this use Collections.emptyMap()? Thanks -Vincent
On Mon, Sep 14, 2009 at 9:06 PM, Vincent Massol <[email protected]> wrote:
Hi,
On Sep 14, 2009, at 6:13 PM, jvdrean (SVN) wrote:
Author: jvdrean Date: 2009-09-14 18:13:16 +0200 (Mon, 14 Sep 2009) New Revision: 23516
Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/plugin/ feed/FeedPlugin.java platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/plugin/ feed/FeedPluginApi.java platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/plugin/ feed/SyndEntryDocumentSource.java platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/plugin/ feed/SyndEntrySource.java platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/plugin/ feed/SyndEntrySourceApi.java Log: [misc] Introduce generics
[snip]
/** @@ -470,7 +481,8 @@ */ public SyndFeed getWebFeed(String query, int count, int start) { - return getWebFeed(query, count, start, Collections.EMPTY_MAP); + Map<String, Object> metadata = new HashMap<String, Object>(); + return getWebFeed(query, count, start, metadata); }
Shouldn't this use Collections.emptyMap()?
Thanks -Vincent
I've used Collections.emptyMap() when possible, a HashMap when a mutable map was required. Thanks, JV.
On Sep 15, 2009, at 11:48 AM, Jean-Vincent Drean wrote:
On Mon, Sep 14, 2009 at 9:06 PM, Vincent Massol <[email protected]> wrote:
Hi,
On Sep 14, 2009, at 6:13 PM, jvdrean (SVN) wrote:
Author: jvdrean Date: 2009-09-14 18:13:16 +0200 (Mon, 14 Sep 2009) New Revision: 23516
Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/plugin/ feed/FeedPlugin.java platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/plugin/ feed/FeedPluginApi.java platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/plugin/ feed/SyndEntryDocumentSource.java platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/plugin/ feed/SyndEntrySource.java platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/plugin/ feed/SyndEntrySourceApi.java Log: [misc] Introduce generics
[snip]
/** @@ -470,7 +481,8 @@ */ public SyndFeed getWebFeed(String query, int count, int start) { - return getWebFeed(query, count, start, Collections.EMPTY_MAP); + Map<String, Object> metadata = new HashMap<String, Object>(); + return getWebFeed(query, count, start, metadata); }
Shouldn't this use Collections.emptyMap()?
Thanks -Vincent
I've used Collections.emptyMap() when possible, a HashMap when a mutable map was required.
Then it's very strange that getWebFeed requires a mutable map isn't it? It should have it own map probably. Thanks -Vincent
participants (2)
-
Jean-Vincent Drean -
Vincent Massol