[xwiki-devs] [Proposal] Change URL resolution behavior when in path-based
Hi devs, Right now when in path-based, if a /wiki/somewiki/ path is found but no wiki descriptor is found for alias "somewiki" then we try to split on "." and then perform some checks on localhost/IP/www. I don't think this is right (there's no real logic behind this) and I'm proposing to fix this. Specifically ATM if you have /wiki/enterprise.xwiki.org/space/page then the algorithm is going to look first for an alias of "enterprise.xwiki.org" (that's good) but if not found, it's going to look for a wikiid descriptor for "enterprise" which isn't normal. Note that I've already implemented this fix locally (in the new URL module) and I'm waiting for this decision to commit it. Barring any negative feedback I'll commit it at the end of the week. Thanks -Vincent
+1 On Wed, May 29, 2013 at 9:33 AM, Vincent Massol <[email protected]> wrote:
Hi devs,
Right now when in path-based, if a /wiki/somewiki/ path is found but no wiki descriptor is found for alias "somewiki" then we try to split on "." and then perform some checks on localhost/IP/www.
I don't think this is right (there's no real logic behind this) and I'm proposing to fix this.
Specifically ATM if you have /wiki/enterprise.xwiki.org/space/page then the algorithm is going to look first for an alias of "enterprise.xwiki.org" (that's good) but if not found, it's going to look for a wikiid descriptor for "enterprise" which isn't normal.
Note that I've already implemented this fix locally (in the new URL module) and I'm waiting for this decision to commit it.
Barring any negative feedback I'll commit it at the end of the week.
Thanks -Vincent
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
+0 On a path-based XEM 5.1-SNAPSHOT with Workspace Manager, I see that the Workspace Template wiki (workspacetemplate) has 'workspacetemplate.template.local' listed as domain name. The link is /xwiki/wiki/workspacetemplate.template.local/view/Main/WebHome . I guess we need to change the domain name? Thanks, Marius On Wed, May 29, 2013 at 10:33 AM, Vincent Massol <[email protected]> wrote:
Hi devs,
Right now when in path-based, if a /wiki/somewiki/ path is found but no wiki descriptor is found for alias "somewiki" then we try to split on "." and then perform some checks on localhost/IP/www.
I don't think this is right (there's no real logic behind this) and I'm proposing to fix this.
Specifically ATM if you have /wiki/enterprise.xwiki.org/space/page then the algorithm is going to look first for an alias of "enterprise.xwiki.org" (that's good) but if not found, it's going to look for a wikiid descriptor for "enterprise" which isn't normal.
Note that I've already implemented this fix locally (in the new URL module) and I'm waiting for this decision to commit it.
Barring any negative feedback I'll commit it at the end of the week.
Thanks -Vincent
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
+1 On Wed, May 29, 2013 at 11:39 AM, Marius Dumitru Florea < [email protected]> wrote:
+0
On a path-based XEM 5.1-SNAPSHOT with Workspace Manager, I see that the Workspace Template wiki (workspacetemplate) has 'workspacetemplate.template.local' listed as domain name. The link is /xwiki/wiki/workspacetemplate.template.local/view/Main/WebHome . I guess we need to change the domain name?
Thanks, Marius
On Wed, May 29, 2013 at 10:33 AM, Vincent Massol <[email protected]> wrote:
Hi devs,
Right now when in path-based, if a /wiki/somewiki/ path is found but no wiki descriptor is found for alias "somewiki" then we try to split on "." and then perform some checks on localhost/IP/www.
I don't think this is right (there's no real logic behind this) and I'm proposing to fix this.
Specifically ATM if you have /wiki/enterprise.xwiki.org/space/page then the algorithm is going to look first for an alias of "enterprise.xwiki.org" (that's good) but if not found, it's going to look for a wikiid descriptor for "enterprise" which isn't normal.
Note that I've already implemented this fix locally (in the new URL module) and I'm waiting for this decision to commit it.
Barring any negative feedback I'll commit it at the end of the week.
Thanks -Vincent
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Denis Gervalle SOFTEC sa - CEO eGuilde sarl - CTO
On May 29, 2013, at 11:39 AM, Marius Dumitru Florea <[email protected]> wrote:
+0
On a path-based XEM 5.1-SNAPSHOT with Workspace Manager, I see that the Workspace Template wiki (workspacetemplate) has 'workspacetemplate.template.local' listed as domain name. The link is /xwiki/wiki/workspacetemplate.template.local/view/Main/WebHome . I guess we need to change the domain name?
Since we've been using path-based as default for a long time now it would be good to change the default alias indeed (but that's independent of this proposal). Thanks -Vincent
Thanks, Marius
On Wed, May 29, 2013 at 10:33 AM, Vincent Massol <[email protected]> wrote:
Hi devs,
Right now when in path-based, if a /wiki/somewiki/ path is found but no wiki descriptor is found for alias "somewiki" then we try to split on "." and then perform some checks on localhost/IP/www.
I don't think this is right (there's no real logic behind this) and I'm proposing to fix this.
Specifically ATM if you have /wiki/enterprise.xwiki.org/space/page then the algorithm is going to look first for an alias of "enterprise.xwiki.org" (that's good) but if not found, it's going to look for a wikiid descriptor for "enterprise" which isn't normal.
Note that I've already implemented this fix locally (in the new URL module) and I'm waiting for this decision to commit it.
Barring any negative feedback I'll commit it at the end of the week.
Thanks -Vincent
participants (4)
-
Denis Gervalle -
Marius Dumitru Florea -
Thomas Mortagne -
Vincent Massol