[xwiki-devs] [VOTE] Modify ParameterDescriptor/PropertyDescriptor to support id/name
Hi devs, We want to display macros parameters pretty names in the WYSIWYG. For that we need to provide it in the WYSIWYG. The current ParameterDescriptor#getName actually return the parameter identifier/technical name. So I see two solutions: 1) the general rule in new XWiki architecture is to use id/name instead of name/prettyname so i propose to break ParameterDescriptor and PropertyDescriptor to follow this rule. 2) add a getDisplayName method and let getName for the identifier WDYT ? +1 for 1). I never like to break an API but doubt this API is used a lots yet except by us internally and it would like we use the same rule everywhere as much as possible. -- Thomas Mortagne
On Oct 26, 2009, at 5:18 PM, Thomas Mortagne wrote:
Hi devs,
We want to display macros parameters pretty names in the WYSIWYG.
For that we need to provide it in the WYSIWYG. The current ParameterDescriptor#getName actually return the parameter identifier/technical name.
So I see two solutions: 1) the general rule in new XWiki architecture is to use id/name instead of name/prettyname so i propose to break ParameterDescriptor and PropertyDescriptor to follow this rule. 2) add a getDisplayName method and let getName for the identifier
WDYT ?
+1 for 1). I never like to break an API but doubt this API is used a lots yet except by us internally and it would like we use the same rule everywhere as much as possible.
+1 for 1). Thanks -Vincent
Hi, On Mon, Oct 26, 2009 at 9:48 PM, Thomas Mortagne <[email protected]>wrote:
Hi devs,
We want to display macros parameters pretty names in the WYSIWYG.
For that we need to provide it in the WYSIWYG. The current ParameterDescriptor#getName actually return the parameter identifier/technical name.
So I see two solutions: 1) the general rule in new XWiki architecture is to use id/name instead of name/prettyname so i propose to break ParameterDescriptor and PropertyDescriptor to follow this rule. 2) add a getDisplayName method and let getName for the identifier
WDYT ?
+1 for 1). I never like to break an API but doubt this API is used a lots yet except by us internally and it would like we use the same rule everywhere as much as possible.
+1 for 1) If you can create a JIRA for updating wiki macros to support this, I will work on it as soon as you are done. Thanks. - Asiri
-- Thomas Mortagne _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
On Mon, Oct 26, 2009 at 17:34, Asiri Rathnayake <[email protected]> wrote:
Hi,
On Mon, Oct 26, 2009 at 9:48 PM, Thomas Mortagne <[email protected]>wrote:
Hi devs,
We want to display macros parameters pretty names in the WYSIWYG.
For that we need to provide it in the WYSIWYG. The current ParameterDescriptor#getName actually return the parameter identifier/technical name.
So I see two solutions: 1) the general rule in new XWiki architecture is to use id/name instead of name/prettyname so i propose to break ParameterDescriptor and PropertyDescriptor to follow this rule. 2) add a getDisplayName method and let getName for the identifier
WDYT ?
+1 for 1). I never like to break an API but doubt this API is used a lots yet except by us internally and it would like we use the same rule everywhere as much as possible.
+1 for 1)
If you can create a JIRA for updating wiki macros to support this, I will work on it as soon as you are done.
Sure. Of course I will handle the breaking part on wiki macro and WYSIWYG myself in the same commit (I well let you and Marius take care of the new pretty name feature part ;)).
Thanks.
- Asiri
-- Thomas Mortagne _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
Thomas Mortagne wrote:
Hi devs,
We want to display macros parameters pretty names in the WYSIWYG.
For that we need to provide it in the WYSIWYG. The current ParameterDescriptor#getName actually return the parameter identifier/technical name.
So I see two solutions: 1) the general rule in new XWiki architecture is to use id/name instead of name/prettyname so i propose to break ParameterDescriptor and PropertyDescriptor to follow this rule. 2) add a getDisplayName method and let getName for the identifier
WDYT ?
+1 for 1) Thanks, Marius
+1 for 1). I never like to break an API but doubt this API is used a lots yet except by us internally and it would like we use the same rule everywhere as much as possible.
On 10/26/2009 05:18 PM, Thomas Mortagne wrote:
Hi devs,
We want to display macros parameters pretty names in the WYSIWYG.
For that we need to provide it in the WYSIWYG. The current ParameterDescriptor#getName actually return the parameter identifier/technical name.
So I see two solutions: 1) the general rule in new XWiki architecture is to use id/name instead of name/prettyname so i propose to break ParameterDescriptor and PropertyDescriptor to follow this rule. 2) add a getDisplayName method and let getName for the identifier
WDYT ?
+1 for 1). I never like to break an API but doubt this API is used a lots yet except by us internally and it would like we use the same rule everywhere as much as possible.
+1 for 1) -- Sergiu Dumitriu http://purl.org/net/sergiu/
participants (5)
-
Asiri Rathnayake -
Marius Dumitru Florea -
Sergiu Dumitriu -
Thomas Mortagne -
Vincent Massol