[xwiki-devs] FindBugs on XWiki
Hello Xwiki-Devs, for the fun of it I let FindBugs check the Xwiki Core code and it found a bunch of "Issues". Some of them are more severe than others. Maybe it is interesting to check it out. In my own programs I found some really interesting errors/problems I was never aware of. (Including some thread safety related stuff) The good thing with Findbugs is the extensive documentation, that gives you a very good explanation why the found issue is an issue. There are also some "false positives", also explained in the documentation. http://findbugs.sourceforge.net/ Findbugs also has good Eclipse Integration and a Maven plugin. Definitely worth a try. A first peek is painlessly done via Java webstart. It's just a pointer.. Greetings Jonas
Hi, I too have worked with FindBugs and I think it's a good tool. May be it's a good idea to fix at least P1 bugs in core. Anyway, I personally don't like these tools (don't ask me why :P) - Asiri On Wed, Oct 1, 2008 at 6:17 PM, Jonas von Malottki <[email protected]> wrote:
Hello Xwiki-Devs,
for the fun of it I let FindBugs check the Xwiki Core code and it found a bunch of "Issues". Some of them are more severe than others.
Maybe it is interesting to check it out. In my own programs I found some really interesting errors/problems I was never aware of. (Including some thread safety related stuff)
The good thing with Findbugs is the extensive documentation, that gives you a very good explanation why the found issue is an issue. There are also some "false positives", also explained in the documentation.
http://findbugs.sourceforge.net/
Findbugs also has good Eclipse Integration and a Maven plugin. Definitely worth a try. A first peek is painlessly done via Java webstart.
It's just a pointer..
Greetings Jonas _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
Asiri Rathnayake wrote:
Hi,
I too have worked with FindBugs and I think it's a good tool. May be it's a good idea to fix at least P1 bugs in core. Anyway, I personally don't like these tools (don't ask me why :P)
What I really liked, was the fact, that I could learn a great deal about my own code that is relevant to some bug prone or security related behavior, especially because the description is always very informative. cheers Jonas
Jonas von Malottki wrote:
Asiri Rathnayake wrote:
Hi,
I too have worked with FindBugs and I think it's a good tool. May be it's a good idea to fix at least P1 bugs in core. Anyway, I personally don't like these tools (don't ask me why :P)
What I really liked, was the fact, that I could learn a great deal about my own code that is relevant to some bug prone or security related behavior, especially because the description is always very informative.
Most of these "bugs" are already detected by the checkstyle maven plugin. But most of the code does not pass the checkstyle, as the effort to "fix" all the code is huge. The strategy is to provide clean implementations when creating new components. -- Sergiu Dumitriu http://purl.org/net/sergiu/
I love findbugs too and we definitely need to enable it as we're doing for checkstyle. I completely agree. It's a great tool. Thanks -Vincent On Oct 1, 2008, at 2:47 PM, Jonas von Malottki wrote:
Hello Xwiki-Devs,
for the fun of it I let FindBugs check the Xwiki Core code and it found a bunch of "Issues". Some of them are more severe than others.
Maybe it is interesting to check it out. In my own programs I found some really interesting errors/problems I was never aware of. (Including some thread safety related stuff)
The good thing with Findbugs is the extensive documentation, that gives you a very good explanation why the found issue is an issue. There are also some "false positives", also explained in the documentation.
http://findbugs.sourceforge.net/
Findbugs also has good Eclipse Integration and a Maven plugin. Definitely worth a try. A first peek is painlessly done via Java webstart.
It's just a pointer..
Greetings Jonas
BTW on this topic I've started playing with Sonar. I'd like to set it up for xwiki. http://sonar.codehaus.org/ Thanks -Vincent On Oct 1, 2008, at 2:47 PM, Jonas von Malottki wrote:
Hello Xwiki-Devs,
for the fun of it I let FindBugs check the Xwiki Core code and it found a bunch of "Issues". Some of them are more severe than others.
Maybe it is interesting to check it out. In my own programs I found some really interesting errors/problems I was never aware of. (Including some thread safety related stuff)
The good thing with Findbugs is the extensive documentation, that gives you a very good explanation why the found issue is an issue. There are also some "false positives", also explained in the documentation.
http://findbugs.sourceforge.net/
Findbugs also has good Eclipse Integration and a Maven plugin. Definitely worth a try. A first peek is painlessly done via Java webstart.
It's just a pointer..
Greetings Jonas
Short update: Netbeans 6.5 users might want to look at the brushed-up SQE Tools (checkstyle, findbugs, etc. meets maven-ide support) here: http://nbguru.blogspot.com/2008/10/sqe-maven-and-netbeans-65.html greetings Jonas Jonas von Malottki wrote:
Hello Xwiki-Devs,
for the fun of it I let FindBugs check the Xwiki Core code and it found a bunch of "Issues". Some of them are more severe than others.
Maybe it is interesting to check it out. In my own programs I found some really interesting errors/problems I was never aware of. (Including some thread safety related stuff)
The good thing with Findbugs is the extensive documentation, that gives you a very good explanation why the found issue is an issue. There are also some "false positives", also explained in the documentation.
http://findbugs.sourceforge.net/
Findbugs also has good Eclipse Integration and a Maven plugin. Definitely worth a try. A first peek is painlessly done via Java webstart.
It's just a pointer..
Greetings Jonas _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
participants (4)
-
Asiri Rathnayake -
Jonas von Malottki -
Sergiu Dumitriu -
Vincent Massol