[xwiki-devs] Dependencies in skins
Hello devs, it was a good idea to separate templates and skins, but skins are still not completely self-contained – e.g. toucan uses .js files from the albatross skin. (fullscreenEdit.js, userandgroups.js etc). It would be great fo fix it, so xwiki-users could use only one skin as prototype to create their own skins. Thanks, Alla -- View this message in context: http://n2.nabble.com/Dependencies-in-skins-tp781062p781062.html Sent from the XWiki- Dev mailing list archive at Nabble.com.
Hi Alla, On Aug 25, 2008, at 12:08 PM, adoro wrote:
Hello devs,
it was a good idea to separate templates and skins, but skins are still not completely self-contained – e.g. toucan uses .js files from the albatross skin. (fullscreenEdit.js, userandgroups.js etc). It would be great fo fix it, so xwiki-users could use only one skin as prototype to create their own skins.
Toucan skin is a skin that extends another skin so it's normal it depends on Albatross files. This is done voluntarily in order not to duplicate files. Thus I don't see we could "fix" this and I'm not sure what there is to fix. Or do you mean that when we build the toucan skin zip file we should also include the albatross skin files in it? We haven't done so voluntarily to prevent lots of duplicate files in your wiki installation. I'm curious: what would it add for xwiki users to have duplicated files for each skin? Thanks! -Vincent
I didn’t mean to copy the same files in all skins folders, but why not to move all common files, used from skins into the separate directory and leave in skins folders only skin-specific things? Sorry, perhaps it was just my wish to have a clear structure :-) vmassol wrote:
Or do you mean that when we build the toucan skin zip file we should also include the albatross skin files in it? We haven't done so voluntarily to prevent lots of duplicate files in your wiki installation.
Regards, Alla -- View this message in context: http://n2.nabble.com/Dependencies-in-skins-tp781062p781145.html Sent from the XWiki- Dev mailing list archive at Nabble.com.
On Aug 25, 2008, at 1:01 PM, adoro wrote:
I didn’t mean to copy the same files in all skins folders, but why not to move all common files, used from skins into the separate directory and leave in skins folders only skin-specific things?
But that's what we're doing... Everything common is in the templates/ directory.
Sorry, perhaps it was just my wish to have a clear structure :-)
We agree that the structure should be cleaned (there are some jira issues about this). But it's more in creating better basic skins easier to extend. There's also the Skin Extension/Interface Extension mechanism being designed. See http://dev.xwiki.org/xwiki/bin/view/Design/ If you have specific ideas or with to help in some manner please let us know here! :) Thanks -Vincent
vmassol wrote:
Or do you mean that when we build the toucan skin zip file we should also include the albatross skin files in it? We haven't done so voluntarily to prevent lots of duplicate files in your wiki installation.
Regards, Alla
participants (2)
-
adoro -
Vincent Massol