New subject: [xwiki-devs] [xwiki-notifications] r9338 - xwiki-platform/xwiki-applications/trunk/statistics/src/main/resources/ Stats

24 Apr 2008

Hi Sergiu,

I'm not sure I agree with this or maybe I don't understand something.

I see 2 problems:
1) when I tried removing the style I compared the output with and  
without and I didn't see much difference so I'm not sure they're needed
2) shouldn't the css to use depend on the skin used. For example the  
colors used don't match Toucan
3) The colors used are really not nice. The light gray makes reading  
column headers and figures very hard. The default colors from the  
Toucan skin are much better for example

Thanks
-Vincent

On Apr 24, 2008, at 2:39 AM, sdumitriu (SVN) wrote:
...
Author: sdumitriu
Date: 2008-04-24 02:39:40 +0200 (Thu, 24 Apr 2008)
New Revision: 9338
Added:
  xwiki-platform/xwiki-applications/trunk/statistics/src/main/ 
resources/Stats/Style
Modified:
  xwiki-platform/xwiki-applications/trunk/statistics/src/main/ 
resources/Stats/Macros
Log:
XASTATS-10: Stats space forces the Albatross skin to be used
Re-added the CSS rules as a SkinExtension
Modified: xwiki-platform/xwiki-applications/trunk/statistics/src/ 
main/resources/Stats/Macros
===================================================================

--- xwiki-platform/xwiki-applications/trunk/statistics/src/main/ 
resources/Stats/Macros	2008-04-24 00:09:48 UTC (rev 9337)
+++ xwiki-platform/xwiki-applications/trunk/statistics/src/main/ 
resources/Stats/Macros	2008-04-24 00:39:40 UTC (rev 9338)
@@ -54,7 +54,8 @@
<tags/>
</property>
</object>
-<content>#macro(printPageStats $stats)
+<content>#macro(printPageStats $stats)
+$!xwiki.ssx.use("Stats.Style")
<table class="stats" cellspacing="0" cellpadding="0">
<thead>
<tr>
@@ -79,6 +80,7 @@
</table>
#end
#macro(printSpaceStats $stats)
+$!xwiki.ssx.use("Stats.Style")
<table class="stats" cellspacing="0" cellpadding="0">
<thead>
<tr>
@@ -96,6 +98,7 @@
</table>
#end
#macro(printContributorStats $stats)
+$!xwiki.ssx.use("Stats.Style")
<table class="stats" cellspacing="0" cellpadding="0">
<thead>
<tr>
@@ -117,6 +120,7 @@
</table>
#end
#macro(printRefererStats $stats)
+$!xwiki.ssx.use("Stats.Style")
<table class="stats" cellspacing="0" cellpadding="0">
<thead>
<tr>
Added: xwiki-platform/xwiki-applications/trunk/statistics/src/main/ 
resources/Stats/Style
===================================================================
--- xwiki-platform/xwiki-applications/trunk/statistics/src/main/ 
resources/Stats/Style	                        (rev 0)
+++ xwiki-platform/xwiki-applications/trunk/statistics/src/main/ 
resources/Stats/Style	2008-04-24 00:39:40 UTC (rev 9338)
@@ -0,0 +1,129 @@
+<?xml version="1.0" encoding="ISO-8859-1"?>
+
+<xwikidoc>
+<web>Stats</web>
+<name>Style</name>
+<language></language>
+<defaultLanguage></defaultLanguage>
+<translation>0</translation>
+<parent></parent>
+<creator>XWiki.Admin</creator>
+<author>XWiki.Admin</author>
+<customClass></customClass>
+<contentAuthor>XWiki.Admin</contentAuthor>
+<creationDate>1208996758000</creationDate>
+<date>1208996826000</date>
+<contentUpdateDate>1208996826000</contentUpdateDate>
+<version>1.1</version>
+<title></title>
+<template></template>
+<defaultTemplate></defaultTemplate>
+<validationScript></validationScript>
+<comment>Adding style for the statistics tables</comment>
+<minorEdit>false</minorEdit>
+<object>
+<class>
+<name>XWiki.StyleSheetExtension</name>
+<customClass></customClass>
+<customMapping></customMapping>
+<defaultViewSheet></defaultViewSheet>
+<defaultEditSheet></defaultEditSheet>
+<defaultWeb></defaultWeb>
+<nameField></nameField>
+<validationScript></validationScript>
+<cache>
+<cache>0</cache>
+<displayType>select</displayType>
+<multiSelect>0</multiSelect>
+<name>cache</name>
+<number>5</number>
+<prettyName>Caching policy</prettyName>
+<relationalStorage>0</relationalStorage>
+<separator> </separator>
+<separators> ,|</separators>
+<size>1</size>
+<unmodifiable>0</unmodifiable>
+<values>long|short|default|forbid</values>
+<classType>com.xpn.xwiki.objects.classes.StaticListClass</classType>
+</cache>
+<code>
+<name>code</name>
+<number>2</number>
+<prettyName>Code</prettyName>
+<rows>20</rows>
+<size>50</size>
+<unmodifiable>0</unmodifiable>
+<classType>com.xpn.xwiki.objects.classes.TextAreaClass</classType>
+</code>
+<name>
+<name>name</name>
+<number>1</number>
+<prettyName>Name</prettyName>
+<size>30</size>
+<unmodifiable>0</unmodifiable>
+<classType>com.xpn.xwiki.objects.classes.StringClass</classType>
+</name>
+<parse>
+<displayFormType>select</displayFormType>
+<displayType>yesno</displayType>
+<name>parse</name>
+<number>4</number>
+<prettyName>Parse content</prettyName>
+<unmodifiable>0</unmodifiable>
+<classType>com.xpn.xwiki.objects.classes.BooleanClass</classType>
+</parse>
+<use>
+<cache>0</cache>
+<displayType>select</displayType>
+<multiSelect>0</multiSelect>
+<name>use</name>
+<number>3</number>
+<prettyName>Use this extension</prettyName>
+<relationalStorage>0</relationalStorage>
+<separator> </separator>
+<separators> ,|</separators>
+<size>1</size>
+<unmodifiable>0</unmodifiable>
+<values>onDemand=On demand|always=Always</values>
+<classType>com.xpn.xwiki.objects.classes.StaticListClass</classType>
+</use>
+</class>
+<name>Stats.Style</name>
+<number>0</number>
+<className>XWiki.StyleSheetExtension</className>
+<property>
+<cache>long</cache>
+</property>
+<property>
+<code>/* CSS Rules for the Statistics Application */
+table.stats {
+  width: 100%;
+}
+table.stats th {
+  font-weight: normal;
+  color: #333333;
+  border-bottom: 1px solid #DDDDDD;
+  border-top: 1px solid #DDDDDD;
+  padding-bottom: 2px;
+}
+table.stats td {
+  color: #888888;
+}
+table.stats th.numeric, table.stats td.numeric {
+  text-align: right;
+  padding-right: 6px;
+  width: 70px;
+}</code>
+</property>
+<property>
+<name>Stat tables</name>
+</property>
+<property>
+<parse>0</parse>
+</property>
+<property>
+<use>onDemand</use>
+</property>
+</object>
+<content>
+</content></xwikidoc>
\ No newline at end of file
_______________________________________________
notifications mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/notifications

    

Re: [xwiki-devs] [xwiki-notifications] r9338 - xwiki-platform/xwiki-applications/trunk/statistics/src/main/resources/Stats

Vincent Massol

Marius Dumitru Florea

Sergiu Dumitriu

tags

participants (3)