[xwiki-devs] [Vote]Error, warning and info macros
Hi folks, Regarding the XWIKI-2968 <http://jira.xwiki.org/jira/browse/XWIKI-2968> issue, this is what i've been suggested: You should put warning, error and info macro in the same project based on the same AbstractMessageMacro or something like that because theses 3 macro have almost exactly the same code. You could even have only one java macro implementation and use the macro name to find the class name. Personally, I'm +1 for the second approach, creating a single java class for all the three macros, and dynamically check for the macro name and deciding what exactly macro type is to be rendered at runtime. Reason: It's simple, it's light, it's an easy to track approach. If you have a different opinion, please let me know. Tnx, Dan
Hi Dan, On Jan 22, 2009, at 12:49 PM, Dan Miron wrote:
Hi folks,
Regarding the XWIKI-2968 <http://jira.xwiki.org/jira/browse/ XWIKI-2968> issue, this is what i've been suggested:
You should put warning, error and info macro in the same project based on the same AbstractMessageMacro or something like that because theses 3 macro have almost exactly the same code. You could even have only one java macro implementation and use the macro name to find the class name.
Personally, I'm +1 for the second approach,
What are the 1st and 2nd approaches? I see only one.
creating a single java class for all the three macros, and dynamically check for the macro name and deciding what exactly macro type is to be rendered at runtime. Reason: It's simple, it's light, it's an easy to track approach.
One class is fine but you still need to have macro aliases so that people can use {{info}}, {{error}} and {{warning}} instead of the generic {{message type="info|error|warning"}} macro.
If you have a different opinion, please let me know.
Tnx, Dan
Thanks -Vincent http://xwiki.com http://xwiki.org http://massol.net
On Thu, Jan 22, 2009 at 1:25 PM, Vincent Massol <[email protected]> wrote:
Hi Dan,
On Jan 22, 2009, at 12:49 PM, Dan Miron wrote:
Hi folks,
Regarding the XWIKI-2968 <http://jira.xwiki.org/jira/browse/ XWIKI-2968> issue, this is what i've been suggested:
You should put warning, error and info macro in the same project based on the same AbstractMessageMacro or something like that because theses 3 macro have almost exactly the same code. You could even have only one java macro implementation and use the macro name to find the class name.
Personally, I'm +1 for the second approach,
What are the 1st and 2nd approaches? I see only one.
creating a single java class for all the three macros, and dynamically check for the macro name and deciding what exactly macro type is to be rendered at runtime. Reason: It's simple, it's light, it's an easy to track approach.
One class is fine but you still need to have macro aliases so that people can use {{info}}, {{error}} and {{warning}} instead of the generic {{message type="info|error|warning"}} macro.
Yes I just suggested it quickly but obviously you would have 3 entries in component.xml.
If you have a different opinion, please let me know.
Tnx, Dan
Thanks -Vincent http://xwiki.com http://xwiki.org http://massol.net
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
On Thu, Jan 22, 2009 at 1:27 PM, Thomas Mortagne <[email protected]> wrote:
On Thu, Jan 22, 2009 at 1:25 PM, Vincent Massol <[email protected]> wrote:
Hi Dan,
On Jan 22, 2009, at 12:49 PM, Dan Miron wrote:
Hi folks,
Regarding the XWIKI-2968 <http://jira.xwiki.org/jira/browse/ XWIKI-2968> issue, this is what i've been suggested:
You should put warning, error and info macro in the same project based on the same AbstractMessageMacro or something like that because theses 3 macro have almost exactly the same code. You could even have only one java macro implementation and use the macro name to find the class name.
Personally, I'm +1 for the second approach,
What are the 1st and 2nd approaches? I see only one.
creating a single java class for all the three macros, and dynamically check for the macro name and deciding what exactly macro type is to be rendered at runtime. Reason: It's simple, it's light, it's an easy to track approach.
One class is fine but you still need to have macro aliases so that people can use {{info}}, {{error}} and {{warning}} instead of the generic {{message type="info|error|warning"}} macro.
Yes I just suggested it quickly but obviously you would have 3 entries in component.xml.
I fact I don't even though of a generic message macro from user point of view because I don't think it could be really usable. At least not if the only option is type="info|error|warning"
If you have a different opinion, please let me know.
Tnx, Dan
Thanks -Vincent http://xwiki.com http://xwiki.org http://massol.net
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
-- Thomas Mortagne
On Jan 22, 2009, at 1:29 PM, Thomas Mortagne wrote:
On Thu, Jan 22, 2009 at 1:27 PM, Thomas Mortagne <[email protected]> wrote:
On Thu, Jan 22, 2009 at 1:25 PM, Vincent Massol <[email protected]> wrote:
Hi Dan,
On Jan 22, 2009, at 12:49 PM, Dan Miron wrote:
Hi folks,
Regarding the XWIKI-2968 <http://jira.xwiki.org/jira/browse/ XWIKI-2968> issue, this is what i've been suggested:
You should put warning, error and info macro in the same project based on the same AbstractMessageMacro or something like that because theses 3 macro have almost exactly the same code. You could even have only one java macro implementation and use the macro name to find the class name.
Personally, I'm +1 for the second approach,
What are the 1st and 2nd approaches? I see only one.
creating a single java class for all the three macros, and dynamically check for the macro name and deciding what exactly macro type is to be rendered at runtime. Reason: It's simple, it's light, it's an easy to track approach.
One class is fine but you still need to have macro aliases so that people can use {{info}}, {{error}} and {{warning}} instead of the generic {{message type="info|error|warning"}} macro.
Yes I just suggested it quickly but obviously you would have 3 entries in component.xml.
I fact I don't even though of a generic message macro from user point of view because I don't think it could be really usable. At least not if the only option is type="info|error|warning"
ok great I don't think we need it either. -Vincent
If you have a different opinion, please let me know.
Tnx, Dan
Thanks -Vincent http://xwiki.com http://xwiki.org http://massol.net
All I need to tweek the entitlement verification part of x wiki enter prise. Basically I need to call a different entitlement system to check if user has some permissions and then wiki permissions to take over. Any idea which classes I might have to take a look? Also is it possible for me to customize a page based on user group? Thanks Manoj Generally, this communication is for informational purposes only and it is not intended as an offer or solicitation for the purchase or sale of any financial instrument or as an official confirmation of any transaction. In the event you are receiving the offering materials attached below related to your interest in hedge funds or private equity, this communication may be intended as an offer or solicitation for the purchase or sale of such fund(s). All market prices, data and other information are not warranted as to completeness or accuracy and are subject to change without notice. Any comments or statements made herein do not necessarily reflect those of JPMorgan Chase & Co., its subsidiaries and affiliates. This transmission may contain information that is privileged, confidential, legally privileged, and/or exempt from disclosure under applicable law. If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution, or use of the information contained herein (including any reliance thereon) is STRICTLY PROHIBITED. Although this transmission and any attachments are believed to be free of any virus or other defect that might affect any computer system into which it is received and opened, it is the responsibility of the recipient to ensure that it is virus free and no responsibility is accepted by JPMorgan Chase & Co., its subsidiaries and affiliates, as applicable, for any loss or damage arising in any way from its use. If you received this transmission in error, please immediately contact the sender and destroy the material in its entirety, whether in electronic or hard copy format. Thank you. Please refer to http://www.jpmorgan.com/pages/disclosures for disclosures relating to UK legal entities.
Hi, Yes you can do that. You can reimplement the XWikiRightService and declare it in the xwiki.org file. You have to look at the XWiki code to see the default implementation. http://svn.xwiki.org/svnroot/xwiki/platform/core/trunk/xwiki-core/src/main/j... Ludovic Mathew, Manoj (JPMC) a écrit :
All
I need to tweek the entitlement verification part of x wiki enter prise. Basically I need to call a different entitlement system to check if user has some permissions and then wiki permissions to take over. Any idea which classes I might have to take a look? Also is it possible for me to customize a page based on user group?
Thanks Manoj Generally, this communication is for informational purposes only and it is not intended as an offer or solicitation for the purchase or sale of any financial instrument or as an official confirmation of any transaction. In the event you are receiving the offering materials attached below related to your interest in hedge funds or private equity, this communication may be intended as an offer or solicitation for the purchase or sale of such fund(s). All market prices, data and other information are not warranted as to completeness or accuracy and are subject to change without notice. Any comments or statements made herein do not necessarily reflect those of JPMorgan Chase & Co., its subsidiaries and affiliates.
This transmission may contain information that is privileged, confidential, legally privileged, and/or exempt from disclosure under applicable law. If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution, or use of the information contained herein (including any reliance thereon) is STRICTLY PROHIBITED. Although this transmission and any attachments are believed to be free of any virus or other defect that might affect any computer system into which it is received and opened, it is the responsibility of the recipient to ensure that it is virus free and no responsibility is accepted by JPMorgan Chase & Co., its subsidiaries and affiliates, as applicable, for any loss or damage arising in any way from its use. If you received this transmission in error, please immediately contact the sender and destroy the material in its entirety, whether in electronic or hard copy format. Thank you. Please refer to http://www.jpmorgan.com/pages/disclosures for disclosures relating to UK legal entities. _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Ludovic Dubost Blog: http://blog.ludovic.org/ XWiki: http://www.xwiki.com Skype: ldubost GTalk: ldubost
Hi I know this is a dumb question. But I am new to Maven. I downloaded the enterprise source and build it. Now where is the source? I am also not sure where I can find XWikiRightServiceImpl.java Appreciate the help. Thanks Manoj Generally, this communication is for informational purposes only and it is not intended as an offer or solicitation for the purchase or sale of any financial instrument or as an official confirmation of any transaction. In the event you are receiving the offering materials attached below related to your interest in hedge funds or private equity, this communication may be intended as an offer or solicitation for the purchase or sale of such fund(s). All market prices, data and other information are not warranted as to completeness or accuracy and are subject to change without notice. Any comments or statements made herein do not necessarily reflect those of JPMorgan Chase & Co., its subsidiaries and affiliates. This transmission may contain information that is privileged, confidential, legally privileged, and/or exempt from disclosure under applicable law. If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution, or use of the information contained herein (including any reliance thereon) is STRICTLY PROHIBITED. Although this transmission and any attachments are believed to be free of any virus or other defect that might affect any computer system into which it is received and opened, it is the responsibility of the recipient to ensure that it is virus free and no responsibility is accepted by JPMorgan Chase & Co., its subsidiaries and affiliates, as applicable, for any loss or damage arising in any way from its use. If you received this transmission in error, please immediately contact the sender and destroy the material in its entirety, whether in electronic or hard copy format. Thank you. Please refer to http://www.jpmorgan.com/pages/disclosures for disclosures relating to UK legal entities.
Hi Manoj, On Thu, Jan 22, 2009 at 11:14 PM, Mathew, Manoj (JPMC) < [email protected]> wrote:
Hi
I know this is a dumb question. But I am new to Maven. I downloaded the enterprise source and build it. Now where is the source? I am also not sure where I can find XWikiRightServiceImpl.java
refer: http://dev.xwiki.org/xwiki/bin/view/Community/Building - Asiri
The path http://svn.xwiki.org/svnroot/xwiki/platform/core/trunk/xwiki-core/src/main/j... shows you the path in your source tree Something like platform/core/xwiki-core/src/main/java/com/xpn/xwiki/user/impl/xwiki/XWikiRightServiceImpl.java Ludovic Mathew, Manoj (JPMC) a écrit :
Hi
I know this is a dumb question. But I am new to Maven. I downloaded the enterprise source and build it. Now where is the source? I am also not sure where I can find XWikiRightServiceImpl.java
Appreciate the help.
Thanks Manoj Generally, this communication is for informational purposes only and it is not intended as an offer or solicitation for the purchase or sale of any financial instrument or as an official confirmation of any transaction. In the event you are receiving the offering materials attached below related to your interest in hedge funds or private equity, this communication may be intended as an offer or solicitation for the purchase or sale of such fund(s). All market prices, data and other information are not warranted as to completeness or accuracy and are subject to change without notice. Any comments or statements made herein do not necessarily reflect those of JPMorgan Chase & Co., its subsidiaries and affiliates.
This transmission may contain information that is privileged, confidential, legally privileged, and/or exempt from disclosure under applicable law. If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution, or use of the information contained herein (including any reliance thereon) is STRICTLY PROHIBITED. Although this transmission and any attachments are believed to be free of any virus or other defect that might affect any computer system into which it is received and opened, it is the responsibility of the recipient to ensure that it is virus free and no responsibility is accepted by JPMorgan Chase & Co., its subsidiaries and affiliates, as applicable, for any loss or damage arising in any way from its use. If you received this transmission in error, please immediately contact the sender and destroy the material in its entirety, whether in electronic or hard copy format. Thank you. Please refer to http://www.jpmorgan.com/pages/disclosures for disclosures relating to UK legal entities. _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Ludovic Dubost Blog: http://blog.ludovic.org/ XWiki: http://www.xwiki.com Skype: ldubost GTalk: ldubost
Well, this is what i meant: The first approach: creating an AbstractMessageMacro to do all the generic stuff and then inherit from it 3 classes, corresponding to the three macros (info, error and warning) The second approach (the one i prefer): create a single implementation for all the three macros (with three different aliases and three entries in components.xml), as Thomas said. Vincent Massol wrote:
Hi Dan,
On Jan 22, 2009, at 12:49 PM, Dan Miron wrote:
Hi folks,
Regarding the XWIKI-2968 <http://jira.xwiki.org/jira/browse/ XWIKI-2968> issue, this is what i've been suggested:
You should put warning, error and info macro in the same project based on the same AbstractMessageMacro or something like that because theses 3 macro have almost exactly the same code. You could even have only one java macro implementation and use the macro name to find the class name.
Personally, I'm +1 for the second approach,
What are the 1st and 2nd approaches? I see only one.
creating a single java class for all the three macros, and dynamically check for the macro name and deciding what exactly macro type is to be rendered at runtime. Reason: It's simple, it's light, it's an easy to track approach.
One class is fine but you still need to have macro aliases so that people can use {{info}}, {{error}} and {{warning}} instead of the generic {{message type="info|error|warning"}} macro.
If you have a different opinion, please let me know.
Tnx, Dan
Thanks -Vincent http://xwiki.com http://xwiki.org http://massol.net
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
participants (6)
-
Asiri Rathnayake -
Dan Miron -
Ludovic Dubost -
Mathew, Manoj (JPMC) -
Thomas Mortagne -
Vincent Massol