[xwiki-devs] [VOTE] Merge new Markdown branch from Guillaume Laforge
Hi devs, I've been working with Guillaume Laforge on reimplementing our support of Markdown. The current version we have relies on Pegdown's HTML serializer which we then read with our HTML parser. This causes several issues, amongst which: * http://jira.xwiki.org/browse/XRENDERING-237 * http://jira.xwiki.org/browse/XRENDERING-236 So Guillaume and I have completely rewritten it, this time mapping the AST events generated by Pegdown to XWiki Rendering events. The work can be seen here: https://github.com/glaforge/xwiki-rendering/tree/master/xwiki-rendering-synt... It fully passes our CTS. I'm this proposing to integrate this work in 4.5M1 since it fixes existing bugs. There's a small risk that it's going to cause other bugs elsewhere but I think it's worth it, especially seen that our markdown support is quite new. Here's my +1 Thanks -Vincent
+1 On Wed, Jan 2, 2013 at 10:58 AM, Vincent Massol <[email protected]> wrote:
Hi devs,
I've been working with Guillaume Laforge on reimplementing our support of Markdown. The current version we have relies on Pegdown's HTML serializer which we then read with our HTML parser.
This causes several issues, amongst which: * http://jira.xwiki.org/browse/XRENDERING-237 * http://jira.xwiki.org/browse/XRENDERING-236
So Guillaume and I have completely rewritten it, this time mapping the AST events generated by Pegdown to XWiki Rendering events.
The work can be seen here: https://github.com/glaforge/xwiki-rendering/tree/master/xwiki-rendering-synt...
It fully passes our CTS.
I'm this proposing to integrate this work in 4.5M1 since it fixes existing bugs. There's a small risk that it's going to cause other bugs elsewhere but I think it's worth it, especially seen that our markdown support is quite new.
Here's my +1
Thanks -Vincent _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
+1 On Wed, Jan 2, 2013 at 10:58 AM, Vincent Massol <[email protected]> wrote:
Hi devs,
I've been working with Guillaume Laforge on reimplementing our support of Markdown. The current version we have relies on Pegdown's HTML serializer which we then read with our HTML parser.
This causes several issues, amongst which: * http://jira.xwiki.org/browse/XRENDERING-237 * http://jira.xwiki.org/browse/XRENDERING-236
So Guillaume and I have completely rewritten it, this time mapping the AST events generated by Pegdown to XWiki Rendering events.
The work can be seen here:
https://github.com/glaforge/xwiki-rendering/tree/master/xwiki-rendering-synt...
It fully passes our CTS.
I'm this proposing to integrate this work in 4.5M1 since it fixes existing bugs. There's a small risk that it's going to cause other bugs elsewhere but I think it's worth it, especially seen that our markdown support is quite new.
Here's my +1
Thanks -Vincent _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Jean-Vincent Drean, XWiki.
+1 On Wed, Jan 2, 2013 at 2:45 PM, Jean-Vincent Drean <[email protected]> wrote:
+1
On Wed, Jan 2, 2013 at 10:58 AM, Vincent Massol <[email protected]> wrote:
Hi devs,
I've been working with Guillaume Laforge on reimplementing our support of Markdown. The current version we have relies on Pegdown's HTML serializer which we then read with our HTML parser.
This causes several issues, amongst which: * http://jira.xwiki.org/browse/XRENDERING-237 * http://jira.xwiki.org/browse/XRENDERING-236
So Guillaume and I have completely rewritten it, this time mapping the AST events generated by Pegdown to XWiki Rendering events.
The work can be seen here:
https://github.com/glaforge/xwiki-rendering/tree/master/xwiki-rendering-synt...
It fully passes our CTS.
I'm this proposing to integrate this work in 4.5M1 since it fixes
existing
bugs. There's a small risk that it's going to cause other bugs elsewhere but I think it's worth it, especially seen that our markdown support is quite new.
Here's my +1
Thanks -Vincent _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Jean-Vincent Drean, XWiki. _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Denis Gervalle SOFTEC sa - CEO eGuilde sarl - CTO
+1 Thanks, Marius On Wed, Jan 2, 2013 at 11:58 AM, Vincent Massol <[email protected]> wrote:
Hi devs,
I've been working with Guillaume Laforge on reimplementing our support of Markdown. The current version we have relies on Pegdown's HTML serializer which we then read with our HTML parser.
This causes several issues, amongst which: * http://jira.xwiki.org/browse/XRENDERING-237 * http://jira.xwiki.org/browse/XRENDERING-236
So Guillaume and I have completely rewritten it, this time mapping the AST events generated by Pegdown to XWiki Rendering events.
The work can be seen here: https://github.com/glaforge/xwiki-rendering/tree/master/xwiki-rendering-synt...
It fully passes our CTS.
I'm this proposing to integrate this work in 4.5M1 since it fixes existing bugs. There's a small risk that it's going to cause other bugs elsewhere but I think it's worth it, especially seen that our markdown support is quite new.
Here's my +1
Thanks -Vincent _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
participants (5)
-
Denis Gervalle -
Jean-Vincent Drean -
Marius Dumitru Florea -
Thomas Mortagne -
Vincent Massol