[xwiki-devs] [Contrib] Redmine-Macro
Hi there! As described in (http://contrib.xwiki.org/xwiki/bin/view/Main/WebHome) i should ask here to get an account for the nexus on http://nexus.xwiki.o <http://nexus.xwiki.org/>rg in order to be able to a macro. The extension / macro i want to release can be found here: https://github.com/4F2E4A2E/xwiki-redminemacro After the release i will create the documentation at extension.xwiki.org. XWiki username: vfzevaze Github username: 4F2E4A2E Best regards, OJ, Sousa Rodrigues
I just created you a vfzevaze user on nexus.xwiki.org. Not sure if Nexus is sending you a mail with a generated password or something. On Fri, Aug 8, 2014 at 8:58 PM, O.J. Sousa Rodrigues <[email protected]> wrote:
Hi there!
As described in (http://contrib.xwiki.org/xwiki/bin/view/Main/WebHome) i should ask here to get an account for the nexus on http://nexus.xwiki.o <http://nexus.xwiki.org/>rg in order to be able to a macro. The extension / macro i want to release can be found here: https://github.com/4F2E4A2E/xwiki-redminemacro
After the release i will create the documentation at extension.xwiki.org.
XWiki username: vfzevaze Github username: 4F2E4A2E
Best regards, OJ, Sousa Rodrigues _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
Hi OJ (hope this is the right way to call you ;)), First let me say that I’m very happy that you’ve shared and published this extension, this is awesome! :) We now have 2 SCM for which we offer some tooling: JIRA and Redmine. Now that the project is set up I can propose some improvements below (feel free to discard them if you don’t like them): * I see that you don’t have any JIRA project for your Redmine Macro. We can create one for you so that users can report issues or improvements (or anyone working on the project) * The macro artifact id was not correct and I’ve just fixed it. I’ve also added a better .gitignore. I’ve also removed tabs in the pom.xml and replaced them with 2 spaces (this is one of the best practice we follow for XML files when developing the XWiki project. You don’t have to follow them for your Redmine project though. In case you’re interested they are defined here: http://dev.xwiki.org/xwiki/bin/view/Community/CodeStyle * I’ve renamed the Redmine page on e.x.o to http://extensions.xwiki.org/xwiki/bin/view/Extension/Redmine+Macro to make it nicer for SEO… I’ve also updated the README.md file. * I’d suggest to rename the space from Redmine-Macro to RedmineMacro or just Redmine. We don’t usually use “-“ in space names. * Why not have a single {{redmine}} Macro. I think it would be simpler to remember/type than “listRedmineIssues” and “listRedmineQueryResult” :). AFIU the second one lists all issues so you could decide that if there are no “issues” parameters specified then all issues are listed, or something like that. * I’d suggest to rename the pages: "Redmine-Macro List” -> RedmineListMacro, “Redmine-Macro Issue” -> “RedmineIssueMacro”. In case you accept the previous suggestion, a single RedmineMacro page would be better of course ;) Thanks again and let me know if I can be of any help! -Vincent On 8 Aug 2014 at 20:58:59, O.J. Sousa Rodrigues ([email protected](mailto:[email protected])) wrote:
Hi there!
As described in (http://contrib.xwiki.org/xwiki/bin/view/Main/WebHome) i should ask here to get an account for the nexus on http://nexus.xwiki.o rg in order to be able to a macro. The extension / macro i want to release can be found here: https://github.com/4F2E4A2E/xwiki-redminemacro
After the release i will create the documentation at extension.xwiki.org.
XWiki username: vfzevaze Github username: 4F2E4A2E
Best regards, OJ, Sousa Rodrigues
* I see that you don’t have any JIRA project for your Redmine Macro. We can create one for you so that users can report issues or improvements (or anyone working on the project)
Please create the project for this macro, thank you!
* The macro artifact id was not correct and I’ve just fixed it. I’ve also added a better .gitignore. I’ve also removed tabs in the pom.xml and replaced them with 2 spaces (this is one of the best practice we follow for XML files when developing the XWiki project. You don’t have to follow them for your Redmine project though. In case you’re interested they are defined here: http://dev.xwiki.org/xwiki/bin/view/Community/CodeStyle
I extended the information on how to set those settings for eclipse, though someone might review it ;)
* I’ve renamed the Redmine page on e.x.o to http://extensions.xwiki.org/xwiki/bin/view/Extension/Redmine+Macro to make it nicer for SEO… I’ve also updated the README.md file.
Perfect! I had it like that at first.
* I’d suggest to rename the space from Redmine-Macro to RedmineMacro or just Redmine. We don’t usually use “-“ in space names.
Done.
* Why not have a single {{redmine}} Macro. I think it would be simpler to remember/type than “listRedmineIssues” and “listRedmineQueryResult” :). AFIU the second one lists all issues so you could decide that if there are no “issues” parameters specified then all issues are listed, or something like that.
Sure thing, i implement just one parameter "param", accepting either issues or issue querys.
* I’d suggest to rename the pages: "Redmine-Macro List” -> RedmineListMacro, “Redmine-Macro Issue” -> “RedmineIssueMacro”. In case you accept the previous suggestion, a single RedmineMacro page would be better of course ;)
Both are merged now into one as sugegsted: "RedmineMacro". The redmine macro is released at version 6 containing all those changes above. Wiki page will be updated asap. Thank you sir! You guys have been very patient and always at it, thank you for that and for this amazing plattform. OJ
Thanks again and let me know if I can be of any help! -Vincent
On 8 Aug 2014 at 20:58:59, O.J. Sousa Rodrigues ([email protected] (mailto:[email protected])) wrote:
Hi there!
As described in (http://contrib.xwiki.org/xwiki/bin/view/Main/WebHome) i should ask here to get an account for the nexus on http://nexus.xwiki.o rg in order to be able to a macro. The extension / macro i want to release can be found here: https://github.com/4F2E4A2E/xwiki-redminemacro
After the release i will create the documentation at extension.xwiki.org .
XWiki username: vfzevaze Github username: 4F2E4A2E
Best regards, OJ, Sousa Rodrigues
Hi, On 18 Aug 2014 at 16:29:27, O.J. Sousa Rodrigues ([email protected](mailto:[email protected])) wrote:
* I see that you don’t have any JIRA project for your Redmine Macro. We can create one for you so that users can report issues or improvements (or anyone working on the project)
Please create the project for this macro, thank you!
Done at http://jira.xwiki.org/browse/XREDMINE You’re the project lead. I’ve recreated all past versions and created version 0.0.7 for your next release (I’ve also created 1.0 for when you think it’s ready to be released): http://jira.xwiki.org/browse/XREDMINE#selectedTab=com.atlassian.jira.plugin.... See below
* The macro artifact id was not correct and I’ve just fixed it. I’ve also added a better .gitignore. I’ve also removed tabs in the pom.xml and replaced them with 2 spaces (this is one of the best practice we follow for XML files when developing the XWiki project. You don’t have to follow them for your Redmine project though. In case you’re interested they are defined here: http://dev.xwiki.org/xwiki/bin/view/Community/CodeStyle
I extended the information on how to set those settings for eclipse, though someone might review it ;)
Not sure I understood you :) You modified some page on xwiki.org?
* I’ve renamed the Redmine page on e.x.o to http://extensions.xwiki.org/xwiki/bin/view/Extension/Redmine+Macro to make it nicer for SEO… I’ve also updated the README.md file.
Perfect! I had it like that at first.
* I’d suggest to rename the space from Redmine-Macro to RedmineMacro or just Redmine. We don’t usually use “-“ in space names.
Done.
* Why not have a single {{redmine}} Macro. I think it would be simpler to remember/type than “listRedmineIssues” and “listRedmineQueryResult” :). AFIU the second one lists all issues so you could decide that if there are no “issues” parameters specified then all issues are listed, or something like that.
Sure thing, i implement just one parameter "param", accepting either issues or issue querys.
* I’d suggest to rename the pages: "Redmine-Macro List” -> RedmineListMacro, “Redmine-Macro Issue” -> “RedmineIssueMacro”. In case you accept the previous suggestion, a single RedmineMacro page would be better of course ;)
Both are merged now into one as sugegsted: "RedmineMacro".
The redmine macro is released at version 6 containing all those changes above. Wiki page will be updated asap.
I’ve edited http://extensions.xwiki.org/xwiki/bin/view/Extension/Redmine+Macro in object mode and changed the artifact id (it was still pointing to the old “xwiki-macro-redmine”). Then I clicked on the refresh icon and version 0.0.6 is now available :)
Thank you sir! You guys have been very patient and always at it, thank you for that and for this amazing plattform.
You’re welcome! Thanks a lot for contributing, that’s great :) -Vincent
OJ
Thanks again and let me know if I can be of any help! -Vincent
On 8 Aug 2014 at 20:58:59, O.J. Sousa Rodrigues ([email protected] (mailto:[email protected])) wrote:
Hi there!
As described in (http://contrib.xwiki.org/xwiki/bin/view/Main/WebHome) i should ask here to get an account for the nexus on http://nexus.xwiki.o rg in order to be able to a macro. The extension / macro i want to release can be found here: https://github.com/4F2E4A2E/xwiki-redminemacro
After the release i will create the documentation at extension.xwiki.org .
XWiki username: vfzevaze Github username: 4F2E4A2E
Best regards, OJ, Sousa Rodrigues
I extended the information on how to set those settings for eclipse, though someone might review it ;)
Not sure I understood you :) You modified some page on xwiki.org?
Yes, i did add the eclipse section there http://dev.xwiki.org/xwiki/bin/view/Community/XmlCodeStyle since there is no xml profile for eclipse. BTW: Still having problem in formatting the xml in eclipse since it does format the license too and it does not look like it should.
I’ve edited http://extensions.xwiki.org/xwiki/bin/view/Extension/Redmine+Macro in object mode and changed the artifact id (it was still pointing to the old “xwiki-macro-redmine”). Then I clicked on the refresh icon and version 0.0.6 is now available :)
But how? Could it be that nexus just needs more time after releasing it until it can be fetched from the homepage? Can you please pass a link where i can read about writing some test cases for this macro? Thank you.
On 18 Aug 2014 at 22:37:42, O.J. Sousa Rodrigues ([email protected](mailto:[email protected])) wrote:
I extended the information on how to set those settings for eclipse, though someone might review it ;)
Not sure I understood you :) You modified some page on xwiki.org(http://xwiki.org)?
Yes, i did add the eclipse section there http://dev.xwiki.org/xwiki/bin/view/Community/XmlCodeStyle since there is no xml profile for eclipse. BTW: Still having problem in formatting the xml in eclipse since it does format the license too and it does not look like it should.
I’m no expert here since I use IntelliJ IDEA. There are quite a few xwiki developers using Eclipse on this list though and maybe they can chime in…
I’ve edited http://extensions.xwiki.org/xwiki/bin/view/Extension/Redmine+Macro in object mode and changed the artifact id (it was still pointing to the old “xwiki-macro-redmine”). Then I clicked on the refresh icon and version 0.0.6 is now available :)
But how? Could it be that nexus just needs more time after releasing it until it can be fetched from the homepage?
I don’t understand the question.
Can you please pass a link where i can read about writing some test cases for this macro?
It’s nice indeed to write some functional tests to prove the app/macro works. However in your case it’s going to be hard since you would need to simulate a Redmine server… One solution though could be to configure your {{redmine}} macro usage to pass a URL that points to a page on xwiki that would return the data as returned by a Redmine server :) Here are some documentation here (with links to examples of existing tests): http://dev.xwiki.org/xwiki/bin/view/Community/Testing#HSelenium2-basedFramew... Thanks -Vincent
Then I clicked on the refresh icon and version 0.0.6 is now available :)
But how? Could it be that nexus just needs more time after releasing it until it can be fetched from the homepage?
I don’t understand the question.
After i did release the version 0.0.6 i did click the refresh button as well, but it did not update the version, i was expecting it to be updated over night since there is this cache issue.
Can you please pass a link where i can read about writing some test cases for this macro?
It’s nice indeed to write some functional tests to prove the app/macro works. However in your case it’s going to be hard since you would need to simulate a Redmine server… One solution though could be to configure your {{redmine}} macro usage to pass a URL that points to a page on xwiki that would return the data as returned by a Redmine server :)
I am intending to use the redmine.org server as test server, thanks for the link.
Here are some documentation here (with links to examples of existing tests):
http://dev.xwiki.org/xwiki/bin/view/Community/Testing#HSelenium2-basedFramew...
Thanks -Vincent
On 18 Aug 2014 at 23:01:37, O.J. Sousa Rodrigues ([email protected](mailto:[email protected])) wrote:
Then I clicked on the refresh icon and version 0.0.6 is now available :)
But how? Could it be that nexus just needs more time after releasing it until it can be fetched from the homepage?
I don’t understand the question.
After i did release the version 0.0.6 i did click the refresh button as well, but it did not update the version, i was expecting it to be updated over night since there is this cache issue.
As I said, I had to modify the artifact id: “ I’ve edited http://extensions.xwiki.org/xwiki/bin/view/Extension/Redmine+Macro in object mode and changed the artifact id (it was still pointing to the old “xwiki-macro-redmine”).[…] " That’s why the refresh didn’t work for you ;) Thanks -Vincent
Can you please pass a link where i can read about writing some test cases for this macro?
It’s nice indeed to write some functional tests to prove the app/macro works. However in your case it’s going to be hard since you would need to simulate a Redmine server… One solution though could be to configure your {{redmine}} macro usage to pass a URL that points to a page on xwiki that would return the data as returned by a Redmine server :)
I am intending to use the redmine.org server as test server, thanks for the link.
Here are some documentation here (with links to examples of existing tests):
http://dev.xwiki.org/xwiki/bin/view/Community/Testing#HSelenium2-basedFramew...
Thanks -Vincent
On 18 Aug 2014 at 16:29:12, O.J. Sousa Rodrigues ([email protected](mailto:[email protected])) wrote: [snip]
The redmine macro is released at version 6 containing all those changes above. Wiki page will be updated asap. Thank you sir! You guys have been very patient and always at it, thank you for that and for this amazing plattform.
BTW I’ve added your text as a quote at http://www.xwiki.org/xwiki/bin/view/References/Testimonials I hope it’s ok :) In case you wish to make a longer, more elaborate qupte, you could write some tweet/blog or simply reply to this email with a longer quote and I’ll integrate it there too! Thanks! -Vincent
OJ
Thanks again and let me know if I can be of any help! -Vincent
On 8 Aug 2014 at 20:58:59, O.J. Sousa Rodrigues ([email protected](mailto:[email protected])(mailto:[email protected])) wrote:
Hi there!
As described in (http://contrib.xwiki.org/xwiki/bin/view/Main/WebHome) i should ask here to get an account for the nexus on http://nexus.xwiki.o rg in order to be able to a macro. The extension / macro i want to release can be found here: https://github.com/4F2E4A2E/xwiki-redminemacro
After the release i will create the documentation at extension.xwiki.org(http://extension.xwiki.org).
XWiki username: vfzevaze Github username: 4F2E4A2E
Best regards, OJ, Sousa Rodrigues
participants (3)
-
O.J. Sousa Rodrigues -
Thomas Mortagne -
vincent＠massol.net