[xwiki-devs] [VOTE] Let WARN level log pass in xwiki-commons-test
Hi devs, Right now xwiki-commons-test has a special logback configuration to let only errors pass. Problem is that in some tests I actually need to get warn too. Also I don't think hidding warning is right, it usually mean there is something wrong. If a test really expect log to be produced it's very easy to isolate them using org.xwiki.loggingLogManager#pushLogListener(null). So the vote is about modifying the test logback configuration to include warn level too. WDYT ? Here is my +1 -- Thomas Mortagne
On 07/04/2012 06:35 AM, Thomas Mortagne wrote:
Hi devs,
Right now xwiki-commons-test has a special logback configuration to let only errors pass.
Problem is that in some tests I actually need to get warn too.
Also I don't think hidding warning is right, it usually mean there is something wrong. If a test really expect log to be produced it's very easy to isolate them using org.xwiki.loggingLogManager#pushLogListener(null).
So the vote is about modifying the test logback configuration to include warn level too.
WDYT ?
Here is my +1
+1 -- Sergiu Dumitriu http://purl.org/net/sergiu/
I just committed, will revert if someone is against it. On Wed, Jul 4, 2012 at 12:35 PM, Thomas Mortagne <[email protected]> wrote:
Hi devs,
Right now xwiki-commons-test has a special logback configuration to let only errors pass.
Problem is that in some tests I actually need to get warn too.
Also I don't think hidding warning is right, it usually mean there is something wrong. If a test really expect log to be produced it's very easy to isolate them using org.xwiki.loggingLogManager#pushLogListener(null).
So the vote is about modifying the test logback configuration to include warn level too.
WDYT ?
Here is my +1
-- Thomas Mortagne
-- Thomas Mortagne
On Jul 4, 2012, at 12:35 PM, Thomas Mortagne wrote:
Hi devs,
Right now xwiki-commons-test has a special logback configuration to let only errors pass.
Problem is that in some tests I actually need to get warn too.
Also I don't think hidding warning is right, it usually mean there is something wrong. If a test really expect log to be produced it's very easy to isolate them using org.xwiki.loggingLogManager#pushLogListener(null).
So the vote is about modifying the test logback configuration to include warn level too.
WDYT ?
Here is my +1
+1 Thanks -Vincent
participants (3)
-
Sergiu Dumitriu -
Thomas Mortagne -
Vincent Massol