+1 On Wed, Mar 10, 2010 at 10:53, Vincent Massol <[email protected]> wrote:

Hi,

I'd like to modify BaseObject.clone() so that it changes the GUID since GUID must be unique per instance.

WDYT?

Thanks -Vincent

_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs

-- Thomas Mortagne

+1 Vincent Massol wrote:

Hi,

I'd like to modify BaseObject.clone() so that it changes the GUID since GUID must be unique per instance.

WDYT?

Thanks -Vincent

_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs

On 03/10/2010 10:53 AM, Vincent Massol wrote:

I'd like to modify BaseObject.clone() so that it changes the GUID since GUID must be unique per instance.

-1, since clones are created for the same document. Every time a document is modified through velocity, a clone of the document is created, so that unsaved changes don't affect other instances of the document. This used to be a bug, where changes done to a $doc, although unsaved, were visible in the document cache. So, a side effect of this change will be that any document modified through the public API will get new GUIDs every time it is saved. -- Sergiu Dumitriu http://purl.org/net/sergiu/