[xwiki-devs] [VOTE] Move all lucene plugin classes to internal
Hello, Right now all code in the lucene plugin is exposed as API while almost none of it is actual API. I would like to move all lucene plugin classes to an internal package, except for "LucenePluginApi". For the non API "LucenePlugin", I'm not sure, since moving it would break users conf (xwiki.cfg). WDYT ? My +1, Jerome
+1 and yes we should not move LucenePlugin since it will break all existing xwiki.cfg On Wed, Nov 28, 2012 at 5:48 PM, Jerome Velociter <[email protected]>wrote:
Hello,
Right now all code in the lucene plugin is exposed as API while almost none of it is actual API. I would like to move all lucene plugin classes to an internal package, except for "LucenePluginApi". For the non API "LucenePlugin", I'm not sure, since moving it would break users conf (xwiki.cfg).
WDYT ?
My +1, Jerome ______________________________**_________________ devs mailing list [email protected] http://lists.xwiki.org/**mailman/listinfo/devs<http://lists.xwiki.org/mailman/listinfo/devs>
-- Thomas Mortagne
On 11/28/2012 06:15 PM, Thomas Mortagne wrote:
+1 and yes we should not move LucenePlugin since it will break all existing xwiki.cfg
Yes I guess this is the safe thing to do. Note that we sometimes break xwiki.cfg : for example when we retire a plugin. Jerome
On Wed, Nov 28, 2012 at 5:48 PM, Jerome Velociter <[email protected]>wrote:
Hello,
Right now all code in the lucene plugin is exposed as API while almost none of it is actual API. I would like to move all lucene plugin classes to an internal package, except for "LucenePluginApi". For the non API "LucenePlugin", I'm not sure, since moving it would break users conf (xwiki.cfg).
WDYT ?
My +1, Jerome ______________________________**_________________ devs mailing list [email protected] http://lists.xwiki.org/**mailman/listinfo/devs<http://lists.xwiki.org/mailman/listinfo/devs>
On Wed, Nov 28, 2012 at 6:17 PM, Jerome Velociter <[email protected]>wrote:
On 11/28/2012 06:15 PM, Thomas Mortagne wrote:
+1 and yes we should not move LucenePlugin since it will break all existing xwiki.cfg
Yes I guess this is the safe thing to do. Note that we sometimes break xwiki.cfg : for example when we retire a plugin.
Sure but in this case it just produce a log, it does not really have any real effect.
Jerome
On Wed, Nov 28, 2012 at 5:48 PM, Jerome Velociter <[email protected]
wrote:
Hello,
Right now all code in the lucene plugin is exposed as API while almost none of it is actual API. I would like to move all lucene plugin classes to an internal package, except for "LucenePluginApi". For the non API "LucenePlugin", I'm not sure, since moving it would break users conf (xwiki.cfg).
WDYT ?
My +1, Jerome ______________________________****_________________ devs mailing list [email protected] http://lists.xwiki.org/****mailman/listinfo/devs<http://lists.xwiki.org/**mailman/listinfo/devs> <http://**lists.xwiki.org/mailman/**listinfo/devs<http://lists.xwiki.org/mailman/listinfo/devs>
______________________________**_________________ devs mailing list [email protected] http://lists.xwiki.org/**mailman/listinfo/devs<http://lists.xwiki.org/mailman/listinfo/devs>
-- Thomas Mortagne
On Nov 28, 2012, at 5:48 PM, Jerome Velociter <[email protected]> wrote:
Hello,
Right now all code in the lucene plugin is exposed as API while almost none of it is actual API. I would like to move all lucene plugin classes to an internal package, except for "LucenePluginApi". For the non API "LucenePlugin", I'm not sure, since moving it would break users conf (xwiki.cfg).
WDYT ?
Can you explain what your goal because the best would be to not touch it, deprecate it and rewrite a new version as a component. Thanks -Vincent
My +1, Jerome
On 11/28/2012 06:34 PM, Vincent Massol wrote:
On Nov 28, 2012, at 5:48 PM, Jerome Velociter <[email protected]> wrote:
Hello,
Right now all code in the lucene plugin is exposed as API while almost none of it is actual API. I would like to move all lucene plugin classes to an internal package, except for "LucenePluginApi". For the non API "LucenePlugin", I'm not sure, since moving it would break users conf (xwiki.cfg).
WDYT ? Can you explain what your goal because the best would be to not touch it, deprecate it and rewrite a new version as a component.
My goal is simply to upgrade to lucene 4.0.0. Our plugin classes use lucene classes in method signatures, and those classes have evolved (renamed for example) since 3.6.x, causing the API breakages on our side. Jerome
Thanks -Vincent
My +1, Jerome
devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
Anyone else ? I would like to get going with this. Thanks, Jerome On 11/28/2012 05:48 PM, Jerome Velociter wrote:
Hello,
Right now all code in the lucene plugin is exposed as API while almost none of it is actual API. I would like to move all lucene plugin classes to an internal package, except for "LucenePluginApi". For the non API "LucenePlugin", I'm not sure, since moving it would break users conf (xwiki.cfg).
WDYT ?
My +1, Jerome
On Sat, Dec 1, 2012 at 5:24 PM, Jerome Velociter <[email protected]> wrote:
Anyone else ?
+0 Thanks, Marius
I would like to get going with this.
Thanks, Jerome
On 11/28/2012 05:48 PM, Jerome Velociter wrote:
Hello,
Right now all code in the lucene plugin is exposed as API while almost none of it is actual API. I would like to move all lucene plugin classes to an internal package, except for "LucenePluginApi". For the non API "LucenePlugin", I'm not sure, since moving it would break users conf (xwiki.cfg).
WDYT ?
My +1, Jerome
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
+1 Thanks, Eduard On Mon, Dec 3, 2012 at 11:06 AM, Marius Dumitru Florea < [email protected]> wrote:
On Sat, Dec 1, 2012 at 5:24 PM, Jerome Velociter <[email protected]> wrote:
Anyone else ?
+0
Thanks, Marius
I would like to get going with this.
Thanks, Jerome
On 11/28/2012 05:48 PM, Jerome Velociter wrote:
Hello,
Right now all code in the lucene plugin is exposed as API while almost none of it is actual API. I would like to move all lucene plugin classes to an internal package, except for "LucenePluginApi". For the non API "LucenePlugin", I'm not
sure,
since moving it would break users conf (xwiki.cfg).
WDYT ?
My +1, Jerome
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
On 11/28/2012 11:48 AM, Jerome Velociter wrote:
Hello,
Right now all code in the lucene plugin is exposed as API while almost none of it is actual API. I would like to move all lucene plugin classes to an internal package, except for "LucenePluginApi". For the non API "LucenePlugin", I'm not sure, since moving it would break users conf (xwiki.cfg).
WDYT ?
+1, keeping LucenePlugin as well. That is an SPI, plugins are supposed to be used from Java using the non-API method. -- Sergiu Dumitriu http://purl.org/net/sergiu/
Done in https://github.com/xwiki/xwiki-platform/commit/38c7c7ad35de48619cdce0bf22f5b... Note that besides LucenePlugin and LucenePluginApi I left out of the internal package two other classes : SearchResults and SearchResult, which should be considered API as well since they are exposed to scripts/templates by the plugin. Jerome On 11/28/2012 05:48 PM, Jerome Velociter wrote:
Hello,
Right now all code in the lucene plugin is exposed as API while almost none of it is actual API. I would like to move all lucene plugin classes to an internal package, except for "LucenePluginApi". For the non API "LucenePlugin", I'm not sure, since moving it would break users conf (xwiki.cfg).
WDYT ?
My +1, Jerome
participants (6)
-
Eduard Moraru -
Jerome Velociter -
Marius Dumitru Florea -
Sergiu Dumitriu -
Thomas Mortagne -
Vincent Massol