[xwiki-devs] [Proposal] Addition of a new extension point (before title)
Hei devs, By default, the ratings app uses JS to inject an HTML element right after the #hierarchy element. This is a bit awkward since that element could be (re)moved and the ratings element would not be present or follow the position of the hierarchy (breadcrumb). As a solution I propose implementing an extension point, namely org.xwiki.platform.template.title.before which would go right before the document title. Due to the fact that in flamingo the "more actions" and "edit" buttons are now in the same place that the ratings are displayed brings us to a point where we will have to integrate the ratings in this interface as well. As a future improvement we could add more extension points and choose where to display the ratings depending on the skin. For example: before title for colibri and after the content menu (where the "edit" and "more actions" buttons are) for flamingo. This extension point would replace the JS inject thus making the code cleaner. Thanks, Victor
On 3 Dec 2014 at 18:05:47, Victor Rachieru ([email protected](mailto:[email protected])) wrote:
Hei devs,
By default, the ratings app uses JS to inject an HTML element right after the #hierarchy element. This is a bit awkward since that element could be (re)moved and the ratings element would not be present or follow the position of the hierarchy (breadcrumb).
As a solution I propose implementing an extension point, namely org.xwiki.platform.template.title.before which would go right before the document title.
Due to the fact that in flamingo the "more actions" and "edit" buttons are now in the same place that the ratings are displayed brings us to a point where we will have to integrate the ratings in this interface as well.
As a future improvement we could add more extension points and choose where to display the ratings depending on the skin.
Actually the goal of an extension point is to be able to auto-adapt to the skin! It’s the skin that says where the extension point is located! This allows code using extension points to work in all skins without a change. Thanks -Vincent
For example: before title for colibri and after the content menu (where the "edit" and "more actions" buttons are) for flamingo.
This extension point would replace the JS inject thus making the code cleaner.
Thanks, Victor
On 3 Dec 2014 at 18:05:47, Victor Rachieru ([email protected](mailto:[email protected])) wrote:
Hei devs,
By default, the ratings app uses JS to inject an HTML element right after the #hierarchy element. This is a bit awkward since that element could be (re)moved and the ratings element would not be present or follow the position of the hierarchy (breadcrumb).
As a solution I propose implementing an extension point, namely org.xwiki.platform.template.title.before which would go right before the document title.
Where do you wish to display the rating of a page? Wouldn’t it be better to display it inside the page content? By “Before the title” WDYM exactly? I don’t think you really mean before the title as otherwise we will have: *** My title here Maybe you mean above the title? In which case the extension point would be a placeholder taking the full horizontal content space (i.e without the panels), similar to http://platform.xwiki.org/xwiki/bin/view/ExtensionPoint/AfterHeaderUIX Also it looks as if on Colibri the ratings are located to the right of the title. So if we want to keep that location “above title" wouldn’t work either. “After title” could work in both cases IMO: * On colibri, it could right aligned * On Flamingo, it could be displayed just on the right of the title Another possibility is on the same line as the “Last modified by” line (shortcuts.vm), after the “Last modified by…” text. Other possibility include: * Don’t display it by default and let users include it in their content using a macro. They can put it in some view sheet for example. * Provide a Panel for displaying it. I’m not convinced that you’d want to display ratings on all pages by default. I don’t know the Rating app, is there a way to deal with this (not displaying ratings on some pages)? For example we may not want to have ratings on home pages. I feel that a typical use case would be to display ratings only for pages containing a specific XObject. BTW I hope you have that use case that rating can be associated with some id because you may want to have 2 different apps in your wiki and provide ratings for both so the ratings value shouldn’t be stored (this means that the {{ratings id=“…”/}} should accept an “id” parameter). So personally I wouldn’t display it by default but make it easy for the admin/organizer to decide where to display it: UC1- only in some livetable column (easy) UC2- only on some spaces (and possibly excluding some pages like the home page) UC3- only on a given wiki (and possibly excluding some pages like the home page or some spaces like the “xwiki” space) UC4- only inside pages having a specific xobject through the sheet system (easy) For UC2 and 3 a Panel would work. A custom skin could work too but it’s too much work probably and an easier solution would be nice. Do you have the list of all use cases? I don’t see them on http://design.xwiki.org/xwiki/bin/view/Proposal/Extensionrepositoryratings and that would be useful to have. We need to see the full list of use cases before we can find solutions, otherwise we risk creating solutions that will not work for all cases... WDYT? Thanks -Vincent
Due to the fact that in flamingo the "more actions" and "edit" buttons are now in the same place that the ratings are displayed brings us to a point where we will have to integrate the ratings in this interface as well.
As a future improvement we could add more extension points and choose where to display the ratings depending on the skin. For example: before title for colibri and after the content menu (where the "edit" and "more actions" buttons are) for flamingo.
This extension point would replace the JS inject thus making the code cleaner.
Thanks, Victor
On 3 Dec 2014 at 18:34:23, [email protected] ([email protected](mailto:[email protected])) wrote:
On 3 Dec 2014 at 18:05:47, Victor Rachieru ([email protected](mailto:[email protected])) wrote:
Hei devs,
By default, the ratings app uses JS to inject an HTML element right after the #hierarchy element. This is a bit awkward since that element could be (re)moved and the ratings element would not be present or follow the position of the hierarchy (breadcrumb).
As a solution I propose implementing an extension point, namely org.xwiki.platform.template.title.before which would go right before the document title.
Where do you wish to display the rating of a page?
Wouldn’t it be better to display it inside the page content?
By “Before the title” WDYM exactly? I don’t think you really mean before the title as otherwise we will have:
*** My title here
Maybe you mean above the title? In which case the extension point would be a placeholder taking the full horizontal content space (i.e without the panels), similar to http://platform.xwiki.org/xwiki/bin/view/ExtensionPoint/AfterHeaderUIX
Also it looks as if on Colibri the ratings are located to the right of the title. So if we want to keep that location “above title" wouldn’t work either.
“After title” could work in both cases IMO: * On colibri, it could right aligned * On Flamingo, it could be displayed just on the right of the title
Another possibility is on the same line as the “Last modified by” line (shortcuts.vm), after the “Last modified by…” text.
Other possibility include: * Don’t display it by default and let users include it in their content using a macro. They can put it in some view sheet for example. * Provide a Panel for displaying it.
I’m not convinced that you’d want to display ratings on all pages by default. I don’t know the Rating app, is there a way to deal with this (not displaying ratings on some pages)? For example we may not want to have ratings on home pages. I feel that a typical use case would be to display ratings only for pages containing a specific XObject. BTW I hope you have that use case that rating can be associated with some id because you may want to have 2 different apps in your wiki and provide ratings for both so the ratings value shouldn’t be stored (this means that the {{ratings id=“…”/}} should accept an “id” parameter).
I meant: “[…] so the ratings value shouldn’t be stored in a single xobject. There should be one xobject per different id.” Thanks -Vincent
So personally I wouldn’t display it by default but make it easy for the admin/organizer to decide where to display it: UC1- only in some livetable column (easy) UC2- only on some spaces (and possibly excluding some pages like the home page) UC3- only on a given wiki (and possibly excluding some pages like the home page or some spaces like the “xwiki” space) UC4- only inside pages having a specific xobject through the sheet system (easy)
For UC2 and 3 a Panel would work. A custom skin could work too but it’s too much work probably and an easier solution would be nice.
Do you have the list of all use cases? I don’t see them on http://design.xwiki.org/xwiki/bin/view/Proposal/Extensionrepositoryratings and that would be useful to have. We need to see the full list of use cases before we can find solutions, otherwise we risk creating solutions that will not work for all cases...
WDYT?
Thanks -Vincent
Due to the fact that in flamingo the "more actions" and "edit" buttons are now in the same place that the ratings are displayed brings us to a point where we will have to integrate the ratings in this interface as well.
As a future improvement we could add more extension points and choose where to display the ratings depending on the skin. For example: before title for colibri and after the content menu (where the "edit" and "more actions" buttons are) for flamingo.
This extension point would replace the JS inject thus making the code cleaner.
Thanks, Victor
On Wed, Dec 3, 2014 at 7:37 PM, [email protected] <[email protected]> wrote:
On 3 Dec 2014 at 18:34:23, [email protected] ([email protected](mailto:[email protected])) wrote:
On 3 Dec 2014 at 18:05:47, Victor Rachieru ([email protected](mailto:[email protected])) wrote:
Hei devs,
By default, the ratings app uses JS to inject an HTML element right after the #hierarchy element. This is a bit awkward since that element could be (re)moved and the ratings element would not be present or follow the position of the hierarchy (breadcrumb).
As a solution I propose implementing an extension point, namely org.xwiki.platform.template.title.before which would go right before the document title.
Where do you wish to display the rating of a page?
Wouldn’t it be better to display it inside the page content?
By “Before the title” WDYM exactly? I don’t think you really mean before the title as otherwise we will have:
*** My title here
Maybe you mean above the title? In which case the extension point would be a placeholder taking the full horizontal content space (i.e without the panels), similar to http://platform.xwiki.org/xwiki/bin/view/ExtensionPoint/AfterHeaderUIX
Also it looks as if on Colibri the ratings are located to the right of the title. So if we want to keep that location “above title" wouldn’t work either.
“After title” could work in both cases IMO: * On colibri, it could right aligned * On Flamingo, it could be displayed just on the right of the title
Another possibility is on the same line as the “Last modified by” line (shortcuts.vm), after the “Last modified by…” text.
Other possibility include: * Don’t display it by default and let users include it in their content using a macro. They can put it in some view sheet for example. * Provide a Panel for displaying it.
I’m not convinced that you’d want to display ratings on all pages by default. I don’t know the Rating app, is there a way to deal with this (not displaying ratings on some pages)? For example we may not want to have ratings on home pages. I feel that a typical use case would be to display ratings only for pages containing a specific XObject. BTW I hope you have that use case that rating can be associated with some id because you may want to have 2 different apps in your wiki and provide ratings for both so the ratings value shouldn’t be stored (this means that the {{ratings id=“…”/}} should accept an “id” parameter).
I meant:
“[…] so the ratings value shouldn’t be stored in a single xobject. There should be one xobject per different id.”
Thanks -Vincent
So personally I wouldn’t display it by default but make it easy for the admin/organizer to decide where to display it: UC1- only in some livetable column (easy) UC2- only on some spaces (and possibly excluding some pages like the home page) UC3- only on a given wiki (and possibly excluding some pages like the home page or some spaces like the “xwiki” space) UC4- only inside pages having a specific xobject through the sheet system (easy)
For UC2 and 3 a Panel would work. A custom skin could work too but it’s too much work probably and an easier solution would be nice.
Do you have the list of all use cases? I don’t see them on http://design.xwiki.org/xwiki/bin/view/Proposal/Extensionrepositoryratings and that would be useful to have. We need to see the full list of use cases before we can find solutions, otherwise we risk creating solutions that will not work for all cases...
WDYT?
I think Victor should focus on what has been included in the roadmap for 6.4, precisely: "adding the Ratings to the Repository app". Being able to rate wiki pages is not a priority at the moment IMO so I wouldn't spend time arguing where the ratings should be displayed for wiki pages. There can be many options and even more opinions on such a topic. Moreover this thread is not only about the Ratings app. The question Victor raised is: do we think an extension point before the document title is useful? My answer is yes (I've heard complaints that we have only a few extension points). If we all agree then the Ratings app can use it for a start to replace the JavaScript injection hack until "rating plain wiki pages" becomes a priority (or someone is willing to work on it). I tried to move the ratings container before the document title and it looks decent on both Colibri and Flamingo. Note that "before the title" is the extension point. The ratings container has some CSS that makes it float to the right of the title where it looks good in the end. If adding this extension point helps Victor move forward to the target of rating extension in the Repository app then I'm +1. Thanks, Marius
Thanks -Vincent
Due to the fact that in flamingo the "more actions" and "edit" buttons are now in the same place that the ratings are displayed brings us to a point where we will have to integrate the ratings in this interface as well.
As a future improvement we could add more extension points and choose where to display the ratings depending on the skin. For example: before title for colibri and after the content menu (where the "edit" and "more actions" buttons are) for flamingo.
This extension point would replace the JS inject thus making the code cleaner.
Thanks, Victor
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
+1 for the extension point Thanks, Caty On Fri, Dec 5, 2014 at 5:08 PM, Marius Dumitru Florea < [email protected]> wrote:
On Wed, Dec 3, 2014 at 7:37 PM, [email protected] <[email protected]> wrote:
On 3 Dec 2014 at 18:34:23, [email protected] ([email protected]
(mailto:[email protected])) wrote:
On 3 Dec 2014 at 18:05:47, Victor Rachieru ([email protected]
(mailto:[email protected])) wrote:
Hei devs,
By default, the ratings app uses JS to inject an HTML element right
after
the #hierarchy element. This is a bit awkward since that element could be (re)moved and the ratings element would not be present or follow the position of the hierarchy (breadcrumb).
As a solution I propose implementing an extension point, namely org.xwiki.platform.template.title.before which would go right before the document title.
Where do you wish to display the rating of a page?
Wouldn’t it be better to display it inside the page content?
By “Before the title” WDYM exactly? I don’t think you really mean before the title as otherwise we will have:
*** My title here
Maybe you mean above the title? In which case the extension point would be a placeholder taking the full horizontal content space (i.e without the panels), similar to http://platform.xwiki.org/xwiki/bin/view/ExtensionPoint/AfterHeaderUIX
Also it looks as if on Colibri the ratings are located to the right of the title. So if we want to keep that location “above title" wouldn’t work either.
“After title” could work in both cases IMO: * On colibri, it could right aligned * On Flamingo, it could be displayed just on the right of the title
Another possibility is on the same line as the “Last modified by” line (shortcuts.vm), after the “Last modified by…” text.
Other possibility include: * Don’t display it by default and let users include it in their content using a macro. They can put it in some view sheet for example. * Provide a Panel for displaying it.
I’m not convinced that you’d want to display ratings on all pages by default. I don’t know the Rating app, is there a way to deal with this (not displaying ratings on some pages)? For example we may not want to have ratings on home pages. I feel that a typical use case would be to display ratings only for pages containing a specific XObject. BTW I hope you have that use case that rating can be associated with some id because you may want to have 2 different apps in your wiki and provide ratings for both so the ratings value shouldn’t be stored (this means that the {{ratings id=“…”/}} should accept an “id” parameter).
I meant:
“[…] so the ratings value shouldn’t be stored in a single xobject. There should be one xobject per different id.”
Thanks -Vincent
So personally I wouldn’t display it by default but make it easy for the
admin/organizer to decide where to display it:
UC1- only in some livetable column (easy) UC2- only on some spaces (and possibly excluding some pages like the home page) UC3- only on a given wiki (and possibly excluding some pages like the home page or some spaces like the “xwiki” space) UC4- only inside pages having a specific xobject through the sheet system (easy)
For UC2 and 3 a Panel would work. A custom skin could work too but it’s too much work probably and an easier solution would be nice.
Do you have the list of all use cases? I don’t see them on http://design.xwiki.org/xwiki/bin/view/Proposal/Extensionrepositoryratings and that would be useful to have. We need to see the full list of use cases before we can find solutions, otherwise we risk creating solutions that will not work for all cases...
WDYT?
I think Victor should focus on what has been included in the roadmap for 6.4, precisely: "adding the Ratings to the Repository app". Being able to rate wiki pages is not a priority at the moment IMO so I wouldn't spend time arguing where the ratings should be displayed for wiki pages. There can be many options and even more opinions on such a topic. Moreover this thread is not only about the Ratings app. The question Victor raised is: do we think an extension point before the document title is useful? My answer is yes (I've heard complaints that we have only a few extension points). If we all agree then the Ratings app can use it for a start to replace the JavaScript injection hack until "rating plain wiki pages" becomes a priority (or someone is willing to work on it).
I tried to move the ratings container before the document title and it looks decent on both Colibri and Flamingo. Note that "before the title" is the extension point. The ratings container has some CSS that makes it float to the right of the title where it looks good in the end.
If adding this extension point helps Victor move forward to the target of rating extension in the Repository app then I'm +1.
Thanks, Marius
Thanks -Vincent
Due to the fact that in flamingo the "more actions" and "edit"
buttons are
now in the same place that the ratings are displayed brings us to a point where we will have to integrate the ratings in this interface as well.
As a future improvement we could add more extension points and choose where to display the ratings depending on the skin. For example: before title for colibri and after the content menu (where the "edit" and "more actions" buttons are) for flamingo.
This extension point would replace the JS inject thus making the code cleaner.
Thanks, Victor
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
Although I would prefer an extension point after the buttons, instead of before the title Thanks, Caty On Fri, Dec 5, 2014 at 5:26 PM, Ecaterina Moraru (Valica) <[email protected]
wrote:
+1 for the extension point
Thanks, Caty
On Fri, Dec 5, 2014 at 5:08 PM, Marius Dumitru Florea < [email protected]> wrote:
On Wed, Dec 3, 2014 at 7:37 PM, [email protected] <[email protected]> wrote:
On 3 Dec 2014 at 18:34:23, [email protected] ([email protected]
(mailto:[email protected])) wrote:
On 3 Dec 2014 at 18:05:47, Victor Rachieru ([email protected]
(mailto:[email protected])) wrote:
Hei devs,
By default, the ratings app uses JS to inject an HTML element right
after
the #hierarchy element. This is a bit awkward since that element could be (re)moved and the ratings element would not be present or follow the position of the hierarchy (breadcrumb).
As a solution I propose implementing an extension point, namely org.xwiki.platform.template.title.before which would go right before the document title.
Where do you wish to display the rating of a page?
Wouldn’t it be better to display it inside the page content?
By “Before the title” WDYM exactly? I don’t think you really mean before the title as otherwise we will have:
*** My title here
Maybe you mean above the title? In which case the extension point would be a placeholder taking the full horizontal content space (i.e without the panels), similar to http://platform.xwiki.org/xwiki/bin/view/ExtensionPoint/AfterHeaderUIX
Also it looks as if on Colibri the ratings are located to the right of the title. So if we want to keep that location “above title" wouldn’t work either.
“After title” could work in both cases IMO: * On colibri, it could right aligned * On Flamingo, it could be displayed just on the right of the title
Another possibility is on the same line as the “Last modified by” line (shortcuts.vm), after the “Last modified by…” text.
Other possibility include: * Don’t display it by default and let users include it in their content using a macro. They can put it in some view sheet for example. * Provide a Panel for displaying it.
I’m not convinced that you’d want to display ratings on all pages by default. I don’t know the Rating app, is there a way to deal with this (not displaying ratings on some pages)? For example we may not want to have ratings on home pages. I feel that a typical use case would be to display ratings only for pages containing a specific XObject. BTW I hope you have that use case that rating can be associated with some id because you may want to have 2 different apps in your wiki and provide ratings for both so the ratings value shouldn’t be stored (this means that the {{ratings id=“…”/}} should accept an “id” parameter).
I meant:
“[…] so the ratings value shouldn’t be stored in a single xobject. There should be one xobject per different id.”
Thanks -Vincent
So personally I wouldn’t display it by default but make it easy for
the admin/organizer to decide where to display it:
UC1- only in some livetable column (easy) UC2- only on some spaces (and possibly excluding some pages like the home page) UC3- only on a given wiki (and possibly excluding some pages like the home page or some spaces like the “xwiki” space) UC4- only inside pages having a specific xobject through the sheet system (easy)
For UC2 and 3 a Panel would work. A custom skin could work too but it’s too much work probably and an easier solution would be nice.
Do you have the list of all use cases? I don’t see them on http://design.xwiki.org/xwiki/bin/view/Proposal/Extensionrepositoryratings and that would be useful to have. We need to see the full list of use cases before we can find solutions, otherwise we risk creating solutions that will not work for all cases...
WDYT?
I think Victor should focus on what has been included in the roadmap for 6.4, precisely: "adding the Ratings to the Repository app". Being able to rate wiki pages is not a priority at the moment IMO so I wouldn't spend time arguing where the ratings should be displayed for wiki pages. There can be many options and even more opinions on such a topic. Moreover this thread is not only about the Ratings app. The question Victor raised is: do we think an extension point before the document title is useful? My answer is yes (I've heard complaints that we have only a few extension points). If we all agree then the Ratings app can use it for a start to replace the JavaScript injection hack until "rating plain wiki pages" becomes a priority (or someone is willing to work on it).
I tried to move the ratings container before the document title and it looks decent on both Colibri and Flamingo. Note that "before the title" is the extension point. The ratings container has some CSS that makes it float to the right of the title where it looks good in the end.
If adding this extension point helps Victor move forward to the target of rating extension in the Repository app then I'm +1.
Thanks, Marius
Thanks -Vincent
Due to the fact that in flamingo the "more actions" and "edit"
buttons are
now in the same place that the ratings are displayed brings us to a point where we will have to integrate the ratings in this interface as well.
As a future improvement we could add more extension points and choose where to display the ratings depending on the skin. For example: before title for colibri and after the content menu (where the "edit" and "more actions" buttons are) for flamingo.
This extension point would replace the JS inject thus making the code cleaner.
Thanks, Victor
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
I agree with Marius, lets start with that and we can alway change later. On Fri, Dec 5, 2014 at 4:08 PM, Marius Dumitru Florea <[email protected]> wrote:
On Wed, Dec 3, 2014 at 7:37 PM, [email protected] <[email protected]> wrote:
On 3 Dec 2014 at 18:34:23, [email protected] ([email protected](mailto:[email protected])) wrote:
On 3 Dec 2014 at 18:05:47, Victor Rachieru ([email protected](mailto:[email protected])) wrote:
Hei devs,
By default, the ratings app uses JS to inject an HTML element right after the #hierarchy element. This is a bit awkward since that element could be (re)moved and the ratings element would not be present or follow the position of the hierarchy (breadcrumb).
As a solution I propose implementing an extension point, namely org.xwiki.platform.template.title.before which would go right before the document title.
Where do you wish to display the rating of a page?
Wouldn’t it be better to display it inside the page content?
By “Before the title” WDYM exactly? I don’t think you really mean before the title as otherwise we will have:
*** My title here
Maybe you mean above the title? In which case the extension point would be a placeholder taking the full horizontal content space (i.e without the panels), similar to http://platform.xwiki.org/xwiki/bin/view/ExtensionPoint/AfterHeaderUIX
Also it looks as if on Colibri the ratings are located to the right of the title. So if we want to keep that location “above title" wouldn’t work either.
“After title” could work in both cases IMO: * On colibri, it could right aligned * On Flamingo, it could be displayed just on the right of the title
Another possibility is on the same line as the “Last modified by” line (shortcuts.vm), after the “Last modified by…” text.
Other possibility include: * Don’t display it by default and let users include it in their content using a macro. They can put it in some view sheet for example. * Provide a Panel for displaying it.
I’m not convinced that you’d want to display ratings on all pages by default. I don’t know the Rating app, is there a way to deal with this (not displaying ratings on some pages)? For example we may not want to have ratings on home pages. I feel that a typical use case would be to display ratings only for pages containing a specific XObject. BTW I hope you have that use case that rating can be associated with some id because you may want to have 2 different apps in your wiki and provide ratings for both so the ratings value shouldn’t be stored (this means that the {{ratings id=“…”/}} should accept an “id” parameter).
I meant:
“[…] so the ratings value shouldn’t be stored in a single xobject. There should be one xobject per different id.”
Thanks -Vincent
So personally I wouldn’t display it by default but make it easy for the admin/organizer to decide where to display it: UC1- only in some livetable column (easy) UC2- only on some spaces (and possibly excluding some pages like the home page) UC3- only on a given wiki (and possibly excluding some pages like the home page or some spaces like the “xwiki” space) UC4- only inside pages having a specific xobject through the sheet system (easy)
For UC2 and 3 a Panel would work. A custom skin could work too but it’s too much work probably and an easier solution would be nice.
Do you have the list of all use cases? I don’t see them on http://design.xwiki.org/xwiki/bin/view/Proposal/Extensionrepositoryratings and that would be useful to have. We need to see the full list of use cases before we can find solutions, otherwise we risk creating solutions that will not work for all cases...
WDYT?
I think Victor should focus on what has been included in the roadmap for 6.4, precisely: "adding the Ratings to the Repository app". Being able to rate wiki pages is not a priority at the moment IMO so I wouldn't spend time arguing where the ratings should be displayed for wiki pages. There can be many options and even more opinions on such a topic. Moreover this thread is not only about the Ratings app. The question Victor raised is: do we think an extension point before the document title is useful? My answer is yes (I've heard complaints that we have only a few extension points). If we all agree then the Ratings app can use it for a start to replace the JavaScript injection hack until "rating plain wiki pages" becomes a priority (or someone is willing to work on it).
I tried to move the ratings container before the document title and it looks decent on both Colibri and Flamingo. Note that "before the title" is the extension point. The ratings container has some CSS that makes it float to the right of the title where it looks good in the end.
If adding this extension point helps Victor move forward to the target of rating extension in the Repository app then I'm +1.
Thanks, Marius
Thanks -Vincent
Due to the fact that in flamingo the "more actions" and "edit" buttons are now in the same place that the ratings are displayed brings us to a point where we will have to integrate the ratings in this interface as well.
As a future improvement we could add more extension points and choose where to display the ratings depending on the skin. For example: before title for colibri and after the content menu (where the "edit" and "more actions" buttons are) for flamingo.
This extension point would replace the JS inject thus making the code cleaner.
Thanks, Victor
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
participants (5)
-
Ecaterina Moraru (Valica) -
Marius Dumitru Florea -
Thomas Mortagne -
Victor Rachieru -
vincent＠massol.net