[Lucene] Fixing the rebuildIndex API?

Vincent Massol

2 Feb 2007 2 Feb '07

12:29 p.m.

Hi everyone, I can see the following API in LucenePluginAPI: public int rebuildIndex(XWiki wiki, Context context) I can see 2 problems with that: 1) I don't see the need for exposing the context, especially as it's known internally by the plugin. 2) Passing both the context and the wiki object seems redundant as it's possible to call context.getXWiki() I'm thus proposing to deprecate this method and instead replace it with: public int rebuildIndex() Ok for everyone? Thanks -Vincent ___________________________________________________________________________ Yahoo! Mail r�invente le mail ! D�couvrez le nouveau Yahoo! Mail et son interface r�volutionnaire. http://fr.mail.yahoo.com

Show replies by date

jeremi joslin

2 Feb 2 Feb

12:39 p.m.

Hi, there is a lot of problems with the API of the lucene plugin. It needs to be completely redone. jeremi On 2/2/07, Vincent Massol <[email protected]> wrote:

...

Hi everyone,

I can see the following API in LucenePluginAPI:

public int rebuildIndex(XWiki wiki, Context context)

I can see 2 problems with that:

1) I don't see the need for exposing the context, especially as it's known internally by the plugin. 2) Passing both the context and the wiki object seems redundant as it's possible to call context.getXWiki()

I'm thus proposing to deprecate this method and instead replace it with:

public int rebuildIndex()

Ok for everyone?

Thanks -Vincent

___________________________________________________________________________ Yahoo! Mail réinvente le mail ! Découvrez le nouveau Yahoo! Mail et son interface révolutionnaire. http://fr.mail.yahoo.com

-- jeremi

Ludovic Dubost

12:42 p.m.

New subject: [xwiki-dev] [Lucene] Fixing the rebuildIndex API?

+1 I started rewriting the whole API leaving the older ones in LucenePluginAPI as deprecated but I have to redo it all because of your styling commit :( I'm in the process of adding the sort parameter for lucene which is needed on curriki http://jira.xwiki.org/jira/browse/XWIKI-795 Ludovic Vincent Massol a écrit :

...

Hi everyone,

I can see the following API in LucenePluginAPI:

public int rebuildIndex(XWiki wiki, Context context)

I can see 2 problems with that:

1) I don't see the need for exposing the context, especially as it's known internally by the plugin. 2) Passing both the context and the wiki object seems redundant as it's possible to call context.getXWiki()

I'm thus proposing to deprecate this method and instead replace it with:

public int rebuildIndex()

Ok for everyone?

Thanks -Vincent

___________________________________________________________________________Yahoo! Mail réinvente le mail ! Découvrez le nouveau Yahoo! Mail et son interface révolutionnaire. http://fr.mail.yahoo.com

------------------------------------------------------------------------

-- You receive this message as a subscriber of the [email protected] mailing list. To unsubscribe: mailto:[email protected] For general help: mailto:[email protected]?subject=help ObjectWeb mailing lists service home page: http://www.objectweb.org/wws

-- Ludovic Dubost Blog: http://www.ludovic.org/blog/ XWiki: http://www.xwiki.com Skype: ldubost GTalk: ldubost AIM: nvludo Yahoo: ludovic

Vincent Massol

1 p.m.

New subject: [xwiki-dev] [Lucene] Fixing the rebuildIndex API?

On Feb 2, 2007, at 12:42 PM, Ludovic Dubost wrote:

...

+1

I started rewriting the whole API leaving the older ones in LucenePluginAPI as deprecated but I have to redo it all because of your styling commit :( I'm in the process of adding the sort parameter for lucene which is needed on curriki

http://jira.xwiki.org/jira/browse/XWIKI-795

I have lots of other styling and other modifications. This is my way of taking ownership of existing code (which you asked me to do ;-)). I was doing this to understand the code and prepare the field for adding stuff from XWIKI-517 and XWIKI-757 which Jeremi asked me to look at. I can put what I'm doing on hold if you want. Let me know what's best. Thanks -Vincent

...

Vincent Massol a écrit :

...
Hi everyone,

I can see the following API in LucenePluginAPI:

public int rebuildIndex(XWiki wiki, Context context)

I can see 2 problems with that:

1) I don't see the need for exposing the context, especially as it's known internally by the plugin. 2) Passing both the context and the wiki object seems redundant as it's possible to call context.getXWiki()

I'm thus proposing to deprecate this method and instead replace it with:

public int rebuildIndex()

Ok for everyone?

Thanks -Vincent

_____________________________________________________________________ ______Yahoo! Mail réinvente le mail ! Découvrez le nouveau Yahoo! Mail et son interface révolutionnaire. http://fr.mail.yahoo.com

--------------------------------------------------------------------- ---

-- You receive this message as a subscriber of the xwiki- [email protected] mailing list. To unsubscribe: mailto:[email protected] For general help: mailto:[email protected]?subject=help ObjectWeb mailing lists service home page: http:// www.objectweb.org/wws

-- Ludovic Dubost Blog: http://www.ludovic.org/blog/ XWiki: http://www.xwiki.com Skype: ldubost GTalk: ldubost AIM: nvludo Yahoo: ludovic

-- You receive this message as a subscriber of the xwiki- [email protected] mailing list. To unsubscribe: mailto:[email protected] For general help: mailto:[email protected]?subject=help ObjectWeb mailing lists service home page: http://www.objectweb.org/ wws

___________________________________________________________________________ Yahoo! Mail réinvente le mail ! Découvrez le nouveau Yahoo! Mail et son interface révolutionnaire. http://fr.mail.yahoo.com

Vincent Massol

1:45 p.m.

New subject: [xwiki-dev] [Lucene] Fixing the rebuildIndex API?

ok, I'm leaving it to Ludovic to make this change along with others. I'm not touching the plugin till further notice... :-) Thanks -Vincent On Feb 2, 2007, at 1:00 PM, Vincent Massol wrote:

...

On Feb 2, 2007, at 12:42 PM, Ludovic Dubost wrote:

...
+1

I started rewriting the whole API leaving the older ones in LucenePluginAPI as deprecated but I have to redo it all because of your styling commit :( I'm in the process of adding the sort parameter for lucene which is needed on curriki

http://jira.xwiki.org/jira/browse/XWIKI-795

I have lots of other styling and other modifications. This is my way of taking ownership of existing code (which you asked me to do ;-)). I was doing this to understand the code and prepare the field for adding stuff from XWIKI-517 and XWIKI-757 which Jeremi asked me to look at.

I can put what I'm doing on hold if you want. Let me know what's best.

Thanks -Vincent

...
Vincent Massol a écrit :

...
Hi everyone,

I can see the following API in LucenePluginAPI:

public int rebuildIndex(XWiki wiki, Context context)

I can see 2 problems with that:

1) I don't see the need for exposing the context, especially as it's known internally by the plugin. 2) Passing both the context and the wiki object seems redundant as it's possible to call context.getXWiki()

I'm thus proposing to deprecate this method and instead replace it with:

public int rebuildIndex()

Ok for everyone?

Thanks -Vincent

7092

Age (days ago)

7092

Last active (days ago)

List overview

Download

4 comments

3 participants

participants (3)

jeremi joslin
Ludovic Dubost
Vincent Massol