[xwiki-devs] What do we do with template field in document ?
Hi devs, We have a "template" field in XWikiDocument and in what we export/import in the XAR but it's not part of the database mapping (there is defaultTemplate but no template). See http://jira.xwiki.org/browse/XWIKI-8650. Since it's not saved in the database it's totally useless to have it in the XAR but we do have it in several pages of XE (some Blog pages). So my question is what the hell is this field and what should be do with it ? I can see two possibilities: 1) stop exporting it in the XAR and deprecated related method in XWikiDocument 2) put it back in the database mapping (I guess it used to be there or I don't see how we could have some pages with it on github) WDYT ? Since I have no idea what this field is supposed to do I don't have a strong opinion but since it's totally useless right now and nobody seems to complain I would go for 1). -- Thomas Mortagne
Hi Thomas, On Jan 15, 2013, at 3:48 PM, Thomas Mortagne <[email protected]> wrote:
Hi devs,
We have a "template" field in XWikiDocument and in what we export/import in the XAR but it's not part of the database mapping (there is defaultTemplate but no template). See http://jira.xwiki.org/browse/XWIKI-8650.
Since it's not saved in the database it's totally useless to have it in the XAR but we do have it in several pages of XE (some Blog pages).
So my question is what the hell is this field and what should be do with it ?
I can see two possibilities: 1) stop exporting it in the XAR and deprecated related method in XWikiDocument 2) put it back in the database mapping (I guess it used to be there or I don't see how we could have some pages with it on github)
WDYT ?
AFAIK it's never been used and since it's not saved in the DB right now I would go for 1). We can then discuss about use cases in the future and decide if we need it. Thanks -Vincent PS: We need to progress on http://jira.xwiki.org/jira/browse/XWIKI-8252 which is a blocker and which is way more important ATM.
Since I have no idea what this field is supposed to do I don't have a strong opinion but since it's totally useless right now and nobody seems to complain I would go for 1).
-- Thomas Mortagne
According to https://github.com/xwiki/xwiki-platform/blob/xwiki-core-1.1.0/src/main/resou... looks like it probably never existed. I don't understand how we can have that in the blog XAR. On Wed, Jan 16, 2013 at 5:37 PM, Vincent Massol <[email protected]> wrote:
Hi Thomas,
On Jan 15, 2013, at 3:48 PM, Thomas Mortagne <[email protected]> wrote:
Hi devs,
We have a "template" field in XWikiDocument and in what we export/import in the XAR but it's not part of the database mapping (there is defaultTemplate but no template). See http://jira.xwiki.org/browse/XWIKI-8650.
Since it's not saved in the database it's totally useless to have it in the XAR but we do have it in several pages of XE (some Blog pages).
So my question is what the hell is this field and what should be do with it ?
I can see two possibilities: 1) stop exporting it in the XAR and deprecated related method in XWikiDocument 2) put it back in the database mapping (I guess it used to be there or I don't see how we could have some pages with it on github)
WDYT ?
AFAIK it's never been used and since it's not saved in the DB right now I would go for 1).
We can then discuss about use cases in the future and decide if we need it.
Thanks -Vincent
PS: We need to progress on http://jira.xwiki.org/jira/browse/XWIKI-8252 which is a blocker and which is way more important ATM.
Since I have no idea what this field is supposed to do I don't have a strong opinion but since it's totally useless right now and nobody seems to complain I would go for 1).
-- Thomas Mortagne
devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
On Wed, Jan 16, 2013 at 5:51 PM, Thomas Mortagne <[email protected]> wrote:
According to https://github.com/xwiki/xwiki-platform/blob/xwiki-core-1.1.0/src/main/resou... looks like it probably never existed. I don't understand how we can have that in the blog XAR.
Actually what' happen I think is that those pages has been created from a template and exported before the cache expire.
On Wed, Jan 16, 2013 at 5:37 PM, Vincent Massol <[email protected]> wrote:
Hi Thomas,
On Jan 15, 2013, at 3:48 PM, Thomas Mortagne <[email protected]> wrote:
Hi devs,
We have a "template" field in XWikiDocument and in what we export/import in the XAR but it's not part of the database mapping (there is defaultTemplate but no template). See http://jira.xwiki.org/browse/XWIKI-8650.
Since it's not saved in the database it's totally useless to have it in the XAR but we do have it in several pages of XE (some Blog pages).
So my question is what the hell is this field and what should be do with it ?
I can see two possibilities: 1) stop exporting it in the XAR and deprecated related method in XWikiDocument 2) put it back in the database mapping (I guess it used to be there or I don't see how we could have some pages with it on github)
WDYT ?
AFAIK it's never been used and since it's not saved in the DB right now I would go for 1).
We can then discuss about use cases in the future and decide if we need it.
Thanks -Vincent
PS: We need to progress on http://jira.xwiki.org/jira/browse/XWIKI-8252 which is a blocker and which is way more important ATM.
Since I have no idea what this field is supposed to do I don't have a strong opinion but since it's totally useless right now and nobody seems to complain I would go for 1).
-- Thomas Mortagne
devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
-- Thomas Mortagne
Nobody complained, lets do 1). On Tue, Jan 15, 2013 at 3:48 PM, Thomas Mortagne <[email protected]> wrote:
Hi devs,
We have a "template" field in XWikiDocument and in what we export/import in the XAR but it's not part of the database mapping (there is defaultTemplate but no template). See http://jira.xwiki.org/browse/XWIKI-8650.
Since it's not saved in the database it's totally useless to have it in the XAR but we do have it in several pages of XE (some Blog pages).
So my question is what the hell is this field and what should be do with it ?
I can see two possibilities: 1) stop exporting it in the XAR and deprecated related method in XWikiDocument 2) put it back in the database mapping (I guess it used to be there or I don't see how we could have some pages with it on github)
WDYT ?
Since I have no idea what this field is supposed to do I don't have a strong opinion but since it's totally useless right now and nobody seems to complain I would go for 1).
-- Thomas Mortagne
-- Thomas Mortagne
participants (2)
-
Thomas Mortagne -
Vincent Massol