[xwiki-devs] [VOTE] Don't embed dependencies by default in xar plugin
hi devs, The idea is that in Maven in general you should never embed anything except for final distribution packages that are not supposed to be used as dependencies of other maven projects (installers, standalone packages, etc.). This will also allow us to properly setup dependencies in xar so that dependency is installed when installing a xar in Extension Manager without its pages being imported twice. So I propose the following changes: * in xar plugin: ** stop embedding dependencies as default behavior ** introduce an optional property for it. * in XE/XEM have two different xars: ** a normal one with just XE pages and proper dependencies setup ** a "standalone" one which embed all XE dependencies xar (basically the one we have now) WDYT ? Here is my +1 -- Thomas Mortagne
On Oct 11, 2011, at 4:04 PM, Thomas Mortagne wrote:
hi devs,
The idea is that in Maven in general you should never embed anything except for final distribution packages that are not supposed to be used as dependencies of other maven projects (installers, standalone packages, etc.). This will also allow us to properly setup dependencies in xar so that dependency is installed when installing a xar in Extension Manager without its pages being imported twice.
So I propose the following changes: * in xar plugin: ** stop embedding dependencies as default behavior ** introduce an optional property for it. * in XE/XEM have two different xars: ** a normal one with just XE pages and proper dependencies setup ** a "standalone" one which embed all XE dependencies xar (basically the one we have now)
WDYT ?
Here is my +1
+1 Thanks -Vincent
On Tue, Oct 11, 2011 at 16:04, Thomas Mortagne <[email protected]>wrote:
hi devs,
The idea is that in Maven in general you should never embed anything except for final distribution packages that are not supposed to be used as dependencies of other maven projects (installers, standalone packages, etc.). This will also allow us to properly setup dependencies in xar so that dependency is installed when installing a xar in Extension Manager without its pages being imported twice.
So I propose the following changes: * in xar plugin: ** stop embedding dependencies as default behavior ** introduce an optional property for it. * in XE/XEM have two different xars: ** a normal one with just XE pages and proper dependencies setup ** a "standalone" one which embed all XE dependencies xar (basically the one we have now)
WDYT ?
+0, for short term, it helps, but if we expect more xar to be build and managed, the XAR plugin is far from what you would use in maven. IMO the assembly-plugin is better suited and properly extendable for this task. It would not require specific knowledge or ways to describe how you want your assembly, and it will be the real maven way.
Here is my +1
-- Thomas Mortagne _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Denis Gervalle SOFTEC sa - CEO eGuilde sarl - CTO
+0 Thanks, Marius On Tue, Oct 11, 2011 at 5:04 PM, Thomas Mortagne <[email protected]> wrote:
hi devs,
The idea is that in Maven in general you should never embed anything except for final distribution packages that are not supposed to be used as dependencies of other maven projects (installers, standalone packages, etc.). This will also allow us to properly setup dependencies in xar so that dependency is installed when installing a xar in Extension Manager without its pages being imported twice.
So I propose the following changes: * in xar plugin: ** stop embedding dependencies as default behavior ** introduce an optional property for it. * in XE/XEM have two different xars: ** a normal one with just XE pages and proper dependencies setup ** a "standalone" one which embed all XE dependencies xar (basically the one we have now)
WDYT ?
Here is my +1
-- Thomas Mortagne _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
On 10/11/2011 10:04 AM, Thomas Mortagne wrote:
hi devs,
The idea is that in Maven in general you should never embed anything except for final distribution packages that are not supposed to be used as dependencies of other maven projects (installers, standalone packages, etc.). This will also allow us to properly setup dependencies in xar so that dependency is installed when installing a xar in Extension Manager without its pages being imported twice.
So I propose the following changes: * in xar plugin: ** stop embedding dependencies as default behavior
+1
** introduce an optional property for it.
+0
* in XE/XEM have two different xars: ** a normal one with just XE pages and proper dependencies setup ** a "standalone" one which embed all XE dependencies xar (basically the one we have now)
Not quite sure I like this. First, we're supposed to be moving documents out of xwiki-enterprise and into application modules inside the platform, so there shouldn't be any XE XAR at all, just a list of default dependencies to include in the standalone database. Second, if we do push forward the extension manager as the preferred way of installing XARs, then such a bundle XAR shouldn't be needed at all. For the standalone distribution the packager plugin could just install the XE shallow XAR + its dependencies, while for WAR installs users could just pull it using the extension manager. So, the big fat XAR shouldn't have any use either.
WDYT ?
Here is my +1
-- Sergiu Dumitriu http://purl.org/net/sergiu/
On Wed, Oct 12, 2011 at 9:27 AM, Sergiu Dumitriu <[email protected]> wrote:
On 10/11/2011 10:04 AM, Thomas Mortagne wrote:
hi devs,
The idea is that in Maven in general you should never embed anything except for final distribution packages that are not supposed to be used as dependencies of other maven projects (installers, standalone packages, etc.). This will also allow us to properly setup dependencies in xar so that dependency is installed when installing a xar in Extension Manager without its pages being imported twice.
So I propose the following changes: * in xar plugin: ** stop embedding dependencies as default behavior
+1
** introduce an optional property for it.
+0
* in XE/XEM have two different xars: ** a normal one with just XE pages and proper dependencies setup ** a "standalone" one which embed all XE dependencies xar (basically the one we have now)
Not quite sure I like this.
First, we're supposed to be moving documents out of xwiki-enterprise and into application modules inside the platform, so there shouldn't be any XE XAR at all, just a list of default dependencies to include in the standalone database.
Yes we are supposed to be I'm pretty sure it's not going to happen in 3.3 and IMO it's another subject. Also you forget some pages like Main.WebHome that are still specific to XE and could not go in any platform application IMO, everything in XEM is properly in application located in platform but you still have some specific XEM pages.
Second, if we do push forward the extension manager as the preferred way of installing XARs, then such a bundle XAR shouldn't be needed at all. For the standalone distribution the packager plugin could just install the XE shallow XAR + its dependencies, while for WAR installs users could just pull it using the extension manager. So, the big fat XAR shouldn't have any use either.
In the future of course but we are not ready for it right now. It's not like I'm proposing to introduce a standalone package, it's already here. Let's not rush it.
WDYT ?
Here is my +1
-- Sergiu Dumitriu http://purl.org/net/sergiu/ _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
On 10/12/2011 03:42 AM, Thomas Mortagne wrote:
On Wed, Oct 12, 2011 at 9:27 AM, Sergiu Dumitriu<[email protected]> wrote:
On 10/11/2011 10:04 AM, Thomas Mortagne wrote:
hi devs,
The idea is that in Maven in general you should never embed anything except for final distribution packages that are not supposed to be used as dependencies of other maven projects (installers, standalone packages, etc.). This will also allow us to properly setup dependencies in xar so that dependency is installed when installing a xar in Extension Manager without its pages being imported twice.
So I propose the following changes: * in xar plugin: ** stop embedding dependencies as default behavior
+1
** introduce an optional property for it.
+0
* in XE/XEM have two different xars: ** a normal one with just XE pages and proper dependencies setup ** a "standalone" one which embed all XE dependencies xar (basically the one we have now)
Not quite sure I like this.
First, we're supposed to be moving documents out of xwiki-enterprise and into application modules inside the platform, so there shouldn't be any XE XAR at all, just a list of default dependencies to include in the standalone database.
Yes we are supposed to be I'm pretty sure it's not going to happen in 3.3 and IMO it's another subject. Also you forget some pages like Main.WebHome that are still specific to XE and could not go in any platform application IMO, everything in XEM is properly in application located in platform but you still have some specific XEM pages.
Second, if we do push forward the extension manager as the preferred way of installing XARs, then such a bundle XAR shouldn't be needed at all. For the standalone distribution the packager plugin could just install the XE shallow XAR + its dependencies, while for WAR installs users could just pull it using the extension manager. So, the big fat XAR shouldn't have any use either.
In the future of course but we are not ready for it right now. It's not like I'm proposing to introduce a standalone package, it's already here. Let's not rush it.
Indeed. So yes, for a quick fix for the moment, while waiting for better solutions, we do need the two packages. I wasn't -1, I was just a reluctant +0.5 knowing that there will be better options in the future. How do you envision this, implementation-wise? Two maven modules, one with documents the other as a bundle, or two build artifacts from the same module?
WDYT ?
Here is my +1
-- Sergiu Dumitriu http://purl.org/net/sergiu/
On Wed, Oct 12, 2011 at 9:50 AM, Sergiu Dumitriu <[email protected]> wrote:
On 10/12/2011 03:42 AM, Thomas Mortagne wrote:
On Wed, Oct 12, 2011 at 9:27 AM, Sergiu Dumitriu<[email protected]> wrote:
On 10/11/2011 10:04 AM, Thomas Mortagne wrote:
hi devs,
The idea is that in Maven in general you should never embed anything except for final distribution packages that are not supposed to be used as dependencies of other maven projects (installers, standalone packages, etc.). This will also allow us to properly setup dependencies in xar so that dependency is installed when installing a xar in Extension Manager without its pages being imported twice.
So I propose the following changes: * in xar plugin: ** stop embedding dependencies as default behavior
+1
** introduce an optional property for it.
+0
* in XE/XEM have two different xars: ** a normal one with just XE pages and proper dependencies setup ** a "standalone" one which embed all XE dependencies xar (basically the one we have now)
Not quite sure I like this.
First, we're supposed to be moving documents out of xwiki-enterprise and into application modules inside the platform, so there shouldn't be any XE XAR at all, just a list of default dependencies to include in the standalone database.
Yes we are supposed to be I'm pretty sure it's not going to happen in 3.3 and IMO it's another subject. Also you forget some pages like Main.WebHome that are still specific to XE and could not go in any platform application IMO, everything in XEM is properly in application located in platform but you still have some specific XEM pages.
Second, if we do push forward the extension manager as the preferred way of installing XARs, then such a bundle XAR shouldn't be needed at all. For the standalone distribution the packager plugin could just install the XE shallow XAR + its dependencies, while for WAR installs users could just pull it using the extension manager. So, the big fat XAR shouldn't have any use either.
In the future of course but we are not ready for it right now. It's not like I'm proposing to introduce a standalone package, it's already here. Let's not rush it.
Indeed. So yes, for a quick fix for the moment, while waiting for better solutions, we do need the two packages.
I wasn't -1, I was just a reluctant +0.5 knowing that there will be better options in the future.
How do you envision this, implementation-wise? Two maven modules, one with documents the other as a bundle, or two build artifacts from the same module?
Definitely two modules. With the bundle somewhere in https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-enterprise-distr... since that's what it is. Then I'm not sure if the not bundled xar will be https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-enterprise-wiki or a package in https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-manager-applicat... like I tried to do with XEM (which already have this separation between proper application but without the dependencies since it was not possible and the bundled package).
WDYT ?
Here is my +1
-- Sergiu Dumitriu http://purl.org/net/sergiu/ _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
On Wed, Oct 12, 2011 at 10:21 AM, Thomas Mortagne <[email protected]> wrote:
On Wed, Oct 12, 2011 at 9:50 AM, Sergiu Dumitriu <[email protected]> wrote:
On 10/12/2011 03:42 AM, Thomas Mortagne wrote:
On Wed, Oct 12, 2011 at 9:27 AM, Sergiu Dumitriu<[email protected]> wrote:
On 10/11/2011 10:04 AM, Thomas Mortagne wrote:
hi devs,
The idea is that in Maven in general you should never embed anything except for final distribution packages that are not supposed to be used as dependencies of other maven projects (installers, standalone packages, etc.). This will also allow us to properly setup dependencies in xar so that dependency is installed when installing a xar in Extension Manager without its pages being imported twice.
So I propose the following changes: * in xar plugin: ** stop embedding dependencies as default behavior
+1
** introduce an optional property for it.
+0
* in XE/XEM have two different xars: ** a normal one with just XE pages and proper dependencies setup ** a "standalone" one which embed all XE dependencies xar (basically the one we have now)
Not quite sure I like this.
First, we're supposed to be moving documents out of xwiki-enterprise and into application modules inside the platform, so there shouldn't be any XE XAR at all, just a list of default dependencies to include in the standalone database.
Yes we are supposed to be I'm pretty sure it's not going to happen in 3.3 and IMO it's another subject. Also you forget some pages like Main.WebHome that are still specific to XE and could not go in any platform application IMO, everything in XEM is properly in application located in platform but you still have some specific XEM pages.
Second, if we do push forward the extension manager as the preferred way of installing XARs, then such a bundle XAR shouldn't be needed at all. For the standalone distribution the packager plugin could just install the XE shallow XAR + its dependencies, while for WAR installs users could just pull it using the extension manager. So, the big fat XAR shouldn't have any use either.
In the future of course but we are not ready for it right now. It's not like I'm proposing to introduce a standalone package, it's already here. Let's not rush it.
Indeed. So yes, for a quick fix for the moment, while waiting for better solutions, we do need the two packages.
I wasn't -1, I was just a reluctant +0.5 knowing that there will be better options in the future.
How do you envision this, implementation-wise? Two maven modules, one with documents the other as a bundle, or two build artifacts from the same module?
Definitely two modules. With the bundle somewhere in https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-enterprise-distr... since that's what it is.
Then I'm not sure if the not bundled xar will be https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-enterprise-wiki or a package in https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-manager-applicat...
https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-enterprise-appli...
like I tried to do with XEM (which already have this separation between proper application but without the dependencies since it was not possible and the bundled package).
WDYT ?
Here is my +1
-- Sergiu Dumitriu http://purl.org/net/sergiu/ _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
-- Thomas Mortagne
On Wed, Oct 12, 2011 at 11:50 AM, Thomas Mortagne <[email protected]> wrote:
On Wed, Oct 12, 2011 at 10:21 AM, Thomas Mortagne <[email protected]> wrote:
On Wed, Oct 12, 2011 at 9:50 AM, Sergiu Dumitriu <[email protected]> wrote:
On 10/12/2011 03:42 AM, Thomas Mortagne wrote:
On Wed, Oct 12, 2011 at 9:27 AM, Sergiu Dumitriu<[email protected]> wrote:
On 10/11/2011 10:04 AM, Thomas Mortagne wrote:
hi devs,
The idea is that in Maven in general you should never embed anything except for final distribution packages that are not supposed to be used as dependencies of other maven projects (installers, standalone packages, etc.). This will also allow us to properly setup dependencies in xar so that dependency is installed when installing a xar in Extension Manager without its pages being imported twice.
So I propose the following changes: * in xar plugin: ** stop embedding dependencies as default behavior
+1
** introduce an optional property for it.
+0
* in XE/XEM have two different xars: ** a normal one with just XE pages and proper dependencies setup ** a "standalone" one which embed all XE dependencies xar (basically the one we have now)
Not quite sure I like this.
First, we're supposed to be moving documents out of xwiki-enterprise and into application modules inside the platform, so there shouldn't be any XE XAR at all, just a list of default dependencies to include in the standalone database.
Yes we are supposed to be I'm pretty sure it's not going to happen in 3.3 and IMO it's another subject. Also you forget some pages like Main.WebHome that are still specific to XE and could not go in any platform application IMO, everything in XEM is properly in application located in platform but you still have some specific XEM pages.
Second, if we do push forward the extension manager as the preferred way of installing XARs, then such a bundle XAR shouldn't be needed at all. For the standalone distribution the packager plugin could just install the XE shallow XAR + its dependencies, while for WAR installs users could just pull it using the extension manager. So, the big fat XAR shouldn't have any use either.
In the future of course but we are not ready for it right now. It's not like I'm proposing to introduce a standalone package, it's already here. Let's not rush it.
Indeed. So yes, for a quick fix for the moment, while waiting for better solutions, we do need the two packages.
I wasn't -1, I was just a reluctant +0.5 knowing that there will be better options in the future.
How do you envision this, implementation-wise? Two maven modules, one with documents the other as a bundle, or two build artifacts from the same module?
Definitely two modules. With the bundle somewhere in https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-enterprise-distr... since that's what it is.
Then I'm not sure if the not bundled xar will be https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-enterprise-wiki or a package in https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-manager-applicat...
https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-enterprise-appli...
like I tried to do with XEM (which already have this separation between proper application but without the dependencies since it was not possible and the bundled package).
I propose * xwiki-enterprise-ui * xwiki-enterprise-distribution/xwiki-enterprise-ui-all WDYT ?
WDYT ?
Here is my +1
-- Sergiu Dumitriu http://purl.org/net/sergiu/ _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
-- Thomas Mortagne
-- Thomas Mortagne
On Oct 12, 2011, at 12:21 PM, Thomas Mortagne wrote:
On Wed, Oct 12, 2011 at 11:50 AM, Thomas Mortagne <[email protected]> wrote:
On Wed, Oct 12, 2011 at 10:21 AM, Thomas Mortagne <[email protected]> wrote:
On Wed, Oct 12, 2011 at 9:50 AM, Sergiu Dumitriu <[email protected]> wrote:
On 10/12/2011 03:42 AM, Thomas Mortagne wrote:
On Wed, Oct 12, 2011 at 9:27 AM, Sergiu Dumitriu<[email protected]> wrote:
On 10/11/2011 10:04 AM, Thomas Mortagne wrote: > hi devs, > > The idea is that in Maven in general you should never embed anything > except for final distribution packages that are not supposed to be > used as dependencies of other maven projects (installers, standalone > packages, etc.). This will also allow us to properly setup > dependencies in xar so that dependency is installed when installing a > xar in Extension Manager without its pages being imported twice. > > So I propose the following changes: > * in xar plugin: > ** stop embedding dependencies as default behavior
+1
> ** introduce an optional property for it.
+0
> * in XE/XEM have two different xars: > ** a normal one with just XE pages and proper dependencies setup > ** a "standalone" one which embed all XE dependencies xar (basically > the one we have now)
Not quite sure I like this.
First, we're supposed to be moving documents out of xwiki-enterprise and into application modules inside the platform, so there shouldn't be any XE XAR at all, just a list of default dependencies to include in the standalone database.
Yes we are supposed to be I'm pretty sure it's not going to happen in 3.3 and IMO it's another subject. Also you forget some pages like Main.WebHome that are still specific to XE and could not go in any platform application IMO, everything in XEM is properly in application located in platform but you still have some specific XEM pages.
Second, if we do push forward the extension manager as the preferred way of installing XARs, then such a bundle XAR shouldn't be needed at all. For the standalone distribution the packager plugin could just install the XE shallow XAR + its dependencies, while for WAR installs users could just pull it using the extension manager. So, the big fat XAR shouldn't have any use either.
In the future of course but we are not ready for it right now. It's not like I'm proposing to introduce a standalone package, it's already here. Let's not rush it.
Indeed. So yes, for a quick fix for the moment, while waiting for better solutions, we do need the two packages.
I wasn't -1, I was just a reluctant +0.5 knowing that there will be better options in the future.
How do you envision this, implementation-wise? Two maven modules, one with documents the other as a bundle, or two build artifacts from the same module?
Definitely two modules. With the bundle somewhere in https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-enterprise-distr... since that's what it is.
Then I'm not sure if the not bundled xar will be https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-enterprise-wiki or a package in https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-manager-applicat...
https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-enterprise-appli...
like I tried to do with XEM (which already have this separation between proper application but without the dependencies since it was not possible and the bundled package).
I propose
* xwiki-enterprise-ui * xwiki-enterprise-distribution/xwiki-enterprise-ui-all
WDYT ?
So you want to: * rename https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-enterprise-wiki into https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-enterprise-ui * add a new https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-enterprise-distr... ? hmmm ok why not.. I wonder if we need a new directory level though for container distributions: https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-enterprise-distr... (so that there's a common pom for them to put common stuff) Right now distribution meant container distributions but putting -ui-all in it changes the meaning, it introduces a new type of distribution. It's not really a distribution in the sense that it doesn't packages XE. It only packages a small subset of XE. I'm still hesitating with this: /xwiki-enterprise-uis/ |_ xwiki-enterprise-ui/ |_ xwiki-enterprise-ui-all/ Thanks -Vincent
> WDYT ? > > Here is my +1
On Wed, Oct 12, 2011 at 4:16 PM, Vincent Massol <[email protected]> wrote:
On Oct 12, 2011, at 12:21 PM, Thomas Mortagne wrote:
On Wed, Oct 12, 2011 at 11:50 AM, Thomas Mortagne <[email protected]> wrote:
On Wed, Oct 12, 2011 at 10:21 AM, Thomas Mortagne <[email protected]> wrote:
On Wed, Oct 12, 2011 at 9:50 AM, Sergiu Dumitriu <[email protected]> wrote:
On 10/12/2011 03:42 AM, Thomas Mortagne wrote:
On Wed, Oct 12, 2011 at 9:27 AM, Sergiu Dumitriu<[email protected]> wrote: > On 10/11/2011 10:04 AM, Thomas Mortagne wrote: >> hi devs, >> >> The idea is that in Maven in general you should never embed anything >> except for final distribution packages that are not supposed to be >> used as dependencies of other maven projects (installers, standalone >> packages, etc.). This will also allow us to properly setup >> dependencies in xar so that dependency is installed when installing a >> xar in Extension Manager without its pages being imported twice. >> >> So I propose the following changes: >> * in xar plugin: >> ** stop embedding dependencies as default behavior > > +1 > >> ** introduce an optional property for it. > > +0 > >> * in XE/XEM have two different xars: >> ** a normal one with just XE pages and proper dependencies setup >> ** a "standalone" one which embed all XE dependencies xar (basically >> the one we have now) > > Not quite sure I like this. > > First, we're supposed to be moving documents out of xwiki-enterprise and > into application modules inside the platform, so there shouldn't be any > XE XAR at all, just a list of default dependencies to include in the > standalone database.
Yes we are supposed to be I'm pretty sure it's not going to happen in 3.3 and IMO it's another subject. Also you forget some pages like Main.WebHome that are still specific to XE and could not go in any platform application IMO, everything in XEM is properly in application located in platform but you still have some specific XEM pages.
> > Second, if we do push forward the extension manager as the preferred way > of installing XARs, then such a bundle XAR shouldn't be needed at all. > For the standalone distribution the packager plugin could just install > the XE shallow XAR + its dependencies, while for WAR installs users > could just pull it using the extension manager. So, the big fat XAR > shouldn't have any use either.
In the future of course but we are not ready for it right now. It's not like I'm proposing to introduce a standalone package, it's already here. Let's not rush it.
Indeed. So yes, for a quick fix for the moment, while waiting for better solutions, we do need the two packages.
I wasn't -1, I was just a reluctant +0.5 knowing that there will be better options in the future.
How do you envision this, implementation-wise? Two maven modules, one with documents the other as a bundle, or two build artifacts from the same module?
Definitely two modules. With the bundle somewhere in https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-enterprise-distr... since that's what it is.
Then I'm not sure if the not bundled xar will be https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-enterprise-wiki or a package in https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-manager-applicat...
https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-enterprise-appli...
like I tried to do with XEM (which already have this separation between proper application but without the dependencies since it was not possible and the bundled package).
I propose
* xwiki-enterprise-ui * xwiki-enterprise-distribution/xwiki-enterprise-ui-all
WDYT ?
So you want to: * rename https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-enterprise-wiki into https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-enterprise-ui * add a new https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-enterprise-distr... ?
hmmm ok why not.. I wonder if we need a new directory level though for container distributions: https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-enterprise-distr... (so that there's a common pom for them to put common stuff)
Right now distribution meant container distributions but putting -ui-all in it changes the meaning, it introduces a new type of distribution.
It's not really a distribution in the sense that it doesn't packages XE. It only packages a small subset of XE.
Actually for me distribution mean a final package you only distribute and that you are not supposed to use in another maven project (except for things like test where you actually want to test the distributed package). Actually I would also move installer in the distribution folder if you ask me.
I'm still hesitating with this:
/xwiki-enterprise-uis/ |_ xwiki-enterprise-ui/ |_ xwiki-enterprise-ui-all/
Thanks -Vincent
>> WDYT ? >> >> Here is my +1
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
On Wed, Oct 12, 2011 at 4:22 PM, Thomas Mortagne <[email protected]> wrote:
On Wed, Oct 12, 2011 at 4:16 PM, Vincent Massol <[email protected]> wrote:
On Oct 12, 2011, at 12:21 PM, Thomas Mortagne wrote:
On Wed, Oct 12, 2011 at 11:50 AM, Thomas Mortagne <[email protected]> wrote:
On Wed, Oct 12, 2011 at 10:21 AM, Thomas Mortagne <[email protected]> wrote:
On Wed, Oct 12, 2011 at 9:50 AM, Sergiu Dumitriu <[email protected]> wrote:
On 10/12/2011 03:42 AM, Thomas Mortagne wrote: > On Wed, Oct 12, 2011 at 9:27 AM, Sergiu Dumitriu<[email protected]> wrote: >> On 10/11/2011 10:04 AM, Thomas Mortagne wrote: >>> hi devs, >>> >>> The idea is that in Maven in general you should never embed anything >>> except for final distribution packages that are not supposed to be >>> used as dependencies of other maven projects (installers, standalone >>> packages, etc.). This will also allow us to properly setup >>> dependencies in xar so that dependency is installed when installing a >>> xar in Extension Manager without its pages being imported twice. >>> >>> So I propose the following changes: >>> * in xar plugin: >>> ** stop embedding dependencies as default behavior >> >> +1 >> >>> ** introduce an optional property for it. >> >> +0 >> >>> * in XE/XEM have two different xars: >>> ** a normal one with just XE pages and proper dependencies setup >>> ** a "standalone" one which embed all XE dependencies xar (basically >>> the one we have now) >> >> Not quite sure I like this. >> >> First, we're supposed to be moving documents out of xwiki-enterprise and >> into application modules inside the platform, so there shouldn't be any >> XE XAR at all, just a list of default dependencies to include in the >> standalone database. > > Yes we are supposed to be I'm pretty sure it's not going to happen in > 3.3 and IMO it's another subject. Also you forget some pages like > Main.WebHome that are still specific to XE and could not go in any > platform application IMO, everything in XEM is properly in application > located in platform but you still have some specific XEM pages. > >> >> Second, if we do push forward the extension manager as the preferred way >> of installing XARs, then such a bundle XAR shouldn't be needed at all. >> For the standalone distribution the packager plugin could just install >> the XE shallow XAR + its dependencies, while for WAR installs users >> could just pull it using the extension manager. So, the big fat XAR >> shouldn't have any use either. > > In the future of course but we are not ready for it right now. It's > not like I'm proposing to introduce a standalone package, it's already > here. Let's not rush it.
Indeed. So yes, for a quick fix for the moment, while waiting for better solutions, we do need the two packages.
I wasn't -1, I was just a reluctant +0.5 knowing that there will be better options in the future.
How do you envision this, implementation-wise? Two maven modules, one with documents the other as a bundle, or two build artifacts from the same module?
Definitely two modules. With the bundle somewhere in https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-enterprise-distr... since that's what it is.
Then I'm not sure if the not bundled xar will be https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-enterprise-wiki or a package in https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-manager-applicat...
https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-enterprise-appli...
like I tried to do with XEM (which already have this separation between proper application but without the dependencies since it was not possible and the bundled package).
I propose
* xwiki-enterprise-ui * xwiki-enterprise-distribution/xwiki-enterprise-ui-all
WDYT ?
So you want to: * rename https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-enterprise-wiki into https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-enterprise-ui * add a new https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-enterprise-distr... ?
hmmm ok why not.. I wonder if we need a new directory level though for container distributions: https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-enterprise-distr... (so that there's a common pom for them to put common stuff)
Right now distribution meant container distributions but putting -ui-all in it changes the meaning, it introduces a new type of distribution.
It's not really a distribution in the sense that it doesn't packages XE. It only packages a small subset of XE.
Actually for me distribution mean a final package you only distribute and that you are not supposed to use in another maven project (except for things like test where you actually want to test the distributed package). Actually I would also move installer in the distribution folder if you ask me.
An in that case yes I'm ok with a xwiki-enterprise-distribution-containers subdirectory.
I'm still hesitating with this:
/xwiki-enterprise-uis/ |_ xwiki-enterprise-ui/ |_ xwiki-enterprise-ui-all/
Thanks -Vincent
>>> WDYT ? >>> >>> Here is my +1
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
-- Thomas Mortagne
On Oct 12, 2011, at 4:22 PM, Thomas Mortagne wrote:
On Wed, Oct 12, 2011 at 4:16 PM, Vincent Massol <[email protected]> wrote:
On Oct 12, 2011, at 12:21 PM, Thomas Mortagne wrote:
On Wed, Oct 12, 2011 at 11:50 AM, Thomas Mortagne <[email protected]> wrote:
On Wed, Oct 12, 2011 at 10:21 AM, Thomas Mortagne <[email protected]> wrote:
On Wed, Oct 12, 2011 at 9:50 AM, Sergiu Dumitriu <[email protected]> wrote:
On 10/12/2011 03:42 AM, Thomas Mortagne wrote: > On Wed, Oct 12, 2011 at 9:27 AM, Sergiu Dumitriu<[email protected]> wrote: >> On 10/11/2011 10:04 AM, Thomas Mortagne wrote: >>> hi devs, >>> >>> The idea is that in Maven in general you should never embed anything >>> except for final distribution packages that are not supposed to be >>> used as dependencies of other maven projects (installers, standalone >>> packages, etc.). This will also allow us to properly setup >>> dependencies in xar so that dependency is installed when installing a >>> xar in Extension Manager without its pages being imported twice. >>> >>> So I propose the following changes: >>> * in xar plugin: >>> ** stop embedding dependencies as default behavior >> >> +1 >> >>> ** introduce an optional property for it. >> >> +0 >> >>> * in XE/XEM have two different xars: >>> ** a normal one with just XE pages and proper dependencies setup >>> ** a "standalone" one which embed all XE dependencies xar (basically >>> the one we have now) >> >> Not quite sure I like this. >> >> First, we're supposed to be moving documents out of xwiki-enterprise and >> into application modules inside the platform, so there shouldn't be any >> XE XAR at all, just a list of default dependencies to include in the >> standalone database. > > Yes we are supposed to be I'm pretty sure it's not going to happen in > 3.3 and IMO it's another subject. Also you forget some pages like > Main.WebHome that are still specific to XE and could not go in any > platform application IMO, everything in XEM is properly in application > located in platform but you still have some specific XEM pages. > >> >> Second, if we do push forward the extension manager as the preferred way >> of installing XARs, then such a bundle XAR shouldn't be needed at all. >> For the standalone distribution the packager plugin could just install >> the XE shallow XAR + its dependencies, while for WAR installs users >> could just pull it using the extension manager. So, the big fat XAR >> shouldn't have any use either. > > In the future of course but we are not ready for it right now. It's > not like I'm proposing to introduce a standalone package, it's already > here. Let's not rush it.
Indeed. So yes, for a quick fix for the moment, while waiting for better solutions, we do need the two packages.
I wasn't -1, I was just a reluctant +0.5 knowing that there will be better options in the future.
How do you envision this, implementation-wise? Two maven modules, one with documents the other as a bundle, or two build artifacts from the same module?
Definitely two modules. With the bundle somewhere in https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-enterprise-distr... since that's what it is.
Then I'm not sure if the not bundled xar will be https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-enterprise-wiki or a package in https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-manager-applicat...
https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-enterprise-appli...
like I tried to do with XEM (which already have this separation between proper application but without the dependencies since it was not possible and the bundled package).
I propose
* xwiki-enterprise-ui * xwiki-enterprise-distribution/xwiki-enterprise-ui-all
WDYT ?
So you want to: * rename https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-enterprise-wiki into https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-enterprise-ui * add a new https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-enterprise-distr... ?
hmmm ok why not.. I wonder if we need a new directory level though for container distributions: https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-enterprise-distr... (so that there's a common pom for them to put common stuff)
Right now distribution meant container distributions but putting -ui-all in it changes the meaning, it introduces a new type of distribution.
It's not really a distribution in the sense that it doesn't packages XE. It only packages a small subset of XE.
Actually for me distribution mean a final package you only distribute and that you are not supposed to use in another maven project (except for things like test where you actually want to test the distributed package). Actually I would also move installer in the distribution folder if you ask me.
In this case you may also want to move the database/ modules in distribution/ For me the whole of XE was about distributions, except for the XAR part it's true. This XAR part could be moved to platform BTW since we already have applications in platform… ;) That would mean the whole of XE is about distributions and in this case we can remove the -distribution module and replace it with -containers… ;) Our future is to have flavor definitions for XE, XEM, Workspaces, etc (they'll be available at runtime from a minimal Runtime Platform -- the build for it could go in https://github.com/xwiki/xwiki-platform/xwiki-platform-distribution -- and installed with Extension Manager). We'll need a location where to store those flavor definitions but IMO that could well go in platform/, maybe in https://github.com/xwiki/xwiki-platform/xwiki-platform-flavors or in https://github.com/xwiki/xwiki-platform/xwiki-platform-distribution/xwiki-pl... Thanks -Vincent
I'm still hesitating with this:
/xwiki-enterprise-uis/ |_ xwiki-enterprise-ui/ |_ xwiki-enterprise-ui-all/
Thanks -Vincent
>>> WDYT ? >>> >>> Here is my +1
On Wed, Oct 12, 2011 at 4:44 PM, Vincent Massol <[email protected]> wrote:
On Oct 12, 2011, at 4:22 PM, Thomas Mortagne wrote:
On Wed, Oct 12, 2011 at 4:16 PM, Vincent Massol <[email protected]> wrote:
On Oct 12, 2011, at 12:21 PM, Thomas Mortagne wrote:
On Wed, Oct 12, 2011 at 11:50 AM, Thomas Mortagne <[email protected]> wrote:
On Wed, Oct 12, 2011 at 10:21 AM, Thomas Mortagne <[email protected]> wrote:
On Wed, Oct 12, 2011 at 9:50 AM, Sergiu Dumitriu <[email protected]> wrote: > On 10/12/2011 03:42 AM, Thomas Mortagne wrote: >> On Wed, Oct 12, 2011 at 9:27 AM, Sergiu Dumitriu<[email protected]> wrote: >>> On 10/11/2011 10:04 AM, Thomas Mortagne wrote: >>>> hi devs, >>>> >>>> The idea is that in Maven in general you should never embed anything >>>> except for final distribution packages that are not supposed to be >>>> used as dependencies of other maven projects (installers, standalone >>>> packages, etc.). This will also allow us to properly setup >>>> dependencies in xar so that dependency is installed when installing a >>>> xar in Extension Manager without its pages being imported twice. >>>> >>>> So I propose the following changes: >>>> * in xar plugin: >>>> ** stop embedding dependencies as default behavior >>> >>> +1 >>> >>>> ** introduce an optional property for it. >>> >>> +0 >>> >>>> * in XE/XEM have two different xars: >>>> ** a normal one with just XE pages and proper dependencies setup >>>> ** a "standalone" one which embed all XE dependencies xar (basically >>>> the one we have now) >>> >>> Not quite sure I like this. >>> >>> First, we're supposed to be moving documents out of xwiki-enterprise and >>> into application modules inside the platform, so there shouldn't be any >>> XE XAR at all, just a list of default dependencies to include in the >>> standalone database. >> >> Yes we are supposed to be I'm pretty sure it's not going to happen in >> 3.3 and IMO it's another subject. Also you forget some pages like >> Main.WebHome that are still specific to XE and could not go in any >> platform application IMO, everything in XEM is properly in application >> located in platform but you still have some specific XEM pages. >> >>> >>> Second, if we do push forward the extension manager as the preferred way >>> of installing XARs, then such a bundle XAR shouldn't be needed at all. >>> For the standalone distribution the packager plugin could just install >>> the XE shallow XAR + its dependencies, while for WAR installs users >>> could just pull it using the extension manager. So, the big fat XAR >>> shouldn't have any use either. >> >> In the future of course but we are not ready for it right now. It's >> not like I'm proposing to introduce a standalone package, it's already >> here. Let's not rush it. > > Indeed. So yes, for a quick fix for the moment, while waiting for better > solutions, we do need the two packages. > > I wasn't -1, I was just a reluctant +0.5 knowing that there will be > better options in the future. > > How do you envision this, implementation-wise? Two maven modules, one > with documents the other as a bundle, or two build artifacts from the > same module?
Definitely two modules. With the bundle somewhere in https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-enterprise-distr... since that's what it is.
Then I'm not sure if the not bundled xar will be https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-enterprise-wiki or a package in https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-manager-applicat...
https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-enterprise-appli...
like I tried to do with XEM (which already have this separation between proper application but without the dependencies since it was not possible and the bundled package).
I propose
* xwiki-enterprise-ui * xwiki-enterprise-distribution/xwiki-enterprise-ui-all
WDYT ?
So you want to: * rename https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-enterprise-wiki into https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-enterprise-ui * add a new https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-enterprise-distr... ?
hmmm ok why not.. I wonder if we need a new directory level though for container distributions: https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-enterprise-distr... (so that there's a common pom for them to put common stuff)
Right now distribution meant container distributions but putting -ui-all in it changes the meaning, it introduces a new type of distribution.
It's not really a distribution in the sense that it doesn't packages XE. It only packages a small subset of XE.
Actually for me distribution mean a final package you only distribute and that you are not supposed to use in another maven project (except for things like test where you actually want to test the distributed package). Actually I would also move installer in the distribution folder if you ask me.
In this case you may also want to move the database/ modules in distribution/
If you reread what i said i talked about something that is not supposed to be used by another maven project and which is here only for distribution (and tests).
For me the whole of XE was about distributions, except for the XAR part it's true.
This XAR part could be moved to platform BTW since we already have applications in platform… ;)
That would mean the whole of XE is about distributions and in this case we can remove the -distribution module and replace it with -containers… ;)
Our future is to have flavor definitions for XE, XEM, Workspaces, etc (they'll be available at runtime from a minimal Runtime Platform -- the build for it could go in https://github.com/xwiki/xwiki-platform/xwiki-platform-distribution -- and installed with Extension Manager).
We'll need a location where to store those flavor definitions but IMO that could well go in platform/, maybe in https://github.com/xwiki/xwiki-platform/xwiki-platform-flavors or in https://github.com/xwiki/xwiki-platform/xwiki-platform-distribution/xwiki-pl...
Thanks -Vincent
I'm still hesitating with this:
/xwiki-enterprise-uis/ |_ xwiki-enterprise-ui/ |_ xwiki-enterprise-ui-all/
Thanks -Vincent
>>>> WDYT ? >>>> >>>> Here is my +1
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
On Oct 12, 2011, at 9:27 AM, Sergiu Dumitriu wrote:
On 10/11/2011 10:04 AM, Thomas Mortagne wrote:
hi devs,
The idea is that in Maven in general you should never embed anything except for final distribution packages that are not supposed to be used as dependencies of other maven projects (installers, standalone packages, etc.). This will also allow us to properly setup dependencies in xar so that dependency is installed when installing a xar in Extension Manager without its pages being imported twice.
So I propose the following changes: * in xar plugin: ** stop embedding dependencies as default behavior
+1
** introduce an optional property for it.
+0
* in XE/XEM have two different xars: ** a normal one with just XE pages and proper dependencies setup ** a "standalone" one which embed all XE dependencies xar (basically the one we have now)
Not quite sure I like this.
First, we're supposed to be moving documents out of xwiki-enterprise and into application modules inside the platform, so there shouldn't be any XE XAR at all, just a list of default dependencies to include in the standalone database.
There'll always be a few pages dedicated to XE, if only for the home page :)
Second, if we do push forward the extension manager as the preferred way of installing XARs, then such a bundle XAR shouldn't be needed at all.
Yep, however thomas is talking about now and not in 4 months time. What you say will become true in the future. That said, even at that time we'll still want a super-bundle IMO since we need to allow people to download something off the internet put it on USB key and later on install it on machine which are not connected to the internet (for example this is the norm usually in operation centers at lots of companies where they have strict policies about which computer can access the internet for security reasons).
For the standalone distribution the packager plugin could just install the XE shallow XAR + its dependencies,
I have thought about this and I don't agree. For me we need to keep the import/export feature for *backups*. The Extension Manager isn't going to replace that. They're both different use cases.
while for WAR installs users could just pull it using the extension manager. So, the big fat XAR shouldn't have any use either.
Thanks -Vincent
WDYT ?
Here is my +1
participants (5)
-
Denis Gervalle -
Marius Dumitru Florea -
Sergiu Dumitriu -
Thomas Mortagne -
Vincent Massol