[xwiki-devs] [Proposal] Having the AppBar panel in the left side column by default.
Hi, In Flamingo, we have created the concept of Application Bar, that we have implemented as a Panel: http://jira.xwiki.org/browse/XWIKI-10254 I propose to put the Application Bar by default on the left column. Since we do not have a configuration system at the skin level, it would be present for both Colibri & Flamingo. I think it is not a problem because I have managed to make it look good for both (except for the size of the icons) : http://jira.xwiki.org/secure/attachment/27707/appbar.png WDYT? Thanks, Guillaume
On Wed, May 28, 2014 at 4:18 PM, Guillaume "Louis-Marie" Delhumeau <[email protected]> wrote:
Hi,
In Flamingo, we have created the concept of Application Bar, that we have implemented as a Panel: http://jira.xwiki.org/browse/XWIKI-10254
I propose to put the Application Bar by default on the left column.
Since we do not have a configuration system at the skin level, it would be present for both Colibri & Flamingo. I think it is not a problem because I have managed to make it look good for both (except for the size of the icons) : http://jira.xwiki.org/secure/attachment/27707/appbar.png
WDYT?
It doesn't look very well, and the Applications panel is redundant. I don't have a solution though. Need to think about it.
Thanks, Guillaume _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
On 29 May 2014 at 11:23:01, Marius Dumitru Florea ([email protected](mailto:[email protected])) wrote:
On Wed, May 28, 2014 at 4:18 PM, Guillaume "Louis-Marie" Delhumeau wrote:
Hi,
In Flamingo, we have created the concept of Application Bar, that we have implemented as a Panel: http://jira.xwiki.org/browse/XWIKI-10254
I propose to put the Application Bar by default on the left column.
Since we do not have a configuration system at the skin level, it would be present for both Colibri & Flamingo. I think it is not a problem because I have managed to make it look good for both (except for the size of the icons) : http://jira.xwiki.org/secure/attachment/27707/appbar.png
WDYT?
It doesn't look very well, and the Applications panel is redundant. I don't have a solution though. Need to think about it.
Note that Guillaume forgot to mention that the icons will be larger (see http://design.xwiki.org/xwiki/bin/download/Improvements/Skin4x/homepageDeskt...). Right now they are the ones from the panel in medium width mode because Guillaume has implemented it yet. @Guillaume: regarding icon colors, what would be your plan? Blue and white colors as on http://design.xwiki.org/xwiki/bin/download/Improvements/Skin4x/homepageDeskt... even for the Colibri skin or different coloring depending on the skin? I also think that it might be best to not change Colibri since people are probably used to it for now. Now we need to find a way to have panels defined differently for each skin for that. There are various solutions for this: * Solution 1: Add support for storing configuration (XWikiPreferences) in skin pages and modify the DefaultConfigurationSource to be profile > skin > space > wiki or possibly better: profile > space > wiki > skin * Solution 2: Refactor the UI configuration in the Admin UI by moving all UI-related configuration parameters in some UIConfig xobjects that depend on the selected skin (one xobject per skin). Make the skin selection the first item on the page and when you change it the rest of the UI configuration below reflects the content of the UIConfig page corresponding to that skin. This means introduction a UIConfigurationSource component impl but that’s easy to do. * Solution 3: Modify the leftpanels/rightpanels configuration properties from String to TextArea and allow scripting to be put inside. Then, by default, have some “if” to handle both Colibri and Flaming default panels. When the user uses the Panel Wizard the first time, the value will be overridden by the list of panels selected by the user. * Solution 4: In the DefaultSkin page, override leftpanels.vm/leftpanels.vm and check if the user has defined any panel preferences in XWikiPreferences. If so, then use them. If not, then compute the left and right panels default values. There are obviously downsides to all these solutions... Personally I think I prefer solution 1 with profile > space > wiki > skin, i.e. if the leftpanels/rightpanels xproperties are not defined at the profile, space, wiki levels (and by default we should leave it empty there) then the value is taken from the skin configuration component. We would need to define how the Panel Wizard works (we probably have an issue even now when the panels are defined in a user’s profile). It should probably be possible int he Panel Wizard UI to select what level is being configured (wiki, space, profile, skin). That’s the main issue for which we need a solution: that it is not too magical for the user when they go to the Panel Wizard. More generally speaking a we have an issue in the Admin UI. We should probably show the inferred values (real value used) and indicate the value for a given property at all levels (wiki, space, profile, skin) and allow users to easily change the value for the level they wish. We need some more brainstorming about this. Any other ideas or variations? Thanks -Vincent
Thanks, Guillaume
Hi Vincent 2014-06-02 8:49 GMT+02:00 [email protected] <[email protected]>:
On 29 May 2014 at 11:23:01, Marius Dumitru Florea ( [email protected](mailto:[email protected])) wrote:
On Wed, May 28, 2014 at 4:18 PM, Guillaume "Louis-Marie" Delhumeau wrote:
Hi,
In Flamingo, we have created the concept of Application Bar, that we have implemented as a Panel: http://jira.xwiki.org/browse/XWIKI-10254
I propose to put the Application Bar by default on the left column.
Since we do not have a configuration system at the skin level, it would be present for both Colibri & Flamingo. I think it is not a problem because I have managed to make it look good for both (except for the size of the icons) : http://jira.xwiki.org/secure/attachment/27707/appbar.png
WDYT?
It doesn't look very well, and the Applications panel is redundant. I don't have a solution though. Need to think about it.
Note that Guillaume forgot to mention that the icons will be larger (see http://design.xwiki.org/xwiki/bin/download/Improvements/Skin4x/homepageDeskt...). Right now they are the ones from the panel in medium width mode because Guillaume has implemented it yet.
@Guillaume: regarding icon colors, what would be your plan? Blue and white colors as on http://design.xwiki.org/xwiki/bin/download/Improvements/Skin4x/homepageDeskt... even for the Colibri skin or different coloring depending on the skin?
There, we need to find a nice alternative of Silk for Flamingo.
I also think that it might be best to not change Colibri since people are probably used to it for now. Now we need to find a way to have panels defined differently for each skin for that.
If people have already customized their panels, an upgrade will not overwrite their settings.
There are various solutions for this: * Solution 1: Add support for storing configuration (XWikiPreferences) in skin pages and modify the DefaultConfigurationSource to be profile > skin > space > wiki or possibly better: profile > space > wiki > skin
I dislike this idea. Not only because it is hard to represent from an UI point of view, but also because it is complicated from a user point of view. It is already complicated to understand what happens when there are rights set everywhere in pages, spaces and wikis, and I don't think it is good to have the same problem on configuration. If you want to have the App Bar only in flamingo, then maybe it is the role of a flavor to propose pre-configured settings, not the role of Flamingo to overwrite the configuration of the wiki.
* Solution 2: Refactor the UI configuration in the Admin UI by moving all UI-related configuration parameters in some UIConfig xobjects that depend on the selected skin (one xobject per skin). Make the skin selection the first item on the page and when you change it the rest of the UI configuration below reflects the content of the UIConfig page corresponding to that skin. This means introduction a UIConfigurationSource component impl but that’s easy to do. * Solution 3: Modify the leftpanels/rightpanels configuration properties from String to TextArea and allow scripting to be put inside. Then, by default, have some “if” to handle both Colibri and Flaming default panels. When the user uses the Panel Wizard the first time, the value will be overridden by the list of panels selected by the user.
I'm not fan of it but I prefer this one.
* Solution 4: In the DefaultSkin page, override leftpanels.vm/leftpanels.vm and check if the user has defined any panel preferences in XWikiPreferences. If so, then use them. If not, then compute the left and right panels default values.
This one too.
There are obviously downsides to all these solutions...
Personally I think I prefer solution 1 with profile > space > wiki > skin, i.e. if the leftpanels/rightpanels xproperties are not defined at the profile, space, wiki levels (and by default we should leave it empty there) then the value is taken from the skin configuration component. We would need to define how the Panel Wizard works (we probably have an issue even now when the panels are defined in a user’s profile). It should probably be possible int he Panel Wizard UI to select what level is being configured (wiki, space, profile, skin). That’s the main issue for which we need a solution: that it is not too magical for the user when they go to the Panel Wizard. More generally speaking a we have an issue in the Admin UI. We should probably show the inferred values (real value used) and indicate the value for a given property at all levels (wiki, space, profile, skin) and allow users to easily change the value for the level they wish.
We need some more brainstorming about this. Any other ideas or variations?
Thanks -Vincent
Thanks, Guillaume
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
Thanks, Guillaume
On Mon, Jun 2, 2014 at 8:49 AM, [email protected] <[email protected]> wrote:
On 29 May 2014 at 11:23:01, Marius Dumitru Florea ( [email protected](mailto:[email protected])) wrote:
On Wed, May 28, 2014 at 4:18 PM, Guillaume "Louis-Marie" Delhumeau wrote:
Hi,
In Flamingo, we have created the concept of Application Bar, that we have implemented as a Panel: http://jira.xwiki.org/browse/XWIKI-10254
I propose to put the Application Bar by default on the left column.
Since we do not have a configuration system at the skin level, it would be present for both Colibri & Flamingo. I think it is not a problem because I have managed to make it look good for both (except for the size of the icons) : http://jira.xwiki.org/secure/attachment/27707/appbar.png
WDYT?
It doesn't look very well, and the Applications panel is redundant. I don't have a solution though. Need to think about it.
Note that Guillaume forgot to mention that the icons will be larger (see http://design.xwiki.org/xwiki/bin/download/Improvements/Skin4x/homepageDeskt...). Right now they are the ones from the panel in medium width mode because Guillaume has implemented it yet.
@Guillaume: regarding icon colors, what would be your plan? Blue and white colors as on http://design.xwiki.org/xwiki/bin/download/Improvements/Skin4x/homepageDeskt... even for the Colibri skin or different coloring depending on the skin?
I also think that it might be best to not change Colibri since people are probably used to it for now. Now we need to find a way to have panels defined differently for each skin for that.
I do not really agree. Panels is (at least intended to be) a standalone application, that is not directly related to skins. Panels themselves are also independent. Linking panel app, panels and skin would not increase the modularity of our solution. I do not really understand why adding that AppBar panel change anything. If the user want an AppBar, she could configure it easily in the panel configuration. And regarding the default distribution, I do not see why in the 6.x release, we couldn't change the default panel layout. This will have no impact on existing users that are migrating. I do not see any reason not to have the AppBar in colibri by default in the new distribution.
There are various solutions for this: * Solution 1: Add support for storing configuration (XWikiPreferences) in skin pages and modify the DefaultConfigurationSource to be profile > skin > space > wiki or possibly better: profile > space > wiki > skin * Solution 2: Refactor the UI configuration in the Admin UI by moving all UI-related configuration parameters in some UIConfig xobjects that depend on the selected skin (one xobject per skin). Make the skin selection the first item on the page and when you change it the rest of the UI configuration below reflects the content of the UIConfig page corresponding to that skin. This means introduction a UIConfigurationSource component impl but that’s easy to do. * Solution 3: Modify the leftpanels/rightpanels configuration properties from String to TextArea and allow scripting to be put inside. Then, by default, have some “if” to handle both Colibri and Flaming default panels. When the user uses the Panel Wizard the first time, the value will be overridden by the list of panels selected by the user. * Solution 4: In the DefaultSkin page, override leftpanels.vm/leftpanels.vm and check if the user has defined any panel preferences in XWikiPreferences. If so, then use them. If not, then compute the left and right panels default values.
There are obviously downsides to all these solutions...
Personally I think I prefer solution 1 with profile > space > wiki > skin, i.e. if the leftpanels/rightpanels xproperties are not defined at the profile, space, wiki levels (and by default we should leave it empty there) then the value is taken from the skin configuration component. We would need to define how the Panel Wizard works (we probably have an issue even now when the panels are defined in a user’s profile). It should probably be possible int he Panel Wizard UI to select what level is being configured (wiki, space, profile, skin). That’s the main issue for which we need a solution: that it is not too magical for the user when they go to the Panel Wizard. More generally speaking a we have an issue in the Admin UI. We should probably show the inferred values (real value used) and indicate the value for a given property at all levels (wiki, space, profile, skin) and allow users to easily change the value for the level they wish.
We need some more brainstorming about this. Any other ideas or variations?
Thanks -Vincent
Thanks, Guillaume
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Denis Gervalle SOFTEC sa - CEO
Hi Denis, On 4 Jun 2014 at 09:27:49, Denis Gervalle ([email protected](mailto:[email protected])) wrote:
On Mon, Jun 2, 2014 at 8:49 AM, [email protected] wrote:
On 29 May 2014 at 11:23:01, Marius Dumitru Florea ( [email protected](mailto:[email protected])) wrote:
On Wed, May 28, 2014 at 4:18 PM, Guillaume "Louis-Marie" Delhumeau wrote:
Hi,
In Flamingo, we have created the concept of Application Bar, that we have implemented as a Panel: http://jira.xwiki.org/browse/XWIKI-10254
I propose to put the Application Bar by default on the left column.
Since we do not have a configuration system at the skin level, it would be present for both Colibri & Flamingo. I think it is not a problem because I have managed to make it look good for both (except for the size of the icons) : http://jira.xwiki.org/secure/attachment/27707/appbar.png
WDYT?
It doesn't look very well, and the Applications panel is redundant. I don't have a solution though. Need to think about it.
Note that Guillaume forgot to mention that the icons will be larger (see http://design.xwiki.org/xwiki/bin/download/Improvements/Skin4x/homepageDeskt...). Right now they are the ones from the panel in medium width mode because Guillaume has implemented it yet.
@Guillaume: regarding icon colors, what would be your plan? Blue and white colors as on http://design.xwiki.org/xwiki/bin/download/Improvements/Skin4x/homepageDeskt... even for the Colibri skin or different coloring depending on the skin?
I also think that it might be best to not change Colibri since people are probably used to it for now. Now we need to find a way to have panels defined differently for each skin for that.
I do not really agree. Panels is (at least intended to be) a standalone application, that is not directly related to skins. Panels themselves are also independent. Linking panel app, panels and skin would not increase the modularity of our solution. I do not really understand why adding that AppBar panel change anything. If the user want an AppBar, she could configure it easily in the panel configuration. And regarding the default distribution, I do not see why in the 6.x release, we couldn't change the default panel layout. This will have no impact on existing users that are migrating. I do not see any reason not to have the AppBar in colibri by default in the new distribution.
[snip] Some thoughts: 1) Panels are indeed independent of the skin but the position of the Panels are not, they depend on the skin, especially the default position. The proof of this is this discussion and the fact that Flamingo requires a different default Panel layout than Colibri… 2) Changing the default set of panels and their position in 6.x to be good for Flamingo means that you consider that we cannot have more than 1 skin at a time. I believe we should go in the direction of being able to have more than 1 skin at a time. 3) It could also be nice if a user could install a skin from extensions.xwiki.org (like the leothrix one) and upon installing it he would be able to choose to have the default Panel layout for this skin or keep his customization. Basically this is all about having a nice user experience. Now I agree that this topic is a bit complex but I still believe we should brainstorm it to decide where we want to go in the future even if for now it’s too complex and we decide to support only 1 skin at a time for that reason (which is a valid reason). Thanks -Vincent
On Wed, Jun 4, 2014 at 9:44 AM, [email protected] <[email protected]> wrote:
Hi Denis,
On 4 Jun 2014 at 09:27:49, Denis Gervalle ([email protected](mailto: [email protected])) wrote:
On Mon, Jun 2, 2014 at 8:49 AM, [email protected] wrote:
On 29 May 2014 at 11:23:01, Marius Dumitru Florea ( [email protected](mailto:[email protected])) wrote:
On Wed, May 28, 2014 at 4:18 PM, Guillaume "Louis-Marie" Delhumeau wrote:
Hi,
In Flamingo, we have created the concept of Application Bar, that
we
have
implemented as a Panel: http://jira.xwiki.org/browse/XWIKI-10254
I propose to put the Application Bar by default on the left column.
Since we do not have a configuration system at the skin level, it would be present for both Colibri & Flamingo. I think it is not a problem because I have managed to make it look good for both (except for the size of the icons) : http://jira.xwiki.org/secure/attachment/27707/appbar.png
WDYT?
It doesn't look very well, and the Applications panel is redundant. I don't have a solution though. Need to think about it.
Note that Guillaume forgot to mention that the icons will be larger (see
http://design.xwiki.org/xwiki/bin/download/Improvements/Skin4x/homepageDeskt... ).
Right now they are the ones from the panel in medium width mode because Guillaume has implemented it yet.
@Guillaume: regarding icon colors, what would be your plan? Blue and white colors as on
http://design.xwiki.org/xwiki/bin/download/Improvements/Skin4x/homepageDeskt...
even for the Colibri skin or different coloring depending on the skin?
I also think that it might be best to not change Colibri since people are probably used to it for now. Now we need to find a way to have panels defined differently for each skin for that.
I do not really agree. Panels is (at least intended to be) a standalone application, that is not directly related to skins. Panels themselves are also independent. Linking panel app, panels and skin would not increase the modularity of our solution. I do not really understand why adding that AppBar panel change anything. If the user want an AppBar, she could configure it easily in the panel configuration. And regarding the default distribution, I do not see why in the 6.x release, we couldn't change the default panel layout. This will have no impact on existing users that are migrating. I do not see any reason not to have the AppBar in colibri by default in the new distribution.
[snip]
Some thoughts:
1) Panels are indeed independent of the skin but the position of the Panels are not, they depend on the skin, especially the default position. The proof of this is this discussion and the fact that Flamingo requires a different default Panel layout than Colibri…
I do not agree, the panel position is admin choice independently of the skin. The skin manage the look, and the panel is about exposing functionalities. This seems to me unrelated even if the panels include a bit of layout.
2) Changing the default set of panels and their position in 6.x to be good for Flamingo means that you consider that we cannot have more than 1 skin at a time. I believe we should go in the direction of being able to have more than 1 skin at a time.
Again, I dislike the idea to closely link panels choice and layout with skins. Panels should individually adapt themselves to the current skin, but changing skin should not change panels. This would be like changing the look also change the functionalities. For example, a user may impose its own skin, but this should not disrupt the specific functionalities expose by the wiki through panels.
3) It could also be nice if a user could install a skin from extensions.xwiki.org (like the leothrix one) and upon installing it he would be able to choose to have the default Panel layout for this skin or keep his customization.
Basically this is all about having a nice user experience.
For sure, and IMO for a nice user experience, panel should stay independent of the skin. Skin should be mainly a matter of look and feel, and no more. That said, we may imagine a feature of the skin installer that propose to set default panels for that skin. But it seems to me overkill, since setting panels is (should be) really easy (with the panel wizard).
Now I agree that this topic is a bit complex but I still believe we should brainstorm it to decide where we want to go in the future even if for now it’s too complex and we decide to support only 1 skin at a time for that reason (which is a valid reason).
Thanks -Vincent
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Denis Gervalle SOFTEC sa - CEO
On Wed, Jun 4, 2014 at 10:27 AM, Denis Gervalle <[email protected]> wrote:
On Mon, Jun 2, 2014 at 8:49 AM, [email protected] <[email protected]> wrote:
On 29 May 2014 at 11:23:01, Marius Dumitru Florea ( [email protected](mailto:[email protected])) wrote:
On Wed, May 28, 2014 at 4:18 PM, Guillaume "Louis-Marie" Delhumeau wrote:
Hi,
In Flamingo, we have created the concept of Application Bar, that we have implemented as a Panel: http://jira.xwiki.org/browse/XWIKI-10254
I propose to put the Application Bar by default on the left column.
Since we do not have a configuration system at the skin level, it would be present for both Colibri & Flamingo. I think it is not a problem because I have managed to make it look good for both (except for the size of the icons) : http://jira.xwiki.org/secure/attachment/27707/appbar.png
WDYT?
It doesn't look very well, and the Applications panel is redundant. I don't have a solution though. Need to think about it.
Note that Guillaume forgot to mention that the icons will be larger (see http://design.xwiki.org/xwiki/bin/download/Improvements/Skin4x/homepageDeskt...). Right now they are the ones from the panel in medium width mode because Guillaume has implemented it yet.
@Guillaume: regarding icon colors, what would be your plan? Blue and white colors as on http://design.xwiki.org/xwiki/bin/download/Improvements/Skin4x/homepageDeskt... even for the Colibri skin or different coloring depending on the skin?
I also think that it might be best to not change Colibri since people are probably used to it for now. Now we need to find a way to have panels defined differently for each skin for that.
I do not really agree. Panels is (at least intended to be) a standalone application, that is not directly related to skins. Panels themselves are also independent. Linking panel app, panels and skin would not increase the modularity of our solution. I do not really understand why adding that AppBar panel change anything. If the user want an AppBar, she could configure it easily in the panel configuration. And regarding the default distribution, I do not see why in the 6.x release, we couldn't change the default panel layout. This will have no impact on existing users that are migrating.
I do not see any reason not to have the AppBar in colibri by default in the new distribution.
Because it doesn't look good? Do you think the AppBar is well integrated into the Colibri skin as it looks like in http://jira.xwiki.org/secure/attachment/27707/appbar.png . I don't. It doesn't look like a panel and the first impression I had is that some styles are missing. I don't mind having the AppBar in Colibri, but it needs to be integrated. The missing panel header and background may be good for flamingo, but I don't find it nice for Colibri. Thanks, Marius
There are various solutions for this: * Solution 1: Add support for storing configuration (XWikiPreferences) in skin pages and modify the DefaultConfigurationSource to be profile > skin > space > wiki or possibly better: profile > space > wiki > skin * Solution 2: Refactor the UI configuration in the Admin UI by moving all UI-related configuration parameters in some UIConfig xobjects that depend on the selected skin (one xobject per skin). Make the skin selection the first item on the page and when you change it the rest of the UI configuration below reflects the content of the UIConfig page corresponding to that skin. This means introduction a UIConfigurationSource component impl but that’s easy to do. * Solution 3: Modify the leftpanels/rightpanels configuration properties from String to TextArea and allow scripting to be put inside. Then, by default, have some “if” to handle both Colibri and Flaming default panels. When the user uses the Panel Wizard the first time, the value will be overridden by the list of panels selected by the user. * Solution 4: In the DefaultSkin page, override leftpanels.vm/leftpanels.vm and check if the user has defined any panel preferences in XWikiPreferences. If so, then use them. If not, then compute the left and right panels default values.
There are obviously downsides to all these solutions...
Personally I think I prefer solution 1 with profile > space > wiki > skin, i.e. if the leftpanels/rightpanels xproperties are not defined at the profile, space, wiki levels (and by default we should leave it empty there) then the value is taken from the skin configuration component. We would need to define how the Panel Wizard works (we probably have an issue even now when the panels are defined in a user’s profile). It should probably be possible int he Panel Wizard UI to select what level is being configured (wiki, space, profile, skin). That’s the main issue for which we need a solution: that it is not too magical for the user when they go to the Panel Wizard. More generally speaking a we have an issue in the Admin UI. We should probably show the inferred values (real value used) and indicate the value for a given property at all levels (wiki, space, profile, skin) and allow users to easily change the value for the level they wish.
We need some more brainstorming about this. Any other ideas or variations?
Thanks -Vincent
Thanks, Guillaume
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Denis Gervalle SOFTEC sa - CEO _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
On Tue, Jun 10, 2014 at 1:27 PM, Marius Dumitru Florea < [email protected]> wrote:
On Wed, Jun 4, 2014 at 10:27 AM, Denis Gervalle <[email protected]> wrote:
On Mon, Jun 2, 2014 at 8:49 AM, [email protected] <[email protected]> wrote:
On 29 May 2014 at 11:23:01, Marius Dumitru Florea ( [email protected](mailto:[email protected])) wrote:
On Wed, May 28, 2014 at 4:18 PM, Guillaume "Louis-Marie" Delhumeau wrote:
Hi,
In Flamingo, we have created the concept of Application Bar, that we have implemented as a Panel: http://jira.xwiki.org/browse/XWIKI-10254
I propose to put the Application Bar by default on the left column.
Since we do not have a configuration system at the skin level, it would be present for both Colibri & Flamingo. I think it is not a problem because I have managed to make it look good for both (except for the size of
the
icons) : http://jira.xwiki.org/secure/attachment/27707/appbar.png
WDYT?
It doesn't look very well, and the Applications panel is redundant. I don't have a solution though. Need to think about it.
Note that Guillaume forgot to mention that the icons will be larger (see
http://design.xwiki.org/xwiki/bin/download/Improvements/Skin4x/homepageDeskt... ).
Right now they are the ones from the panel in medium width mode because Guillaume has implemented it yet.
@Guillaume: regarding icon colors, what would be your plan? Blue and white colors as on
http://design.xwiki.org/xwiki/bin/download/Improvements/Skin4x/homepageDeskt...
even for the Colibri skin or different coloring depending on the skin?
I also think that it might be best to not change Colibri since people are probably used to it for now. Now we need to find a way to have panels defined differently for each skin for that.
I do not really agree. Panels is (at least intended to be) a standalone application, that is not directly related to skins. Panels themselves are also independent. Linking panel app, panels and skin would not increase the modularity of our solution. I do not really understand why adding that AppBar panel change anything. If the user want an AppBar, she could configure it easily in the panel configuration. And regarding the default distribution, I do not see why in the 6.x release, we couldn't change the default panel layout. This will have no impact on existing users that are migrating.
I do not see any reason not to have the AppBar in colibri by default in the new distribution.
Because it doesn't look good? Do you think the AppBar is well integrated into the Colibri skin as it looks like in http://jira.xwiki.org/secure/attachment/27707/appbar.png . I don't. It doesn't look like a panel and the first impression I had is that some styles are missing.
I do not have that feeling. The default setup will be Flamingo anyway, and you may change to a large panel to get back the old design. That said, we can probably do some more CSS styling in Colibri to meet your requirements.
I don't mind having the AppBar in Colibri, but it needs to be integrated. The missing panel header and background may be good for flamingo, but I don't find it nice for Colibri.
I do not really find it ugly, but if other see it the way you do, I am not against in improved styling.
Thanks, Marius
There are various solutions for this: * Solution 1: Add support for storing configuration (XWikiPreferences)
in
skin pages and modify the DefaultConfigurationSource to be profile > skin > space > wiki or possibly better: profile > space > wiki > skin * Solution 2: Refactor the UI configuration in the Admin UI by moving all UI-related configuration parameters in some UIConfig xobjects that depend on the selected skin (one xobject per skin). Make the skin selection the first item on the page and when you change it the rest of the UI configuration below reflects the content of the UIConfig page corresponding to that skin. This means introduction a UIConfigurationSource component impl but that’s easy to do. * Solution 3: Modify the leftpanels/rightpanels configuration properties from String to TextArea and allow scripting to be put inside. Then, by default, have some “if” to handle both Colibri and Flaming default panels. When the user uses the Panel Wizard the first time, the value will be overridden by the list of panels selected by the user. * Solution 4: In the DefaultSkin page, override leftpanels.vm/leftpanels.vm and check if the user has defined any panel preferences in XWikiPreferences. If so, then use them. If not, then compute the left and right panels default values.
There are obviously downsides to all these solutions...
Personally I think I prefer solution 1 with profile > space > wiki > skin, i.e. if the leftpanels/rightpanels xproperties are not defined at the profile, space, wiki levels (and by default we should leave it empty there) then the value is taken from the skin configuration component. We would need to define how the Panel Wizard works (we probably have an issue even now when the panels are defined in a user’s profile). It should probably be possible int he Panel Wizard UI to select what level is being configured (wiki, space, profile, skin). That’s the main issue for which we need a solution: that it is not too magical for the user when they go to the Panel Wizard. More generally speaking a we have an issue in the Admin UI. We should probably show the inferred values (real value used) and indicate the value for a given property at all levels (wiki, space, profile, skin) and allow users to easily change the value for the level they wish.
We need some more brainstorming about this. Any other ideas or variations?
Thanks -Vincent
Thanks, Guillaume
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Denis Gervalle SOFTEC sa - CEO _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Denis Gervalle SOFTEC sa - CEO
Solution 5: Provide the styling differences only in Panels.Applications. Provide a ssx that with an IF handles both Colibri (we can consider the default styling to include Colibri) and Flamingo. This way we are not making the whole Panels app skin dependent, but only Panels.Applications. Depending on the skin, the panels can provide a different style. Initially, changing the skin to Flamingo, will have panels only on the right side (a big panels applications, after the other standard panels). It is in the duty of the Administrator to change the panels configuration and choose the default arrangement (he will have to manually put the Applications panel in the left area). So the order is default no matter the skin. Solution 6: Just like we have multiple ColorThemes, we could provide something like a PanelsTheme (or something that stores the Panels order). This application would store everything from Administration-Page Elements-Panels section (Display, Width, List x 2 for left and right panels). This application is dependent of Panels app. When I want to customize the look of my wiki, I would go in Presentation, choose the skin, the colortheme and the panels order (choose Flamingo, choose a ColorTheme that matches better Flamingo and then I would choose FlamingoPanelsOrder). This solution is a good idea also for the customization of sub-wikis and flavors. For example, in Knowledge Base wiki I need both left and right column, with the Tree in the left side. On groupware flavor I need the Applications on the left side. I can make some panels order that I display for team's sub-wikis while I have another order for the main wiki, etc. Thanks, Caty On Mon, Jun 2, 2014 at 9:49 AM, [email protected] <[email protected]> wrote:
On 29 May 2014 at 11:23:01, Marius Dumitru Florea ( [email protected](mailto:[email protected])) wrote:
On Wed, May 28, 2014 at 4:18 PM, Guillaume "Louis-Marie" Delhumeau wrote:
Hi,
In Flamingo, we have created the concept of Application Bar, that we have implemented as a Panel: http://jira.xwiki.org/browse/XWIKI-10254
I propose to put the Application Bar by default on the left column.
Since we do not have a configuration system at the skin level, it would be present for both Colibri & Flamingo. I think it is not a problem because I have managed to make it look good for both (except for the size of the icons) : http://jira.xwiki.org/secure/attachment/27707/appbar.png
WDYT?
It doesn't look very well, and the Applications panel is redundant. I don't have a solution though. Need to think about it.
Note that Guillaume forgot to mention that the icons will be larger (see http://design.xwiki.org/xwiki/bin/download/Improvements/Skin4x/homepageDeskt...). Right now they are the ones from the panel in medium width mode because Guillaume has implemented it yet.
@Guillaume: regarding icon colors, what would be your plan? Blue and white colors as on http://design.xwiki.org/xwiki/bin/download/Improvements/Skin4x/homepageDeskt... even for the Colibri skin or different coloring depending on the skin?
I also think that it might be best to not change Colibri since people are probably used to it for now. Now we need to find a way to have panels defined differently for each skin for that.
There are various solutions for this: * Solution 1: Add support for storing configuration (XWikiPreferences) in skin pages and modify the DefaultConfigurationSource to be profile > skin > space > wiki or possibly better: profile > space > wiki > skin * Solution 2: Refactor the UI configuration in the Admin UI by moving all UI-related configuration parameters in some UIConfig xobjects that depend on the selected skin (one xobject per skin). Make the skin selection the first item on the page and when you change it the rest of the UI configuration below reflects the content of the UIConfig page corresponding to that skin. This means introduction a UIConfigurationSource component impl but that’s easy to do. * Solution 3: Modify the leftpanels/rightpanels configuration properties from String to TextArea and allow scripting to be put inside. Then, by default, have some “if” to handle both Colibri and Flaming default panels. When the user uses the Panel Wizard the first time, the value will be overridden by the list of panels selected by the user. * Solution 4: In the DefaultSkin page, override leftpanels.vm/leftpanels.vm and check if the user has defined any panel preferences in XWikiPreferences. If so, then use them. If not, then compute the left and right panels default values.
There are obviously downsides to all these solutions...
Personally I think I prefer solution 1 with profile > space > wiki > skin, i.e. if the leftpanels/rightpanels xproperties are not defined at the profile, space, wiki levels (and by default we should leave it empty there) then the value is taken from the skin configuration component. We would need to define how the Panel Wizard works (we probably have an issue even now when the panels are defined in a user’s profile). It should probably be possible int he Panel Wizard UI to select what level is being configured (wiki, space, profile, skin). That’s the main issue for which we need a solution: that it is not too magical for the user when they go to the Panel Wizard. More generally speaking a we have an issue in the Admin UI. We should probably show the inferred values (real value used) and indicate the value for a given property at all levels (wiki, space, profile, skin) and allow users to easily change the value for the level they wish.
We need some more brainstorming about this. Any other ideas or variations?
Thanks -Vincent
Thanks, Guillaume
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
2014-06-04 13:31 GMT+02:00 Ecaterina Moraru (Valica) <[email protected]>:
Solution 5: Provide the styling differences only in Panels.Applications. Provide a ssx that with an IF handles both Colibri (we can consider the default styling to include Colibri) and Flamingo.
Panels.Applications already works for colibri and flamingo, with pure CSS.
This way we are not making the whole Panels app skin dependent, but only Panels.Applications. Depending on the skin, the panels can provide a different style. Initially, changing the skin to Flamingo, will have panels only on the right side (a big panels applications, after the other standard panels). It is in the duty of the Administrator to change the panels configuration and choose the default arrangement (he will have to manually put the Applications panel in the left area). So the order is default no matter the skin.
Solution 6: Just like we have multiple ColorThemes, we could provide something like a PanelsTheme (or something that stores the Panels order). This application would store everything from Administration-Page Elements-Panels section (Display, Width, List x 2 for left and right panels). This application is dependent of Panels app. When I want to customize the look of my wiki, I would go in Presentation, choose the skin, the colortheme and the panels order (choose Flamingo, choose a ColorTheme that matches better Flamingo and then I would choose FlamingoPanelsOrder). This solution is a good idea also for the customization of sub-wikis and flavors. For example, in Knowledge Base wiki I need both left and right column, with the Tree in the left side. On groupware flavor I need the Applications on the left side. I can make some panels order that I display for team's sub-wikis while I have another order for the main wiki, etc.
Thanks, Caty
On Mon, Jun 2, 2014 at 9:49 AM, [email protected] <[email protected]> wrote:
On 29 May 2014 at 11:23:01, Marius Dumitru Florea ( [email protected](mailto:[email protected])) wrote:
On Wed, May 28, 2014 at 4:18 PM, Guillaume "Louis-Marie" Delhumeau wrote:
Hi,
In Flamingo, we have created the concept of Application Bar, that we have implemented as a Panel: http://jira.xwiki.org/browse/XWIKI-10254
I propose to put the Application Bar by default on the left column.
Since we do not have a configuration system at the skin level, it would be present for both Colibri & Flamingo. I think it is not a problem because I have managed to make it look good for both (except for the size of
the
icons) : http://jira.xwiki.org/secure/attachment/27707/appbar.png
WDYT?
It doesn't look very well, and the Applications panel is redundant. I don't have a solution though. Need to think about it.
Note that Guillaume forgot to mention that the icons will be larger (see
http://design.xwiki.org/xwiki/bin/download/Improvements/Skin4x/homepageDeskt... ).
Right now they are the ones from the panel in medium width mode because Guillaume has implemented it yet.
@Guillaume: regarding icon colors, what would be your plan? Blue and white colors as on
http://design.xwiki.org/xwiki/bin/download/Improvements/Skin4x/homepageDeskt...
even for the Colibri skin or different coloring depending on the skin?
I also think that it might be best to not change Colibri since people are probably used to it for now. Now we need to find a way to have panels defined differently for each skin for that.
There are various solutions for this: * Solution 1: Add support for storing configuration (XWikiPreferences) in skin pages and modify the DefaultConfigurationSource to be profile > skin > space > wiki or possibly better: profile > space > wiki > skin * Solution 2: Refactor the UI configuration in the Admin UI by moving all UI-related configuration parameters in some UIConfig xobjects that depend on the selected skin (one xobject per skin). Make the skin selection the first item on the page and when you change it the rest of the UI configuration below reflects the content of the UIConfig page corresponding to that skin. This means introduction a UIConfigurationSource component impl but that’s easy to do. * Solution 3: Modify the leftpanels/rightpanels configuration properties from String to TextArea and allow scripting to be put inside. Then, by default, have some “if” to handle both Colibri and Flaming default panels. When the user uses the Panel Wizard the first time, the value will be overridden by the list of panels selected by the user. * Solution 4: In the DefaultSkin page, override leftpanels.vm/leftpanels.vm and check if the user has defined any panel preferences in XWikiPreferences. If so, then use them. If not, then compute the left and right panels default values.
There are obviously downsides to all these solutions...
Personally I think I prefer solution 1 with profile > space > wiki > skin, i.e. if the leftpanels/rightpanels xproperties are not defined at the profile, space, wiki levels (and by default we should leave it empty there) then the value is taken from the skin configuration component. We would need to define how the Panel Wizard works (we probably have an issue even now when the panels are defined in a user’s profile). It should probably be possible int he Panel Wizard UI to select what level is being configured (wiki, space, profile, skin). That’s the main issue for which we need a solution: that it is not too magical for the user when they go to the Panel Wizard. More generally speaking a we have an issue in the Admin UI. We should probably show the inferred values (real value used) and indicate the value for a given property at all levels (wiki, space, profile, skin) and allow users to easily change the value for the level they wish.
We need some more brainstorming about this. Any other ideas or variations?
Thanks -Vincent
Thanks, Guillaume
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
On Wed, Jun 4, 2014 at 2:31 PM, Ecaterina Moraru (Valica) <[email protected]> wrote:
Solution 5: Provide the styling differences only in Panels.Applications. Provide a ssx that with an IF handles both Colibri (we can consider the default styling to include Colibri) and Flamingo. This way we are not making the whole Panels app skin dependent, but only Panels.Applications. Depending on the skin, the panels can provide a different style. Initially, changing the skin to Flamingo, will have panels only on the right side (a big panels applications, after the other standard panels). It is in the duty of the Administrator to change the panels configuration and choose the default arrangement (he will have to manually put the Applications panel in the left area). So the order is default no matter the skin.
Solution 6: Just like we have multiple ColorThemes, we could provide something like a PanelsTheme (or something that stores the Panels order). This application would store everything from Administration-Page Elements-Panels section (Display, Width, List x 2 for left and right panels). This application is dependent of Panels app. When I want to customize the look of my wiki, I would go in Presentation, choose the skin, the colortheme and the panels order (choose Flamingo, choose a ColorTheme that matches better Flamingo and then I would choose FlamingoPanelsOrder). This solution is a good idea also for the customization of sub-wikis and flavors. For example, in Knowledge Base wiki I need both left and right column, with the Tree in the left side. On groupware flavor I need the Applications on the left side. I can make some panels order that I display for team's sub-wikis while I have another order for the main wiki, etc.
I like the Panels Theme idea. Thanks, Marius
Thanks, Caty
On Mon, Jun 2, 2014 at 9:49 AM, [email protected] <[email protected]> wrote:
On 29 May 2014 at 11:23:01, Marius Dumitru Florea ( [email protected](mailto:[email protected])) wrote:
On Wed, May 28, 2014 at 4:18 PM, Guillaume "Louis-Marie" Delhumeau wrote:
Hi,
In Flamingo, we have created the concept of Application Bar, that we have implemented as a Panel: http://jira.xwiki.org/browse/XWIKI-10254
I propose to put the Application Bar by default on the left column.
Since we do not have a configuration system at the skin level, it would be present for both Colibri & Flamingo. I think it is not a problem because I have managed to make it look good for both (except for the size of the icons) : http://jira.xwiki.org/secure/attachment/27707/appbar.png
WDYT?
It doesn't look very well, and the Applications panel is redundant. I don't have a solution though. Need to think about it.
Note that Guillaume forgot to mention that the icons will be larger (see http://design.xwiki.org/xwiki/bin/download/Improvements/Skin4x/homepageDeskt...). Right now they are the ones from the panel in medium width mode because Guillaume has implemented it yet.
@Guillaume: regarding icon colors, what would be your plan? Blue and white colors as on http://design.xwiki.org/xwiki/bin/download/Improvements/Skin4x/homepageDeskt... even for the Colibri skin or different coloring depending on the skin?
I also think that it might be best to not change Colibri since people are probably used to it for now. Now we need to find a way to have panels defined differently for each skin for that.
There are various solutions for this: * Solution 1: Add support for storing configuration (XWikiPreferences) in skin pages and modify the DefaultConfigurationSource to be profile > skin > space > wiki or possibly better: profile > space > wiki > skin * Solution 2: Refactor the UI configuration in the Admin UI by moving all UI-related configuration parameters in some UIConfig xobjects that depend on the selected skin (one xobject per skin). Make the skin selection the first item on the page and when you change it the rest of the UI configuration below reflects the content of the UIConfig page corresponding to that skin. This means introduction a UIConfigurationSource component impl but that’s easy to do. * Solution 3: Modify the leftpanels/rightpanels configuration properties from String to TextArea and allow scripting to be put inside. Then, by default, have some “if” to handle both Colibri and Flaming default panels. When the user uses the Panel Wizard the first time, the value will be overridden by the list of panels selected by the user. * Solution 4: In the DefaultSkin page, override leftpanels.vm/leftpanels.vm and check if the user has defined any panel preferences in XWikiPreferences. If so, then use them. If not, then compute the left and right panels default values.
There are obviously downsides to all these solutions...
Personally I think I prefer solution 1 with profile > space > wiki > skin, i.e. if the leftpanels/rightpanels xproperties are not defined at the profile, space, wiki levels (and by default we should leave it empty there) then the value is taken from the skin configuration component. We would need to define how the Panel Wizard works (we probably have an issue even now when the panels are defined in a user’s profile). It should probably be possible int he Panel Wizard UI to select what level is being configured (wiki, space, profile, skin). That’s the main issue for which we need a solution: that it is not too magical for the user when they go to the Panel Wizard. More generally speaking a we have an issue in the Admin UI. We should probably show the inferred values (real value used) and indicate the value for a given property at all levels (wiki, space, profile, skin) and allow users to easily change the value for the level they wish.
We need some more brainstorming about this. Any other ideas or variations?
Thanks -Vincent
Thanks, Guillaume
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
participants (5)
-
Denis Gervalle -
Ecaterina Moraru (Valica) -
Guillaume "Louis-Marie" Delhumeau -
Marius Dumitru Florea -
vincent＠massol.net