On Feb 19, 2012, at 10:35 PM, Sergiu Dumitriu wrote:

On 02/17/2012 08:13 AM, Vincent Massol wrote:

...

Hi devs,

I'd like to propose to add a new xwiki-platform-git module in xwiki-platform. This module will provide a simple Script Service to make it easy to perform Git actions on a git repository from which wiki pages.

+0.

It won't be included in the distribution by default, will it?

Correct, it won't be in the XE distribution.

Is it written in Groovy or Java? If in Groovy, do you plan to move the implementation to Java once it matures?

Java. Now I'd also like to propose bringing the GitHub Application I've coded over the weekend. I've documented it at http://extensions.xwiki.org/xwiki/bin/view/Extension/GitHub+Application I'm proposing: xwiki-platform-git/ |_ xwiki-platform-git-api/ <-- script service |_ xwiki-platform-github/ <-- application The application consists in 3 pages written in Groovy: * a Repository importer * a Committer importer * a macro to list committers and their associated stats My idea is to use this macro for our Hall Of Fame page. It also lists inactive committers which is nice and what we need. <groovy vs java> I've been wondering if they should be written in Java or not. The importers are pretty basic and small and I don't think they need Java. For the Macro it's less obvious. However writing it in Java would mean three things: * bringing the notion of RepositoryClass and CommitterClass to the java code * removing the nice shortcuts I've used in Groovy for writing scripts, such as: def memberOfClause = repoNames.collect { "'${it}' member of committer.repositories" }.join(" or ") * inability to tune the stats and the macro in general ATM I'm not entirely convinced rewriting in Java is the best thing to do, since users could want to tune it a lot (it's not a domain that's rigid and where there are no variations to the results you want). I'd suggest keeping it in Groovy for some time and see how it goes. </groovy vs java> Thanks -Vincent

...

I've already coded the script service and I've started documenting it on http://extensions.xwiki.org/xwiki/bin/view/Extension/Git+Module

The rationale for having it in platform: * I'm committing to maintain it * I'd like that we use it on xwiki.org to provide all sorts of stats for the XWiki development, for the new Home page/Community page and for having an always up to date Hall of Fame page: - http://newxwiki.xwiki.org/xwiki/bin/view/Main/WebHome - http://incubator.myxwiki.org/xwiki/bin/view/Improvements/XWikiOrgProposal2#H... - http://dev.xwiki.org/xwiki/bin/view/Community/HallOfFame

Here's my +1

-- Sergiu Dumitriu http://purl.org/net/sergiu/ _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs

+1 On Mon, Feb 20, 2012 at 8:40 AM, Vincent Massol <[email protected]> wrote:

On Feb 19, 2012, at 10:35 PM, Sergiu Dumitriu wrote:

...

On 02/17/2012 08:13 AM, Vincent Massol wrote:

...

Hi devs,

I'd like to propose to add a new xwiki-platform-git module in xwiki-platform. This module will provide a simple Script Service to make it easy to perform Git actions on a git repository from which wiki pages.

+0.

It won't be included in the distribution by default, will it?

Correct, it won't be in the XE distribution.

...

Is it written in Groovy or Java? If in Groovy, do you plan to move the implementation to Java once it matures?

Java.

Now I'd also like to propose bringing the GitHub Application I've coded over the weekend. I've documented it at http://extensions.xwiki.org/xwiki/bin/view/Extension/GitHub+Application

I'm proposing:

xwiki-platform-git/  |_ xwiki-platform-git-api/ <-- script service  |_ xwiki-platform-github/ <-- application

The application consists in 3 pages written in Groovy: * a Repository importer * a Committer importer * a macro to list committers and their associated stats

My idea is to use this macro for our Hall Of Fame page. It also lists inactive committers which is nice and what we need.

<groovy vs java> I've been wondering if they should be written in Java or not. The importers are pretty basic and small and I don't think they need Java.

For the Macro it's less obvious. However writing it in Java would mean three things: * bringing the notion of RepositoryClass and CommitterClass to the java code * removing the nice shortcuts I've used in Groovy for writing scripts, such as: def memberOfClause = repoNames.collect { "'${it}' member of committer.repositories" }.join(" or ") * inability to tune the stats and the macro in general

ATM I'm not entirely convinced rewriting in Java is the best thing to do, since users could want to tune it a lot (it's not a domain that's rigid and where there are no variations to the results you want).

I'd suggest keeping it in Groovy for some time and see how it goes. </groovy vs java>

Thanks -Vincent

...

...

I've already coded the script service and I've started documenting it on http://extensions.xwiki.org/xwiki/bin/view/Extension/Git+Module

The rationale for having it in platform: * I'm committing to maintain it * I'd like that we use it on xwiki.org to provide all sorts of stats for the XWiki development, for the new Home page/Community page and for having an always up to date Hall of Fame page: - http://newxwiki.xwiki.org/xwiki/bin/view/Main/WebHome - http://incubator.myxwiki.org/xwiki/bin/view/Improvements/XWikiOrgProposal2#H... - http://dev.xwiki.org/xwiki/bin/view/Community/HallOfFame

Here's my +1

-- Sergiu Dumitriu http://purl.org/net/sergiu/ _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs

_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs

-- Thomas Mortagne