[xwiki-devs] [VOTE] Add new XWiki APIs for searching attachments (ie without programming rights)
Hi, I'd like to apply Caleb's patch for http://jira.xwiki.org/jira/browse/XWIKI-4410 . This issue is a prereq to fix "AllDocs's attachment tab requires programming right to work" (http://jira.xwiki.org/jira/browse/XE-521). This means introducing the following new APIs: - public List<Attachment> searchAttachments(String parametrizedSqlClause, int nb, int start, List< ? > parameterValues) throws XWikiException - public List<Attachment> searchAttachments(String whereSql, int nb, int start) throws XWikiException - public List<Attachment> searchAttachments(String whereSql) throws XWikiException - public int countAttachments(String parametrizedSqlClause, List< ? > parameterValues) throws XWikiException - public int countAttachments(String whereSql) throws XWikiException Here's my +1 (even though it keeps making the class larger but I don't have any other idea for now without a huge refactoring) Thanks -Vincent
On 11/19/2009 09:52 PM, Vincent Massol wrote:
Hi,
I'd like to apply Caleb's patch for http://jira.xwiki.org/jira/browse/XWIKI-4410 . This issue is a prereq to fix "AllDocs's attachment tab requires programming right to work" (http://jira.xwiki.org/jira/browse/XE-521).
This means introducing the following new APIs:
- public List<Attachment> searchAttachments(String parametrizedSqlClause, int nb, int start, List< ?> parameterValues) throws XWikiException - public List<Attachment> searchAttachments(String whereSql, int nb, int start) throws XWikiException - public List<Attachment> searchAttachments(String whereSql) throws XWikiException - public int countAttachments(String parametrizedSqlClause, List< ?> parameterValues) throws XWikiException - public int countAttachments(String whereSql) throws XWikiException
Here's my +1 (even though it keeps making the class larger but I don't have any other idea for now without a huge refactoring)
I'd rather use the query manager component, which would need to be made accessible from Velocity. -- Sergiu Dumitriu http://purl.org/net/sergiu/
Hi,
Here's my +1 (even though it keeps making the class larger but I don't have any other idea for now without a huge refactoring)
I'd rather use the query manager component, which would need to be made accessible from Velocity.
I also think this is the right approach. - Asiri
-- Sergiu Dumitriu http://purl.org/net/sergiu/ _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
On 11/19/09 9:52 PM, Vincent Massol wrote:
Hi,
I'd like to apply Caleb's patch for http://jira.xwiki.org/jira/browse/XWIKI-4410 . This issue is a prereq to fix "AllDocs's attachment tab requires programming right to work" (http://jira.xwiki.org/jira/browse/XE-521).
This means introducing the following new APIs:
- public List<Attachment> searchAttachments(String parametrizedSqlClause, int nb, int start, List< ?> parameterValues) throws XWikiException - public List<Attachment> searchAttachments(String whereSql, int nb, int start) throws XWikiException - public List<Attachment> searchAttachments(String whereSql) throws XWikiException - public int countAttachments(String parametrizedSqlClause, List< ?> parameterValues) throws XWikiException - public int countAttachments(String whereSql) throws XWikiException
Here's my +1 (even though it keeps making the class larger but I don't have any other idea for now without a huge refactoring)
+1 Jerome
Thanks -Vincent
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
participants (4)
-
Asiri Rathnayake -
Jerome Velociter -
Sergiu Dumitriu -
Vincent Massol