[xwiki-devs] [VOTE] Move component related events to their own project
Hi devs, For http://jira.xwiki.org/jira/browse/XWIKI-5490 I need to make ObservationManager itself listen to ComponentDescriptorAddedEvent events. There is two issue here: - currently ComponentDescriptorAddedEvent is in the same project than the component manager implemenation which is pretty much the same thing as behing internal since there is no reason to force to depends on a specific implementation of component manager just to listen on some generic events that has nothing to do with it - i can move them to component-api because that would produce a circular dependency with observation project which depends on component-api So the only technical solution I can see is to create a new project with theses events. I propose to name it xwiki-core-component-observation and to move ComponentEventManager from component-api to it too. Note: i took ObservationManager here because it's a core one but a lot of other components will probably have the exact same need to support properly installed/uninstalled extensions WDYT ? -- Thomas Mortagne
On Tue, Sep 14, 2010 at 16:47, Thomas Mortagne <[email protected]> wrote:
Hi devs,
For http://jira.xwiki.org/jira/browse/XWIKI-5490 I need to make ObservationManager itself listen to ComponentDescriptorAddedEvent events. There is two issue here: - currently ComponentDescriptorAddedEvent is in the same project than the component manager implemenation which is pretty much the same thing as behing internal since there is no reason to force to depends on a specific implementation of component manager just to listen on some generic events that has nothing to do with it - i can move them to component-api because that would produce a circular dependency with observation project which depends on component-api
So the only technical solution I can see is to create a new project with theses events.
I propose to name it xwiki-core-component-observation and to move ComponentEventManager from component-api to it too.
I was a bit too quick on that, forget about ComponentEventManager.
Note: i took ObservationManager here because it's a core one but a lot of other components will probably have the exact same need to support properly installed/uninstalled extensions
WDYT ? -- Thomas Mortagne
-- Thomas Mortagne
+0 Thanks, Marius On 09/14/2010 05:47 PM, Thomas Mortagne wrote:
Hi devs,
For http://jira.xwiki.org/jira/browse/XWIKI-5490 I need to make ObservationManager itself listen to ComponentDescriptorAddedEvent events. There is two issue here: - currently ComponentDescriptorAddedEvent is in the same project than the component manager implemenation which is pretty much the same thing as behing internal since there is no reason to force to depends on a specific implementation of component manager just to listen on some generic events that has nothing to do with it - i can move them to component-api because that would produce a circular dependency with observation project which depends on component-api
So the only technical solution I can see is to create a new project with theses events.
I propose to name it xwiki-core-component-observation and to move ComponentEventManager from component-api to it too.
Note: i took ObservationManager here because it's a core one but a lot of other components will probably have the exact same need to support properly installed/uninstalled extensions
WDYT ?
+1 IMO "it's the worst option, except for all the others." Caleb Thomas Mortagne wrote:
Hi devs,
For http://jira.xwiki.org/jira/browse/XWIKI-5490 I need to make ObservationManager itself listen to ComponentDescriptorAddedEvent events. There is two issue here: - currently ComponentDescriptorAddedEvent is in the same project than the component manager implemenation which is pretty much the same thing as behing internal since there is no reason to force to depends on a specific implementation of component manager just to listen on some generic events that has nothing to do with it - i can move them to component-api because that would produce a circular dependency with observation project which depends on component-api
So the only technical solution I can see is to create a new project with theses events.
I propose to name it xwiki-core-component-observation and to move ComponentEventManager from component-api to it too.
Note: i took ObservationManager here because it's a core one but a lot of other components will probably have the exact same need to support properly installed/uninstalled extensions
WDYT ?
+1 Alex On 09/14/2010 04:47 PM, Thomas Mortagne wrote:
Hi devs,
For http://jira.xwiki.org/jira/browse/XWIKI-5490 I need to make ObservationManager itself listen to ComponentDescriptorAddedEvent events. There is two issue here: - currently ComponentDescriptorAddedEvent is in the same project than the component manager implemenation which is pretty much the same thing as behing internal since there is no reason to force to depends on a specific implementation of component manager just to listen on some generic events that has nothing to do with it - i can move them to component-api because that would produce a circular dependency with observation project which depends on component-api
So the only technical solution I can see is to create a new project with theses events.
I propose to name it xwiki-core-component-observation and to move ComponentEventManager from component-api to it too.
Note: i took ObservationManager here because it's a core one but a lot of other components will probably have the exact same need to support properly installed/uninstalled extensions
WDYT ?
participants (4)
-
Alex Busenius -
Caleb James DeLisle -
Marius Dumitru Florea -
Thomas Mortagne