[xwiki-devs] WYSIWYG editor in trunk
Hi Marius, Just to let you know that it seems the editor you've committed on last Friday doesn't use an updated version of the XWiki syntax and is thus out of sync with the renderer. For example: * Bold is **bold**, not *bold* * Macros use 2 curly braces * etc We need to fix this ASAP since otherwise it won't work and we need to release a working version for 1.6M1 (not everything should work but easy stuff like this should work). Thanks -Vincent
Also I see you have a custom StringInputStream. What's the need vs using a ByteArrayInputStream (http://java.sun.com/j2se/1.4.2/docs/api/java/io/ByteArrayInputStream.html)? Thanks -Vincent On Aug 23, 2008, at 4:33 PM, Vincent Massol wrote:
Hi Marius,
Just to let you know that it seems the editor you've committed on last Friday doesn't use an updated version of the XWiki syntax and is thus out of sync with the renderer. For example: * Bold is **bold**, not *bold* * Macros use 2 curly braces * etc
We need to fix this ASAP since otherwise it won't work and we need to release a working version for 1.6M1 (not everything should work but easy stuff like this should work).
Thanks -Vincent
Another comment: There's now a XHTML cleaner interface and a first implementation located in xwiki-xml. Could you please refactor the wysiwyg module to use it so that we have only 1 cleaner? Also I don't think we need 2 cleaner implementations (jtidy + htmlcleaner). Let us know what's missing so that we can add to it. The office GSOc project is also starting to use it and it's going to add some cleaning rules real soon so we should all work on it and make it the official xwiki XHTML cleaner. Thanks -Vincent On Aug 23, 2008, at 4:35 PM, Vincent Massol wrote:
Also I see you have a custom StringInputStream. What's the need vs using a ByteArrayInputStream (http://java.sun.com/j2se/1.4.2/docs/api/java/io/ByteArrayInputStream.html)?
Thanks -Vincent
On Aug 23, 2008, at 4:33 PM, Vincent Massol wrote:
Hi Marius,
Just to let you know that it seems the editor you've committed on last Friday doesn't use an updated version of the XWiki syntax and is thus out of sync with the renderer. For example: * Bold is **bold**, not *bold* * Macros use 2 curly braces * etc
We need to fix this ASAP since otherwise it won't work and we need to release a working version for 1.6M1 (not everything should work but easy stuff like this should work).
Thanks -Vincent
Another comment:
There's now a XHTML cleaner interface and a first implementation located in xwiki-xml. Could you please refactor the wysiwyg module to use it so that we have only 1 cleaner? Also I don't think we need 2 cleaner implementations (jtidy + htmlcleaner).
Monday morning I'll do the refactoring and I'll drop JTidy.
Let us know what's missing so that we can add to it. The office GSOc project is also starting to use it and it's going to add some cleaning rules real soon so we should all work on it and make it the official xwiki XHTML cleaner.
Thanks -Vincent
On Aug 23, 2008, at 4:35 PM, Vincent Massol wrote:
Also I see you have a custom StringInputStream. What's the need vs using a ByteArrayInputStream (http://java.sun.com/j2se/1.4.2/docs/api/java/io/ByteArrayInputStream.html)?
Thanks -Vincent
On Aug 23, 2008, at 4:33 PM, Vincent Massol wrote:
Hi Marius,
Just to let you know that it seems the editor you've committed on last Friday doesn't use an updated version of the XWiki syntax and is thus out of sync with the renderer. For example: * Bold is **bold**, not *bold* * Macros use 2 curly braces * etc
We need to fix this ASAP since otherwise it won't work and we need to release a working version for 1.6M1 (not everything should work but easy stuff like this should work).
Thanks -Vincent
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
Also I see you have a custom StringInputStream. What's the need vs using a ByteArrayInputStream (http://java.sun.com/j2se/1.4.2/docs/api/java/io/ByteArrayInputStream.html)?
That's not my code. Ludovic? It is used by the Radeox-based XHTMLConverter. Since we're going to drop radeox, I had no incentive for refactoring and cleaning that code. I kept it only to have a B-plan when the new rendering didn't worked.
Thanks -Vincent
On Aug 23, 2008, at 4:33 PM, Vincent Massol wrote:
Hi Marius,
Just to let you know that it seems the editor you've committed on last Friday doesn't use an updated version of the XWiki syntax and is thus out of sync with the renderer. For example: * Bold is **bold**, not *bold* * Macros use 2 curly braces * etc
We need to fix this ASAP since otherwise it won't work and we need to release a working version for 1.6M1 (not everything should work but easy stuff like this should work).
Thanks -Vincent
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
Hi Marius,
Just to let you know that it seems the editor you've committed on last Friday doesn't use an updated version of the XWiki syntax and is thus out of sync with the renderer. For example:
The WYSIWYG editor doesn't use internally the XWiki syntax. It has HTML as input and outputs also HTML. The conversion to and from XWiki syntax is done here: http://tinyurl.com/5mwjq6 . So as long as xwiki-core-rendering-1.6*.jar is in the class path it must be the latest version of the renderer that it is used to make the conversion. If you look at XWikiXHTMLConverter#fromXHTML method, the XWiki syntax is not specified. I suspect it gets defaulted to version 1.0.
* Bold is **bold**, not *bold* * Macros use 2 curly braces * etc
We need to fix this ASAP since otherwise it won't work and we need to release a working version for 1.6M1 (not everything should work but easy stuff like this should work).
Thanks -Vincent
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
On Aug 23, 2008, at 8:53 PM, Marius Dumitru Florea wrote:
Hi Marius,
Just to let you know that it seems the editor you've committed on last Friday doesn't use an updated version of the XWiki syntax and is thus out of sync with the renderer. For example:
The WYSIWYG editor doesn't use internally the XWiki syntax. It has HTML as input and outputs also HTML. The conversion to and from XWiki syntax is done here: http://tinyurl.com/5mwjq6 . So as long as xwiki-core-rendering-1.6*.jar is in the class path it must be the latest version of the renderer that it is used to make the conversion.
Ok then it means I was looking at code that uses the old rendering I guess. Should we keep this code? Or did we all agree to drop it and focus on the new rendering only? (I think that's what we agreed on). If that's the case then we should clean the code and remove the support for the old renderer I guess. WDYT? Thanks -Vincent
If you look at XWikiXHTMLConverter#fromXHTML method, the XWiki syntax is not specified. I suspect it gets defaulted to version 1.0.
* Bold is **bold**, not *bold* * Macros use 2 curly braces * etc
We need to fix this ASAP since otherwise it won't work and we need to release a working version for 1.6M1 (not everything should work but easy stuff like this should work).
Thanks -Vincent
On Aug 23, 2008, at 8:53 PM, Marius Dumitru Florea wrote:
Hi Marius,
Just to let you know that it seems the editor you've committed on last Friday doesn't use an updated version of the XWiki syntax and is thus out of sync with the renderer. For example:
The WYSIWYG editor doesn't use internally the XWiki syntax. It has HTML as input and outputs also HTML. The conversion to and from XWiki syntax is done here: http://tinyurl.com/5mwjq6 . So as long as xwiki-core-rendering-1.6*.jar is in the class path it must be the latest version of the renderer that it is used to make the conversion.
Ok then it means I was looking at code that uses the old rendering I guess. Should we keep this code? Or did we all agree to drop it and focus on the new rendering only? (I think that's what we agreed on).
If that's the case then we should clean the code and remove the support for the old renderer I guess.
WDYT?
Right. Monday morning the Radeox-based XHTMLConverter will be dropped. I will also refactor my XxxImpl classes to DefaultXxx to meet the naming conventions. Thanks, Marius
Thanks -Vincent
If you look at XWikiXHTMLConverter#fromXHTML method, the XWiki syntax is not specified. I suspect it gets defaulted to version 1.0.
* Bold is **bold**, not *bold* * Macros use 2 curly braces * etc
We need to fix this ASAP since otherwise it won't work and we need to release a working version for 1.6M1 (not everything should work but easy stuff like this should work).
Thanks -Vincent
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
On Aug 24, 2008, at 1:11 AM, Marius Dumitru Florea wrote:
On Aug 23, 2008, at 8:53 PM, Marius Dumitru Florea wrote:
Hi Marius,
Just to let you know that it seems the editor you've committed on last Friday doesn't use an updated version of the XWiki syntax and is thus out of sync with the renderer. For example:
The WYSIWYG editor doesn't use internally the XWiki syntax. It has HTML as input and outputs also HTML. The conversion to and from XWiki syntax is done here: http://tinyurl.com/5mwjq6 . So as long as xwiki-core-rendering-1.6*.jar is in the class path it must be the latest version of the renderer that it is used to make the conversion.
Ok then it means I was looking at code that uses the old rendering I guess. Should we keep this code? Or did we all agree to drop it and focus on the new rendering only? (I think that's what we agreed on).
If that's the case then we should clean the code and remove the support for the old renderer I guess.
WDYT?
Right. Monday morning the Radeox-based XHTMLConverter will be dropped. I will also refactor my XxxImpl classes to DefaultXxx to meet the naming conventions.
BTW the build is not working for me after your commit of Friday. It works if you build only the wysiwyg module but it doesn't work when you build the whole platform for some reason. Haven't found why yet. Thanks -Vincent
If you look at XWikiXHTMLConverter#fromXHTML method, the XWiki syntax is not specified. I suspect it gets defaulted to version 1.0.
* Bold is **bold**, not *bold* * Macros use 2 curly braces * etc
We need to fix this ASAP since otherwise it won't work and we need to release a working version for 1.6M1 (not everything should work but easy stuff like this should work).
Thanks -Vincent
participants (2)
-
Marius Dumitru Florea -
Vincent Massol