[xwiki-devs] Removing Ratings app dependency from XAForum app ?
Hi, I'm working on "XAForum application" ( github.com/xwiki-contrib/application-forum2<https://github.com/xwiki-contrib/application-forum2m2>) and I found some issues due to "Ratings application" ( github.com/xwiki-contrib/application-ratings) dependency, examples : - Rating stars are displayed on every page (maybe the admin who installed the application doesn't expect or want this behavior. It has already been reported as an issue too :jira.xwiki.org/browse/XAFORUM-26) - XAForum app vote and ratings app vote use the same object (same XClasse) which may lead to a wrong result. XAForum vote expects only +1 (== means I like) on a topic, however Rating app vote expects 1 to 5 (5 stars) on a page, which means if a user rate a topic page +5, this means too, there are 5 other users like this topic, which is wrong !! To avoid these issues, I think we need to remove the ratings app dependency from XAForum app and implement a specific vote for this (XAForum) app. WDYT ? Thanks, Sofiane Baloul
Hi, Ratings dependency inside the Forum application is not nicely done and I agree that it adds a level of complexity not needed by the Forum app, so I'm +1 for this removal. Not sure how much more time it would take from a development point of view, but instead of having a Forum specific vote class, how about creating a generic -1/0/+1 vote mechanism, instead of Rating's 5 step mechanism. This kind of voting -1/0/+1 could be used by Forum app, Ideas app (has a pro/contra feature), any application that could want maybe a Facebook 'Like' mechanism or other applications that requires a simple voting system. It could be called Vote application, using VoteClass, etc. Thanks, Caty On Wed, Mar 19, 2014 at 1:01 PM, Sofiane Baloul <[email protected]>wrote:
Hi,
I'm working on "XAForum application" ( github.com/xwiki-contrib/application-forum2< https://github.com/xwiki-contrib/application-forum2m2>) and I found some issues due to "Ratings application" ( github.com/xwiki-contrib/application-ratings) dependency, examples : - Rating stars are displayed on every page (maybe the admin who installed the application doesn't expect or want this behavior. It has already been reported as an issue too :jira.xwiki.org/browse/XAFORUM-26) - XAForum app vote and ratings app vote use the same object (same XClasse) which may lead to a wrong result. XAForum vote expects only +1 (== means I like) on a topic, however Rating app vote expects 1 to 5 (5 stars) on a page, which means if a user rate a topic page +5, this means too, there are 5 other users like this topic, which is wrong !!
To avoid these issues, I think we need to remove the ratings app dependency from XAForum app and implement a specific vote for this (XAForum) app.
WDYT ?
Thanks, Sofiane Baloul _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
Quick note: changing the class will break all existing forum so some kind of migration would be nice. On Thu, Mar 20, 2014 at 9:41 AM, Ecaterina Moraru (Valica) <[email protected]> wrote:
Hi,
Ratings dependency inside the Forum application is not nicely done and I agree that it adds a level of complexity not needed by the Forum app, so I'm +1 for this removal.
Not sure how much more time it would take from a development point of view, but instead of having a Forum specific vote class, how about creating a generic -1/0/+1 vote mechanism, instead of Rating's 5 step mechanism.
This kind of voting -1/0/+1 could be used by Forum app, Ideas app (has a pro/contra feature), any application that could want maybe a Facebook 'Like' mechanism or other applications that requires a simple voting system.
It could be called Vote application, using VoteClass, etc.
Thanks, Caty
On Wed, Mar 19, 2014 at 1:01 PM, Sofiane Baloul <[email protected]>wrote:
Hi,
I'm working on "XAForum application" ( github.com/xwiki-contrib/application-forum2< https://github.com/xwiki-contrib/application-forum2m2>) and I found some issues due to "Ratings application" ( github.com/xwiki-contrib/application-ratings) dependency, examples : - Rating stars are displayed on every page (maybe the admin who installed the application doesn't expect or want this behavior. It has already been reported as an issue too :jira.xwiki.org/browse/XAFORUM-26) - XAForum app vote and ratings app vote use the same object (same XClasse) which may lead to a wrong result. XAForum vote expects only +1 (== means I like) on a topic, however Rating app vote expects 1 to 5 (5 stars) on a page, which means if a user rate a topic page +5, this means too, there are 5 other users like this topic, which is wrong !!
To avoid these issues, I think we need to remove the ratings app dependency from XAForum app and implement a specific vote for this (XAForum) app.
WDYT ?
Thanks, Sofiane Baloul _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
Hi, 2014-03-20 9:41 GMT+01:00 Ecaterina Moraru (Valica) <[email protected]>:
Hi,
Ratings dependency inside the Forum application is not nicely done and I agree that it adds a level of complexity not needed by the Forum app, so I'm +1 for this removal.
Not sure how much more time it would take from a development point of view, but instead of having a Forum specific vote class, how about creating a generic -1/0/+1 vote mechanism, instead of Rating's 5 step mechanism.
This kind of voting -1/0/+1 could be used by Forum app, Ideas app (has a pro/contra feature), any application that could want maybe a Facebook 'Like' mechanism or other applications that requires a simple voting system.
It could be called Vote application, using VoteClass, etc.
Maybe an alternative could be to implement another upper-level class for the existing Ratings, that would allow to instanciate ratings features in different parts of the wiki. For example you could create new objects (a bit like when you create new Blogs) with: - Ratings mode (facebook-like, or [1-5] stars, ...) - Scope (global wiki, specific sub-wiki, specific space, specific page, ...) - Rating Id (to differentiate when defined ratings overlap on same pages) - Show in UI (true/false) - ... Obviously many issues can come to mind with this, but some features may be interesting even for existing ratings app (like, limiting the scope).
Thanks, Caty
On Wed, Mar 19, 2014 at 1:01 PM, Sofiane Baloul <[email protected]
wrote:
Hi,
I'm working on "XAForum application" ( github.com/xwiki-contrib/application-forum2< https://github.com/xwiki-contrib/application-forum2m2>) and I found some issues due to "Ratings application" ( github.com/xwiki-contrib/application-ratings) dependency, examples : - Rating stars are displayed on every page (maybe the admin who installed the application doesn't expect or want this behavior. It has already been reported as an issue too :jira.xwiki.org/browse/XAFORUM-26) - XAForum app vote and ratings app vote use the same object (same XClasse) which may lead to a wrong result. XAForum vote expects only +1 (== means I like) on a topic, however Rating app vote expects 1 to 5 (5 stars) on a page, which means if a user rate a topic page +5, this means too, there are 5 other users like this topic, which is wrong !!
To avoid these issues, I think we need to remove the ratings app dependency from XAForum app and implement a specific vote for this (XAForum) app.
WDYT ?
Thanks, Sofiane Baloul _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
participants (4)
-
Ecaterina Moraru (Valica) -
Jeremie BOUSQUET -
Sofiane Baloul -
Thomas Mortagne