[xwiki-devs] debugging sheets applications
Hello fellow developers, we have met a fairly hard bug on www.curriki.org which has almost delayed our release and required a last minute removal of our new discussions feature: the trigger of the sheet application has not been consistent. It has been inconsistent between servers (development, staging, production) and has been inconsistent between syntaxes. For a while I thought that the lack of the class XWiki.ClassSheetBinding was guilty, but adding it did not change anything. I then went through the XWiki core pages and added as much as possible that could have something related… then it started to work on pages in old syntax but failed with newly created pages (which are copies of a template page). Where could I look to debug this? There seems to be *something* applied, since the rendered page is empty and the content is ignored. Thanks for hints. Paul PS: we're now running xwiki 3.5.1
Hi Paul, Have you read http://extensions.xwiki.org/xwiki/bin/view/Extension/Sheet+Module ? Hope this helps, Marius On Thu, Jan 16, 2014 at 6:43 PM, Paul Libbrecht <[email protected]> wrote:
Hello fellow developers,
we have met a fairly hard bug on www.curriki.org which has almost delayed our release and required a last minute removal of our new discussions feature: the trigger of the sheet application has not been consistent. It has been inconsistent between servers (development, staging, production) and has been inconsistent between syntaxes.
For a while I thought that the lack of the class XWiki.ClassSheetBinding was guilty, but adding it did not change anything. I then went through the XWiki core pages and added as much as possible that could have something related… then it started to work on pages in old syntax but failed with newly created pages (which are copies of a template page).
Where could I look to debug this? There seems to be *something* applied, since the rendered page is empty and the content is ignored.
Thanks for hints.
Paul
PS: we're now running xwiki 3.5.1 _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
Le 17 janv. 2014 à 10:17, Marius Dumitru Florea <[email protected]> a écrit :
Have you read http://extensions.xwiki.org/xwiki/bin/view/Extension/Sheet+Module ?
Hello Marius, I have done so, at least five times and it's been steadily open in my browsers since a few days. To respond in more details to the features presented there, I tried to detail my case (the usage of ConversationCode.ForumClass) which I had observed to use "marker classes", i.e. classes which do not have a property. In particular, I attributed to my old xwiki 3.5 the lack of "sheet" property in my XWiki.ClassSheetBinding objects on the ForumClass, assuming the naming conventions were, instead, leveraged (ForumClass would use ForumSheet). After a while I realized that the reason of these classes to appear as marker classes is that they were missing! ClassSheetBinding was an object, but an object of a non-existing class. I noticed it when opening the "add an object" pop-up menu… Having imported the right ClassSheetBinding and re-imported ConversionCode.ForumClass, things starting to work smoothly. Rationale: - don't trust marker classes (maybe they don't exist?). - wish that the object editor indicates it, when an object is presented whose class is missing, maybe also when the class-editor is used for the first time on a given page. thanks! paul
On Thu, Jan 16, 2014 at 6:43 PM, Paul Libbrecht <[email protected]> wrote:
Hello fellow developers,
we have met a fairly hard bug on www.curriki.org which has almost delayed our release and required a last minute removal of our new discussions feature: the trigger of the sheet application has not been consistent. It has been inconsistent between servers (development, staging, production) and has been inconsistent between syntaxes.
For a while I thought that the lack of the class XWiki.ClassSheetBinding was guilty, but adding it did not change anything. I then went through the XWiki core pages and added as much as possible that could have something related… then it started to work on pages in old syntax but failed with newly created pages (which are copies of a template page).
Where could I look to debug this? There seems to be *something* applied, since the rendered page is empty and the content is ignored.
Thanks for hints.
Paul
PS: we're now running xwiki 3.5.1 _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
On Jan 19, 2014 3:47 PM, "Paul Libbrecht" <[email protected]> wrote:
Le 17 janv. 2014 à 10:17, Marius Dumitru Florea <
[email protected]> a écrit :
Have you read http://extensions.xwiki.org/xwiki/bin/view/Extension/Sheet+Module ?
Hello Marius,
I have done so, at least five times and it's been steadily open in my browsers since a few days.
To respond in more details to the features presented there, I tried to detail my case (the usage of ConversationCode.ForumClass) which I had observed to use "marker classes", i.e. classes which do not have a property. In particular, I attributed to my old xwiki 3.5 the lack of "sheet" property in my XWiki.ClassSheetBinding objects on the ForumClass, assuming the naming conventions were, instead, leveraged (ForumClass would use ForumSheet). After a while I realized that the reason of these classes to appear as marker classes is that they were missing! ClassSheetBinding was an object, but an object of a non-existing class. I noticed it when opening the "add an object" pop-up menu… Having imported the right ClassSheetBinding and re-imported ConversionCode.ForumClass, things starting to work smoothly.
Rationale:
- don't trust marker classes (maybe they don't exist?).
They don't exist. You cannot create an XClass with no properties.
- wish that the object editor indicates it, when an object is presented whose class is missing
I agree. The object editor just shows them as deprecated I think, because it doesn't find them in the class as the class is an empty document as return by $xwiki.getDocument() when a document doesn't exist.
, maybe also when the class-editor is used for the first time on a given page.
thanks!
paul
On Thu, Jan 16, 2014 at 6:43 PM, Paul Libbrecht <[email protected]>
wrote:
Hello fellow developers,
we have met a fairly hard bug on www.curriki.org which has almost delayed our release and required a last minute removal of our new discussions feature: the trigger of the sheet application has not been consistent. It has been inconsistent between servers (development, staging, production) and has been inconsistent between syntaxes.
For a while I thought that the lack of the class XWiki.ClassSheetBinding was guilty, but adding it did not change anything. I then went through the XWiki core pages and added as much as possible that could have something related… then it started to work on pages in old syntax but failed with newly created pages (which are copies of a template page).
Where could I look to debug this? There seems to be *something* applied, since the rendered page is empty and the content is ignored.
Thanks for hints.
Paul
PS: we're now running xwiki 3.5.1 _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
that means that the class editor should really show a warning about the class not existing yet when I have used /xwiki/bin/edit/XWiki/ClassSheetBinding?editor=class shall I open an issue? paul Le 20 janv. 2014 à 00:01, Marius Dumitru Florea <[email protected]> a écrit :
Rationale:
- don't trust marker classes (maybe they don't exist?).
They don't exist. You cannot create an XClass with no properties.
- wish that the object editor indicates it, when an object is presented whose class is missing
I agree. The object editor just shows them as deprecated I think, because it doesn't find them in the class as the class is an empty document as return by $xwiki.getDocument() when a document doesn't exist.
, maybe also when the class-editor is used for the first time on a given page.
Yes please. I don't think a "warning" is best, but more like an informative helpful message, something along the lines of: this class doesn't have any properties yet, you can add some below, property names should follow the following rules, you can set a user friendly name afterwards, and until you add some properties, this isn't really a class which you can use. This acts both as a warning and short inline documentation. On 01/19/2014 06:17 PM, Paul Libbrecht wrote:
that means that the class editor should really show a warning about the class not existing yet when I have used
/xwiki/bin/edit/XWiki/ClassSheetBinding?editor=class
shall I open an issue?
paul
Le 20 janv. 2014 à 00:01, Marius Dumitru Florea <[email protected]> a écrit :
Rationale:
- don't trust marker classes (maybe they don't exist?).
They don't exist. You cannot create an XClass with no properties.
- wish that the object editor indicates it, when an object is presented whose class is missing
I agree. The object editor just shows them as deprecated I think, because it doesn't find them in the class as the class is an empty document as return by $xwiki.getDocument() when a document doesn't exist.
, maybe also when the class-editor is used for the first time on a given page.
-- Sergiu Dumitriu http://purl.org/net/sergiu
participants (3)
-
Marius Dumitru Florea -
Paul Libbrecht -
Sergiu Dumitriu