On Jan 6, 2009, at 5:05 PM, jvdrean (SVN) wrote:

Author: jvdrean Date: 2009-01-06 17:05:57 +0100 (Tue, 06 Jan 2009) New Revision: 15098

Modified: platform/web/branches/xwiki-web-1.7/wysiwyg/src/main/java/com/xpn/ xwiki/wysiwyg/client/plugin/table/TablePlugin.java Log: XWIKI-3068 : Builtin firefox table features (add row, add col) messes up tables in the WYSIWYG

Fixed by disabling builtin firefox table features. Merged from trunk.

Modified: platform/web/branches/xwiki-web-1.7/wysiwyg/src/main/java/ com/xpn/xwiki/wysiwyg/client/plugin/table/TablePlugin.java =================================================================== --- platform/web/branches/xwiki-web-1.7/wysiwyg/src/main/java/com/ xpn/xwiki/wysiwyg/client/plugin/table/TablePlugin.java 2009-01-06 16:02:23 UTC (rev 15097) +++ platform/web/branches/xwiki-web-1.7/wysiwyg/src/main/java/com/ xpn/xwiki/wysiwyg/client/plugin/table/TablePlugin.java 2009-01-06 16:05:57 UTC (rev 15098) @@ -85,6 +85,10 @@ addFeature(rta, new InsertColAfter(this)); addFeature(rta, new DeleteCol(this)); addFeature(rta, new DeleteTable(this)); + + // Disable the standard table editing features of Firefox. + // See XWIKI-3068 for more info.

I don't think we should put JIRA references in our code and not for describing a solution. Rationale: we can move to another issue tracker in the future, the issue can be moved/deleted/replace, etc. It's better to have all the information in the source file IMO.

+ rta.getDocument().execCommand("enableInlineTableEditing", "false");

getUIExtensionList().add(toolBarExtension); }

Thanks -Vincent http://xwiki.com http://massol.net http://xwiki.org