[xwiki-devs] Removing viewheader.vm?
Hi, I think viewheader.vm is not used anymore. I couldn't find any reference of it in other vm nor in skins. However it's still referenced from XWiki.java, in getSkinClass() (and from ApplicationResources*.properties files): needsUpdate |= bclass.addTemplateField("viewheader.vm", "View Header"); But I think this field is now not only useless but even misleading since filling it will have no effect AFAIK. Could someone confirm this? Does it mean people with custom skin will find their skin not working anymore? Anyone knows when viewheader.vm was stopped to be used because AFAICS this will break all existing custom skins? What new properties should we add t o the XWikiSkins class? Thanks -Vincent
On 02/09/2010 11:08 AM, Vincent Massol wrote:
Hi,
I think viewheader.vm is not used anymore. I couldn't find any reference of it in other vm nor in skins.
However it's still referenced from XWiki.java, in getSkinClass() (and from ApplicationResources*.properties files):
needsUpdate |= bclass.addTemplateField("viewheader.vm", "View Header");
But I think this field is now not only useless but even misleading since filling it will have no effect AFAIK.
Could someone confirm this? Does it mean people with custom skin will find their skin not working anymore?
Anyone knows when viewheader.vm was stopped to be used because AFAICS this will break all existing custom skins?
I think Dodo was the last (and only) skin that used it.
What new properties should we add to the XWikiSkins class?
None. Personally I'd like to completely refactor the skin class, so that it only contains a name, a description, a parent skin, and a filesystem directory name. Everything else should be either in its own object (a generic SkinResource with 'name' and 'content'), or as an attachment. Currently I prefer to work with attachments, that I can access via WebDAV and edit in the system editor. -- Sergiu Dumitriu http://purl.org/net/sergiu/
Sergiu Dumitriu wrote:
On 02/09/2010 11:08 AM, Vincent Massol wrote:
Hi,
I think viewheader.vm is not used anymore. I couldn't find any reference of it in other vm nor in skins.
However it's still referenced from XWiki.java, in getSkinClass() (and from ApplicationResources*.properties files):
needsUpdate |= bclass.addTemplateField("viewheader.vm", "View Header");
But I think this field is now not only useless but even misleading since filling it will have no effect AFAIK.
Could someone confirm this? Does it mean people with custom skin will find their skin not working anymore?
Anyone knows when viewheader.vm was stopped to be used because AFAICS this will break all existing custom skins?
I think Dodo was the last (and only) skin that used it.
What new properties should we add to the XWikiSkins class?
None. Personally I'd like to completely refactor the skin class, so that it only contains a name, a description, a parent skin, and a filesystem directory name. Everything else should be either in its own object (a generic SkinResource with 'name' and 'content'), or as an attachment.
Currently I prefer to work with attachments, that I can access via WebDAV and edit in the system editor.
What about templates with underscore in their names (e.g. textarea_wysiwyg.vm)? I recently tried to overwrite such a template by attaching a modified version to the skin page but the underscore was removed from the attachment's name.. Thanks, Marius
On 02/09/2010 03:51 PM, Marius Dumitru Florea wrote:
Sergiu Dumitriu wrote:
On 02/09/2010 11:08 AM, Vincent Massol wrote:
Hi,
I think viewheader.vm is not used anymore. I couldn't find any reference of it in other vm nor in skins.
However it's still referenced from XWiki.java, in getSkinClass() (and from ApplicationResources*.properties files):
needsUpdate |= bclass.addTemplateField("viewheader.vm", "View Header");
But I think this field is now not only useless but even misleading since filling it will have no effect AFAIK.
Could someone confirm this? Does it mean people with custom skin will find their skin not working anymore?
Anyone knows when viewheader.vm was stopped to be used because AFAICS this will break all existing custom skins?
I think Dodo was the last (and only) skin that used it.
What new properties should we add to the XWikiSkins class?
None. Personally I'd like to completely refactor the skin class, so that it only contains a name, a description, a parent skin, and a filesystem directory name. Everything else should be either in its own object (a generic SkinResource with 'name' and 'content'), or as an attachment.
Currently I prefer to work with attachments, that I can access via WebDAV and edit in the system editor.
What about templates with underscore in their names (e.g. textarea_wysiwyg.vm)? I recently tried to overwrite such a template by attaching a modified version to the skin page but the underscore was removed from the attachment's name..
This should be fixed in 2.3M1. -- Sergiu Dumitriu http://purl.org/net/sergiu/
participants (3)
-
Marius Dumitru Florea -
Sergiu Dumitriu -
Vincent Massol