[xwiki-devs] Rename office-preview to office-viewer
Hi devs, I'd like to rename the office-preview module to office-viewer since it better matches the current provided functionality: view office attachments (either inside a wiki page or standalone) without downloading them. Let me know if you are against this rename. Thanks, Marius
On Sep 28, 2010, at 11:49 AM, Marius Dumitru Florea wrote:
Hi devs,
I'd like to rename the office-preview module to office-viewer since it better matches the current provided functionality: view office attachments (either inside a wiki page or standalone) without downloading them.
Let me know if you are against this rename.
Fine with me. What would be the name of the macro? {{office}}?) Thanks -Vincent
On 09/28/2010 12:52 PM, Vincent Massol wrote:
On Sep 28, 2010, at 11:49 AM, Marius Dumitru Florea wrote:
Hi devs,
I'd like to rename the office-preview module to office-viewer since it better matches the current provided functionality: view office attachments (either inside a wiki page or standalone) without downloading them.
Let me know if you are against this rename.
Fine with me. What would be the name of the macro? {{office}}?)
{{office attachment="presentation.ppt"/}} looks very good to me. Thanks, Marius
Thanks -Vincent
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
On 09/28/2010 01:18 PM, Marius Dumitru Florea wrote:
On 09/28/2010 12:52 PM, Vincent Massol wrote:
On Sep 28, 2010, at 11:49 AM, Marius Dumitru Florea wrote:
Hi devs,
I'd like to rename the office-preview module to office-viewer since it better matches the current provided functionality: view office attachments (either inside a wiki page or standalone) without downloading them.
Let me know if you are against this rename.
Fine with me. What would be the name of the macro? {{office}}?)
{{office attachment="presentation.ppt"/}}
looks very good to me.
+1 -- Sergiu Dumitriu http://purl.org/net/sergiu/
On Sep 28, 2010, at 1:18 PM, Marius Dumitru Florea wrote:
On 09/28/2010 12:52 PM, Vincent Massol wrote:
On Sep 28, 2010, at 11:49 AM, Marius Dumitru Florea wrote:
Hi devs,
I'd like to rename the office-preview module to office-viewer since it better matches the current provided functionality: view office attachments (either inside a wiki page or standalone) without downloading them.
Let me know if you are against this rename.
Fine with me. What would be the name of the macro? {{office}}?)
{{office attachment="presentation.ppt"/}}
looks very good to me.
Yes. We should make sure that the attachment value takes an attachment entity reference so that we can refer to attachments on other pages too. Thanks -Vincent
On 09/28/2010 02:30 PM, Vincent Massol wrote:
On Sep 28, 2010, at 1:18 PM, Marius Dumitru Florea wrote:
On 09/28/2010 12:52 PM, Vincent Massol wrote:
On Sep 28, 2010, at 11:49 AM, Marius Dumitru Florea wrote:
Hi devs,
I'd like to rename the office-preview module to office-viewer since it better matches the current provided functionality: view office attachments (either inside a wiki page or standalone) without downloading them.
Let me know if you are against this rename.
Fine with me. What would be the name of the macro? {{office}}?)
{{office attachment="presentation.ppt"/}}
looks very good to me.
Yes. We should make sure that the attachment value takes an attachment entity reference so that we can refer to attachments on other pages too.
Yep. This means that @ character will have to be escaped in the attachment name when viewing an attachment from the current page: {{office attachment="presentation\@xwiki.ppt"/}} I'll make sure this is well documented. Thanks, Marius
Thanks -Vincent
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
On Sep 28, 2010, at 1:42 PM, Marius Dumitru Florea wrote:
On 09/28/2010 02:30 PM, Vincent Massol wrote:
On Sep 28, 2010, at 1:18 PM, Marius Dumitru Florea wrote:
On 09/28/2010 12:52 PM, Vincent Massol wrote:
On Sep 28, 2010, at 11:49 AM, Marius Dumitru Florea wrote:
Hi devs,
I'd like to rename the office-preview module to office-viewer since it better matches the current provided functionality: view office attachments (either inside a wiki page or standalone) without downloading them.
Let me know if you are against this rename.
Fine with me. What would be the name of the macro? {{office}}?)
{{office attachment="presentation.ppt"/}}
looks very good to me.
Yes. We should make sure that the attachment value takes an attachment entity reference so that we can refer to attachments on other pages too.
Yep. This means that @ character will have to be escaped in the attachment name when viewing an attachment from the current page:
{{office attachment="presentation\@xwiki.ppt"/}}
I'll make sure this is well documented.
I don't understand why you would need to escape anything. You only need to escape @ if the attachment names contains such a character. Unless I'm missing something.... Thanks -Vincent
On 09/28/2010 02:48 PM, Vincent Massol wrote:
On Sep 28, 2010, at 1:42 PM, Marius Dumitru Florea wrote:
On 09/28/2010 02:30 PM, Vincent Massol wrote:
On Sep 28, 2010, at 1:18 PM, Marius Dumitru Florea wrote:
On 09/28/2010 12:52 PM, Vincent Massol wrote:
On Sep 28, 2010, at 11:49 AM, Marius Dumitru Florea wrote:
Hi devs,
I'd like to rename the office-preview module to office-viewer since it better matches the current provided functionality: view office attachments (either inside a wiki page or standalone) without downloading them.
Let me know if you are against this rename.
Fine with me. What would be the name of the macro? {{office}}?)
{{office attachment="presentation.ppt"/}}
looks very good to me.
Yes. We should make sure that the attachment value takes an attachment entity reference so that we can refer to attachments on other pages too.
Yep. This means that @ character will have to be escaped in the attachment name when viewing an attachment from the current page:
{{office attachment="presentation\@xwiki.ppt"/}}
I'll make sure this is well documented.
I don't understand why you would need to escape anything.
You only need to escape @ if the attachment names contains such a character.
That's exactly what I meant. Thanks, Marius
Unless I'm missing something....
Thanks -Vincent
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
+1 On Tue, Sep 28, 2010 at 11:49, Marius Dumitru Florea <[email protected]> wrote:
Hi devs,
I'd like to rename the office-preview module to office-viewer since it better matches the current provided functionality: view office attachments (either inside a wiki page or standalone) without downloading them.
Let me know if you are against this rename.
Thanks, Marius _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
+1, JV. On Tue, Sep 28, 2010 at 11:49 AM, Marius Dumitru Florea <[email protected]> wrote:
Hi devs,
I'd like to rename the office-preview module to office-viewer since it better matches the current provided functionality: view office attachments (either inside a wiki page or standalone) without downloading them.
Let me know if you are against this rename.
Thanks, Marius _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
participants (5)
-
Jean-Vincent Drean -
Marius Dumitru Florea -
Sergiu Dumitriu -
Thomas Mortagne -
Vincent Massol