[xwiki-devs] [proposal] Refactor pages footer (comments, attachments, etc)
Hi XWikiers, I've recently worked on a refactoring of the page footer and I'd like to get some feedback about it. Features: * New "information" section displaying parent, backlinks, included pages, etc * New "history" section (as described in the original albatross spec) * Tags edition with suggest (information) * Lazy loading of sections via AJAX * Url hash (#comments) taken into account, for example autoload/scroll after having upladed an attachments. * Unobstrusive JavaScript (links are working with JS turned off) Since a demo is worth a thousand words, you can try it here : http://jv.myxwiki.org/xwiki/bin/view/Main/ WDYT ? Thanks, JV.
FYI the information section idea is coming from http://jira.xwiki.org/jira/browse/XWIKI-522 On Thu, Jul 31, 2008 at 3:39 PM, Jean-Vincent Drean <[email protected]> wrote:
Hi XWikiers,
I've recently worked on a refactoring of the page footer and I'd like to get some feedback about it.
Features: * New "information" section displaying parent, backlinks, included pages, etc * New "history" section (as described in the original albatross spec) * Tags edition with suggest (information) * Lazy loading of sections via AJAX * Url hash (#comments) taken into account, for example autoload/scroll after having upladed an attachments. * Unobstrusive JavaScript (links are working with JS turned off)
Jean-Vincent Drean wrote:
Hi XWikiers,
I've recently worked on a refactoring of the page footer and I'd like to get some feedback about it.
Features: * New "information" section displaying parent, backlinks, included pages, etc * New "history" section (as described in the original albatross spec) * Tags edition with suggest (information) * Lazy loading of sections via AJAX * Url hash (#comments) taken into account, for example autoload/scroll after having upladed an attachments. * Unobstrusive JavaScript (links are working with JS turned off)
Since a demo is worth a thousand words, you can try it here : http://jv.myxwiki.org/xwiki/bin/view/Main/
WDYT ?
I like it a lot! I find the history section a little too big. I would tend to see that section as a way to do quick reviews of what happened recently on the page, and I would limit it to latest 10 major edits for example (and then the one who needs can use the pagination). Plus, one can always click "Show > History" to have the regular large view. Despite that I find it way cool, +1 to have it in 1.6 Jerome.
Thanks, JV. _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
On Thu, Jul 31, 2008 at 4:04 PM, Jerome Velociter <[email protected]> wrote:
I find the history section a little too big. I would tend to see that section as a way to do quick reviews of what happened recently on the page, and I would limit it to latest 10 major edits for example (and then the one who needs can use the pagination). Plus, one can always click "Show > History" to have the regular large view.
About Show > Something, this is still a WIP and I'd like to make those links points to the corresponding section at the bottom of the page. BTW +1 about having only 10 versions in the history section. JV.
Jean-Vincent Drean wrote:
On Thu, Jul 31, 2008 at 4:04 PM, Jerome Velociter <[email protected]> wrote:
I find the history section a little too big. I would tend to see that section as a way to do quick reviews of what happened recently on the page, and I would limit it to latest 10 major edits for example (and then the one who needs can use the pagination). Plus, one can always click "Show > History" to have the regular large view.
About Show > Something, this is still a WIP and I'd like to make those links points to the corresponding section at the bottom of the page. BTW +1 about having only 10 versions in the history section.
Then we won't have a way to display more than ten items at a time, which is not very good... What about having 10 as a default settings + links (and possibly user cookies?) to display more items, like 20, 50 ? Jerome.
JV. _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
I vote for the page not moving at all when a user clicks on attachments/history/etc.. It feels weird when it moves. At the same time clicking on Show/history should move the page to the right place Using only 10 elements in the history won't help since the comments or attachments section can be very long possibly Ludovic Jean-Vincent Drean wrote:
On Thu, Jul 31, 2008 at 4:04 PM, Jerome Velociter <[email protected]> wrote:
I find the history section a little too big. I would tend to see that section as a way to do quick reviews of what happened recently on the page, and I would limit it to latest 10 major edits for example (and then the one who needs can use the pagination). Plus, one can always click "Show > History" to have the regular large view.
About Show > Something, this is still a WIP and I'd like to make those links points to the corresponding section at the bottom of the page. BTW +1 about having only 10 versions in the history section.
JV. _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Ludovic Dubost Blog: http://blog.ludovic.org/ XWiki: http://www.xwiki.com Skype: ldubost GTalk: ldubost
Ludovic Dubost wrote:
I vote for the page not moving at all when a user clicks on attachments/history/etc.. It feels weird when it moves. At the same time clicking on Show/history should move the page to the right place
Yes, I feel the same.
Using only 10 elements in the history won't help since the comments or attachments section can be very long possibly
True, but most pages have few or no comments or attachments, so the long history on this pages is a bit odd. Anyway, as you say, it is the same the other way round : few history items will look odd on a page with a lot of comments. Jerome.
Ludovic
Jean-Vincent Drean wrote:
On Thu, Jul 31, 2008 at 4:04 PM, Jerome Velociter <[email protected]> wrote:
I find the history section a little too big. I would tend to see that section as a way to do quick reviews of what happened recently on the page, and I would limit it to latest 10 major edits for example (and then the one who needs can use the pagination). Plus, one can always click "Show > History" to have the regular large view.
About Show > Something, this is still a WIP and I'd like to make those links points to the corresponding section at the bottom of the page. BTW +1 about having only 10 versions in the history section.
JV. _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
On Thu, Jul 31, 2008 at 4:34 PM, Ludovic Dubost <[email protected]> wrote:
I vote for the page not moving at all when a user clicks on attachments/history/etc.. It feels weird when it moves. At the same time clicking on Show/history should move the page to the right place
I've updated http://jv.myxwiki.org/xwiki/bin/view/Main/ with my last modifications. The viewport still moves but the anchors are placed so that the tabs remains visible, I really think it's the best behavior and it doesn't look "weird" anymore. WDYT ? JV.
Jean-Vincent Drean wrote:
On Thu, Jul 31, 2008 at 4:34 PM, Ludovic Dubost <[email protected]> wrote:
I vote for the page not moving at all when a user clicks on attachments/history/etc.. It feels weird when it moves. At the same time clicking on Show/history should move the page to the right place
I've updated http://jv.myxwiki.org/xwiki/bin/view/Main/ with my last modifications. The viewport still moves but the anchors are placed so that the tabs remains visible, I really think it's the best behavior and it doesn't look "weird" anymore.
Agreed, like that it's very cool, and the big history does not shock any longer. Definitely +1, Jerome
WDYT ?
JV. _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
It's better but I still find it weird.. If it's possible it would be great to be able to test both version side by side and vote Ludovic Jean-Vincent Drean wrote:
On Thu, Jul 31, 2008 at 4:34 PM, Ludovic Dubost <[email protected]> wrote:
I vote for the page not moving at all when a user clicks on attachments/history/etc.. It feels weird when it moves. At the same time clicking on Show/history should move the page to the right place
I've updated http://jv.myxwiki.org/xwiki/bin/view/Main/ with my last modifications. The viewport still moves but the anchors are placed so that the tabs remains visible, I really think it's the best behavior and it doesn't look "weird" anymore.
WDYT ?
JV. _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Ludovic Dubost Blog: http://blog.ludovic.org/ XWiki: http://www.xwiki.com Skype: ldubost GTalk: ldubost
On Fri, Aug 1, 2008 at 5:13 PM, Ludovic Dubost <[email protected]> wrote:
It's better but I still find it weird.. If it's possible it would be great to be able to test both version side by side and vote
Sure, try the other possibility here : http://jv.myxwiki.org/xwiki/bin/view/Main/Layout2#Comments Note that with this URL you won't see the comments at first. JV.
On Aug 1, 2008, at 5:33 PM, Jean-Vincent Drean wrote:
On Fri, Aug 1, 2008 at 5:13 PM, Ludovic Dubost <[email protected]> wrote:
It's better but I still find it weird.. If it's possible it would be great to be able to test both version side by side and vote
Sure, try the other possibility here : http://jv.myxwiki.org/xwiki/bin/view/Main/Layout2#Comments
Ah I prefer that the document doesn't move. There's a bug for the Attachment tab but the rest are working fine.
Note that with this URL you won't see the comments at first.
I could see the comments. Not sure what you mean. Thanks -Vincent
On Fri, Aug 1, 2008 at 5:42 PM, Vincent Massol <[email protected]> wrote:
Note that with this URL you won't see the comments at first.
I could see the comments. Not sure what you mean.
Just because of a big resolution I think. With a long document you would'nt see them. Brr, I don't like the idea of having fake anchors. JV.
On Fri, Aug 1, 2008 at 5:33 PM, Jean-Vincent Drean <[email protected]> wrote:
On Fri, Aug 1, 2008 at 5:13 PM, Ludovic Dubost <[email protected]> wrote:
It's better but I still find it weird.. If it's possible it would be great to be able to test both version side by side and vote
Sure, try the other possibility here : http://jv.myxwiki.org/xwiki/bin/view/Main/Layout2#Comments Note that with this URL you won't see the comments at first.
I definitely prefer this.
JV. _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
On Fri, Aug 1, 2008 at 5:44 PM, Thomas Mortagne <[email protected]> wrote:
I definitely prefer this.
From my POV reducing the need of manual scrolling is a good thing. When I see the tabs at the bottom of my viewport, if I want to see the attachments, I click on "attachments" I'd prefer not to have to scroll to see a maximum of them. BTW I understand that the "abrupt" scrolling can be disappointing but unfortunately scriptaculous "smooth scrolling" (nice sliding transition) is broken in the version we use (the last one).
-- Jean-Vincent Drean
After testing the 3 versions (autoscrolling where you cannot see the tab, autoscrolling where you can see the tabs, no autoscrolling when you click on a tab) and after considering JV's arguments about anchors and my personal usability preferences, I like the version with autoscrolling and visible tabs best. Not having to scroll is indeed a good thing since it saves the user some time but since tabs can still be viewed clearly it does not confuse him. Guillaume On Fri, Aug 1, 2008 at 5:53 PM, Jean-Vincent Drean <[email protected]> wrote:
On Fri, Aug 1, 2008 at 5:44 PM, Thomas Mortagne <[email protected]> wrote:
I definitely prefer this.
From my POV reducing the need of manual scrolling is a good thing. When I see the tabs at the bottom of my viewport, if I want to see the attachments, I click on "attachments" I'd prefer not to have to scroll to see a maximum of them. BTW I understand that the "abrupt" scrolling can be disappointing but unfortunately scriptaculous "smooth scrolling" (nice sliding transition) is broken in the version we use (the last one).
-- Jean-Vincent Drean _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Guillaume Lerouge Product Manager - XWiki Skype ID : wikibc http://blog.xwiki.com/
However I just tested with someone in the office who feels confused when autoscroll is used -> he feels like a new page has been opened and does not know where the content of the page has gone, therefore he like the version where tabs do not move better... Popular vote, please get us out of this usability trap ;-) Guillaume On Fri, Aug 1, 2008 at 6:01 PM, Guillaume Lerouge <[email protected]>wrote:
After testing the 3 versions (autoscrolling where you cannot see the tab, autoscrolling where you can see the tabs, no autoscrolling when you click on a tab) and after considering JV's arguments about anchors and my personal usability preferences, I like the version with autoscrolling and visible tabs best. Not having to scroll is indeed a good thing since it saves the user some time but since tabs can still be viewed clearly it does not confuse him. Guillaume
On Fri, Aug 1, 2008 at 5:53 PM, Jean-Vincent Drean <[email protected]> wrote:
On Fri, Aug 1, 2008 at 5:44 PM, Thomas Mortagne <[email protected]> wrote:
I definitely prefer this.
From my POV reducing the need of manual scrolling is a good thing. When I see the tabs at the bottom of my viewport, if I want to see the attachments, I click on "attachments" I'd prefer not to have to scroll to see a maximum of them. BTW I understand that the "abrupt" scrolling can be disappointing but unfortunately scriptaculous "smooth scrolling" (nice sliding transition) is broken in the version we use (the last one).
-- Jean-Vincent Drean _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Guillaume Lerouge Product Manager - XWiki Skype ID : wikibc http://blog.xwiki.com/
-- Guillaume Lerouge Product Manager - XWiki Skype ID : wikibc http://blog.xwiki.com/
On Fri, Aug 1, 2008 at 6:05 PM, Guillaume Lerouge <[email protected]> wrote:
Popular vote, please get us out of this usability trap ;-)
Ok, forget about the 2 different version, I've mixed the 2 behaviors with a POJW (Plain Old JavaScript Ha^Wworkaround) [1] consisting in using CSS poperties display/visibility to deactivate/activate anchors at will. - 1st behavior (don't forget to clear your browser's cache), go there and click on any tab : http://jv.myxwiki.org/xwiki/bin/view/Main/ The viewport is not moving. - 2nd behavior, go here : http://jv.myxwiki.org/xwiki/bin/view/Main/#Comments or there : http://jv.myxwiki.org/xwiki/bin/view/Main/#History The viewport is moved to the corresponding extra section. I guess this one is ok for everyone, right ? :) [1] : For the curious : if (triggeredByURL) { // Yes, this is a POJW (Plain Old JavaScript Ha^Wworkaround) which // prevents the anchor 'jump' after a click event but enable it // when the user is arriving from a direct /Space/Page#Section URL $('hiddenanchors').className = 'invisible'; location.href='#' + extraID; $('hiddenanchors').className = 'hidden'; } JV.
On Fri, Aug 1, 2008 at 7:27 PM, Jean-Vincent Drean <[email protected]> wrote:
On Fri, Aug 1, 2008 at 6:05 PM, Guillaume Lerouge <[email protected]> wrote:
Popular vote, please get us out of this usability trap ;-)
Ok, forget about the 2 different version, I've mixed the 2 behaviors with a POJW (Plain Old JavaScript Ha^Wworkaround) [1] consisting in using CSS poperties display/visibility to deactivate/activate anchors at will.
- 1st behavior (don't forget to clear your browser's cache), go there and click on any tab : http://jv.myxwiki.org/xwiki/bin/view/Main/ The viewport is not moving. - 2nd behavior, go here : http://jv.myxwiki.org/xwiki/bin/view/Main/#Comments or there : http://jv.myxwiki.org/xwiki/bin/view/Main/#History The viewport is moved to the corresponding extra section.
I guess this one is ok for everyone, right ? :)
Yes it's the good one :)
[1] : For the curious :
if (triggeredByURL) { // Yes, this is a POJW (Plain Old JavaScript Ha^Wworkaround) which // prevents the anchor 'jump' after a click event but enable it // when the user is arriving from a direct /Space/Page#Section URL $('hiddenanchors').className = 'invisible'; location.href='#' + extraID; $('hiddenanchors').className = 'hidden'; }
JV. _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
On Aug 1, 2008, at 7:27 PM, Jean-Vincent Drean wrote:
On Fri, Aug 1, 2008 at 6:05 PM, Guillaume Lerouge <[email protected]> wrote:
Popular vote, please get us out of this usability trap ;-)
Ok, forget about the 2 different version, I've mixed the 2 behaviors with a POJW (Plain Old JavaScript Ha^Wworkaround) [1] consisting in using CSS poperties display/visibility to deactivate/activate anchors at will.
- 1st behavior (don't forget to clear your browser's cache), go there and click on any tab : http://jv.myxwiki.org/xwiki/bin/view/Main/ The viewport is not moving. - 2nd behavior, go here : http://jv.myxwiki.org/xwiki/bin/view/Main/#Comments or there : http://jv.myxwiki.org/xwiki/bin/view/Main/#History The viewport is moved to the corresponding extra section.
I guess this one is ok for everyone, right ? :)
yep, perfect :) Thanks -Vincent
[1] : For the curious :
if (triggeredByURL) { // Yes, this is a POJW (Plain Old JavaScript Ha^Wworkaround) which // prevents the anchor 'jump' after a click event but enable it // when the user is arriving from a direct /Space/Page#Section URL $('hiddenanchors').className = 'invisible'; location.href='#' + extraID; $('hiddenanchors').className = 'hidden'; }
JV. _________
The perfect mix. Bravo ;-) Guillaume On Fri, Aug 1, 2008 at 7:49 PM, Vincent Massol <[email protected]> wrote:
On Aug 1, 2008, at 7:27 PM, Jean-Vincent Drean wrote:
On Fri, Aug 1, 2008 at 6:05 PM, Guillaume Lerouge <[email protected]> wrote:
Popular vote, please get us out of this usability trap ;-)
Ok, forget about the 2 different version, I've mixed the 2 behaviors with a POJW (Plain Old JavaScript Ha^Wworkaround) [1] consisting in using CSS poperties display/visibility to deactivate/activate anchors at will.
- 1st behavior (don't forget to clear your browser's cache), go there and click on any tab : http://jv.myxwiki.org/xwiki/bin/view/Main/ The viewport is not moving. - 2nd behavior, go here : http://jv.myxwiki.org/xwiki/bin/view/Main/#Comments or there : http://jv.myxwiki.org/xwiki/bin/view/Main/#History The viewport is moved to the corresponding extra section.
I guess this one is ok for everyone, right ? :)
yep, perfect :)
Thanks -Vincent
[1] : For the curious :
if (triggeredByURL) { // Yes, this is a POJW (Plain Old JavaScript Ha^Wworkaround) which // prevents the anchor 'jump' after a click event but enable it // when the user is arriving from a direct /Space/Page#Section URL $('hiddenanchors').className = 'invisible'; location.href='#' + extraID; $('hiddenanchors').className = 'hidden'; }
JV. _________
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Guillaume Lerouge Product Manager - XWiki Skype ID : wikibc http://blog.xwiki.com/
On Fri, Aug 1, 2008 at 4:52 PM, Jean-Vincent Drean <[email protected]> wrote:
On Thu, Jul 31, 2008 at 4:34 PM, Ludovic Dubost <[email protected]> wrote:
I vote for the page not moving at all when a user clicks on attachments/history/etc.. It feels weird when it moves. At the same time clicking on Show/history should move the page to the right place
I've updated http://jv.myxwiki.org/xwiki/bin/view/Main/ with my last modifications. The viewport still moves but the anchors are placed so that the tabs remains visible, I really think it's the best behavior and it doesn't look "weird" anymore.
WDYT ?
Looks great ! Just one comment : I would prefer to not move down when I click on a tab.
JV. _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
Sounds good to me +1 <story> I had a long internal debate deciding if I wanted the tabs at the top of the page or not. For the sake of record here are my initial thoughts ( I've now agreed that it's ok at the bottom): * The tabs look strange to me at the bottom of a page. I would expect them at the top of a page. I think I'd prefer these tabs to be more visible and be located at the top somehow. In addition for long documents they won't be seen. If they were at the top we could also remove the show menu. Note that if the tabs were located at the top of the page we could extend the feature by adding an Objects tab, a Class tab, a Rights tab (they would be shown only for advanced users) and a Content tab (default) which would contain the document's content. Basically this would remove the need for the Show and Edit menu items in the top bar (which would need to be retought since less necessary). The edit button could be located inside the Content tab somewhere in big so that it's more visible than now. </story> I still have some comments/questions: * Do we want 2 ways of editing tags: in edit mode and in view mode. I think so but not sure. * When a tab is clicked the document scrolls. I think I'd prefer if it remained where it is. Not sure though. * We need a "Show>Information" menu entry and a Document Information standalone page too. Thanks -Vincent On Jul 31, 2008, at 3:39 PM, Jean-Vincent Drean wrote:
Hi XWikiers,
I've recently worked on a refactoring of the page footer and I'd like to get some feedback about it.
Features: * New "information" section displaying parent, backlinks, included pages, etc * New "history" section (as described in the original albatross spec) * Tags edition with suggest (information) * Lazy loading of sections via AJAX * Url hash (#comments) taken into account, for example autoload/scroll after having upladed an attachments. * Unobstrusive JavaScript (links are working with JS turned off)
Since a demo is worth a thousand words, you can try it here : http://jv.myxwiki.org/xwiki/bin/view/Main/
WDYT ?
Thanks, JV.
Since the proposal seems to be ok for everyone I plan to commit it on trunk tomorrow. The feature is now working with toucan/albatross, overrides some links (Show menu items) and keyboard shortcuts (default:c,a,h,i). Tested on firefox, ie6/7 and safari. Still need some functionnal tests. JV. On Thu, Jul 31, 2008 at 3:39 PM, Jean-Vincent Drean <[email protected]> wrote:
Hi XWikiers,
I've recently worked on a refactoring of the page footer and I'd like to get some feedback about it.
Features: * New "information" section displaying parent, backlinks, included pages, etc * New "history" section (as described in the original albatross spec) * Tags edition with suggest (information) * Lazy loading of sections via AJAX * Url hash (#comments) taken into account, for example autoload/scroll after having upladed an attachments. * Unobstrusive JavaScript (links are working with JS turned off)
Since a demo is worth a thousand words, you can try it here : http://jv.myxwiki.org/xwiki/bin/view/Main/
participants (6)
-
Guillaume Lerouge -
Jean-Vincent Drean -
Jerome Velociter -
Ludovic Dubost -
Thomas Mortagne -
Vincent Massol