[xwiki-devs] Wrongly deprecated xe.pagination.* translation properties?
Hi Sergiu, I've seen you committed the following below. I'm now renaming properties since I' m moving the livetable to platform. You've marked 2 properties as "deprecated": +# Deprecated: xe.pagination.results=Results xe.pagination.results.of=out of However they're are still used in livetable.js. How come? Thanks -Vincent Author: sdumitriu Date: 2009-05-22 15:09:39 +0200 (Fri, 22 May 2009) New Revision: 20272 Modified: platform/core/trunk/xwiki-core/src/main/resources/ApplicationResources.properties Log: XWIKI-3880: Improve the pagination aspect Adding resources Modified: platform/core/trunk/xwiki-core/src/main/resources/ApplicationResources.properties =================================================================== --- platform/core/trunk/xwiki-core/src/main/resources/ApplicationResources.properties 2009-05-22 12:57:04 UTC (rev 20271) +++ platform/core/trunk/xwiki-core/src/main/resources/ApplicationResources.properties 2009-05-22 13:09:39 UTC (rev 20272) @@ -1675,11 +1675,19 @@ xe.space.index=Space Index xe.space.index.description=This page lists all your wiki's spaces +xe.pagination.page=Page +xe.pagination.page.title=Go to page {0} +xe.pagination.page.previous=« previous page +xe.pagination.page.prev.title=Previous Page +xe.pagination.page.next=next page » +xe.pagination.page.next.title=Next Page +xe.pagination.results.none=No results +xe.pagination.results.one=One result +xe.pagination.results.single=Result <span class="currentResultsNo">{0}</span> of <span class="totalResultsNo">{1}</span> +xe.pagination.results.many=Results <span class="currentResultsNo">{0} - {1}</span> of <span class="totalResultsNo">{2}</span> +# Deprecated: xe.pagination.results=Results xe.pagination.results.of=out of -xe.pagination.page=Page -xe.pagination.page.next.title=Next Page -xe.pagination.page.prev.title=Previous Page xe.livetable._actions.delete=delete xe.livetable._actions.rename=rename
On 01/20/2012 07:10 AM, Vincent Massol wrote:
Hi Sergiu,
I've seen you committed the following below. I'm now renaming properties since I' m moving the livetable to platform.
You've marked 2 properties as "deprecated": +# Deprecated: xe.pagination.results=Results xe.pagination.results.of=out of
However they're are still used in livetable.js.
How come?
I didn't notice at the time that the Livetable was using those keys. Anyway, both old and new keys are wrong (the new ones shouldn't contain markup inside them), so for the moment you can unmark those two as deprecated.
Thanks -Vincent
Author: sdumitriu Date: 2009-05-22 15:09:39 +0200 (Fri, 22 May 2009) New Revision: 20272
Modified: platform/core/trunk/xwiki-core/src/main/resources/ApplicationResources.properties Log: XWIKI-3880: Improve the pagination aspect Adding resources
Modified: platform/core/trunk/xwiki-core/src/main/resources/ApplicationResources.properties =================================================================== --- platform/core/trunk/xwiki-core/src/main/resources/ApplicationResources.properties 2009-05-22 12:57:04 UTC (rev 20271) +++ platform/core/trunk/xwiki-core/src/main/resources/ApplicationResources.properties 2009-05-22 13:09:39 UTC (rev 20272) @@ -1675,11 +1675,19 @@ xe.space.index=Space Index xe.space.index.description=This page lists all your wiki's spaces
+xe.pagination.page=Page +xe.pagination.page.title=Go to page {0} +xe.pagination.page.previous=« previous page +xe.pagination.page.prev.title=Previous Page +xe.pagination.page.next=next page» +xe.pagination.page.next.title=Next Page +xe.pagination.results.none=No results +xe.pagination.results.one=One result +xe.pagination.results.single=Result<span class="currentResultsNo">{0}</span> of<span class="totalResultsNo">{1}</span> +xe.pagination.results.many=Results<span class="currentResultsNo">{0} - {1}</span> of<span class="totalResultsNo">{2}</span> +# Deprecated: xe.pagination.results=Results xe.pagination.results.of=out of -xe.pagination.page=Page -xe.pagination.page.next.title=Next Page -xe.pagination.page.prev.title=Previous Page
xe.livetable._actions.delete=delete xe.livetable._actions.rename=rename
-- Sergiu Dumitriu http://purl.org/net/sergiu/
participants (2)
-
Sergiu Dumitriu -
Vincent Massol