Re: [xwiki-devs] [xwiki-notifications] r13895 - in platform/web/trunk/wysiwyg/src/main/java/com/xpn/xwiki/wysiwyg/client: plugin ui/cmd ui/cmd/internal util util/internal
Hi Marius, On Oct 29, 2008, at 5:23 PM, mflorea (SVN) wrote:
Author: mflorea Date: 2008-10-29 17:23:28 +0100 (Wed, 29 Oct 2008) New Revision: 13895
Modified: platform/web/trunk/wysiwyg/src/main/java/com/xpn/xwiki/wysiwyg/ client/plugin/Config.java platform/web/trunk/wysiwyg/src/main/java/com/xpn/xwiki/wysiwyg/ client/plugin/Plugin.java platform/web/trunk/wysiwyg/src/main/java/com/xpn/xwiki/wysiwyg/ client/plugin/PluginFactory.java platform/web/trunk/wysiwyg/src/main/java/com/xpn/xwiki/wysiwyg/ client/plugin/PluginFactoryManager.java platform/web/trunk/wysiwyg/src/main/java/com/xpn/xwiki/wysiwyg/ client/plugin/PluginManager.java platform/web/trunk/wysiwyg/src/main/java/com/xpn/xwiki/wysiwyg/ client/plugin/UIExtension.java platform/web/trunk/wysiwyg/src/main/java/com/xpn/xwiki/wysiwyg/ client/ui/cmd/CommandListener.java platform/web/trunk/wysiwyg/src/main/java/com/xpn/xwiki/wysiwyg/ client/ui/cmd/CommandListenerCollection.java platform/web/trunk/wysiwyg/src/main/java/com/xpn/xwiki/wysiwyg/ client/ui/cmd/CommandManager.java platform/web/trunk/wysiwyg/src/main/java/com/xpn/xwiki/wysiwyg/ client/ui/cmd/SourcesCommandEvents.java platform/web/trunk/wysiwyg/src/main/java/com/xpn/xwiki/wysiwyg/ client/ui/cmd/internal/AbstractCommandManager.java platform/web/trunk/wysiwyg/src/main/java/com/xpn/xwiki/wysiwyg/ client/util/DOMUtils.java platform/web/trunk/wysiwyg/src/main/java/com/xpn/xwiki/wysiwyg/ client/util/Document.java platform/web/trunk/wysiwyg/src/main/java/com/xpn/xwiki/wysiwyg/ client/util/internal/IEDOMUtils.java platform/web/trunk/wysiwyg/src/main/java/com/xpn/xwiki/wysiwyg/ client/util/internal/MozillaDOMUtils.java Log: * more javadoc * ability to import DOM nodes (the current GWT support for this is broken); this is needed for the FormatInline command that I'm writing.
One remark: I hope that you're putting these comments in the code as otherwise it'll be imposible to remember why you're doing extra work in the code in 6 months time. It's very important that anything not standard/normal is fully documented with a reference on the web to the reason and even better with a link too on the issue in the project issue tracer that references the pb so that when it's fixed we can remove our cruft. Thanks -Vincent
Vincent Massol wrote:
Hi Marius,
On Oct 29, 2008, at 5:23 PM, mflorea (SVN) wrote:
Author: mflorea Date: 2008-10-29 17:23:28 +0100 (Wed, 29 Oct 2008) New Revision: 13895
Modified: platform/web/trunk/wysiwyg/src/main/java/com/xpn/xwiki/wysiwyg/ client/plugin/Config.java platform/web/trunk/wysiwyg/src/main/java/com/xpn/xwiki/wysiwyg/ client/plugin/Plugin.java platform/web/trunk/wysiwyg/src/main/java/com/xpn/xwiki/wysiwyg/ client/plugin/PluginFactory.java platform/web/trunk/wysiwyg/src/main/java/com/xpn/xwiki/wysiwyg/ client/plugin/PluginFactoryManager.java platform/web/trunk/wysiwyg/src/main/java/com/xpn/xwiki/wysiwyg/ client/plugin/PluginManager.java platform/web/trunk/wysiwyg/src/main/java/com/xpn/xwiki/wysiwyg/ client/plugin/UIExtension.java platform/web/trunk/wysiwyg/src/main/java/com/xpn/xwiki/wysiwyg/ client/ui/cmd/CommandListener.java platform/web/trunk/wysiwyg/src/main/java/com/xpn/xwiki/wysiwyg/ client/ui/cmd/CommandListenerCollection.java platform/web/trunk/wysiwyg/src/main/java/com/xpn/xwiki/wysiwyg/ client/ui/cmd/CommandManager.java platform/web/trunk/wysiwyg/src/main/java/com/xpn/xwiki/wysiwyg/ client/ui/cmd/SourcesCommandEvents.java platform/web/trunk/wysiwyg/src/main/java/com/xpn/xwiki/wysiwyg/ client/ui/cmd/internal/AbstractCommandManager.java platform/web/trunk/wysiwyg/src/main/java/com/xpn/xwiki/wysiwyg/ client/util/DOMUtils.java platform/web/trunk/wysiwyg/src/main/java/com/xpn/xwiki/wysiwyg/ client/util/Document.java platform/web/trunk/wysiwyg/src/main/java/com/xpn/xwiki/wysiwyg/ client/util/internal/IEDOMUtils.java platform/web/trunk/wysiwyg/src/main/java/com/xpn/xwiki/wysiwyg/ client/util/internal/MozillaDOMUtils.java Log: * more javadoc * ability to import DOM nodes (the current GWT support for this is broken); this is needed for the FormatInline command that I'm writing.
One remark: I hope that you're putting these comments in the code as otherwise it'll be imposible to remember why you're doing extra work in the code in 6 months time. It's very important that anything not standard/normal is fully documented with a reference on the web to the reason and even better with a link too on the issue in the project issue tracer that references the pb so that when it's fixed we can remove our cruft.
Right, I'll review my extensions to GWT code and document them. Thanks Vincent, Marius P.S.: To be honest, I'm starting to be frustrated by the fact that I don't receive answers to any of my mails on GWT Google Groups or any of the issues I opened. I opened this one http://code.google.com/p/google-web-toolkit/issues/detail?id=3006 9 days ago..
Thanks -Vincent _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
On Oct 29, 2008, at 6:53 PM, Marius Dumitru Florea wrote: [snip]
P.S.: To be honest, I'm starting to be frustrated by the fact that I don't receive answers to any of my mails on GWT Google Groups or any of the issues I opened. I opened this one http://code.google.com/p/google-web-toolkit/issues/detail?id=3006 9 days ago..
Don't be! Remember that some people post here too and don't get any answers :) If you've up-ped your message and nobody answered it probably means that nobody knows. You could create an issue in their bug tracker so that it's not forgotten and to get some answer eventually. Thanks -Vincent
participants (2)
-
Marius Dumitru Florea -
Vincent Massol