[xwiki-devs] [VOTE] Fix typo in org.xwiki.properties.PropertyDescriptor#getFied()
Hi devs, There is a typo in org.xwiki.properties.PropertyDescriptor#getFied() so in order to fix it I need to deprecate it and add new getField() method. Since addinf a new method makes me add an CLIRR exclude, here is the VOTE. Note that in practice this interface is supposed to be implemented only by internal class so it's not going to break anyone. WDYT ? Here is my +1. -- Thomas Mortagne
+1 Best Regards, /Andreas 2012-07-05 12:24, Thomas Mortagne skrev:
Hi devs,
There is a typo in org.xwiki.properties.PropertyDescriptor#getFied() so in order to fix it I need to deprecate it and add new getField() method.
Since addinf a new method makes me add an CLIRR exclude, here is the VOTE.
Note that in practice this interface is supposed to be implemented only by internal class so it's not going to break anyone.
WDYT ?
Here is my +1.
+1 Thanks, Eduard On Thu, Jul 5, 2012 at 1:34 PM, Andreas Jonsson <[email protected]> wrote:
+1
Best Regards,
/Andreas
2012-07-05 12:24, Thomas Mortagne skrev:
Hi devs,
There is a typo in org.xwiki.properties.**PropertyDescriptor#getFied() so in order to fix it I need to deprecate it and add new getField() method.
Since addinf a new method makes me add an CLIRR exclude, here is the VOTE.
Note that in practice this interface is supposed to be implemented only by internal class so it's not going to break anyone.
WDYT ?
Here is my +1.
______________________________**_________________ devs mailing list [email protected] http://lists.xwiki.org/**mailman/listinfo/devs<http://lists.xwiki.org/mailman/listinfo/devs>
On 07/05/2012 06:24 AM, Thomas Mortagne wrote:
Hi devs,
There is a typo in org.xwiki.properties.PropertyDescriptor#getFied() so in order to fix it I need to deprecate it and add new getField() method.
Since addinf a new method makes me add an CLIRR exclude, here is the VOTE.
Note that in practice this interface is supposed to be implemented only by internal class so it's not going to break anyone.
WDYT ?
Here is my +1.
+1. -- Sergiu Dumitriu http://purl.org/net/sergiu/
On Jul 5, 2012, at 12:24 PM, Thomas Mortagne wrote:
Hi devs,
There is a typo in org.xwiki.properties.PropertyDescriptor#getFied() so in order to fix it I need to deprecate it and add new getField() method.
Since addinf a new method makes me add an CLIRR exclude, here is the VOTE.
Note that in practice this interface is supposed to be implemented only by internal class so it's not going to break anyone.
WDYT ?
Here is my +1.
+1, don't forge to explain the reason where you put the CLIRR exclude (that will go in the release notes too). Thanks -Vincent
+1 Thanks, Marius On Thu, Jul 5, 2012 at 1:24 PM, Thomas Mortagne <[email protected]> wrote:
Hi devs,
There is a typo in org.xwiki.properties.PropertyDescriptor#getFied() so in order to fix it I need to deprecate it and add new getField() method.
Since addinf a new method makes me add an CLIRR exclude, here is the VOTE.
Note that in practice this interface is supposed to be implemented only by internal class so it's not going to break anyone.
WDYT ?
Here is my +1.
-- Thomas Mortagne _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
+1 On Thu, Jul 5, 2012 at 3:36 PM, Marius Dumitru Florea < [email protected]> wrote:
+1
Thanks, Marius
On Thu, Jul 5, 2012 at 1:24 PM, Thomas Mortagne <[email protected]> wrote:
Hi devs,
There is a typo in org.xwiki.properties.PropertyDescriptor#getFied() so in order to fix it I need to deprecate it and add new getField() method.
Since addinf a new method makes me add an CLIRR exclude, here is the VOTE.
Note that in practice this interface is supposed to be implemented only by internal class so it's not going to break anyone.
WDYT ?
Here is my +1.
-- Thomas Mortagne _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Denis Gervalle SOFTEC sa - CEO eGuilde sarl - CTO
No one against, done. On Thu, Jul 5, 2012 at 12:24 PM, Thomas Mortagne <[email protected]> wrote:
Hi devs,
There is a typo in org.xwiki.properties.PropertyDescriptor#getFied() so in order to fix it I need to deprecate it and add new getField() method.
Since addinf a new method makes me add an CLIRR exclude, here is the VOTE.
Note that in practice this interface is supposed to be implemented only by internal class so it's not going to break anyone.
WDYT ?
Here is my +1.
-- Thomas Mortagne
-- Thomas Mortagne
participants (7)
-
Andreas Jonsson -
Denis Gervalle -
Eduard Moraru -
Marius Dumitru Florea -
Sergiu Dumitriu -
Thomas Mortagne -
Vincent Massol