[xwiki-devs] Access for macro-jwplayer on github
Hi Marius, I added some params like autostart and repeat to your macro-jwplayer, if you like I would add this to the project and document it. My github-id is jhaimerl. Regards, Josef -- View this message in context: http://xwiki.475771.n2.nabble.com/Access-for-macro-jwplayer-on-github-tp7589... Sent from the XWiki- Dev mailing list archive at Nabble.com.
Hi Josef, The best is probably to create a pull request and Marius will review it. On Wed, Mar 19, 2014 at 10:42 AM, jhaimerl <[email protected]> wrote:
Hi Marius,
I added some params like autostart and repeat to your macro-jwplayer, if you like I would add this to the project and document it. My github-id is jhaimerl.
Regards,
Josef
-- View this message in context: http://xwiki.475771.n2.nabble.com/Access-for-macro-jwplayer-on-github-tp7589... Sent from the XWiki- Dev mailing list archive at Nabble.com. _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
I see that someone (probably Thomas) has given you access already. I agree with Thomas that for a start it's best to make a pull request. Otherwise if you're confident on your change then you can go ahead and commit, I'll review you change anyway. Thanks, Marius On Wed, Mar 19, 2014 at 11:42 AM, jhaimerl <[email protected]> wrote:
Hi Marius,
I added some params like autostart and repeat to your macro-jwplayer, if you like I would add this to the project and document it. My github-id is jhaimerl.
Regards,
Josef
-- View this message in context: http://xwiki.475771.n2.nabble.com/Access-for-macro-jwplayer-on-github-tp7589... Sent from the XWiki- Dev mailing list archive at Nabble.com. _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
participants (3)
-
jhaimerl -
Marius Dumitru Florea -
Thomas Mortagne