[xwiki-devs] [Proposal] Remove hardcoded version to their parent dependency in every submodule
Currently all xwiki-platform submodules have in their pom.xml definition the following: <parent> <groupId>org.xwiki.platform</groupId> <artifactId>xwiki-platform-...</artifactId> <version>3.5-SNAPSHOT</version> </parent> The problem I see is that the parent version is a hardcoded in every submodule, thus making some some tasks very very difficult. This is because Maven cannot read a placeholder value placed inside <version> tag. There seems to be some work on behalf of Maven guys for this issue: http://jira.codehaus.org/browse/MNG-624 but ... My proposal is to either: 1) remove the <version> tag in the parent definition from every child module and let inheritance do it's job 2) use the <relativePath> *if the child can have access to it's parent pom by relative path* I haven't tested yet but if you remove it, will the sub module know from which parent (which could have many versions) to inherit the <version> property? WDYT? ing. Bogdan Flueras Tel: +33666116067
On Thu, Feb 16, 2012 at 4:10 PM, Bogdan Flueras <[email protected]> wrote:
Currently all xwiki-platform submodules have in their pom.xml definition the following:
<parent> <groupId>org.xwiki.platform</groupId> <artifactId>xwiki-platform-...</artifactId> <version>3.5-SNAPSHOT</version> </parent>
The problem I see is that the parent version is a hardcoded in every submodule, thus making some some tasks very very difficult.
Like what ?
This is because Maven cannot read a placeholder value placed inside <version> tag. There seems to be some work on behalf of Maven guys for this issue: http://jira.codehaus.org/browse/MNG-624 but ...
My proposal is to either: 1) remove the <version> tag in the parent definition from every child module and let inheritance do it's job 2) use the <relativePath> *if the child can have access to it's parent pom by relative path*
I haven't tested yet but if you remove it, will the sub module know from which parent (which could have many versions) to inherit the <version> property?
Only if you provide the relativePath as far as I know.
WDYT?
ing. Bogdan Flueras Tel: +33666116067 _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
Hi Bogdan, On Feb 16, 2012, at 4:10 PM, Bogdan Flueras wrote:
Currently all xwiki-platform submodules have in their pom.xml definition the following:
<parent> <groupId>org.xwiki.platform</groupId> <artifactId>xwiki-platform-...</artifactId> <version>3.5-SNAPSHOT</version> </parent>
The problem I see is that the parent version is a hardcoded in every submodule, thus making some some tasks very very difficult.
I haven't encountered such issues. Could you be more specific?
This is because Maven cannot read a placeholder value placed inside <version> tag. There seems to be some work on behalf of Maven guys for this issue: http://jira.codehaus.org/browse/MNG-624 but ...
My proposal is to either: 1) remove the <version> tag in the parent definition from every child module and let inheritance do it's job
That would generate invalid POMs that cannot be built unless you also checkout parents in the "correct" directory structure. I would call this an anti pattern.
2) use the <relativePath> *if the child can have access to it's parent pom by relative path*
Note that there's the maven versions plugin to help manipulate versions: http://mojo.codehaus.org/versions-maven-plugin/ Thanks -Vincent
I haven't tested yet but if you remove it, will the sub module know from which parent (which could have many versions) to inherit the <version> property?
WDYT?
ing. Bogdan Flueras Tel: +33666116067 _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
participants (3)
-
Bogdan Flueras -
Thomas Mortagne -
Vincent Massol