On Wed, Oct 8, 2008 at 11:44 AM, Sergiu Dumitriu <[email protected]> wrote:

tmortagne (SVN) wrote:

...

Author: tmortagne Date: 2008-10-07 19:24:57 +0200 (Tue, 07 Oct 2008) New Revision: 13381

Added: platform/core/trunk/xwiki-rendering/src/main/java/org/xwiki/rendering/renderer/XHTMLWikiPrinter.java Removed: platform/core/trunk/xwiki-rendering/src/main/java/org/xwiki/rendering/renderer/AbstractXMLRenderer.java Modified: platform/core/trunk/xwiki-rendering/src/main/java/org/xwiki/rendering/renderer/XHTMLRenderer.java Log: * makes AbstractXMLRenderer a XHTMLWikiPrinter tool

I don't quite agree with this... The class is about XML printing, yet it is named XHTML. The methods are all about pure XML: printXMLStartElement, printXMLEndElement, createAttributes... And I'd like to keep it that way, if we don't need something HTML specific in it, just in case we'll need a different renderer (DocBook? the dead WML?).

I started to create a XMLWikiPrinter and base the XHTMLWikiPrinter based on it (like it was previously with Abtract version) but Vincent needed it quickly so I just did what was needed for XHTMLRenderer.

-- Sergiu Dumitriu http://purl.org/net/sergiu/ _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs

-- Thomas Mortagne