Re: [xwiki-devs] [xwiki-notifications] r14548 - in platform: core/trunk/xwiki-core/src/main/java/com/xpn/xwiki web/trunk/standard/src/main/webapp/WEB-INF
tmortagne (SVN) wrote:
Author: tmortagne Date: 2008-12-04 18:31:07 +0100 (Thu, 04 Dec 2008) New Revision: 14548
Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/XWiki.java platform/web/trunk/standard/src/main/webapp/WEB-INF/web.xml Log: XWIKI-2824: Support multiwiki using path urls and not host urls * fix action name
Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/XWiki.java
+ String[] vhi = uri.split("/"); + if (vhi.length > 2 && vhi[2].equals("wiki")) { + host = vhi[3]; + } }
This is wrong. This will break http://www.boston.com/yourtown/wiki/Newton/ /wiki/ should be configurable. -- Sergiu Dumitriu http://purl.org/net/sergiu/
On Fri, Dec 5, 2008 at 4:20 AM, Sergiu Dumitriu <[email protected]> wrote:
tmortagne (SVN) wrote:
Author: tmortagne Date: 2008-12-04 18:31:07 +0100 (Thu, 04 Dec 2008) New Revision: 14548
Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/XWiki.java platform/web/trunk/standard/src/main/webapp/WEB-INF/web.xml Log: XWIKI-2824: Support multiwiki using path urls and not host urls * fix action name
Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/XWiki.java
+ String[] vhi = uri.split("/"); + if (vhi.length > 2 && vhi[2].equals("wiki")) { + host = vhi[3]; + } }
This is wrong. This will break http://www.boston.com/yourtown/wiki/Newton/
Only if xwiki.virtual.urlpath is enabled.
/wiki/ should be configurable.
Yes anyway it would be better, i adding it.
-- Sergiu Dumitriu http://purl.org/net/sergiu/
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
On Fri, Dec 5, 2008 at 10:17 AM, Thomas Mortagne <[email protected]> wrote:
On Fri, Dec 5, 2008 at 4:20 AM, Sergiu Dumitriu <[email protected]> wrote:
tmortagne (SVN) wrote:
Author: tmortagne Date: 2008-12-04 18:31:07 +0100 (Thu, 04 Dec 2008) New Revision: 14548
Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/XWiki.java platform/web/trunk/standard/src/main/webapp/WEB-INF/web.xml Log: XWIKI-2824: Support multiwiki using path urls and not host urls * fix action name
Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/XWiki.java
+ String[] vhi = uri.split("/"); + if (vhi.length > 2 && vhi[2].equals("wiki")) { + host = vhi[3]; + } }
This is wrong. This will break http://www.boston.com/yourtown/wiki/Newton/
Only if xwiki.virtual.urlpath is enabled.
/wiki/ should be configurable.
Yes anyway it would be better, i adding it.
Hmm XWikiRequestProcessor makes it really difficult as it don't have access to the XWiki.Param (which is not even initialized when XWikiRequestProcessor.processPath is called).
-- Sergiu Dumitriu http://purl.org/net/sergiu/
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
-- Thomas Mortagne
Thomas Mortagne wrote:
On Fri, Dec 5, 2008 at 10:17 AM, Thomas Mortagne <[email protected]> wrote:
On Fri, Dec 5, 2008 at 4:20 AM, Sergiu Dumitriu <[email protected]> wrote:
tmortagne (SVN) wrote:
Author: tmortagne Date: 2008-12-04 18:31:07 +0100 (Thu, 04 Dec 2008) New Revision: 14548
Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/XWiki.java platform/web/trunk/standard/src/main/webapp/WEB-INF/web.xml Log: XWIKI-2824: Support multiwiki using path urls and not host urls * fix action name
Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/XWiki.java + String[] vhi = uri.split("/"); + if (vhi.length > 2 && vhi[2].equals("wiki")) { + host = vhi[3]; + } } This is wrong. This will break http://www.boston.com/yourtown/wiki/Newton/
Only if xwiki.virtual.urlpath is enabled.
/wiki/ should be configurable. Yes anyway it would be better, i adding it.
Hmm XWikiRequestProcessor makes it really difficult as it don't have access to the XWiki.Param (which is not even initialized when XWikiRequestProcessor.processPath is called).
How about xwiki.properties and the new configuration module? Could this help? -- Sergiu Dumitriu http://purl.org/net/sergiu/
On Fri, Dec 5, 2008 at 11:02 AM, Sergiu Dumitriu <[email protected]> wrote:
Thomas Mortagne wrote:
On Fri, Dec 5, 2008 at 10:17 AM, Thomas Mortagne <[email protected]> wrote:
On Fri, Dec 5, 2008 at 4:20 AM, Sergiu Dumitriu <[email protected]> wrote:
tmortagne (SVN) wrote:
Author: tmortagne Date: 2008-12-04 18:31:07 +0100 (Thu, 04 Dec 2008) New Revision: 14548
Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/XWiki.java platform/web/trunk/standard/src/main/webapp/WEB-INF/web.xml Log: XWIKI-2824: Support multiwiki using path urls and not host urls * fix action name
Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/XWiki.java + String[] vhi = uri.split("/"); + if (vhi.length > 2 && vhi[2].equals("wiki")) { + host = vhi[3]; + } } This is wrong. This will break http://www.boston.com/yourtown/wiki/Newton/
Only if xwiki.virtual.urlpath is enabled.
/wiki/ should be configurable. Yes anyway it would be better, i adding it.
Hmm XWikiRequestProcessor makes it really difficult as it don't have access to the XWiki.Param (which is not even initialized when XWikiRequestProcessor.processPath is called).
How about xwiki.properties and the new configuration module? Could this help?
The ComponentManager is not initialized either the first time XWikiRequestProcessor is called. And anyway the compfiguration module need the ServletContainer initialized also and i have to check to be sure but I think it's the same. In fact AFAIK nothing is initialized when Struts call XWikiRequestProcessor. I'm looking a little more, see if at least we have acces to Strust servlet resourceLoader and at worst I can maybe make XWikiRequestProcessor's own configuration loader (or extract some code from XWiki configuration loader) even I don't like it.
-- Sergiu Dumitriu http://purl.org/net/sergiu/ _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
Thomas Mortagne wrote:
On Fri, Dec 5, 2008 at 11:02 AM, Sergiu Dumitriu <[email protected]> wrote:
Thomas Mortagne wrote:
On Fri, Dec 5, 2008 at 10:17 AM, Thomas Mortagne <[email protected]> wrote:
On Fri, Dec 5, 2008 at 4:20 AM, Sergiu Dumitriu <[email protected]> wrote:
tmortagne (SVN) wrote:
Author: tmortagne Date: 2008-12-04 18:31:07 +0100 (Thu, 04 Dec 2008) New Revision: 14548
Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/XWiki.java platform/web/trunk/standard/src/main/webapp/WEB-INF/web.xml Log: XWIKI-2824: Support multiwiki using path urls and not host urls * fix action name
Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/XWiki.java + String[] vhi = uri.split("/"); + if (vhi.length > 2 && vhi[2].equals("wiki")) { + host = vhi[3]; + } } This is wrong. This will break http://www.boston.com/yourtown/wiki/Newton/
Only if xwiki.virtual.urlpath is enabled.
/wiki/ should be configurable. Yes anyway it would be better, i adding it. Hmm XWikiRequestProcessor makes it really difficult as it don't have access to the XWiki.Param (which is not even initialized when XWikiRequestProcessor.processPath is called). How about xwiki.properties and the new configuration module? Could this help?
The ComponentManager is not initialized either the first time XWikiRequestProcessor is called. And anyway the compfiguration module need the ServletContainer initialized also and i have to check to be sure but I think it's the same. In fact AFAIK nothing is initialized when Struts call XWikiRequestProcessor. I'm looking a little more, see if at least we have acces to Strust servlet resourceLoader and at worst I can maybe make XWikiRequestProcessor's own configuration loader (or extract some code from XWiki configuration loader) even I don't like it.
Worst case: httpServletRequest.getSession().getServletContext().getInitParameter("multiwikiPathName") A bit of duplication (well documented) is better than hardcoded values. -- Sergiu Dumitriu http://purl.org/net/sergiu/
On Fri, Dec 5, 2008 at 11:43 AM, Sergiu Dumitriu <[email protected]> wrote:
Thomas Mortagne wrote:
On Fri, Dec 5, 2008 at 11:02 AM, Sergiu Dumitriu <[email protected]> wrote:
Thomas Mortagne wrote:
On Fri, Dec 5, 2008 at 10:17 AM, Thomas Mortagne <[email protected]> wrote:
On Fri, Dec 5, 2008 at 4:20 AM, Sergiu Dumitriu <[email protected]> wrote:
tmortagne (SVN) wrote: > Author: tmortagne > Date: 2008-12-04 18:31:07 +0100 (Thu, 04 Dec 2008) > New Revision: 14548 > > Modified: > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/XWiki.java > platform/web/trunk/standard/src/main/webapp/WEB-INF/web.xml > Log: > XWIKI-2824: Support multiwiki using path urls and not host urls > * fix action name > > Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/XWiki.java > + String[] vhi = uri.split("/"); > + if (vhi.length > 2 && vhi[2].equals("wiki")) { > + host = vhi[3]; > + } > } This is wrong. This will break http://www.boston.com/yourtown/wiki/Newton/
Only if xwiki.virtual.urlpath is enabled.
/wiki/ should be configurable. Yes anyway it would be better, i adding it. Hmm XWikiRequestProcessor makes it really difficult as it don't have access to the XWiki.Param (which is not even initialized when XWikiRequestProcessor.processPath is called). How about xwiki.properties and the new configuration module? Could this help?
The ComponentManager is not initialized either the first time XWikiRequestProcessor is called. And anyway the compfiguration module need the ServletContainer initialized also and i have to check to be sure but I think it's the same. In fact AFAIK nothing is initialized when Struts call XWikiRequestProcessor. I'm looking a little more, see if at least we have acces to Strust servlet resourceLoader and at worst I can maybe make XWikiRequestProcessor's own configuration loader (or extract some code from XWiki configuration loader) even I don't like it.
Worst case:
httpServletRequest.getSession().getServletContext().getInitParameter("multiwikiPathName")
A bit of duplication (well documented) is better than hardcoded values.
Yes. I'm looking what i can do for it.
-- Sergiu Dumitriu http://purl.org/net/sergiu/ _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
On Fri, Dec 5, 2008 at 12:02 PM, Thomas Mortagne <[email protected]> wrote:
On Fri, Dec 5, 2008 at 11:43 AM, Sergiu Dumitriu <[email protected]> wrote:
Thomas Mortagne wrote:
On Fri, Dec 5, 2008 at 11:02 AM, Sergiu Dumitriu <[email protected]> wrote:
Thomas Mortagne wrote:
On Fri, Dec 5, 2008 at 10:17 AM, Thomas Mortagne <[email protected]> wrote:
On Fri, Dec 5, 2008 at 4:20 AM, Sergiu Dumitriu <[email protected]> wrote: > tmortagne (SVN) wrote: >> Author: tmortagne >> Date: 2008-12-04 18:31:07 +0100 (Thu, 04 Dec 2008) >> New Revision: 14548 >> >> Modified: >> platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/XWiki.java >> platform/web/trunk/standard/src/main/webapp/WEB-INF/web.xml >> Log: >> XWIKI-2824: Support multiwiki using path urls and not host urls >> * fix action name >> >> Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/XWiki.java >> + String[] vhi = uri.split("/"); >> + if (vhi.length > 2 && vhi[2].equals("wiki")) { >> + host = vhi[3]; >> + } >> } > This is wrong. This will break http://www.boston.com/yourtown/wiki/Newton/ > Only if xwiki.virtual.urlpath is enabled.
> /wiki/ should be configurable. Yes anyway it would be better, i adding it. Hmm XWikiRequestProcessor makes it really difficult as it don't have access to the XWiki.Param (which is not even initialized when XWikiRequestProcessor.processPath is called). How about xwiki.properties and the new configuration module? Could this help?
The ComponentManager is not initialized either the first time XWikiRequestProcessor is called. And anyway the compfiguration module need the ServletContainer initialized also and i have to check to be sure but I think it's the same. In fact AFAIK nothing is initialized when Struts call XWikiRequestProcessor. I'm looking a little more, see if at least we have acces to Strust servlet resourceLoader and at worst I can maybe make XWikiRequestProcessor's own configuration loader (or extract some code from XWiki configuration loader) even I don't like it.
Worst case:
httpServletRequest.getSession().getServletContext().getInitParameter("multiwikiPathName")
A bit of duplication (well documented) is better than hardcoded values.
Yes.
I'm looking what i can do for it.
Done
-- Sergiu Dumitriu http://purl.org/net/sergiu/ _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
-- Thomas Mortagne
participants (2)
-
Sergiu Dumitriu -
Thomas Mortagne