[xwiki-devs] Proposing addition to DocumentAccessBridge
Hi, Should not this method in DocumentAccessBridge: Object getProperty(String documentReference, String className, int objectNumber, String propertyName); be deprecated and replaced with a method: Object getProperty(DocumentReference documentReference, DocumentReference classReference, int objectNumber, String propertyName); Also, to be able to use it, there should be a method like: Iterable<Integer> getObjectNumbers(DocumentReference documentReference, DocumentReference classReference); With these changes, it would be possible to read the access rights objects without being depending on the core. But the rights service would still need the core for querying group memberships, checking the document creator, and checking the wiki owner. Or have I missed something? Best regards, /Andreas
Hi Andreas, On 06/10/2010 11:02 PM, Andreas Jonsson wrote:
Hi,
Should not this method in DocumentAccessBridge:
Object getProperty(String documentReference, String className, int objectNumber, String propertyName);
be deprecated
Indeed, but
and replaced with a method:
Object getProperty(DocumentReference documentReference, DocumentReference classReference, int objectNumber, String propertyName);
why not Object getPropertyValue(ObjectPropertyReference propertyReference);
Also, to be able to use it, there should be a method like:
Iterable<Integer> getObjectNumbers(DocumentReference documentReference, DocumentReference classReference);
and Iterable<ObjectReference> getObjectReferences(DocumentReference documentReference) Iterable<ObjectReference> getObjectReferences(DocumentReference documentReference, DocumentReference classReference) using new ObjectPropertyReference(propertyName, objectReference) Thanks, Marius
With these changes, it would be possible to read the access rights objects without being depending on the core.
But the rights service would still need the core for querying group memberships, checking the document creator, and checking the wiki owner. Or have I missed something?
Best regards,
/Andreas _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
Hi Marius, 2010-06-11 08:53, Marius Dumitru Florea skrev:
Hi Andreas,
On 06/10/2010 11:02 PM, Andreas Jonsson wrote:
Hi,
Should not this method in DocumentAccessBridge:
Object getProperty(String documentReference, String className, int objectNumber, String propertyName);
be deprecated
Indeed, but
and replaced with a method:
Object getProperty(DocumentReference documentReference, DocumentReference classReference, int objectNumber, String propertyName);
why not
Object getPropertyValue(ObjectPropertyReference propertyReference);
Also, to be able to use it, there should be a method like:
Iterable<Integer> getObjectNumbers(DocumentReference documentReference, DocumentReference classReference);
and
Iterable<ObjectReference> getObjectReferences(DocumentReference documentReference)
Iterable<ObjectReference> getObjectReferences(DocumentReference documentReference, DocumentReference classReference)
using
new ObjectPropertyReference(propertyName, objectReference)
Thanks, Marius
Yes, those methods would also do the trick, and I think, be more convenient to use. /Andreas
With these changes, it would be possible to read the access rights objects without being depending on the core.
But the rights service would still need the core for querying group memberships, checking the document creator, and checking the wiki owner. Or have I missed something?
Best regards,
/Andreas _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
participants (2)
-
Andreas Jonsson -
Marius Dumitru Florea