Re: [xwiki-devs] [xwiki-notifications] [xwiki/xwiki-platform] f438eb: XWIKI-6741: Move all retro compatibility aspects t...
I see that this patch removed parseMessage() entirely as evidenced by broken login tests. Although I am very happy to see deprecated API removed, I'm not sure it's what you wanted. Caleb On 07/26/2011 04:04 AM, [email protected] wrote:
Branch: refs/heads/feature-legacyprojects Home: https://github.com/xwiki/xwiki-platform
Commit: f438eb421f58d22ca4a1e32aebdde36e08580448 https://github.com/xwiki/xwiki-platform/commit/f438eb421f58d22ca4a1e32aebdde... Author: tmortagne <[email protected]> Date: 2011-06-24 (Fri, 24 Jun 2011)
Changed paths: M xwiki-platform-core/xwiki-platform-application-manager/xwiki-platform-application-manager-api/pom.xml M xwiki-platform-core/xwiki-platform-legacy/pom.xml R xwiki-platform-core/xwiki-platform-legacy/src/main/java/com/xpn/xwiki/plugin/ldap/LDAPPlugin.java R xwiki-platform-core/xwiki-platform-legacy/src/main/java/com/xpn/xwiki/plugin/ldap/LDAPPluginApi.java R xwiki-platform-core/xwiki-platform-legacy/src/main/java/com/xpn/xwiki/user/impl/LDAP/LDAPAuthServiceImpl.java R xwiki-platform-core/xwiki-platform-legacy/src/main/java/org/xwiki/annotation/internal/AnnotationVelocityContextInitializer.java R xwiki-platform-core/xwiki-platform-legacy/src/main/java/org/xwiki/legacy/internal/LegacyEventDispatcher.java R xwiki-platform-core/xwiki-platform-legacy/src/main/java/org/xwiki/observation/event/AbstractDocumentEvent.java R xwiki-platform-core/xwiki-platform-legacy/src/main/java/org/xwiki/observation/event/DocumentDeleteEvent.java R xwiki-platform-core/xwiki-platform-legacy/src/main/java/org/xwiki/observation/event/DocumentSaveEvent.java R xwiki-platform-core/xwiki-platform-legacy/src/main/java/org/xwiki/observation/event/DocumentUpdateEvent.java R xwiki-platform-core/xwiki-platform-legacy/src/main/resources/META-INF/components.txt R xwiki-platform-core/xwiki-platform-legacy/src/test/java/org/xwiki/observation/DocumentEventTest.java R xwiki-platform-core/xwiki-platform-legacy/src/test/java/org/xwiki/observation/event/LegacyEventDispatcherTest.java A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-annotation/pom.xml A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-annotation/src/main/java/org/xwiki/annotation/internal/AnnotationVelocityContextInitializer.java A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-annotation/src/main/resources/META-INF/components.txt A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-observation/pom.xml A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-observation/src/main/java/org/xwiki/observation/event/AbstractDocumentEvent.java A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-observation/src/main/java/org/xwiki/observation/event/DocumentDeleteEvent.java A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-observation/src/main/java/org/xwiki/observation/event/DocumentSaveEvent.java A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-observation/src/main/java/org/xwiki/observation/event/DocumentUpdateEvent.java A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-observation/src/main/java/org/xwiki/observation/legacy/LegacyEventDispatcher.java A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-observation/src/main/resources/META-INF/components.txt A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-observation/src/test/java/org/xwiki/observation/DocumentEventTest.java A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-observation/src/test/java/org/xwiki/observation/legacy/LegacyEventDispatcherTest.java A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-oldcore/pom.xml A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-oldcore/src/main/aspect/compatibility/com/xpn/xwiki/XWikiCompatibilityAspect.aj A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-oldcore/src/main/java/com/xpn/xwiki/plugin/ldap/LDAPPlugin.java A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-oldcore/src/main/java/com/xpn/xwiki/plugin/ldap/LDAPPluginApi.java A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-oldcore/src/main/java/com/xpn/xwiki/user/impl/LDAP/LDAPAuthServiceImpl.java M xwiki-platform-core/xwiki-platform-oldcore/pom.xml R xwiki-platform-core/xwiki-platform-oldcore/src/main/aspect/compatibility/com/xpn/xwiki/XWikiCompatibilityAspect.aj R xwiki-platform-core/xwiki-platform-oldcore/src/main/aspect/compatibility/com/xpn/xwiki/XWikiContextCompatibilityAspect.aj R xwiki-platform-core/xwiki-platform-oldcore/src/main/aspect/compatibility/com/xpn/xwiki/api/ApiCompatibilityAspect.aj R xwiki-platform-core/xwiki-platform-oldcore/src/main/aspect/compatibility/com/xpn/xwiki/api/ContextCompatibilityAspect.aj R xwiki-platform-core/xwiki-platform-oldcore/src/main/aspect/compatibility/com/xpn/xwiki/api/DocumentCompatibilityAspect.aj R xwiki-platform-core/xwiki-platform-oldcore/src/main/aspect/compatibility/com/xpn/xwiki/api/StatsServiceCompatibilityAspect.aj R xwiki-platform-core/xwiki-platform-oldcore/src/main/aspect/compatibility/com/xpn/xwiki/api/XWikiCompatibilityAspect.aj R xwiki-platform-core/xwiki-platform-oldcore/src/main/aspect/compatibility/com/xpn/xwiki/doc/XWikiDocumentCompatibilityAspect.aj R xwiki-platform-core/xwiki-platform-oldcore/src/main/aspect/compatibility/com/xpn/xwiki/objects/BaseCollectionCompatibiityAspect.aj R xwiki-platform-core/xwiki-platform-oldcore/src/main/aspect/compatibility/com/xpn/xwiki/plugin/PluginApiAspect.aj R xwiki-platform-core/xwiki-platform-oldcore/src/main/aspect/compatibility/com/xpn/xwiki/stats/impl/StatsUtilCompatibilityAspect.aj R xwiki-platform-core/xwiki-platform-oldcore/src/main/aspect/compatibility/com/xpn/xwiki/web/UtilsCompatibilityAspect.aj
Log Message: ----------- XWIKI-6741: Move all retro compatibility aspects to xwiki-legacy
_______________________________________________ notifications mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/notifications
As the log message indicate it's a mistake since it should have been moved and not deleted, looks like there has been some refactoring issue. Checking if there is some files not committed waiting somewhere. On Fri, Aug 12, 2011 at 3:24 PM, Caleb James DeLisle <[email protected]> wrote:
I see that this patch removed parseMessage() entirely as evidenced by broken login tests. Although I am very happy to see deprecated API removed, I'm not sure it's what you wanted.
Caleb
On 07/26/2011 04:04 AM, [email protected] wrote:
Branch: refs/heads/feature-legacyprojects Home: https://github.com/xwiki/xwiki-platform
Commit: f438eb421f58d22ca4a1e32aebdde36e08580448 https://github.com/xwiki/xwiki-platform/commit/f438eb421f58d22ca4a1e32aebdde... Author: tmortagne <[email protected]> Date: 2011-06-24 (Fri, 24 Jun 2011)
Changed paths: M xwiki-platform-core/xwiki-platform-application-manager/xwiki-platform-application-manager-api/pom.xml M xwiki-platform-core/xwiki-platform-legacy/pom.xml R xwiki-platform-core/xwiki-platform-legacy/src/main/java/com/xpn/xwiki/plugin/ldap/LDAPPlugin.java R xwiki-platform-core/xwiki-platform-legacy/src/main/java/com/xpn/xwiki/plugin/ldap/LDAPPluginApi.java R xwiki-platform-core/xwiki-platform-legacy/src/main/java/com/xpn/xwiki/user/impl/LDAP/LDAPAuthServiceImpl.java R xwiki-platform-core/xwiki-platform-legacy/src/main/java/org/xwiki/annotation/internal/AnnotationVelocityContextInitializer.java R xwiki-platform-core/xwiki-platform-legacy/src/main/java/org/xwiki/legacy/internal/LegacyEventDispatcher.java R xwiki-platform-core/xwiki-platform-legacy/src/main/java/org/xwiki/observation/event/AbstractDocumentEvent.java R xwiki-platform-core/xwiki-platform-legacy/src/main/java/org/xwiki/observation/event/DocumentDeleteEvent.java R xwiki-platform-core/xwiki-platform-legacy/src/main/java/org/xwiki/observation/event/DocumentSaveEvent.java R xwiki-platform-core/xwiki-platform-legacy/src/main/java/org/xwiki/observation/event/DocumentUpdateEvent.java R xwiki-platform-core/xwiki-platform-legacy/src/main/resources/META-INF/components.txt R xwiki-platform-core/xwiki-platform-legacy/src/test/java/org/xwiki/observation/DocumentEventTest.java R xwiki-platform-core/xwiki-platform-legacy/src/test/java/org/xwiki/observation/event/LegacyEventDispatcherTest.java A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-annotation/pom.xml A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-annotation/src/main/java/org/xwiki/annotation/internal/AnnotationVelocityContextInitializer.java A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-annotation/src/main/resources/META-INF/components.txt A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-observation/pom.xml A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-observation/src/main/java/org/xwiki/observation/event/AbstractDocumentEvent.java A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-observation/src/main/java/org/xwiki/observation/event/DocumentDeleteEvent.java A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-observation/src/main/java/org/xwiki/observation/event/DocumentSaveEvent.java A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-observation/src/main/java/org/xwiki/observation/event/DocumentUpdateEvent.java A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-observation/src/main/java/org/xwiki/observation/legacy/LegacyEventDispatcher.java A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-observation/src/main/resources/META-INF/components.txt A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-observation/src/test/java/org/xwiki/observation/DocumentEventTest.java A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-observation/src/test/java/org/xwiki/observation/legacy/LegacyEventDispatcherTest.java A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-oldcore/pom.xml A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-oldcore/src/main/aspect/compatibility/com/xpn/xwiki/XWikiCompatibilityAspect.aj A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-oldcore/src/main/java/com/xpn/xwiki/plugin/ldap/LDAPPlugin.java A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-oldcore/src/main/java/com/xpn/xwiki/plugin/ldap/LDAPPluginApi.java A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-oldcore/src/main/java/com/xpn/xwiki/user/impl/LDAP/LDAPAuthServiceImpl.java M xwiki-platform-core/xwiki-platform-oldcore/pom.xml R xwiki-platform-core/xwiki-platform-oldcore/src/main/aspect/compatibility/com/xpn/xwiki/XWikiCompatibilityAspect.aj R xwiki-platform-core/xwiki-platform-oldcore/src/main/aspect/compatibility/com/xpn/xwiki/XWikiContextCompatibilityAspect.aj R xwiki-platform-core/xwiki-platform-oldcore/src/main/aspect/compatibility/com/xpn/xwiki/api/ApiCompatibilityAspect.aj R xwiki-platform-core/xwiki-platform-oldcore/src/main/aspect/compatibility/com/xpn/xwiki/api/ContextCompatibilityAspect.aj R xwiki-platform-core/xwiki-platform-oldcore/src/main/aspect/compatibility/com/xpn/xwiki/api/DocumentCompatibilityAspect.aj R xwiki-platform-core/xwiki-platform-oldcore/src/main/aspect/compatibility/com/xpn/xwiki/api/StatsServiceCompatibilityAspect.aj R xwiki-platform-core/xwiki-platform-oldcore/src/main/aspect/compatibility/com/xpn/xwiki/api/XWikiCompatibilityAspect.aj R xwiki-platform-core/xwiki-platform-oldcore/src/main/aspect/compatibility/com/xpn/xwiki/doc/XWikiDocumentCompatibilityAspect.aj R xwiki-platform-core/xwiki-platform-oldcore/src/main/aspect/compatibility/com/xpn/xwiki/objects/BaseCollectionCompatibiityAspect.aj R xwiki-platform-core/xwiki-platform-oldcore/src/main/aspect/compatibility/com/xpn/xwiki/plugin/PluginApiAspect.aj R xwiki-platform-core/xwiki-platform-oldcore/src/main/aspect/compatibility/com/xpn/xwiki/stats/impl/StatsUtilCompatibilityAspect.aj R xwiki-platform-core/xwiki-platform-oldcore/src/main/aspect/compatibility/com/xpn/xwiki/web/UtilsCompatibilityAspect.aj
Log Message: ----------- XWIKI-6741: Move all retro compatibility aspects to xwiki-legacy
_______________________________________________ notifications mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/notifications
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
Should be ok now, thanks for catching it ! On Fri, Aug 12, 2011 at 4:22 PM, Thomas Mortagne <[email protected]> wrote:
As the log message indicate it's a mistake since it should have been moved and not deleted, looks like there has been some refactoring issue.
Checking if there is some files not committed waiting somewhere.
On Fri, Aug 12, 2011 at 3:24 PM, Caleb James DeLisle <[email protected]> wrote:
I see that this patch removed parseMessage() entirely as evidenced by broken login tests. Although I am very happy to see deprecated API removed, I'm not sure it's what you wanted.
Caleb
On 07/26/2011 04:04 AM, [email protected] wrote:
Branch: refs/heads/feature-legacyprojects Home: https://github.com/xwiki/xwiki-platform
Commit: f438eb421f58d22ca4a1e32aebdde36e08580448 https://github.com/xwiki/xwiki-platform/commit/f438eb421f58d22ca4a1e32aebdde... Author: tmortagne <[email protected]> Date: 2011-06-24 (Fri, 24 Jun 2011)
Changed paths: M xwiki-platform-core/xwiki-platform-application-manager/xwiki-platform-application-manager-api/pom.xml M xwiki-platform-core/xwiki-platform-legacy/pom.xml R xwiki-platform-core/xwiki-platform-legacy/src/main/java/com/xpn/xwiki/plugin/ldap/LDAPPlugin.java R xwiki-platform-core/xwiki-platform-legacy/src/main/java/com/xpn/xwiki/plugin/ldap/LDAPPluginApi.java R xwiki-platform-core/xwiki-platform-legacy/src/main/java/com/xpn/xwiki/user/impl/LDAP/LDAPAuthServiceImpl.java R xwiki-platform-core/xwiki-platform-legacy/src/main/java/org/xwiki/annotation/internal/AnnotationVelocityContextInitializer.java R xwiki-platform-core/xwiki-platform-legacy/src/main/java/org/xwiki/legacy/internal/LegacyEventDispatcher.java R xwiki-platform-core/xwiki-platform-legacy/src/main/java/org/xwiki/observation/event/AbstractDocumentEvent.java R xwiki-platform-core/xwiki-platform-legacy/src/main/java/org/xwiki/observation/event/DocumentDeleteEvent.java R xwiki-platform-core/xwiki-platform-legacy/src/main/java/org/xwiki/observation/event/DocumentSaveEvent.java R xwiki-platform-core/xwiki-platform-legacy/src/main/java/org/xwiki/observation/event/DocumentUpdateEvent.java R xwiki-platform-core/xwiki-platform-legacy/src/main/resources/META-INF/components.txt R xwiki-platform-core/xwiki-platform-legacy/src/test/java/org/xwiki/observation/DocumentEventTest.java R xwiki-platform-core/xwiki-platform-legacy/src/test/java/org/xwiki/observation/event/LegacyEventDispatcherTest.java A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-annotation/pom.xml A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-annotation/src/main/java/org/xwiki/annotation/internal/AnnotationVelocityContextInitializer.java A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-annotation/src/main/resources/META-INF/components.txt A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-observation/pom.xml A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-observation/src/main/java/org/xwiki/observation/event/AbstractDocumentEvent.java A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-observation/src/main/java/org/xwiki/observation/event/DocumentDeleteEvent.java A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-observation/src/main/java/org/xwiki/observation/event/DocumentSaveEvent.java A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-observation/src/main/java/org/xwiki/observation/event/DocumentUpdateEvent.java A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-observation/src/main/java/org/xwiki/observation/legacy/LegacyEventDispatcher.java A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-observation/src/main/resources/META-INF/components.txt A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-observation/src/test/java/org/xwiki/observation/DocumentEventTest.java A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-observation/src/test/java/org/xwiki/observation/legacy/LegacyEventDispatcherTest.java A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-oldcore/pom.xml A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-oldcore/src/main/aspect/compatibility/com/xpn/xwiki/XWikiCompatibilityAspect.aj A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-oldcore/src/main/java/com/xpn/xwiki/plugin/ldap/LDAPPlugin.java A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-oldcore/src/main/java/com/xpn/xwiki/plugin/ldap/LDAPPluginApi.java A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-oldcore/src/main/java/com/xpn/xwiki/user/impl/LDAP/LDAPAuthServiceImpl.java M xwiki-platform-core/xwiki-platform-oldcore/pom.xml R xwiki-platform-core/xwiki-platform-oldcore/src/main/aspect/compatibility/com/xpn/xwiki/XWikiCompatibilityAspect.aj R xwiki-platform-core/xwiki-platform-oldcore/src/main/aspect/compatibility/com/xpn/xwiki/XWikiContextCompatibilityAspect.aj R xwiki-platform-core/xwiki-platform-oldcore/src/main/aspect/compatibility/com/xpn/xwiki/api/ApiCompatibilityAspect.aj R xwiki-platform-core/xwiki-platform-oldcore/src/main/aspect/compatibility/com/xpn/xwiki/api/ContextCompatibilityAspect.aj R xwiki-platform-core/xwiki-platform-oldcore/src/main/aspect/compatibility/com/xpn/xwiki/api/DocumentCompatibilityAspect.aj R xwiki-platform-core/xwiki-platform-oldcore/src/main/aspect/compatibility/com/xpn/xwiki/api/StatsServiceCompatibilityAspect.aj R xwiki-platform-core/xwiki-platform-oldcore/src/main/aspect/compatibility/com/xpn/xwiki/api/XWikiCompatibilityAspect.aj R xwiki-platform-core/xwiki-platform-oldcore/src/main/aspect/compatibility/com/xpn/xwiki/doc/XWikiDocumentCompatibilityAspect.aj R xwiki-platform-core/xwiki-platform-oldcore/src/main/aspect/compatibility/com/xpn/xwiki/objects/BaseCollectionCompatibiityAspect.aj R xwiki-platform-core/xwiki-platform-oldcore/src/main/aspect/compatibility/com/xpn/xwiki/plugin/PluginApiAspect.aj R xwiki-platform-core/xwiki-platform-oldcore/src/main/aspect/compatibility/com/xpn/xwiki/stats/impl/StatsUtilCompatibilityAspect.aj R xwiki-platform-core/xwiki-platform-oldcore/src/main/aspect/compatibility/com/xpn/xwiki/web/UtilsCompatibilityAspect.aj
Log Message: ----------- XWIKI-6741: Move all retro compatibility aspects to xwiki-legacy
_______________________________________________ notifications mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/notifications
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
-- Thomas Mortagne
participants (2)
-
Caleb James DeLisle -
Thomas Mortagne