Asiri Rathnayake wrote:

Hi devs,

I have completed implementing office importer document splitting functionality and I would like to commit this code in trunk. However the functionality of splitting a xwiki document into many sub documents does not belong to the officeimporter module. Rather it belongs to the more generic topic of refactoring existing wiki documents.

There for, I propose to introduce a new core module: xwiki-core-refactoring and include the document splitting code into this module rather than having splitting code within the officeimporter code base. This will allow us to extend the refactoring module in future to include following possibilities:

- Split an exiting document into multiple documents (first refactoring) - Merge documents to form a single document - Rename documents - Rename attachments - Replace words - More...

Here's my +1 for introducing the xwiki-core-refactoring module and comitting document splitting code in it.

+1 for the refactoring module and for the document splitting. I hope that the module will grow and that XEclipse will become an hungry consumer of it :) some more ideas: - rename space - extract space (somehow similar to split document, but for a space) - rename class (including all its referenced objects) - ... a lot more I'm sure Jerome.

Thanks.

- Asiri _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs

Asiri Rathnayake wrote:

Hi devs,

I have completed implementing office importer document splitting functionality and I would like to commit this code in trunk. However the functionality of splitting a xwiki document into many sub documents does not belong to the officeimporter module. Rather it belongs to the more generic topic of refactoring existing wiki documents.

There for, I propose to introduce a new core module: xwiki-core-refactoring and include the document splitting code into this module rather than having splitting code within the officeimporter code base. This will allow us to extend the refactoring module in future to include following possibilities:

- Split an exiting document into multiple documents (first refactoring) - Merge documents to form a single document - Rename documents - Rename attachments - Replace words - More...

Here's my +1 for introducing the xwiki-core-refactoring module and comitting document splitting code in it.

+1 How exactly will this module be organized? I guess that a generic interface with several implementations would be fine. This forces us to keep refactorings specific, and keeps things pretty clear and modular. Asiri, can you start a design thread? -- Sergiu Dumitriu http://purl.org/net/sergiu/

+1 On Mon, Apr 6, 2009 at 15:30, Asiri Rathnayake <[email protected]> wrote:

Hi devs,

I have completed implementing office importer document splitting functionality and I would like to commit this code in trunk. However the functionality of splitting a xwiki document into many sub documents does not belong to the officeimporter module. Rather it belongs to the more generic topic of refactoring existing wiki documents.

There for, I propose to introduce a new core module: xwiki-core-refactoring and include the document splitting code into this module rather than having splitting code within the officeimporter code base. This will allow us to extend the refactoring module in future to include following possibilities:

- Split an exiting document into multiple documents (first refactoring) - Merge documents to form a single document - Rename documents - Rename attachments - Replace words - More...

Here's my +1 for introducing the xwiki-core-refactoring module and comitting document splitting code in it.

Thanks.

- Asiri _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs

-- Thomas Mortagne