Why is log4j.properties included in xwiki.jar ?
Dear XWiki developers, I'm configuring XWiki 1.0b4 to run on top of JOnAS 4.8.4 to use it for the future website of the OW2 Consortium. When I start XWiki (on JOnAS), a file xwiki.log is created in the current directory. First at all, I was suspecting a configuration problem in the webapp. So I've discovered that the log xwiki.log is configured in the file log4j.properties included within xwiki.jar. This is not really handy to configure XWiki log directory. I think it should be better if that file would be directly in WEB-INF/ at the same level of xwiki.log. Unless if there is a way to configure the log directory in xwiki.cfg, isn't there ? Cheers -- Xavier MOGHRABI - OW2 Consortium Jabber: [email protected] Tel: +33 4 76 61 52 35
Hi Xavier, On Mar 5, 2007, at 6:10 PM, Xavier MOGHRABI wrote:
Dear XWiki developers,
I'm configuring XWiki 1.0b4 to run on top of JOnAS 4.8.4 to use it for the future website of the OW2 Consortium.
When I start XWiki (on JOnAS), a file xwiki.log is created in the current directory.
First at all, I was suspecting a configuration problem in the webapp. So I've discovered that the log xwiki.log is configured in the file log4j.properties included within xwiki.jar. This is not really handy to configure XWiki log directory.
I agree we shouldn't have it in the JAR. It should be in the WAR. That said you don't have to edit it. See http://www.xwiki.org/xwiki/ bin/view/Community/Debugging#HLogging
I think it should be better if that file would be directly in WEB- INF/ at the same level of xwiki.log.
I'd rather put it in WEB-INF/classes as it'll be in the classpath and can be found by log4j automatically. Actually I'd personally prefer to have all configuration files located there instead of WEB-INF as this will make them available using CP mechanism but that's a personal preference. For log4j.properties it makes sense to have it WEB-INF/classes though even if we don't move the other config files. Please file a JIRA issues and possibly attach a patch :) Thanks -Vincent
Unless if there is a way to configure the log directory in xwiki.cfg, isn't there ?
Cheers
Hi Vincent, Le lundi 5 mars 2007, Vincent Massol a écrit :
I agree we shouldn't have it in the JAR. It should be in the WAR.
That said you don't have to edit it. See http://www.xwiki.org/xwiki/ bin/view/Community/Debugging#HLogging
I wasn't aware of a such feature. I've tested and it works well.
I think it should be better if that file would be directly in WEB- INF/ at the same level of xwiki.log.
I'd rather put it in WEB-INF/classes as it'll be in the classpath and can be found by log4j automatically. Actually I'd personally prefer to have all configuration files located there instead of WEB-INF as this will make them available using CP mechanism but that's a personal preference. For log4j.properties it makes sense to have it WEB-INF/classes though even if we don't move the other config files.
Please file a JIRA issues and possibly attach a patch :)
Is it really usefull since it works fine ? -- Xavier MOGHRABI - OW2 Consortium Jabber: [email protected] Tel: +33 4 76 61 52 35
participants (2)
-
Vincent Massol -
Xavier MOGHRABI