Vincent Massol wrote:

Hi,

+1 as thomas said.

I've tried on the incubator and I don't like too much the implementation. IMO if we do this, the page should not reload at all and the user should edit directly the content he clicked on: * if he clicked on a header he should be able to edit only the header * if he clicked on a paragraph he should edit this paragraph only * same for tables, list, etc

Hi This certainly needs more work, but I agree it would be great. To do this you might have to inject dynamically an iframe for the WYSIWYG passing it only the content to edit, and have a custom save button that re-inject the edited content in place of the table/header/paragraph that has been doubled-clicked before actually saving the whole document. This raises some questions : - do you lock the whole document when you double click a header ? why not, as long as its released as soon as saving - when you save, what do you update ? only the edited section ? then you might have issues with transformations (TOC inconsistent, etc.) an alternative could be to reload all the xwiki content using AJAX, so that you do not leave the page. Quite complex feature in the end, but it would be nice. If we do that we need to add too a generic way to edit XWiki Objects properties displayed in a document in a similar manner. Jerome

At the very minimum the granularity should be the section (so headers + sections).

-Vincent

On Apr 10, 2009, at 11:31 AM, Guillaume Lerouge wrote:

...

Hi devs,

I'd like to propose adding a new feature for XWiki: double-click to edit a page.

*PROS*

- It makes page edition real fast and easy from anywhere on the page - 45 wikis have it: http://www.wikimatrix.org/search.php?sid=395

*CONS*

- "Users may find this feature irritating, particularly if they are in the habit of double-clicking to select a word (normal browser behaviour)" (from http://www.wikimatrix.org/wiki/feature:Double-Click%20Edit ) - Potential JS side effects?

*IMPLEMENTATION IDEAS*

- Make the feature configurable through a setting on the user profile: - The same way an user can choose between simple & advanced mode, he could activate/deactivate double-click to edit - It could be added pretty easily to xwiki.js: - $(’xwikimaincontainer’).observe("dblclick", function() {window.location="$doc.getURL(’edit’)"})

*EXAMPLE*

You can see a test implementation on this page (double-click anywhere on the page to edit it):

http://incubator.myxwiki.org/xwiki/bin/view/Grid/Test

If the user setting part isn't too hard to do, it would be worth keeping the feature in mind as a XWiki UX improvement.

WDYT?

Guillaume

-- Guillaume Lerouge Product Manager - XWiki Skype ID : wikibc http://guillaumelerouge.com/ _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs

_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs