[xwiki-devs] [VOTE] Upgrade to Velocity Engine 1.6.1 and Velocity Tools 1.4
Hi devs, Under Anca's pressure (joking :)) here's a vote to upgrade our velocity deps. Reasons: * There are some features listed below we want to benefit from in the near future * We have some lock issue with some velocity code in Velocity 1.5 on myxwiki.org and we hope (dream?) that the upgrade could fix them... For details see http://jira.xwiki.org/jira/browse/XWIKI-3142 Note that the build works fine and the selenium tests seem ok (although some tests are failing but some - all? - were also failing before - this is bad btw since we can't trust our build, we need to fix that). Here's my +1 Thanks -Vincent http://xwiki.com http://xwiki.org http://massol.net
+1 can't wait to #break ! Vincent Massol wrote:
Hi devs,
Under Anca's pressure (joking :)) here's a vote to upgrade our velocity deps.
Reasons: * There are some features listed below we want to benefit from in the near future * We have some lock issue with some velocity code in Velocity 1.5 on myxwiki.org and we hope (dream?) that the upgrade could fix them...
For details see http://jira.xwiki.org/jira/browse/XWIKI-3142
Note that the build works fine and the selenium tests seem ok (although some tests are failing but some - all? - were also failing before - this is bad btw since we can't trust our build, we need to fix that).
Here's my +1
Thanks -Vincent http://xwiki.com http://xwiki.org http://massol.net
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
+1 Vincent Massol wrote:
Hi devs,
Under Anca's pressure (joking :)) here's a vote to upgrade our velocity deps.
Reasons: * There are some features listed below we want to benefit from in the near future * We have some lock issue with some velocity code in Velocity 1.5 on myxwiki.org and we hope (dream?) that the upgrade could fix them...
For details see http://jira.xwiki.org/jira/browse/XWIKI-3142
Note that the build works fine and the selenium tests seem ok (although some tests are failing but some - all? - were also failing before - this is bad btw since we can't trust our build, we need to fix that).
Here's my +1
Thanks -Vincent http://xwiki.com http://xwiki.org http://massol.net
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
+1 On Wed, Jan 21, 2009 at 6:48 PM, Vincent Massol <[email protected]> wrote:
Hi devs,
Under Anca's pressure (joking :)) here's a vote to upgrade our velocity deps.
Reasons: * There are some features listed below we want to benefit from in the near future * We have some lock issue with some velocity code in Velocity 1.5 on myxwiki.org and we hope (dream?) that the upgrade could fix them...
For details see http://jira.xwiki.org/jira/browse/XWIKI-3142
Note that the build works fine and the selenium tests seem ok (although some tests are failing but some - all? - were also failing before - this is bad btw since we can't trust our build, we need to fix that).
Here's my +1
Thanks -Vincent http://xwiki.com http://xwiki.org http://massol.net
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
Vincent Massol wrote:
Hi devs,
Under Anca's pressure (joking :)) here's a vote to upgrade our velocity deps.
:)
Reasons: * There are some features listed below we want to benefit from in the near future * We have some lock issue with some velocity code in Velocity 1.5 on myxwiki.org and we hope (dream?) that the upgrade could fix them...
For details see http://jira.xwiki.org/jira/browse/XWIKI-3142
Note that the build works fine and the selenium tests seem ok (although some tests are failing but some - all? - were also failing before - this is bad btw since we can't trust our build, we need to fix that).
Here's my +1
+1 we want to #break free, too!
Thanks -Vincent http://xwiki.com http://xwiki.org http://massol.net
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
+1 +1 +1 +1 I like that: If you have a reference that is an array, you can now call fixed-length list methods on it. (e.g. $array.size() and $array.get($index) ) And this could make our dream come true: The underlying Velocimacro code has been refactored to allow: Much, much better performance than Velocity 1.5 This could be cool also (we need to set a property for it.. I would say 100 or 200) users to configure a velocimacro.max.depth property (to limit recursion et al) That's nice too: There is now an automatic $velocityHasNext reference in #foreach loops Is it working without changes ? Can we try it right now on myxwiki.org ? Ludovic Vincent Massol a écrit :
Hi devs,
Under Anca's pressure (joking :)) here's a vote to upgrade our velocity deps.
Reasons: * There are some features listed below we want to benefit from in the near future * We have some lock issue with some velocity code in Velocity 1.5 on myxwiki.org and we hope (dream?) that the upgrade could fix them...
For details see http://jira.xwiki.org/jira/browse/XWIKI-3142
Note that the build works fine and the selenium tests seem ok (although some tests are failing but some - all? - were also failing before - this is bad btw since we can't trust our build, we need to fix that).
Here's my +1
Thanks -Vincent http://xwiki.com http://xwiki.org http://massol.net
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Ludovic Dubost Blog: http://blog.ludovic.org/ XWiki: http://www.xwiki.com Skype: ldubost GTalk: ldubost
On Jan 21, 2009, at 9:11 PM, Ludovic Dubost wrote:
+1 +1 +1 +1
I like that:
If you have a reference that is an array, you can now call fixed-length list methods on it. (e.g. $array.size() and $array.get($index) )
And this could make our dream come true:
The underlying Velocimacro code has been refactored to allow: Much, much better performance than Velocity 1.5
This could be cool also (we need to set a property for it.. I would say 100 or 200)
users to configure a velocimacro.max.depth property (to limit recursion et al)
That's nice too:
There is now an automatic $velocityHasNext reference in #foreach loops
Is it working without changes ?
I think so. Just committed it. Now need to see how the functional tests work (but unfortunately our tests are broken right now). I'll revert it if there's a big problem but it looks ok so far.
Can we try it right now on myxwiki.org ?
Yep. Just replace velocity engine with the 1.6.1 version and the velocity tools with 1.4 if you don't want to use a new build. Make sure you update that page at the end to explain the change (we must all log what we do on that page): http://myxwiki.org/xwiki/bin/view/XWiki/Upgrading Thanks -Vincent
Ludovic
Vincent Massol a écrit :
Hi devs,
Under Anca's pressure (joking :)) here's a vote to upgrade our velocity deps.
Reasons: * There are some features listed below we want to benefit from in the near future * We have some lock issue with some velocity code in Velocity 1.5 on myxwiki.org and we hope (dream?) that the upgrade could fix them...
For details see http://jira.xwiki.org/jira/browse/XWIKI-3142
Note that the build works fine and the selenium tests seem ok (although some tests are failing but some - all? - were also failing before - this is bad btw since we can't trust our build, we need to fix that).
Here's my +1
Thanks -Vincent http://xwiki.com http://xwiki.org http://massol.net
I reverted it on myxwiki.org . It's getting this one out on both my blog and vincent's at java.lang.Thread.run(Thread.java:619) Caused by: java.lang.NullPointerException at com.xpn.xwiki.XWiki.formatDate(XWiki.java:5143) at com.xpn.xwiki.XWiki.formatDate(XWiki.java:5148) at com.xpn.xwiki.api.XWiki.formatDate(XWiki.java:1846) at sun.reflect.GeneratedMethodAccessor201.invoke(Unknown S Vincent Massol a écrit :
On Jan 21, 2009, at 9:11 PM, Ludovic Dubost wrote:
+1 +1 +1 +1
I like that:
If you have a reference that is an array, you can now call fixed-length list methods on it. (e.g. $array.size() and $array.get($index) )
And this could make our dream come true:
The underlying Velocimacro code has been refactored to allow: Much, much better performance than Velocity 1.5
This could be cool also (we need to set a property for it.. I would say 100 or 200)
users to configure a velocimacro.max.depth property (to limit recursion et al)
That's nice too:
There is now an automatic $velocityHasNext reference in #foreach loops
Is it working without changes ?
I think so. Just committed it. Now need to see how the functional tests work (but unfortunately our tests are broken right now). I'll revert it if there's a big problem but it looks ok so far.
Can we try it right now on myxwiki.org ?
Yep. Just replace velocity engine with the 1.6.1 version and the velocity tools with 1.4 if you don't want to use a new build. Make sure you update that page at the end to explain the change (we must all log what we do on that page): http://myxwiki.org/xwiki/bin/view/XWiki/Upgrading
Thanks -Vincent
Ludovic
Vincent Massol a écrit :
Hi devs,
Under Anca's pressure (joking :)) here's a vote to upgrade our velocity deps.
Reasons: * There are some features listed below we want to benefit from in the near future * We have some lock issue with some velocity code in Velocity 1.5 on myxwiki.org and we hope (dream?) that the upgrade could fix them...
For details see http://jira.xwiki.org/jira/browse/XWIKI-3142
Note that the build works fine and the selenium tests seem ok (although some tests are failing but some - all? - were also failing before - this is bad btw since we can't trust our build, we need to fix that).
Here's my +1
Thanks -Vincent http://xwiki.com http://xwiki.org http://massol.net
devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Ludovic Dubost Blog: http://blog.ludovic.org/ XWiki: http://www.xwiki.com Skype: ldubost GTalk: ldubost
participants (6)
-
Anca Paula Luca -
Jerome Velociter -
Ludovic Dubost -
Marius Dumitru Florea -
Thomas Mortagne -
Vincent Massol